Re: Kafka Streams: Dynamic Topic Routing & Nonexistent Topics

2020-07-04 Thread Guozhang Wang
Hello, Thanks for reaching out to the community for this. I think (maybe you've also suggested) it is rather an observation on producer client than on streams client. Generally speaking we want to know if we can fail fast if the metadata cannot be found in producer.send() call. And here are my

[GitHub] [kafka-site] huxihx commented on pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

2020-07-04 Thread GitBox
huxihx commented on pull request #272: URL: https://github.com/apache/kafka-site/pull/272#issuecomment-653833022 @mjsax Thanks for reminding. Will close this PR and open a new PR to track this issue. This is an automated

[GitHub] [kafka-site] huxihx closed pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

2020-07-04 Thread GitBox
huxihx closed pull request #272: URL: https://github.com/apache/kafka-site/pull/272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[DISCUSS] KIP-639 Move nodeLevelSensor and storeLevelSensor methods from StreamsMetricsImpl to StreamsMetrics

2020-07-04 Thread Mohamed Chebbi
https://cwiki.apache.org/confluence/display/KAFKA/KIP-639%3A+Move+nodeLevelSensor+and+storeLevelSensor+methods+from+StreamsMetricsImpl+to+StreamsMetrics

[GitHub] [kafka-site] mjsax commented on pull request #272: KAFKA-10222:Incorrect methods show up in 0.10 Kafka Streams docs

2020-07-04 Thread GitBox
mjsax commented on pull request #272: URL: https://github.com/apache/kafka-site/pull/272#issuecomment-653828716 Thanks for the PR @huxihx -- note, that this pages are generated from the JavaDocs. Thus, if we fix it, we should fix it in the source code?

Build failed in Jenkins: kafka-trunk-jdk11 #1619

2020-07-04 Thread Apache Jenkins Server
See Changes: [github] MINOR: Document that max.block.ms affects some transaction methods -- [...truncated 3.19 MB...] org.apache.kafka.streams.test.OutputVerifierTest

Build failed in Jenkins: kafka-trunk-jdk8 #4693

2020-07-04 Thread Apache Jenkins Server
See Changes: [github] MINOR: Document that max.block.ms affects some transaction methods -- [...truncated 3.17 MB...]

Build failed in Jenkins: kafka-trunk-jdk14 #268

2020-07-04 Thread Apache Jenkins Server
See Changes: [github] MINOR: Document that max.block.ms affects some transaction methods -- [...truncated 3.19 MB...] org.apache.kafka.streams.TopologyTestDriverTest >

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-07-04 Thread John Roesler
Thanks Sagar, That looks good to me! The only minor comment I’d make is that I think the method declaration should have a default implementation that throws an UnsupportedOperationException, for source compatibility with existing state stores. Otherwise, as far as I’m concerned, I’m ready to

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-07-04 Thread Sagar
Hi John, I have updated the KIP with all the new changes we discussed in this discussion thread. https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores Request you to go through the same. Thanks! Sagar. On Tue, Jun 30, 2020 at 8:09 AM John

Re: [VOTE] KIP-617: Allow Kafka Streams State Stores to be iterated backwards

2020-07-04 Thread John Roesler
Thanks Jorge, I’m +1 (binding) -John On Fri, Jul 3, 2020, at 10:26, Jorge Esteban Quilcate Otoya wrote: > Hola everyone, > > I'd like to start a new thread to vote for KIP-617 as there have been > significant changes since the previous vote started. > > KIP wiki page: >

Re: [VOTE] KIP-418: A method-chaining way to branch KStream

2020-07-04 Thread John Roesler
Hi Ivan, Congratulations! It looks like you have 3 binding and 2 non-binding votes, so you can announce this KIP as accepted and follow up with a PR. Thanks, John On Mon, Jun 29, 2020, at 20:46, Bill Bejeck wrote: > Thanks for the KIP Ivan, +1 (binding). > > -Bill > > On Mon, Jun 29, 2020

Re: [DISCUSS] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext

2020-07-04 Thread John Roesler
Hi Richard, It’s good to hear from you! Thanks for bringing up the wall-clock suppression feature. IIRC, someone actually started a KIP discussion for it already, but I don’t think it went to a vote. I don’t recall any technical impediment, just the lack of availability to finish it up.

Re: [DISCUSS] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

2020-07-04 Thread John Roesler
Hi Yuriy, I agree, we can keep them separate. I just wanted to make you aware of it. Thanks for the PR, it looks the way I expected. I just read over the KIP document again. I think it needs to be updated to the current proposal, and then we’ll be able to start the vote. Thanks, John On

Re: [DISCUSS] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext

2020-07-04 Thread Richard Yu
Hi all, This reminds me of a previous issue I think that we were discussing. @John Roesler I think you should remember this one. A while back, we were talking about having suppress operator emit records by wall-clock time instead of stream time. If we are adding this, wouldn't that make it more

Re: [DISCUSS] KIP-617: Allow Kafka Streams State Stores to be iterated backwards

2020-07-04 Thread John Roesler
Thanks Jorge, This KIP looks good to me! -John On Fri, Jul 3, 2020, at 03:19, Jorge Esteban Quilcate Otoya wrote: > Hi John, > > Thanks for the feedback. > > I'd be happy to take the third option and consider moving methods to > ReadOnlySessionStore as part of the KIP. > Docs is updated to

Re: [DISCUSS] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext

2020-07-04 Thread John Roesler
Hi all, 1. Thanks, Boyang, it is nice to see usage examples in KIPs like this. It helps during the discussion, and it’s also good documentation later on. 2. Yeah, this is a subtle point. The motivation mentions being able to control the time during tests, but to be able to make it work, the