Re: [DISCUSS] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

Gotcha, thanks. On Fri, Jun 4, 2021, 8:20 PM Ismael Juma wrote: > Documentation, yes. Including the downloads page. > > Ismael > > On Fri, Jun 4, 2021, 4:44 PM Ryanne Dolan wrote: > > > Thanks Ismael, this will be great for 4.0, but I don't understand what > > exactly will change in 3.0? Just

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #198

See Changes: -- [...truncated 472278 lines...] [2021-06-04T22:08:23.513Z] [INFO]

Re: [DISCUSS] KIP-494 Connect REST Endpoint for Transformations (SMTs) and other Plugins

Hi Cyrus. The proposal looks good and I like the API spec definition the way it's presented. Having said that, a few examples that would list the request type and body, the returned status and the json response would be nice too, following the tradition of other KIPs. See

Re: [VOTE] KIP-738: Removal of Connect's internal converter properties

+1 (binding) but also with the note that we don't tend to require a KIP in order to remove configurations that have been deprecated in previous KIPs. A jira ticket with the right release as a target should suffice. In future KIPs adding a note that says that a feature is deprecated and may be

Re: [DISCUSS] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

Documentation, yes. Including the downloads page. Ismael On Fri, Jun 4, 2021, 4:44 PM Ryanne Dolan wrote: > Thanks Ismael, this will be great for 4.0, but I don't understand what > exactly will change in 3.0? Just documentation? > > I guess I don't know what it means to deprecate a build

Re: [VOTE] KIP-722: Enable connector client overrides by default

Good to flip the switch on this useful feature with the opportunity of the major release here as well. I don't see any disadvantages in doing so. +1 (binding) Konstantine On Thu, May 6, 2021 at 6:07 AM Ryanne Dolan wrote: > +1 (non-binding) Thanks! > > Ryanne > > On Wed, May 5, 2021, 4:04 PM

Re: [VOTE] KIP-721: Enable connector log contexts in Connect Log4j configuration

I agree 3.0.0 is a good opportunity to enable this useful feature by default. +1 (binding) Konstantine On Fri, May 7, 2021 at 6:33 PM Dongjin Lee wrote: > +1 (Non-binding) > > Thanks, > Dongjin > > On Thu, May 6, 2021 at 3:19 AM Randall Hauch wrote: > > > I'd like to start a vote on KIP-721:

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

Thanks for the KIP Randall! Really happy to see this feature coming along finally. Will indeed resolve an unintuitive aspect of Connect's REST API. I'm in favor of the current approach overall. Just a few comments below that could use a brief discussion: 1) Is there a specific reason why you

Re: [DISCUSS] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

Thanks Ismael, this will be great for 4.0, but I don't understand what exactly will change in 3.0? Just documentation? I guess I don't know what it means to deprecate a build target. Thanks! Ryanne On Fri, Jun 4, 2021, 9:06 AM Ismael Juma wrote: > Hi all, > > Please take a look at the KIP

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Guozhang, So if I understand correctly, it's only a couple of small changes that need to be made to this KIP to be aligned with KAFKA-12370, right? I'm guessing that StreamsMetadata would not only moved to o.a.k.streams but also be split with Interface + internal implementation, am I right?

Re: [DISCUSS] Apache Kafka 3.0.0 release plan with new updated dates

Hi all, Just a quick reminder that KIP Freeze is next Wednesday, June 9th. A vote thread needs to be open for at least 72 hours, so to everyone that is working hard on proposals targeting 3.0.0, please make sure that your [VOTE] threads are started on time. Best, Konstantine On Wed, May 26,

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hello Josep, Thanks for the proposal! The write-up looks good to me in general. I'm just wondering if you feel comfortable to align this with another JIRA/KIP further down the road: https://issues.apache.org/jira/browse/KAFKA-12370 Which tries to clean up the metadata hierarchy and the callers

Re: [DISCUSS] KIP-724: Drop support for message formats v0 and v1

Hi Ismael, I agree it would be awesome to drop support for the old formats! A few comments below: 1. Suppose that a partition with 3 replicas begins at v0. One broker is upgraded to v2 with the new "force upgrade" config as part of a rolling restart, which leaves two replicas on v0 and one on

Enforcing reviews on pull requests

Occasionally a Pull Request will get merged to trunk with an approval from a community member, but not a committer. We should consider enabling the GitHub branch protection feature that requires an approval from a committer. We discussed this some time ago (December 2017)

Re: [DISCUSS] KIP-731: Record Rate Limiting for Kafka Connect

Hey Tom, thanks for taking a look. > It's a bit weird that there's a separate start(Time) method Good call, I think we can use a second constructor instead. > No metrics for batch rates? Good call. TBH I assumed there would already be put/poll rates, but looking again I don't see them. Will

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #197

See Changes: -- [...truncated 473512 lines...] [2021-06-04T17:47:10.510Z] > Task :storage:api:compileJava UP-TO-DATE [2021-06-04T17:47:10.510Z] > Task

Re: [DISCUSS] KIP-747 Add support for basic aggregation APIs

Hi Mohan, I like the idea of adding those methods to the API, but I'd like to make a suggestion: Although the most used scenario for min() / max() might possibly be for numeric values, I think they could also be useful on other objects like Dates, LocalDates or Strings. Why limit the API to

[jira] [Created] (KAFKA-12898) Owned partitions in the subscription must be sorted

David Jacot created KAFKA-12898: --- Summary: Owned partitions in the subscription must be sorted Key: KAFKA-12898 URL: https://issues.apache.org/jira/browse/KAFKA-12898 Project: Kafka Issue

[jira] [Created] (KAFKA-12897) KRaft Controller cannot create topic with more partitions than racks

Ron Dagostino created KAFKA-12897: - Summary: KRaft Controller cannot create topic with more partitions than racks Key: KAFKA-12897 URL: https://issues.apache.org/jira/browse/KAFKA-12897 Project:

Re: [DISCUSS] KIP-746: Revise KRaft Metadata Records

Hi, Colin, 1. Sounds good. 2. Yes, adding the listener fields will make it clear how BrokerRegistrationChangeRecord will be used. Thanks, Jun On Thu, Jun 3, 2021 at 4:34 PM Colin McCabe wrote: > On Thu, Jun 3, 2021, at 16:29, Jun Rao wrote: > > Hi, Colin, > > > > Thanks for the KIP. Just a

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #196

See Changes: -- [...truncated 476058 lines...] [2021-06-04T10:01:01.057Z] SaslSslAdminIntegrationTest > testCreateTopicsResponseMetadataAndConfig() STARTED

Re: [DISCUSS] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

Hi Ismael, I see no major problem with the KIP. The vast majority of Scala projects offer support for 2 major versions of Scala as well (note Scala uses epoch.major.minor scheme), so the community is more or less used to it. Also migrating from major versions has significantly improved since

[jira] [Created] (KAFKA-12896) Group rebalance loop caused by repeated group leader JoinGroups

Lucas Bradstreet created KAFKA-12896: Summary: Group rebalance loop caused by repeated group leader JoinGroups Key: KAFKA-12896 URL: https://issues.apache.org/jira/browse/KAFKA-12896 Project:

[DISCUSS] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

Hi all, Please take a look at the KIP and provide your feedback: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181308218 Ismael

[DISCUSS] KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0)

Hi all, Please take a look at the KIP and provide your feedback: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181308223 Ismael

[jira] [Created] (KAFKA-12895) KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

Ismael Juma created KAFKA-12895: --- Summary: KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0) Key: KAFKA-12895 URL: https://issues.apache.org/jira/browse/KAFKA-12895 Project: Kafka

[jira] [Created] (KAFKA-12894) KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0)

Ismael Juma created KAFKA-12894: --- Summary: KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0) Key: KAFKA-12894 URL: https://issues.apache.org/jira/browse/KAFKA-12894 Project: Kafka

[jira] [Created] (KAFKA-12893) MM2 fails to replicate if starting two+ nodes same time

Tommi Vainikainen created KAFKA-12893: - Summary: MM2 fails to replicate if starting two+ nodes same time Key: KAFKA-12893 URL: https://issues.apache.org/jira/browse/KAFKA-12893 Project: Kafka

[jira] [Created] (KAFKA-12892) InvalidACLException thrown in tests caused jenkins build unstable

Luke Chen created KAFKA-12892: - Summary: InvalidACLException thrown in tests caused jenkins build unstable Key: KAFKA-12892 URL: https://issues.apache.org/jira/browse/KAFKA-12892 Project: Kafka

Re: [DISCUSS] KIP-724: Drop support for message formats v0 and v1

If there are no comments or objections, I will start a vote on this soon. On Tue, Jun 1, 2021 at 7:59 AM Ismael Juma wrote: > Hi all, > > It's time to start the process of sunsetting message formats v0 and v1 in > order to establish a new baseline in terms of supported client/broker > behavior

Adding @NotNull annotation to public APIs, KIP needed or not?

Hello everyone, I was thinking of doing a PR which involved adding @NotNull annotations to various Kafka API's. Afaik the @NotNull annotation doesn't break binary compatibility however it can break source compatibility. The point is that even though using @NotNull can break source compatibility,

[DISCUSS] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Hi all I'd like to discuss the following kip, any suggestions are welcome. https://cwiki.apache.org/confluence/display/KAFKA/KIP-749%3A+Add+--files+and+--file-separator+options+to+the+ConsoleProducer Many thanks, Wenbing

[jira] [Created] (KAFKA-12891) Add --files and --file-separator options to the ConsoleProducer

Wenbing Shen created KAFKA-12891: Summary: Add --files and --file-separator options to the ConsoleProducer Key: KAFKA-12891 URL: https://issues.apache.org/jira/browse/KAFKA-12891 Project: Kafka

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Thanks, Josep! +1 (binding) Bruno On 04.06.21 10:27, Josep Prat wrote: Hi all, I'd like to call for a vote on KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation KIP page can be found here: https://cwiki.apache.org/confluence/x/XIrOCg Discussion

[VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi all, I'd like to call for a vote on KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation KIP page can be found here: https://cwiki.apache.org/confluence/x/XIrOCg Discussion thread can be found here:

Re: [DISCUSS] KIP-748: Add Broker Count Metrics

Hi Ryan, Thanks for the KIP. +1 for adding RegisteredBrokerCount to the ZK controller as well. This would be really helpful. Best, David On Fri, Jun 4, 2021 at 12:44 AM Colin McCabe wrote: > Hi Ryan, > > Thanks for the KIP. I think it would be good to provide the > RegisteredBrokerCount

[jira] [Created] (KAFKA-12890) Consumer group stuck in `CompletingRebalance`

David Jacot created KAFKA-12890: --- Summary: Consumer group stuck in `CompletingRebalance` Key: KAFKA-12890 URL: https://issues.apache.org/jira/browse/KAFKA-12890 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-12889) log clean group consider empty log segment to avoid empty log left

qiang Liu created KAFKA-12889: - Summary: log clean group consider empty log segment to avoid empty log left Key: KAFKA-12889 URL: https://issues.apache.org/jira/browse/KAFKA-12889 Project: Kafka