Re: [DISCUSS] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-01-29 Thread deng ziming
Hi everyone, I will start a voting progress soon if no body has more concerns. > On Jan 25, 2022, at 1:04 PM, deng ziming wrote: > > Thank you Luke, I already changed the file name. > >> On Jan 20, 2022, at 10:08 AM, Luke Chen wrote: >> >> Hi Ziming, >> >> Thanks for the update! It looks

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2022-01-29 Thread Dongjin Lee
Hi Mickael and Luke, Nice catch! Sure, I just updated the KIP document and the PR. As you can see in '8. embedded zookeeper' section, the embedded zookeeper launcher script will show that it does not support the Log4j MBean registration feature anymore. (And then, zookeeper's

[DISCUSS] KIP-818: Introduce cache-size-bytes-total Task Level Metric

2022-01-29 Thread Sagar
Hi All, I would like to open a discussion thread on the following KIP: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390 PS: This is about introducing a new metric and I am assuming that it requires a KIP. If that isn't the case, I can close it. Thanks! Sagar.

[jira] [Resolved] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-01-29 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-13152. --- Resolution: Done > Replace "buffered.records.per.partition" with "input.buffer.max.bytes" >

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2022-01-29 Thread Luke Chen
Hi Mickael, Nice catch! I agree that we should mention the zookeeper log4j dependency things in the KIP or upgrade/release notes. Thank you. Luke On Fri, Jan 28, 2022 at 10:35 PM Mickael Maison wrote: > Hi Dongjin, > > Before starting to review the PR, I was doing a bit of research of the >