Re: [DISCUSS] KIP-868 Metadata Transactions (new thread)

2022-09-22 Thread deng ziming
David, Thanks for the feedback about #2 and #3, I'm OK with them. I also mentioned the visibility in the MetadataShell in #1, do you have any thoughts? -- Best, Ziming On Wed, Sep 21, 2022 at 10:56 PM David Arthur wrote: > Ziming, thanks for the feedback! Let me know your thoughts on #2 and #3

[jira] [Created] (KAFKA-14257) Unexpected error INCONSISTENT_CLUSTER_ID in VOTE response

2022-09-22 Thread jianbin.chen (Jira)
jianbin.chen created KAFKA-14257: Summary: Unexpected error INCONSISTENT_CLUSTER_ID in VOTE response Key: KAFKA-14257 URL: https://issues.apache.org/jira/browse/KAFKA-14257 Project: Kafka

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #1249

2022-09-22 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread Guozhang Wang
+1, thanks ShunKang. Though its proposed motivation is on consumer fetcher's deserialization, I think adding an overloaded method with ByteBuffer would help with other serde places on the client side as well. Guozhang On Thu, Sep 22, 2022 at 9:41 AM ShunKang Lin wrote: > Hi everyone, > > I'd

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2022-09-22 Thread Randall Hauch
Hi, Yash. Thanks for picking up this KIP and discussion. The KIP includes this rejected alternative: > 4. Update SinkTask.put in any way to pass the new information outside > SinkRecord (e.g. a Map or a derived class) > >- > >Much more disruptive change without considerable pros > > One

Re: [DISCUSS] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread ShunKang Lin
Thanks Guozhang! Best, ShunKang Guozhang Wang 于2022年9月23日周五 00:27写道: > Could you start a separate VOTE email thread calling for votes? > > On Thu, Sep 22, 2022 at 9:19 AM ShunKang Lin > wrote: > > > Hi Guozhang, > > > > Thanks for your help! By the way, what should I do next? > > > > Best, >

[VOTE] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread ShunKang Lin
Hi everyone, I'd like to open the vote for KIP-863, which proposes to reduce memory allocation and memory copying in Fetcher#parseRecord(TopicPartition, RecordBatch, Record). The proposal is here: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=225152035 Thanks to all who

Re: [DISCUSS] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread Guozhang Wang
Could you start a separate VOTE email thread calling for votes? On Thu, Sep 22, 2022 at 9:19 AM ShunKang Lin wrote: > Hi Guozhang, > > Thanks for your help! By the way, what should I do next? > > Best, > ShunKang > > Guozhang Wang 于2022年9月22日周四 23:21写道: > > > Thanks ShunKang, > > > > I made a

Re: [DISCUSS] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread ShunKang Lin
Hi Guozhang, Thanks for your help! By the way, what should I do next? Best, ShunKang Guozhang Wang 于2022年9月22日周四 23:21写道: > Thanks ShunKang, > > I made a few nit edits on the Motivation section as well. LGTM for me now. > > On Thu, Sep 22, 2022 at 7:33 AM ShunKang Lin > wrote: > > > Hi

Re: [DISCUSS] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread Guozhang Wang
Thanks ShunKang, I made a few nit edits on the Motivation section as well. LGTM for me now. On Thu, Sep 22, 2022 at 7:33 AM ShunKang Lin wrote: > Hi Guozhang, > > I've updated the "Motivation" section of the KIP, please take a look. > > Thanks. > ShunKang > > Guozhang Wang 于2022年9月21日周三

Re: [DISCUSS] KIP-863: Reduce Fetcher#parseRecord() memory copy

2022-09-22 Thread ShunKang Lin
Hi Guozhang, I've updated the "Motivation" section of the KIP, please take a look. Thanks. ShunKang Guozhang Wang 于2022年9月21日周三 01:26写道: > In this case, could you update the KIP to clarify the allocation savings > more clearly in the "Motivation" section? Also you could mention that for >

[jira] [Created] (KAFKA-14256) Update to Scala 2.13.9

2022-09-22 Thread Matthew de Detrich (Jira)
Matthew de Detrich created KAFKA-14256: -- Summary: Update to Scala 2.13.9 Key: KAFKA-14256 URL: https://issues.apache.org/jira/browse/KAFKA-14256 Project: Kafka Issue Type: Task

Re: [kafka-clients] Re: [VOTE] 3.3.0 RC2

2022-09-22 Thread David Arthur
Josep, thanks for the note. We will mention the CVEs fixed in this release in the announcement email. I believe we can also update the release notes HTML after the vote is complete. -David On Wed, Sep 21, 2022 at 2:51 AM 'Josep Prat' via kafka-clients < kafka-clie...@googlegroups.com> wrote: >

Re: [DISCUSS] KIP-869: Improve Streams State Restoration Visibility

2022-09-22 Thread Bruno Cadonna
Hi Guozhang! Thanks for the updates! 1. Why do you distinguish between active and standby for the total amount of restored/updated records but not for the rate of restored/updated records? 2. Regarding "standby-records-remaining" I am not sure how useful this metric is and I am not sure

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2022-09-22 Thread David Jacot
Thanks, Luke. Feel free to ping me for reviews. I am happy to help on this one. Cheers, David On Thu, Sep 22, 2022 at 11:00 AM Luke Chen wrote: > > Hi David, > > Sorry for the delay. > I'll complete it in v3.4.0. > > Thank you. > Luke > > On Thu, Sep 22, 2022 at 3:52 PM David Jacot > wrote: >

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2022-09-22 Thread Luke Chen
Hi David, Sorry for the delay. I'll complete it in v3.4.0. Thank you. Luke On Thu, Sep 22, 2022 at 3:52 PM David Jacot wrote: > Hi Luke, > > Are you still interested in implementing this KIP? We need it for > KIP-848. If you are not, we could find someone to take it over. > > Thanks, > David

[jira] [Created] (KAFKA-14255) Fetching from follower should be disallowed if fetch from follower is disabled

2022-09-22 Thread David Jacot (Jira)
David Jacot created KAFKA-14255: --- Summary: Fetching from follower should be disallowed if fetch from follower is disabled Key: KAFKA-14255 URL: https://issues.apache.org/jira/browse/KAFKA-14255

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2022-09-22 Thread David Jacot
Hi Luke, Are you still interested in implementing this KIP? We need it for KIP-848. If you are not, we could find someone to take it over. Thanks, David On Thu, Mar 3, 2022 at 10:04 AM Luke Chen wrote: > > Thanks, Ziming! > > So, now, this KIP vote passed with 3 binding +1 votes (David, Tom, >

Re: [VOTE] KIP-864: Add End-To-End Latency Metrics to Connectors

2022-09-22 Thread Yash Mayya
Hi Jorge, Thanks for the KIP. +1 (non-binding) Thanks, Yash On Mon, Sep 12, 2022 at 4:17 PM Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Pressed send to soon. Updating subject. > > On Mon, 12 Sept 2022 at 11:45, Jorge Esteban Quilcate Otoya < > quilcate.jo...@gmail.com>