Re: request to contribute to kafka

2022-11-09 Thread Luke Chen
Hi Dan, Done. Thanks for the interest in Apache Kafka. Luke On Thu, Nov 10, 2022 at 3:41 PM Dan S wrote: > Hello, > > I would like to contribute to kafka, > > my wiki id, jira id, and github username are all "scanteianu" > > Thanks, > > Dan >

Review request - PR#12753

2022-11-09 Thread Dan S
Hello, I would really appreciate another review on https://github.com/apache/kafka/pull/12753/files as I think it would be great to add a bit more documentation on the behaviour of seek, as well as some tests around invalid offsets (I found this very confusing when developing for it). Thanks,

request to contribute to kafka

2022-11-09 Thread Dan S
Hello, I would like to contribute to kafka, my wiki id, jira id, and github username are all "scanteianu" Thanks, Dan

Re: [DISCUSS] KIP-852 Optimize calculation of size for log in remote tier

2022-11-09 Thread Luke Chen
Hi Divij, One more question about the metric: I think the metric will be updated when (1) each time we run the log retention check (that is, log.retention.check.interval.ms) (2) When user explicitly call getRemoteLogSize Is that correct? Maybe we should add a note in metric description,

[jira] [Resolved] (KAFKA-13964) kafka-configs.sh end with UnsupportedVersionException when describing TLS user with quotas

2022-11-09 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13964. - Resolution: Duplicate Thanks for reporting the issue. This will be resolved by

[jira] [Created] (KAFKA-14373) provide builders for producer/consumer

2022-11-09 Thread Daniel Scanteianu (Jira)
Daniel Scanteianu created KAFKA-14373: - Summary: provide builders for producer/consumer Key: KAFKA-14373 URL: https://issues.apache.org/jira/browse/KAFKA-14373 Project: Kafka Issue Type:

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-09 Thread Colin McCabe
Hi David, Thanks for the response. Replies inline. On Wed, Nov 9, 2022, at 08:17, David Arthur wrote: > Colin > >> Maybe zk.metadata.migration.enable ? > > Done. I went with "zookeeper.metadata.migration.enable" since our > other ZK configs start with "zookeeper.*" > >> SImilarly, for

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-09 Thread Greg Harris
Hi Hector, Thanks for the KIP! This is certainly missing functionality from the native Connect framework, and we should try to make it possible to inform connectors about this part of their lifecycle. However, as with most functionality that was left out of the initial implementation of the

[jira] [Created] (KAFKA-14372) RackAwareReplicaSelector should choose a replica from the isr

2022-11-09 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-14372: Summary: RackAwareReplicaSelector should choose a replica from the isr Key: KAFKA-14372 URL: https://issues.apache.org/jira/browse/KAFKA-14372 Project: Kafka Issue

Re: [DISCUSS] KIP-852 Optimize calculation of size for log in remote tier

2022-11-09 Thread Jun Rao
Hi, Divij, Thanks for the explanation. 1. Hmm, the default implementation of RLMM does local caching, right? Currently, we also cache all segment metadata in the brokers without KIP-405. Do you see a need to change that? 2,3,4: Yes, your explanation makes sense. However, currently,

Re: [DISCUSS] KIP-866 ZooKeeper to KRaft Migration

2022-11-09 Thread Jun Rao
Hi, David, Thanks for the reply. Now that we have added KRaftControllerId to both UpdateMetdataRequest and LeaderAndIsrRequest, should we add it to StopReplicaRequest to make it more consistent? Thanks, Jun On Wed, Nov 9, 2022 at 8:17 AM David Arthur wrote: > Jun, I've updated the doc with

[jira] [Created] (KAFKA-14371) quorum-state file contains empty/unused clusterId field

2022-11-09 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-14371: - Summary: quorum-state file contains empty/unused clusterId field Key: KAFKA-14371 URL: https://issues.apache.org/jira/browse/KAFKA-14371 Project: Kafka

Re: [VOTE] KIP-866 ZooKeeper to KRaft Migration

2022-11-09 Thread David Arthur
Colin > Maybe zk.metadata.migration.enable ? Done. I went with "zookeeper.metadata.migration.enable" since our other ZK configs start with "zookeeper.*" > SImilarly, for MigrationRecord: can we rename this to ZkMigrationStateRecord? > Then change MigrationState -> ZkMigrationState. Sure >

Re: [DISCUSS] KIP-866 ZooKeeper to KRaft Migration

2022-11-09 Thread David Arthur
Jun, I've updated the doc with clarification of combined mode under the ApiVersionsResponse section. I also added your suggestion to rename the config to something more explicit. Colin had some feedback in the VOTE thread which I've also incorporated. Thanks! David On Tue, Nov 8, 2022 at 1:18 PM

Re: [DISCUSS] KIP-864: Add End-To-End Latency Metrics to Connectors

2022-11-09 Thread Mickael Maison
Hi Jorge, Thanks for the KIP, it is a nice improvement. 1) The per transformation metrics still have a question mark next to them in the KIP. Do you want to include them? If so we'll want to tag them, we should be able to include the aliases in TransformationChain and use them. 2) I see no

Kafka adopt two measurement systems

2022-11-09 Thread 张占昌
Hello! Why does Kafka adopt two measurement systems? One is yammer, and the other is its own metric.

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-11-09 Thread Mickael Maison
Hi Chris, Thanks for the KIP, you're picking something that has been in my todo list for a while ;) It looks good overall, I just have a couple of questions: 1) I consider both features listed in Future Work pretty important. In both cases you mention the reason for not addressing them now is

[jira] [Resolved] (KAFKA-14298) Getting null pointer exception

2022-11-09 Thread Ramakrishna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramakrishna resolved KAFKA-14298. - Resolution: Not A Problem > Getting null pointer exception > -- > >

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #1347

2022-11-09 Thread Apache Jenkins Server
See