Re: [DISCUSS] KIP-900: KRaft kafka-storage.sh API additions to support SCRAM

2023-01-23 Thread Colin McCabe
On Fri, Jan 20, 2023, at 13:02, Proven Provenzano wrote: > Hi Colin, > Thanks for the response. > > I chose raw records, thinking it might be useful for future additions of > records that customers might want to add before the first start of the > cluster. I do see that it is at best an engineer

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #1535

2023-01-23 Thread Apache Jenkins Server
See

[GitHub] [kafka-site] mjsax closed pull request #395: Update powered-by.html

2023-01-23 Thread via GitHub
mjsax closed pull request #395: Update powered-by.html URL: https://github.com/apache/kafka-site/pull/395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka-site] mjsax commented on pull request #395: Update powered-by.html

2023-01-23 Thread via GitHub
mjsax commented on PR #395: URL: https://github.com/apache/kafka-site/pull/395#issuecomment-1401373222 Closing this PR due to inactivity. Feel free to re-open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka-site] mjsax closed pull request #357: Update powered-by.html

2023-01-23 Thread via GitHub
mjsax closed pull request #357: Update powered-by.html URL: https://github.com/apache/kafka-site/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka-site] mjsax commented on pull request #357: Update powered-by.html

2023-01-23 Thread via GitHub
mjsax commented on PR #357: URL: https://github.com/apache/kafka-site/pull/357#issuecomment-1401372524 Closing this PR due to inactivity. Feel free to re-open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka-site] mjsax closed pull request #333: Added documentation fix for KAFKA-12360

2023-01-23 Thread via GitHub
mjsax closed pull request #333: Added documentation fix for KAFKA-12360 URL: https://github.com/apache/kafka-site/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka-site] mjsax commented on pull request #333: Added documentation fix for KAFKA-12360

2023-01-23 Thread via GitHub
mjsax commented on PR #333: URL: https://github.com/apache/kafka-site/pull/333#issuecomment-1401372190 Closing due to inactivity. The corresponding ticket was resolved in the meantime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] mjsax merged pull request #297: MINOR: fix for example implementation of how to add a new header to the record

2023-01-23 Thread via GitHub
mjsax merged PR #297: URL: https://github.com/apache/kafka-site/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka-site] mjsax commented on pull request #297: MINOR: fix for example implementation of how to add a new header to the record

2023-01-23 Thread via GitHub
mjsax commented on PR #297: URL: https://github.com/apache/kafka-site/pull/297#issuecomment-1401367738 Seems it's fixed in 3.0+ Will do a follow up PR for other 2.0 versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka-site] mjsax merged pull request #296: MINOR: fix for extra line break in streams processor API documentation

2023-01-23 Thread via GitHub
mjsax merged PR #296: URL: https://github.com/apache/kafka-site/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Jenkins build is unstable: Kafka » Kafka Branch Builder » 3.4 #60

2023-01-23 Thread Apache Jenkins Server
See

[GitHub] [kafka-site] mjsax commented on pull request #296: MINOR: fix for extra line break in streams processor API documentation

2023-01-23 Thread via GitHub
mjsax commented on PR #296: URL: https://github.com/apache/kafka-site/pull/296#issuecomment-1401361165 Seems this part was re-written via https://github.com/apache/kafka/commit/a08e0cfe652dc93cbed07a8912a460d85c579dd8 No need to update `kafka.git` for old versions. Will do a

[GitHub] [kafka-site] mjsax commented on pull request #441: Correct the year of release date for 2.7.1 in downloads.html

2023-01-23 Thread via GitHub
mjsax commented on PR #441: URL: https://github.com/apache/kafka-site/pull/441#issuecomment-1401357661 Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka-site] mjsax commented on pull request #410: KAFKA-13882 Docker to preview docs locally

2023-01-23 Thread via GitHub
mjsax commented on PR #410: URL: https://github.com/apache/kafka-site/pull/410#issuecomment-1401357923 @mimaison -- seems this slipped. Can you help finishing it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka-site] mjsax merged pull request #441: Correct the year of release date for 2.7.1 in downloads.html

2023-01-23 Thread via GitHub
mjsax merged PR #441: URL: https://github.com/apache/kafka-site/pull/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka-site] mjsax commented on pull request #443: Update Cloudflare section

2023-01-23 Thread via GitHub
mjsax commented on PR #443: URL: https://github.com/apache/kafka-site/pull/443#issuecomment-1401357094 Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka-site] mjsax merged pull request #443: Update Cloudflare section

2023-01-23 Thread via GitHub
mjsax merged PR #443: URL: https://github.com/apache/kafka-site/pull/443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka-site] mjsax commented on pull request #461: MINOR: Fix docs in security.html

2023-01-23 Thread via GitHub
mjsax commented on PR #461: URL: https://github.com/apache/kafka-site/pull/461#issuecomment-1401356477 Call for review @mimaison -- seem you have context from the referenced PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [VOTE] KIP-869: Improve Streams State Restoration Visibility

2023-01-23 Thread Matthias J. Sax
Thanks Guozhang. Couple of clarifications and follow up questions. I'm not aware of a discussion to rename the call name to "suspend" for KIP-834. Could you point me to the reference? My commend was not about KIP-834, but about this KIP. You originally proposed to call the new call-back

[jira] [Created] (KAFKA-14647) Move TopicFilter shared class

2023-01-23 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-14647: - Summary: Move TopicFilter shared class Key: KAFKA-14647 URL: https://issues.apache.org/jira/browse/KAFKA-14647 Project: Kafka Issue Type: Sub-task

Re: [DISCUSS] KIP-890 Server Side Defense

2023-01-23 Thread Matthias J. Sax
Just a side note about Guozhang comments about timestamps. If the producer sets the timestamp, putting the record into purgatory seems not to be an issue (as already said: for this case we don't guarantee timestamp order between writes of different producers anyway). However, if the broker

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-01-23 Thread Greg Harris
Federico, Thanks for taking a look! > I was just wondering if we should use a better script name like > "connect-convert-to-service-provider.sh" or something like this I agree that the current name is not ideal, while the current name describes part of what it is doing, it does not describe all

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #1534

2023-01-23 Thread Apache Jenkins Server
See Changes: -- [...truncated 439616 lines...] [2023-01-24T01:47:00.773Z] [INFO] Project created from Archetype in dir:

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.4 #59

2023-01-23 Thread Apache Jenkins Server
See Changes: -- [...truncated 262096 lines...] [2023-01-24T00:55:56.266Z] [2023-01-24T00:55:56.266Z] Gradle Test Run :core:integrationTest > Gradle Test Executor 171 >

Re: [DISCUSS] KIP-899: Allow clients to rebootstrap

2023-01-23 Thread Philip Nee
Hey Ivan, Thanks for the KIP. Some questions for clarification: It seems like the main problem is that if we don't poll frequently enough, the cluster topology can change entirely before the metadata is refreshed and thus causing staled clients. My question is: if you don't use the client for a

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-23 Thread Greg Harris
Hi Chris, I'm +1 (non-binding) for KIP-875. Thanks for proposing this change! Greg Harris On Wed, Jan 18, 2023 at 10:41 AM Chris Egerton wrote: > Hi all, > > I'd like to call for a vote on KIP-875, which adds support for viewing and > manipulating the offsets of connectors to the Kafka

[GitHub] [kafka-site] C0urante merged pull request #484: MINOR: Use archive links for 3.3.1

2023-01-23 Thread via GitHub
C0urante merged PR #484: URL: https://github.com/apache/kafka-site/pull/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #1533

2023-01-23 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-890: Transactions Server Side Defense

2023-01-23 Thread Guozhang Wang
Thanks Justine, I have no further comments on the KIP. +1. On Tue, Jan 17, 2023 at 10:34 AM Jason Gustafson wrote: > > +1. Thanks Justine! > > -Jason > > On Tue, Jan 10, 2023 at 3:46 PM Colt McNealy wrote: > > > (non-binding) +1. Thank you for the KIP, Justine! I've read it; it makes > > sense

[ANNOUNCE] Apache Kafka 3.3.2

2023-01-23 Thread Chris Egerton
The Apache Kafka community is pleased to announce the release for Apache Kafka 3.3.2 Apache Kafka 3.3.2 is a bugfix release and it contains, among other things, fixes for 20 issues reported since 3.3.1. All of the changes in this release can be found in the release notes:

[GitHub] [kafka-site] mjsax commented on pull request #484: MINOR: Use archive links for 3.3.1

2023-01-23 Thread via GitHub
mjsax commented on PR #484: URL: https://github.com/apache/kafka-site/pull/484#issuecomment-1401076448 Thanks for the PR -- can we also update the 3.3.0 links (seems we forgot during the 3.3.1 release to update them). -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka-site] C0urante merged pull request #483: MINOR: Update download links and Javadocs for 3.3.2

2023-01-23 Thread via GitHub
C0urante merged PR #483: URL: https://github.com/apache/kafka-site/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-01-23 Thread Chris Egerton
Hi Greg, Thanks for the KIP! This part of Connect has been due for an update for a while, it's nice to see it getting some attention. I especially like how the migration plan is broken down into affected personas; makes review easier and, hopefully, makes the feature easier to understand for

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2023-01-23 Thread Chris Egerton
Hi Mickael, Thanks for the updates, this is looking great. I have two more small thoughts: 1) What's the rationale for defining PluginMetrics as a class instead of an interface? AFAICT we don't need a public constructor for it since the runtime will be responsible for creating all instances.

[jira] [Resolved] (KAFKA-14311) Connect Worker clean shutdown does not cleanly stop connectors/tasks

2023-01-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14311. --- Resolution: Fixed > Connect Worker clean shutdown does not cleanly stop connectors/tasks >

[jira] [Created] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-23 Thread Jochen Schalanda (Jira)
Jochen Schalanda created KAFKA-14646: Summary: SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2) Key: KAFKA-14646 URL: https://issues.apache.org/jira/browse/KAFKA-14646

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #1532

2023-01-23 Thread Apache Jenkins Server
See Changes: -- [...truncated 435609 lines...] [2023-01-23T17:30:33.868Z] - Gradle detected a problem with the following location:

[GitHub] [kafka-site] C0urante opened a new pull request, #483: MINOR: Update download links and Javadocs for 3.3.2

2023-01-23 Thread via GitHub
C0urante opened a new pull request, #483: URL: https://github.com/apache/kafka-site/pull/483 To be merged once the official mailing list announcement is published for 3.3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (KAFKA-14645) Plugin classloader not used when retrieving connector plugin config defs via REST API

2023-01-23 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-14645: - Summary: Plugin classloader not used when retrieving connector plugin config defs via REST API Key: KAFKA-14645 URL: https://issues.apache.org/jira/browse/KAFKA-14645

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #1531

2023-01-23 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-899: Allow clients to rebootstrap

2023-01-23 Thread Christo Lolov
Hello! Thank you for the KIP. I would like to summarise my understanding of the problem in case I am wrong. Currently a long-running client refreshes their metadata from a set of brokers obtained when first contacting the cluster. If they have been “away” for too long those brokers might have

Re: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2023-01-23 Thread Tom Bentley
Hi Igor, Thanks for your replies on points 21-25. Those all LGTM. See below for a further thought on the meta.properties upgrade. Kind regards, Tom On Fri, 13 Jan 2023 at 18:09, Igor Soarez wrote: > Hi Tom, > > Thank you for having another look. > > 20. Upon a downgrade to a Kafka version

Kafka issues related 3.2.3 version zookeeper less cluster

2023-01-23 Thread Kunal Jadhav
Hello All, We are facing some issues in the 3.2.3 kafka version cluster. We have implemented 3 brokers cluster on a single node server in the kubernetes environment. After every week are facing issues which are listed below. So, please help us to resolve these issues. Thanks to all in advance.

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-01-23 Thread Federico Valeri
Hi Greg, this looks like a useful change to me. I was just wondering if we should use a better script name like "connect-convert-to-service-provider.sh" or something like this, and maybe add a --dry-run option. On Tue, Jan 17, 2023 at 8:45 PM Greg Harris wrote: > > Hi all! > > I'd like to start

RE: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2023-01-23 Thread Christo Lolov
Hello! Below you will find the latest state of the Mockito migration. 81% or 39/48 of streams-related tests have been migrated. The last 5 pull requests which are in need of reviews are: * https://github.com/apache/kafka/pull/12449 * https://github.com/apache/kafka/pull/12524 *