[jira] [Created] (KAFKA-15265) Remote copy/fetch quotas for tiered storage.

2023-07-27 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15265: -- Summary: Remote copy/fetch quotas for tiered storage. Key: KAFKA-15265 URL: https://issues.apache.org/jira/browse/KAFKA-15265 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-953: partition method to be overloaded to accept headers as well.

2023-07-27 Thread Sagar
Hey Andrew, Thanks for the review. Since I had reviewed the KIP I thought I would also respond. Of course Jack has the final say on this since he wrote the KIP. 1) This is an interesting point and I hadn't considered it. The comparison with KIP-848 is a valid one but even within that KIP, it

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2050

2023-07-27 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ismael Juma
Sounds good to me. Ismael On Thu, Jul 27, 2023, 6:32 PM Colin McCabe wrote: > I would incline towards plural, but I honestly don't feel that strongly > about it. I will just change it to --bootstrap-controller for now, to match > --bootstrap-server. Perhaps we can discuss this further in a

[jira] [Created] (KAFKA-15264) Compared with 1.1.0zk, the peak throughput of 3.5.1kraft is very jitter

2023-07-27 Thread jianbin.chen (Jira)
jianbin.chen created KAFKA-15264: Summary: Compared with 1.1.0zk, the peak throughput of 3.5.1kraft is very jitter Key: KAFKA-15264 URL: https://issues.apache.org/jira/browse/KAFKA-15264 Project:

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2049

2023-07-27 Thread Apache Jenkins Server
See Changes: -- [...truncated 296882 lines...] Gradle Test Run :streams:integrationTest > Gradle Test Executor 182 > TableTableJoinIntegrationTest > [caching enabled =

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2048

2023-07-27 Thread Apache Jenkins Server
See

Re: Apache Kafka 3.6.0 release

2023-07-27 Thread Divij Vaidya
Those are great suggestions, thank you. We will continue this discussion forward in a separate KIP for release plan for Tiered Storage. On Thu 27. Jul 2023 at 21:46, Ismael Juma wrote: > Hi Divij, > > I think the points you bring up for discussion are all good. My main > feedback is that they

Re: Apache Kafka 3.6.0 release

2023-07-27 Thread Ismael Juma
Hi Divij, I think the points you bring up for discussion are all good. My main feedback is that they should be discussed in the context of KIPs vs the release template. That's why we have a backwards compatibility section for every KIP, it's precisely to ensure we think carefully about some of

Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-07-27 Thread Guozhang Wang
Yes, that sounds right to me. Thanks Sophie. On Thu, Jul 27, 2023 at 12:35 PM Sophie Blee-Goldman wrote: > > A2: Guozhang, just to close the book on the ListValue store thing, I fully > agree it seems like overreach > to expose/force this on users, especially if it's fully internal today. But >

Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-07-27 Thread Sophie Blee-Goldman
A2: Guozhang, just to close the book on the ListValue store thing, I fully agree it seems like overreach to expose/force this on users, especially if it's fully internal today. But just to make sure we're on the same page here, you're still ok with this KIP fixing the API gap that exists today, in

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2047

2023-07-27 Thread Apache Jenkins Server
See Changes: -- [...truncated 296680 lines...] Gradle Test Run :streams:integrationTest > Gradle Test Executor 180 > HighAvailabilityTaskAssignorIntegrationTest >

Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-07-27 Thread Guozhang Wang
Hi all, Like Almog's secretary as well! Just following up on that index: A2: I'm also happy without introducing versioned KV in this KIP as I would envision it to be introduced as new params into the KeyValuePluginParams in the future. And just to clarify on Sophie's previous comment, I think

Re: Apache Kafka 3.6.0 release

2023-07-27 Thread Divij Vaidya
Thank you for the response, Ismael. 1. Specifically in context of 3.6, I wanted this compatibility guarantee point to encourage a discussion on

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Colin McCabe
I would incline towards plural, but I honestly don't feel that strongly about it. I will just change it to --bootstrap-controller for now, to match --bootstrap-server. Perhaps we can discuss this further in a later KIP, if people are inclined... Colin On Thu, Jul 27, 2023, at 07:13, Ron

Re: plz help me code review

2023-07-27 Thread Guozhang Wang
Hello Xiangyuan, Thanks for your contributions and thanks for raising it to community's attention. I will take a look at it sooner than later. On Thu, Jul 27, 2023 at 2:41 AM Xiangyuan LI wrote: > > Hi kafka team: > I raise a pr https://github.com/apache/kafka/pull/13965 to fix >

[jira] [Created] (KAFKA-15263) KRaftMigrationDriver can run the migration twice

2023-07-27 Thread David Arthur (Jira)
David Arthur created KAFKA-15263: Summary: KRaftMigrationDriver can run the migration twice Key: KAFKA-15263 URL: https://issues.apache.org/jira/browse/KAFKA-15263 Project: Kafka Issue Type:

Re: [VOTE] KIP-951: Leader discovery optimisations for the client

2023-07-27 Thread José Armando García Sancio
The KIP LGTM. Thanks for the design. I am looking forward to the implementation. +1 (binding). Thanks! -- -José

Re: [DISCUSS] KIP-953: partition method to be overloaded to accept headers as well.

2023-07-27 Thread Andrew Schofield
Hi Jack, Thanks for the KIP. I have a few concerns about the idea. 1) I think that while a client-side partitioner seems like a neat idea and it’s an established part of Kafka, it’s one of the things which makes Kafka clients quite complicated. Just as KIP-848 is moving from client-side

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.4 #152

2023-07-27 Thread Apache Jenkins Server
See Changes: -- [...truncated 476998 lines...] Gradle Test Run :core:integrationTest > Gradle Test Executor 170 > KafkaZkClientTest > testGetTopicsAndPartitions() PASSED

[jira] [Created] (KAFKA-15262) MirrorHeartbeatConnector is not working as documented

2023-07-27 Thread Ravindranath Kakarla (Jira)
Ravindranath Kakarla created KAFKA-15262: Summary: MirrorHeartbeatConnector is not working as documented Key: KAFKA-15262 URL: https://issues.apache.org/jira/browse/KAFKA-15262 Project: Kafka

Re: [DISCUSS] KIP-953: partition method to be overloaded to accept headers as well.

2023-07-27 Thread Jack Tomy
Hey Everyone, Please consider this as a gentle reminder. Please have a look at the KIP and share your thoughts. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263424937 On Tue, Jul 25, 2023 at 7:28 PM Jack Tomy wrote: > Hey @Sagar > > Thanks again for the review. > 1. "a null

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ron Dagostino
> support plural for both and the singular one is just an alias for > compatibility I like that approach. I can never remember what works, so I would prefer to just use what I think works and then have it work. Ron On Thu, Jul 27, 2023 at 8:33 AM Ismael Juma wrote: > > I think singular was

Re: [DISCUSS] KIP-960: Support interactive queries (IQv2) for versioned state stores

2023-07-27 Thread Alieh Saeedi
Thanks, Bruno, for the feedback. - I agree with both points 2 and 3. About 3: Having "VersionsQualifier" reduces the number of methods and makes everything less confusing. At the end, that will be easier to use for the developers. - About point 4: I renamed all the properties and

Re: [DISCUSS] KIP-960: Support interactive queries (IQv2) for versioned state stores

2023-07-27 Thread Alieh Saeedi
Thanks, Matthias, for the feedback! > Not sure if "bound" is the right term? My understanding from your comment is that just the name "*bound*" is not the right one, while having this query type makes sense. Right? If *bound* is a confusing word, we can simply change it to a better one. I do not

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ismael Juma
I think singular was used because that's the common case for the cli tools. To be honest, it's actually a bit more confusing to have both singular and plural for the cli tools and you have to remember the exact version for each one. We should either support plural for both and the singular one is

Re: [DISCUSS] KIP-960: Support interactive queries (IQv2) for versioned state stores

2023-07-27 Thread Bruno Cadonna
Hi Alieh, Thanks for the KIP! Here my feedback. 1. You can remove the private fields and constructors from the KIP. Those are implementation details. 2. Some proposals for renamings in VersionedKeyQuery withKeyWithTimestampBound() -> withKeyAndAsOf() withKeyWithTimestampRange() ->

Re: Apache Kafka 3.6.0 release

2023-07-27 Thread Ismael Juma
Hi Divij, Some of these are launch checklist items (not really goals) and some are compatibility guarantees. More below. On Thu, Jul 27, 2023, 12:10 PM Divij Vaidya wrote: > Hey Satish > > Could we consider adding "launch goals" in the release plan. While > some of these may be implicit, it

Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-07-27 Thread Bruno Cadonna
Hi, A5. I have to admit that "If we envision extending this beyond just StoreSupplier types, it could be a good option." is scaring me a bit. I am wondering what would be an example for such an extension? In general, I would propose to limit the scope of a config. In this case the config

Re: Apache Kafka 3.6.0 release

2023-07-27 Thread Divij Vaidya
Hey Satish Could we consider adding "launch goals" in the release plan. While some of these may be implicit, it would be nice to list them down in the release plan. For this release, our launch requirements would be: 1. Users should be able to upgrade from any prior Kafka version to this version.

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.5 #51

2023-07-27 Thread Apache Jenkins Server
See Changes: -- [...truncated 471806 lines...] > Task :raft:compileTestJava UP-TO-DATE > Task :raft:testClasses UP-TO-DATE > Task :connect:json:testSrcJar > Task

[jira] [Resolved] (KAFKA-15251) Upgrade system test to use 3.5.1

2023-07-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15251. -- Resolution: Fixed > Upgrade system test to use 3.5.1 > > >

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2046

2023-07-27 Thread Apache Jenkins Server
See

plz help me code review

2023-07-27 Thread Xiangyuan LI
Hi kafka team: I raise a pr https://github.com/apache/kafka/pull/13965 to fix https://issues.apache.org/jira/browse/KAFKA-15106, it mentions some serious bug and no one check it for a long time, plz help me review if could. thx! these bugs are in

[jira] [Created] (KAFKA-15261) ReplicaFetcher thread should not block if RLMM is not initialized

2023-07-27 Thread Abhijeet Kumar (Jira)
Abhijeet Kumar created KAFKA-15261: -- Summary: ReplicaFetcher thread should not block if RLMM is not initialized Key: KAFKA-15261 URL: https://issues.apache.org/jira/browse/KAFKA-15261 Project: Kafka

[jira] [Created] (KAFKA-15260) RLM Task should wait until RLMM is initialized before copying segments to remote

2023-07-27 Thread Abhijeet Kumar (Jira)
Abhijeet Kumar created KAFKA-15260: -- Summary: RLM Task should wait until RLMM is initialized before copying segments to remote Key: KAFKA-15260 URL: https://issues.apache.org/jira/browse/KAFKA-15260

[jira] [Resolved] (KAFKA-14500) Implement JoinGroup/SyncGroup APIs

2023-07-27 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14500. - Fix Version/s: 3.6.0 Resolution: Fixed > Implement JoinGroup/SyncGroup APIs >