Re: [DISCUSS] KIP-939: Support Participation in 2PC

2023-10-06 Thread Artem Livshits
Hi Raman, Thank you for the questions. Given that the primary effect of setting enable2pc flag is disabling timeout, it makes sense to make enable2pc have similar behavior w.r.t. when it can be set. One clarification about the Ongoing case -- the current (pre-KIP-939) behavior is to abort

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-10-06 Thread Igor Soarez
Hi Colin, > I would call #2 LOST. It was assigned in the past, but we don't know where. > I see that you called this OFFLINE). This is not really normal... > it should happen only when we're migrating from ZK mode to KRaft mode, > or going from an older KRaft release with multiple directories to

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-10-06 Thread Igor Soarez
Hi David, Thanks for shedding light on migration goals, makes sense. Your preference for option a) makes it even more attractive. We'll keep that as the preferred approach, thanks for the advice. > One question with this approach is how the KRaft controller learns about > the multiple log

Re: [DISCUSS] KIP-714: Client metrics and observability

2023-10-06 Thread Matthias J. Sax
Thanks Andrew. SGTM. One point you did not address is the idea to add a method to `KafkaStreams` similar to the proposed `clientInstanceId()` that will be added to consumer/producer/admin clients. Without addressing this, Kafka Streams users won't have a way to get the assigned `instanceId`

Re: [DISCUSS] KIP-939: Support Participation in 2PC

2023-10-06 Thread Artem Livshits
Hi Justine, Thank you for the questions. Currently (pre-KIP-939) we always bump the epoch on InitProducerId and abort an ongoing transaction (if any). I expect this behavior will continue with KIP-890 as well. With KIP-939 we need to support the case when the ongoing transaction needs to be

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-10-06 Thread Colin McCabe
Thanks for posting these notes, Igor. I think we should definitely distinguish between these two cases: 1. this replica hasn't been assigned to a storage directory 2. we don't know which storage directory this replica was assigned to in the past I would call #1 UNASSIGNED. I see that you

Re: [DISCUSS] KIP-979: Allow independently stop KRaft controllers or brokers

2023-10-06 Thread Colin McCabe
Not everything is a broker, though. So --node-id seems better. best, Colin On Sun, Oct 1, 2023, at 23:08, Kamal Chandraprakash wrote: > Hi Hailey, > > Thanks for working on this! This is one of the long-standing open issues. > Now, users have to find the PID of the respective Kafka process to

Re: [VOTE]KIP-966: Eligible Leader Replicas

2023-10-06 Thread Colin McCabe
Hi Calvin, Thanks for the KIP. I think the config discussion was good and I have no more comments there. I have one last thing I think we should fix up: I think we should improve DescribeTopicRequest. The current mechanism of "you can only list 20 topics" doesn't do a very good job of

[jira] [Created] (KAFKA-15563) Provide informative error messages when Connect REST requests time out

2023-10-06 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15563: - Summary: Provide informative error messages when Connect REST requests time out Key: KAFKA-15563 URL: https://issues.apache.org/jira/browse/KAFKA-15563 Project:

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2263

2023-10-06 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-15562) CommitRequestManager needs to test different error handling

2023-10-06 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15562: -- Summary: CommitRequestManager needs to test different error handling Key: KAFKA-15562 URL: https://issues.apache.org/jira/browse/KAFKA-15562 Project: Kafka

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-06 Thread Hanyu (Peter) Zheng
Thank you, Matthias, for the detailed implementation and explanation. As of now, our capability is limited to executing interactive queries on individual partitions. To illustrate: Consider the IQv2StoreIntegrationTest: We have two partitions: Partition0 contains key-value pairs: <0,0> and

[PR] MINOR Access SslPrincipalMapper from Custom KafkaPrincipalBuilder(KIP-982) #14491

2023-10-06 Thread Raghu B
Hi Kafka Dev Community, Hope you are doing well. I wanted to bring your attention to the following pull request KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) #14491 . The changes made will allow

Re: [VOTE] KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-10-06 Thread Greg Harris
Hey Chris, Thanks for the KIP! I think that preserving the ephemeral nature of the logging change is the right choice here, and using the config topic for intra-cluster broadcast is better than REST forwarding. +1 (binding) Thanks, Greg On Fri, Oct 6, 2023 at 9:05 AM Chris Egerton wrote: > >

[VOTE] KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-10-06 Thread Chris Egerton
Hi all, I'd like to call for a vote on KIP-976, which augments the existing dynamic logger adjustment REST API for Kafka Connect to apply changes cluster-wide instead on a per-worker basis. The KIP:

[jira] [Created] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2023-10-06 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15561: -- Summary: Client support for new SubscriptionPattern based subscription Key: KAFKA-15561 URL: https://issues.apache.org/jira/browse/KAFKA-15561 Project: Kafka

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2262

2023-10-06 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-714: Client metrics and observability

2023-10-06 Thread Andrew Schofield
Hi Matthias, Thanks for your comments. I agree that a follow-up KIP for Kafka Streams makes sense. This KIP currently has made a bit of an effort to embrace KS, but it’s not enough by a long way. I have removed `application.id `. This should be done properly in the

[VOTE] KIP-960: Support single-key_single-timestamp interactive queries (IQv2) for versioned state stores

2023-10-06 Thread Alieh Saeedi
Hi everyone, Since KIP-960 is reduced to the simplest IQ type and all further comments are related to the following-up KIPs, I decided to finalize it at this point. A huge thank you to everyone who has reviewed this KIP (and also the following-up ones), and participated in the discussion

Re: [PR] MINOR Update default docs point to 3.6.0 release docs [kafka-site]

2023-10-06 Thread via GitHub
divijvaidya commented on code in PR #556: URL: https://github.com/apache/kafka-site/pull/556#discussion_r1348427549 ## downloads.html: ## @@ -6,12 +6,41 @@ Download -3.5.1 is the latest release. The current stable version is 3.5.1 +3.6.0 is the latest

Re: [PR] KAFKA-15530: Add 3.6 metrics documentation for new transactions metrics [kafka-site]

2023-10-06 Thread via GitHub
divijvaidya merged PR #555: URL: https://github.com/apache/kafka-site/pull/555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-15560) Upgrade argparse4j to 0.9.0

2023-10-06 Thread Siddharth R (Jira)
Siddharth R created KAFKA-15560: --- Summary: Upgrade argparse4j to 0.9.0 Key: KAFKA-15560 URL: https://issues.apache.org/jira/browse/KAFKA-15560 Project: Kafka Issue Type: Improvement

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2261

2023-10-06 Thread Apache Jenkins Server
See Changes: -- [...truncated 316223 lines...] Gradle Test Run :streams:test > Gradle Test Executor 88 > TasksTest >

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-06 Thread Yash Mayya
Hi Chris, I've updated the KIP to call out the parsing logic and the user expectations explicitly. Thanks again for all your feedback on this KIP! I'll wait for a few more days to see if anyone else has comments before kicking off a vote thread. Thanks, Yash On Thu, Oct 5, 2023 at 10:49 PM

Re: [PR] Added a blog entry for 3.6.0 release [kafka-site]

2023-10-06 Thread via GitHub
satishd commented on PR #547: URL: https://github.com/apache/kafka-site/pull/547#issuecomment-1750070114 @mimaison I did not update the PR completely earlier based on the review comments as we were planning to update the KIP items section with more details as received from others'

Re: [PR] Added a blog entry for 3.6.0 release [kafka-site]

2023-10-06 Thread via GitHub
satishd commented on PR #547: URL: https://github.com/apache/kafka-site/pull/547#issuecomment-1750064512 @mimaison Earlier I did not update the PR completely earlier based on the review comments as we were planning to update the KIP items section with more details as received from others'