Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2287

2023-10-13 Thread Apache Jenkins Server
See Changes: -- [...truncated 315757 lines...] Gradle Test Run :core:test > Gradle Test Executor 90 > KafkaZkClientTest > testConditionalUpdatePath() STARTED Gradle Test

Re: [DISCUSS] KIP-988 Streams Standby Task Update Listener

2023-10-13 Thread Colt McNealy
Hello there! Thanks everyone for the comments. There's a lot of back-and-forth going on, so I'll do my best to summarize what everyone's said in TLDR format: 1. Rename `onStandbyUpdateStart()` -> `onUpdateStart()`, and do similarly for the other methods. 2. Keep `SuspendReason.PROMOTED` and

Re: [DISCUSS] KIP-988 Streams Standby Task Update Listener

2023-10-13 Thread Eduwer Camacaro
Hello everyone, Thanks for all your feedback for this KIP! I think that the key to choosing proper names for this API is understanding the terms used inside the StoreChangelogReader. Currently, this class has two possible states: ACTIVE_RESTORING and STANDBY_UPDATING. In my opinion, using

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

2023-10-13 Thread Guozhang Wang
Hello Nick, First of all, thanks a lot for the great effort you've put in driving this KIP! I really like it coming through finally, as many people in the community have raised this. At the same time I honestly feel a bit ashamed for not putting enough of my time supporting it and pushing it

Re: [DISCUSS] KIP-988 Streams Standby Task Update Listener

2023-10-13 Thread Guozhang Wang
Hello Colt, Thanks for writing the KIP! I have read through the updated KIP and overall it looks great. I only have minor naming comments (well, aren't naming the least boring stuff to discuss and that takes the most of the time for KIPs :P): 1. I tend to agree with Sophie regarding whether or

Re: [DISCUSS] KIP-968: Support single-key_multi-timestamp interactive queries (IQv2) for versioned state stores

2023-10-13 Thread Guozhang Wang
Thanks Alieh for the KIP, as well as a nice summary of all the discussions! Just my 2c regarding your open questions: 1. I just checked KIP-889 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-889%3A+Versioned+State+Stores) and we used "VersionedRecord get(K key, long asOfTimestamp);", so I

Re: [VOTE] KIP-714: Client metrics and observability

2023-10-13 Thread Jun Rao
Hi, Andrew, Thanks for the KIP. +1 from me too. Jun On Wed, Oct 11, 2023 at 4:00 PM Sophie Blee-Goldman wrote: > This looks great! +1 (binding) > > Sophie > > On Wed, Oct 11, 2023 at 1:46 PM Matthias J. Sax wrote: > > > +1 (binding) > > > > On 9/13/23 5:48 PM, Jason Gustafson wrote: > > >

[jira] [Created] (KAFKA-15606) Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()

2023-10-13 Thread Kirk True (Jira)
Kirk True created KAFKA-15606: - Summary: Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval() Key: KAFKA-15606 URL: https://issues.apache.org/jira/browse/KAFKA-15606 Project: Kafka

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2286

2023-10-13 Thread Apache Jenkins Server
See Changes: -- [...truncated 210073 lines...] Gradle Test Run :streams:test > Gradle Test Executor 84 > DefaultStateUpdaterTest > shouldDrainRestoredActiveTasks()

Re: [DISCUSS] KIP-714: Client metrics and observability

2023-10-13 Thread Andrew Schofield
Hi Jun, Thanks for the clarifications. 131. The client instance ids returned from KafkaStreams.clientInstanceIds(Duration) correspond to the client_instance_id labels added by the broker to the metrics pushed from the clients. This should be sufficient information to enable correlation between

[jira] [Created] (KAFKA-15605) Topic marked for deletion are incorrectly migrated to KRaft

2023-10-13 Thread David Arthur (Jira)
David Arthur created KAFKA-15605: Summary: Topic marked for deletion are incorrectly migrated to KRaft Key: KAFKA-15605 URL: https://issues.apache.org/jira/browse/KAFKA-15605 Project: Kafka

Re: [PR] MINOR Add note about KAFKA-15552 to 3.6 upgrade section [kafka-site]

2023-10-13 Thread via GitHub
ijuma commented on code in PR #560: URL: https://github.com/apache/kafka-site/pull/560#discussion_r1358724223 ## 36/upgrade.html: ## @@ -84,7 +84,9 @@ Upgrading KRaft-based cl Notable changes in 3.6.0 -Apache Kafka now supports having both an IPv4 and an

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2285

2023-10-13 Thread Apache Jenkins Server
See

Re: [PR] MINOR Add note about KAFKA-15552 to 3.6 upgrade section [kafka-site]

2023-10-13 Thread via GitHub
jolshan commented on code in PR #560: URL: https://github.com/apache/kafka-site/pull/560#discussion_r1358710418 ## 36/upgrade.html: ## @@ -84,7 +84,9 @@ Upgrading KRaft-based cl Notable changes in 3.6.0 -Apache Kafka now supports having both an IPv4 and an

Re: [DISCUSS] KIP-983: Full speed async processing during rebalance

2023-10-13 Thread David Jacot
Hi Erik, Thanks for the KIP. I haven’t fully read the KIP yet but I agree with the weaknesses that you point out in it. I will continue to read it. For your information, we are working full speed on implementing KIP-848 while also changing the internal threading model of consumer. Those changes

[PR] Add note about KAFKA-15552 to 3.6 upgrade section [kafka-site]

2023-10-13 Thread via GitHub
mumrah opened a new pull request, #560: URL: https://github.com/apache/kafka-site/pull/560 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [DISCUSS] KIP-983: Full speed async processing during rebalance

2023-10-13 Thread Erik van Oosten
Thanks Philip, No worries, I am not in a hurry. Knowing this is not forgotten is enough for me. If there is anything I can do to help the process please let me know. Kind regards,     Erik. Op 13-10-2023 om 20:29 schreef Philip Nee: Hi Erik, Sorry for the delay, I have not finished

Re: [DISCUSS] KIP-983: Full speed async processing during rebalance

2023-10-13 Thread Philip Nee
Hi Erik, Sorry for the delay, I have not finished reviewing the KIP, but I also have not forgotten about it! In general, KIP review process can be lengthy, so I think mailing list is the best bet to get the committer's attention. P On Fri, Oct 13, 2023 at 10:55 AM Erik van Oosten wrote: > Hi

Re: [DISCUSS] KIP-983: Full speed async processing during rebalance

2023-10-13 Thread Erik van Oosten
Hi client developers, The text is updated so that it is more clear that you can only use auto-commit when doing synchronous processing (approach 1). I am assuming that auto-commit commits whatever was consumed in the previous poll. I am wondering why this KIP doesn't get more attention. Is

Re: Requesting permission for contributions

2023-10-13 Thread Apoorv Mittal
Thank you Matthias. Regards, Apoorv Mittal On Fri, Oct 13, 2023 at 5:55 PM Matthias J. Sax wrote: > Done. You should be all set. > > -Matthias > > On 10/13/23 8:21 AM, Apoorv Mittal wrote: > > Hi, > > Can I please get permission to contribute KIP and assign Jiras to myself. > > > > Wiki and

Re: Requesting permission for contributions

2023-10-13 Thread Matthias J. Sax
Done. You should be all set. -Matthias On 10/13/23 8:21 AM, Apoorv Mittal wrote: Hi, Can I please get permission to contribute KIP and assign Jiras to myself. Wiki and Jira Id: apoorvmittal10 Email: apoorvmitta...@gmail.com Regards, Apoorv Mittal +44 7721681581

[jira] [Created] (KAFKA-15604) Add Telemetry RPCs Definitions

2023-10-13 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15604: - Summary: Add Telemetry RPCs Definitions Key: KAFKA-15604 URL: https://issues.apache.org/jira/browse/KAFKA-15604 Project: Kafka Issue Type: Sub-task

Re: [DISCUSS] 3.5.2 Release

2023-10-13 Thread Matthias J. Sax
Thanks -- there is a few fixed for Kafka Streams we are considering to cherry-pick to get into 3.5.2 release -- can you give us a few more days for this? -Matthias On 10/12/23 6:20 PM, Sophie Blee-Goldman wrote: Thanks for volunteering Luke! On Thu, Oct 12, 2023 at 2:55 AM Levani Kokhreidze

Re: [PR] MINOR: fix Kafka Streams metric names [kafka-site]

2023-10-13 Thread via GitHub
mjsax merged PR #558: URL: https://github.com/apache/kafka-site/pull/558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-13 Thread Hanyu (Peter) Zheng
Thank you, Matthias and Alieh, I've initiated a vote. Sincerely, Hanyu On Fri, Oct 13, 2023 at 9:14 AM Matthias J. Sax wrote: > Thanks for pointing this out Alieh! I totally missed this. > > So I guess everything is settled and Hanyu can start a VOTE? > > For the KIP PR, we should ensure to

Re: [VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-13 Thread Hanyu (Peter) Zheng
Hello everyone, I would like to start a vote for KIP-985 that Add reverseRange and reverseAll query over kv-store in IQv2. Sincerely, Hanyu On Fri, Oct 13, 2023 at 9:15 AM Hanyu (Peter) Zheng wrote: > >

[jira] [Created] (KAFKA-15603) kafka-dump-log --offsets-decoder should handle parsing errors

2023-10-13 Thread David Jacot (Jira)
David Jacot created KAFKA-15603: --- Summary: kafka-dump-log --offsets-decoder should handle parsing errors Key: KAFKA-15603 URL: https://issues.apache.org/jira/browse/KAFKA-15603 Project: Kafka

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2284

2023-10-13 Thread Apache Jenkins Server
See

[VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-13 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-985:+Add+reverseRange+and+reverseAll+query+over+kv-store+in+IQv2 -- [image: Confluent] Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (213) 431-7193 <+1+(213)+431-7193> Follow us: [image: Blog]

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-13 Thread Matthias J. Sax
Thanks for pointing this out Alieh! I totally missed this. So I guess everything is settled and Hanyu can start a VOTE? For the KIP PR, we should ensure to update the JavaDocs to avoid confusion in the future. -Matthias On 10/12/23 12:21 PM, Alieh Saeedi wrote: Hi, just pointing to

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

2023-10-13 Thread Nick Telford
Hi Bruno, 4. I'll hold off on making that change until we have a consensus as to what configuration to use to control all of this, as it'll be affected by the decision on EOS isolation levels. 5. Done. I've chosen "committedOffsets". Regards, Nick On Fri, 13 Oct 2023 at 16:23, Bruno Cadonna

Requesting permission for contributions

2023-10-13 Thread Apoorv Mittal
Hi, Can I please get permission to contribute KIP and assign Jiras to myself. Wiki and Jira Id: apoorvmittal10 Email: apoorvmitta...@gmail.com Regards, Apoorv Mittal +44 7721681581

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

2023-10-13 Thread Bruno Cadonna
Hi Nick, 1. Yeah, you are probably right that it does not make too much sense. Thanks for the clarification! 4. Yes, sorry for the back and forth, but I think for the sake of the KIP it is better to let the ALOS behavior as it is for now due to the possible issues you would run into. Maybe

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.6 #92

2023-10-13 Thread Apache Jenkins Server
See Changes: -- [...truncated 306736 lines...] Gradle Test Run :core:test > Gradle Test Executor 90 > TransactionsTest > testBumpTransactionalEpoch(String) >

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2283

2023-10-13 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

2023-10-13 Thread Nick Telford
Hi Bruno, Thanks for getting back to me. 1. I think this should be possible. Are you thinking of the situation where a user may downgrade to a previous version of Kafka Streams? In that case, sadly, the RocksDBStore would get wiped by the older version of Kafka Streams anyway, because that

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

2023-10-13 Thread Bruno Cadonna
Hi Nick, I think the KIP is converging! 1. I am wondering whether it makes sense to write the position file during close as we do for the checkpoint file, so that in case the state store is replaced with a non-transactional state store the non-transactional state store finds the position

Re: [DISCUSS] KIP-892: Transactional Semantics for StateStores

2023-10-13 Thread Nick Telford
Hi Sophie, Thanks for taking the time to review the KIP and catch up. > my singular goal in responding is to help this KIP past a perceived impasse so we can finally move on to voting and implementing it Just so we're clear, is the impasse you're referring to this limitation in the current

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2282

2023-10-13 Thread Apache Jenkins Server
See Changes: -- [...truncated 315602 lines...] Gradle Test Run :streams:test > Gradle Test Executor 84 > DefaultStateUpdaterTest > shouldDrainRestoredActiveTasks()

Re: [DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-10-13 Thread Christo Lolov
Heya Gantigmaa, Apologies for the (very) late reply! Now that 3.6 has been released and reviewers have a bit more time I will be picking up this KIP again. I am more than happy to add useful new metrics to the KIP, I would just ask for a couple of days to review your pull request and I will come

Re: [PR] Add upgrade documentation for 3.6.0 [kafka-site]

2023-10-13 Thread via GitHub
showuon merged PR #559: URL: https://github.com/apache/kafka-site/pull/559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add upgrade documentation for 3.6.0 [kafka-site]

2023-10-13 Thread via GitHub
fvaleri opened a new pull request, #559: URL: https://github.com/apache/kafka-site/pull/559 This change adds the upgrade documentation for 3.6.0 and fix the notable changes position in 3.5.0. In previous releases, notable changes always come after the upgrade instructions. -- This is an