Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-11-18 Thread Guozhang Wang
Hello Almog, I left a comment in the PR before I got to read the newest updates from this thread. My 2c: 1. I liked the idea of delaying the instantiation of StoreBuiler from suppliers after the Topology is created. It has been a bit annoying for many other features we were trying back then. The

Re: [VOTE] KIP-968: Support single-key_multi-timestamp interactive queries (IQv2) for versioned state stores

2023-11-18 Thread Guozhang Wang
Thanks Alieh, I read through the wiki page and the DISCUSS thread, all LGTM except a minor thing in javadoc: "The query returns the records with a global ascending order of keys. The records with the same key are ordered based on their insertion timestamp in ascending order. Both the global and

Re: [DISCUSS] KIP-924: customizable task assignment for Streams

2023-11-18 Thread Guozhang Wang
Hi Rohan, I took another look at the updated wiki page and do not have any major questions. Regarding returning a plugin object v.s. configuring a plugin object, I do not have a strong opinion except that the latter seems more consistent with existing patterns. Just curious, any other motivations

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2393

2023-11-18 Thread Apache Jenkins Server
See Changes: -- [...truncated 435226 lines...] Gradle Test Run :streams:test > Gradle Test Executor 89 > DefaultTaskManagerTest >

[jira] [Created] (KAFKA-15854) Move Java classes from kafka.server to the server module

2023-11-18 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15854: --- Summary: Move Java classes from kafka.server to the server module Key: KAFKA-15854 URL: https://issues.apache.org/jira/browse/KAFKA-15854 Project: Kafka Issue

Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-11-18 Thread Almog Gavra
Hello Everyone - one more minor change to the KIP that came up during implementation (reflected in the KIP itself). I will be adding the method below to TopologyConfig. This allows us to determine whether or not the DslStoreSuppliers was explicitly passed in via either

[jira] [Created] (KAFKA-15853) Move KafkaConfig to server module

2023-11-18 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15853: --- Summary: Move KafkaConfig to server module Key: KAFKA-15853 URL: https://issues.apache.org/jira/browse/KAFKA-15853 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-15852) Move broker code from `core` to `broker` module

2023-11-18 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15852: --- Summary: Move broker code from `core` to `broker` module Key: KAFKA-15852 URL: https://issues.apache.org/jira/browse/KAFKA-15852 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-18 Thread Andrew Schofield
Hi Jun, This is an example of inconsistency between the tools. I do agree that it would be nice to have `--list` on the `kafka-client-metrics.sh` tool. However, `kafka-config.sh` has the convention that `--describe` with no entity name supplied first gets a list of all the entities, and then