/Compressor.java
0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
428968cd38a7b12991f87868bf759926ff7e594e
Diff: https://reviews.apache.org/r/22063/diff/
Testing
---
Thanks,
Dong Lin
5559d26ba2b96059f719754a351fa4598ca8a70b
Diff: https://reviews.apache.org/r/22905/diff/
Testing
---
Thanks,
Dong Lin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22905/#review46576
---
On June 24, 2014, 2:02 a.m., Dong Lin wrote
Diff: https://reviews.apache.org/r/22905/diff/
Testing
---
Thanks,
Dong Lin
/
Testing
---
Thanks,
Dong Lin
/
Testing
---
Thanks,
Dong Lin
5559d26ba2b96059f719754a351fa4598ca8a70b
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23568/diff/
Testing
---
Thanks,
Dong Lin
/browse/KAFKA-1525
Repository: kafka
Description
---
KAFKA-1525 DumpLogSegments
Diffs
-
core/src/main/scala/kafka/tools/DumpLogSegments.scala
6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
Diff: https://reviews.apache.org/r/23569/diff/
Testing
---
Thanks,
Dong Lin
://reviews.apache.org/r/23568/#comment84260
Need to specify txId = txRequest.requestInfo.txId in Message construction.
- Dong Lin
On July 16, 2014, 9:29 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23568/diff/
Testing
---
Thanks,
Dong Lin
/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
-CREATION
core/src/main/scala/kafka/common/ErrorMapping.scala
5559d26ba2b96059f719754a351fa4598ca8a70b
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23568/diff/
Testing
---
Thanks,
Dong Lin
core/src/main/scala/kafka/common/ErrorMapping.scala
5559d26ba2b96059f719754a351fa4598ca8a70b
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23568/diff/
Testing
---
Thanks,
Dong Lin
/browse/KAFKA-1550
Repository: kafka
Description
---
KAFKA-1550 Patch review tool should use git format-patch to generate patch
Diffs
-
kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef
Diff: https://reviews.apache.org/r/23692/diff/
Testing
---
Thanks,
Dong
---
On July 22, 2014, 6:41 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23692/
---
(Updated July 22, 2014
://reviews.apache.org/r/23692/diff/
Testing
---
Thanks,
Dong Lin
, visit:
https://reviews.apache.org/r/23569/#review48416
---
On July 16, 2014, 9:30 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/23569/diff/
Testing
---
Thanks,
Dong Lin
core/src/main/scala/kafka/common/ErrorMapping.scala
5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23568/diff/
Testing
---
Thanks,
Dong Lin
---
Thanks,
Dong Lin
/23567/#review48259
---
On July 22, 2014, 11:43 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23567
/23568/#review48261
---
On July 22, 2014, 11:45 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23568
/main/scala/kafka/tools/DumpLogSegments.scala
6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
Diff: https://reviews.apache.org/r/23569/diff/
Testing
---
Thanks,
Dong Lin
/RequestResponseSerializationTest.scala
a2117b34c2ee3554602fe068eed0c90b075958c1
kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef
Diff: https://reviews.apache.org/r/24340/diff/
Testing
---
Thanks,
Dong Lin
dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/24340/diff/
Testing
---
Thanks,
Dong Lin
/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/24340/diff/
Testing
---
Thanks,
Dong Lin
/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/24340/diff/
Testing
---
Thanks,
Dong Lin
/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
Diff: https://reviews.apache.org/r/23568/diff/
Testing
---
Thanks,
Dong Lin
/scala/kafka/common/ErrorMapping.scala
5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
cd16ced5465d098be7a60498326b2a98c248f343
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
.
- Dong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23568/#review49692
---
On Aug. 6, 2014, 4:25 a.m., Dong Lin wrote
sense?
- Dong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23568/#review49696
---
On Aug. 6, 2014, 4:25 a.m., Dong Lin wrote
that took over has a small batch size now, even though
the version has incremented the new range now overlaps then right? It might
already been handled but just want to throw it out there.
Dong Lin wrote:
Sure. Thanks for taking time to help think about it.
Here I assume
that took over has a small batch size now, even though
the version has incremented the new range now overlaps then right? It might
already been handled but just want to throw it out there.
Dong Lin wrote:
Sure. Thanks for taking time to help think about it.
Here I assume
that took over has a small batch size now, even though
the version has incremented the new range now overlaps then right? It might
already been handled but just want to throw it out there.
Dong Lin wrote:
Sure. Thanks for taking time to help think about it.
Here I assume
,
Dong Lin
core/src/main/scala/kafka/common/ErrorMapping.scala
5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
cd16ced5465d098be7a60498326b2a98c248f343
Diff: https://reviews.apache.org/r/23567/diff/
Testing
---
Thanks,
Dong Lin
://reviews.apache.org/r/24510/diff/
Testing
---
Thanks,
Dong Lin
://reviews.apache.org/r/24510/#review50127
---
On Aug. 11, 2014, 4:23 a.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24510
. Thanks!
- Dong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23567/#review50663
---
On Aug. 15, 2014, 6:37 p.m., Dong Lin wrote
/diff/
Testing
---
Thanks,
Dong Lin
/diff/
Testing
---
Thanks,
Dong Lin
://reviews.apache.org/r/24874/diff/
Testing
---
Thanks,
Dong Lin
7602b8d705970a5dab49ed36d117346a960701ac
Diff: https://reviews.apache.org/r/24874/diff/
Testing
---
Thanks,
Dong Lin
/tools/SimpleConsumerPerformance.scala
7602b8d705970a5dab49ed36d117346a960701ac
Diff: https://reviews.apache.org/r/24874/diff/
Testing
---
Thanks,
Dong Lin
6edd64a92ce749421b5ab60fbea5b55e2ccbfe94
Diff: https://reviews.apache.org/r/24874/diff/
Testing
---
Thanks,
Dong Lin
323fc8566d974acc4e5c7d7c2a065794f3b5df4a
core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala
7602b8d705970a5dab49ed36d117346a960701ac
Diff: https://reviews.apache.org/r/24874/diff/
Testing
---
Thanks,
Dong Lin
/kafka_system_test_utils.py
6edd64a92ce749421b5ab60fbea5b55e2ccbfe94
Diff: https://reviews.apache.org/r/24874/diff/
Testing
---
Thanks,
Dong Lin
: https://reviews.apache.org/r/24856/diff/
Testing
---
Thanks,
Dong Lin
., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24856/
---
(Updated Aug. 20, 2014, 4:10 a.m.)
Review request
: https://reviews.apache.org/r/24856/diff/
Testing
---
Thanks,
Dong Lin
7d90fceffd4a92460c616f8bacd78057a38a3c16
Diff: https://reviews.apache.org/r/24992/diff/
Testing
---
Thanks,
Dong Lin
/requests/MetadataResponse.java
7d90fceffd4a92460c616f8bacd78057a38a3c16
Diff: https://reviews.apache.org/r/24992/diff/
Testing
---
Thanks,
Dong Lin
/kafka/common/requests/MetadataResponse.java
7d90fceffd4a92460c616f8bacd78057a38a3c16
Diff: https://reviews.apache.org/r/24992/diff/
Testing
---
Thanks,
Dong Lin
, visit:
https://reviews.apache.org/r/24992/#review51317
---
On Aug. 22, 2014, 8:04 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24992/
---
(Updated Aug. 22, 2014, 8:04 p.m.)
Review request
/requests/MetadataResponse.java
7d90fceffd4a92460c616f8bacd78057a38a3c16
Diff: https://reviews.apache.org/r/24992/diff/
Testing
---
Thanks,
Dong Lin
is updated.
- Dong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24992/#review51327
---
On Aug. 22, 2014, 11:22 p.m., Dong Lin wrote
., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33557/
---
(Updated April 27, 2015, 4:26 a.m.)
Review request
://reviews.apache.org/r/33557/diff/
Testing
---
Thanks,
Dong Lin
/test/scala/unit/kafka/server/OffsetCommitTest.scala
652208a70f66045b854549d93cbbc2b77c24b10b
Diff: https://reviews.apache.org/r/33557/diff/
Testing
---
Thanks,
Dong Lin
:
https://reviews.apache.org/r/33557/#review82392
---
On May 4, 2015, 10:18 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/33378/#comment134302
Should delayTimeSize be deducted from expectedBytesToWrite?
- Dong Lin
On May 11, 2015, 9:51 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/33378/#comment134427
Will readFromLocalLog() read data into memory before the cilent's quota is
checked?
- Dong Lin
On May 11, 2015, 9:51 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail
violaation, and calculate delayTime
based on this violation.
Should we enumerate all metric in this.metrics() and set delayTime of the
QuotaViolationException to be the largest delayTime of all violatoins?
- Dong Lin
On May 11, 2015, 11:17 p.m., Aditya Auradkar wrote
/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java
b341b7daaa10204906d78b812fb05fd27bc69373
Diff: https://reviews.apache.org/r/34170/diff/
Testing
---
Thanks,
Dong Lin
. To reply, visit:
https://reviews.apache.org/r/34170/#review83629
---
On May 13, 2015, 3:47 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/33049/#comment135148
Do you mean RequestKeys.nameForKey(RequestKeys.FetchKey)?
- Dong Lin
On May 11, 2015, 11:17 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
do we need that? Isn't purging obsolete samples
handled on measurement already? I think that is more elegant. You must see
some issue there, maybe you can explain?
Dong Lin wrote:
Adi: Good catch! I will update the patch to fix the problem.
Jay: Sure. Here is the problem I
On May 12, 2015, 7:38 p.m., Dong Lin wrote:
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, lines
122-127
https://reviews.apache.org/r/33049/diff/9/?file=955824#file955824line122
The function quits on the first quota violaation, and calculate
delayTime based
/stats/SampledStat.java
b341b7daaa10204906d78b812fb05fd27bc69373
Diff: https://reviews.apache.org/r/34170/diff/
Testing
---
Thanks,
Dong Lin
shrinks to zero but why is giving back 0 the right answer? In
the case you guys were testing 0 was safe, but imagine a case where the
monitoring was checking that the value didn't fall below some threshold.
Dong Lin wrote:
The question is, when Rate.measure() is called right after
shrinks to zero but why is giving back 0 the right answer? In
the case you guys were testing 0 was safe, but imagine a case where the
monitoring was checking that the value didn't fall below some threshold.
Dong Lin wrote:
The question is, when Rate.measure() is called right after
?
- Dong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170/#review83687
---
On May 13, 2015, 10:32 p.m., Dong Lin wrote
/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java
b341b7daaa10204906d78b812fb05fd27bc69373
Diff: https://reviews.apache.org/r/34170/diff/
Testing
---
Thanks,
Dong Lin
/test/scala/unit/kafka/server/OffsetCommitTest.scala
528525b719ec916e16f8b3ae3715bec4b5dcc47d
Diff: https://reviews.apache.org/r/33557/diff/
Testing
---
Thanks,
Dong Lin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33557/#review83234
---
On May 12, 2015, 2:32 p.m., Dong Lin wrote
/unit/kafka/server/OffsetCommitTest.scala
528525b719ec916e16f8b3ae3715bec4b5dcc47d
Diff: https://reviews.apache.org/r/33557/diff/
Testing
---
Thanks,
Dong Lin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33557/#review83398
---
On May 12, 2015, 3:02 p.m., Dong Lin wrote
do we need that? Isn't purging obsolete samples
handled on measurement already? I think that is more elegant. You must see
some issue there, maybe you can explain?
Dong Lin wrote:
Adi: Good catch! I will update the patch to fix the problem.
Jay: Sure. Here is the problem I
for quota implementation.
- Dong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170/#review84341
---
On May 14, 2015, 7:34 a.m., Dong Lin
---
On May 14, 2015, 7:34 a.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170
On May 19, 2015, 5:41 p.m., Dong Lin wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line
64
https://reviews.apache.org/r/34418/diff/1/?file=963982#file963982line64
Hey Jay,
My approach differs with your only in this line
31a2639477bf66f9a05d2b9b07794572d7ec393b
core/src/main/scala/kafka/server/AbstractFetcherThread.scala
83fc47417dd7fe4edf030217fa7fd69d99b170b0
Diff: https://reviews.apache.org/r/34965/diff/
Testing
---
Thanks,
Dong Lin
---
On June 3, 2015, 10:30 p.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34965
/kafka/server/AbstractFetcherThread.scala
83fc47417dd7fe4edf030217fa7fd69d99b170b0
Diff: https://reviews.apache.org/r/34965/diff/
Testing
---
Thanks,
Dong Lin
/
Testing
---
Thanks,
Dong Lin
Diff: https://reviews.apache.org/r/35791/diff/
Testing
---
Thanks,
Dong Lin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35791/#review89010
---
On June 23, 2015, 5:41 p.m., Dong Lin wrote
method?
Dong Lin wrote:
I have thought about it as well. But probabaly no. Because in
Selector.send() we put failed destinationId is put in failedSends rather than
disconnected. The reason we use failedSends is because send() and poll() in
Selector will be called asynchronously
method?
Dong Lin wrote:
I have thought about it as well. But probabaly no. Because in
Selector.send() we put failed destinationId is put in failedSends rather than
disconnected. The reason we use failedSends is because send() and poll() in
Selector will be called asynchronously
/Selector.java
4aee214b24fd990be003adc36d675f015bf22fe6
Diff: https://reviews.apache.org/r/35791/diff/
Testing
---
Thanks,
Dong Lin
method?
Dong Lin wrote:
I have thought about it as well. But probabaly no. Because in
Selector.send() we put failed destinationId is put in failedSends rather than
disconnected. The reason we use failedSends is because send() and poll() in
Selector will be called asynchronously
1 - 100 of 1118 matches
Mail list logo
