[jira] [Resolved] (KAFKA-1859) Can`t run kafka vagrant images on Windows 7

2015-01-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-1859. -- Resolution: Won't Fix Assignee: Ewen Cheslack-Postava Can`t run kafka

Re: Heads up: KAFKA-1697 - remove code related to ack1 on the broker

2015-01-15 Thread Ewen Cheslack-Postava
Right, so this looks like it could create an issue similar to what's currently being discussed in https://issues.apache.org/jira/browse/KAFKA-1649 where users now get errors under conditions when they previously wouldn't. Old clients won't even know about the error code, so besides failing they

Re: [kafka-clients] Re: Heads up: KAFKA-1697 - remove code related to ack1 on the broker

2015-01-15 Thread Ewen Cheslack-Postava
original intentions of having it because of the 0.7=-0.8. We said no more breaking changes when we did that. - Joe Stein On Thu, Jan 15, 2015 at 12:38 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Right, so this looks like it could create an issue similar to what's

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-01-21 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286967#comment-14286967 ] Ewen Cheslack-Postava commented on KAFKA-1835: -- [~ppearcy] these are easier

[jira] [Commented] (KAFKA-1876) pom file for scala 2.11 should reference a specific version

2015-01-19 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282784#comment-14282784 ] Ewen Cheslack-Postava commented on KAFKA-1876: -- Based on the output

Re: [DISCUSS] KIPs

2015-01-16 Thread Ewen Cheslack-Postava
I think adding a section about deprecation would be helpful. A good fraction of the time I would expect the goal of a KIP is to fix or replace older functionality that needs continued support for compatibility, but should eventually be phased out. This helps Kafka devs understand how long they'll

Re: [kafka-clients] Re: Heads up: KAFKA-1697 - remove code related to ack1 on the broker

2015-01-16 Thread Ewen Cheslack-Postava
help make that call. Am I missing anything? Should I start a KIP? It seems like a KIP-type discussion :) Gwen On Thu, Jan 15, 2015 at 2:31 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Gwen, I think the only option that wouldn't require a protocol version change

Re: Review Request 27799: New consumer

2015-01-23 Thread Ewen Cheslack-Postava
since this result node is used for consumerCoordinator and other code compares node IDs? core/src/main/scala/kafka/tools/ConsumerPerformance.scala https://reviews.apache.org/r/27799/#comment114069 Lots of unused import cleanup here. - Ewen Cheslack-Postava On Jan. 23, 2015, 4:22 a.m

[jira] [Updated] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2015-01-05 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1642: - Attachment: KAFKA-1642_2015-01-05_18:56:55.patch [Java New Producer Kafka Trunk

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2015-01-05 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14265602#comment-14265602 ] Ewen Cheslack-Postava commented on KAFKA-1642: -- Updated reviewboard https

Re: Review Request 28582: Patch for KAFKA-1642

2015-01-05 Thread Ewen Cheslack-Postava
(updated) - clients/src/main/java/org/apache/kafka/clients/NetworkClient.java 525b95e98010cd2053eacd8c321d079bcac2f910 Diff: https://reviews.apache.org/r/28582/diff/ Testing --- Thanks, Ewen Cheslack-Postava

Re: Follow-up On Important Issues for 0.8.2

2015-01-09 Thread Ewen Cheslack-Postava
Bhavesh, 1. I would expect the behavior you're suggesting as well. Any fix for the JIRA should address this, and I raised that point when reviewing the current version of the patch. 2. It's currently marked for 0.8.3 so it probably won't make it into 0.8.2, especially if there isn't a patch for

Re: Review Request 29752: Patch for KAFKA-1836

2015-01-09 Thread Ewen Cheslack-Postava
maxWaitMs instead of remainingWaitMs. There's no functional difference, but I think checking remainingWaitMs instead would be clearer for someone reading this code. - Ewen Cheslack-Postava On Jan. 9, 2015, 3:59 a.m., Jaikiran Pai wrote

Re: Review Request 29751: Patch for kafka-1851

2015-01-09 Thread Ewen Cheslack-Postava
. - Ewen Cheslack-Postava On Jan. 9, 2015, 2:53 a.m., Jun Rao wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29751/ --- (Updated

[jira] [Created] (KAFKA-1843) Metadata fetch/refresh in new producer should handle all node connection states gracefully

2015-01-06 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-1843: Summary: Metadata fetch/refresh in new producer should handle all node connection states gracefully Key: KAFKA-1843 URL: https://issues.apache.org/jira/browse

[jira] [Created] (KAFKA-1842) New producer/consumer should support configurable connection timeouts

2015-01-06 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-1842: Summary: New producer/consumer should support configurable connection timeouts Key: KAFKA-1842 URL: https://issues.apache.org/jira/browse/KAFKA-1842

Re: Review Request 29379: Patch for KAFKA-1788

2015-01-06 Thread Ewen Cheslack-Postava
this no longer applies to trunk due to 50b734690, so it'll need rebasing. - Ewen Cheslack-Postava On Jan. 6, 2015, 6:44 p.m., Parth Brahmbhatt wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379

[jira] [Commented] (KAFKA-1859) Can`t run kafka vagrant images on Windows 7

2015-01-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275610#comment-14275610 ] Ewen Cheslack-Postava commented on KAFKA-1859: -- I'm not sure how much we can

[jira] [Commented] (KAFKA-1934) Add a shutdownNow() call to new producer

2015-02-08 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311689#comment-14311689 ] Ewen Cheslack-Postava commented on KAFKA-1934: -- There was previous discussion

Re: Kafka New(Java) Producer Connection reset by peer error and LB

2015-02-10 Thread Ewen Cheslack-Postava
Bhavesh, I'm unclear what the impact is here. The line numbers don't match up exactly with trunk or 0.8.2.0, but it looks like this exception is just caught and logged. As far as I can tell the producer would continue to function normally. Does this have any impact on the producer or is the

Re: Review Request 31040: Patch for kafka-1952

2015-02-14 Thread Ewen Cheslack-Postava
on to? I think the current code probably makes more sense, but I want to check since, given the CPU usage problem wasn't identified in the original patch it seems we previously thought the check was worth it. - Ewen Cheslack-Postava On Feb. 14, 2015, 1:52 a.m., Jun Rao wrote

Re: Kafka New(Java) Producer Connection reset by peer error and LB

2015-02-11 Thread Ewen Cheslack-Postava
ticket for this. We are on non-release 0.8.2 from trunk. Thanks, Bhavesh Thanks, Bhavesh On Tue, Feb 10, 2015 at 12:29 AM, Ewen Cheslack-Postava e...@confluent.io wrote: Bhavesh, I'm unclear what the impact is here. The line numbers don't match up

Re: Review Request 29379: Patch for KAFKA-1788

2015-01-05 Thread Ewen Cheslack-Postava
/apache/kafka/clients/producer/RecordAccumulatorTest.java https://reviews.apache.org/r/29379/#comment110295 This would probably be clearer if it was just batchExpirationMs. - Ewen Cheslack-Postava On Dec. 23, 2014, 8:44 p.m., Parth Brahmbhatt wrote

Re: Review Request 29468: Patch for KAFKA-1805

2015-01-05 Thread Ewen Cheslack-Postava
/ProducerRecord.java https://reviews.apache.org/r/29468/#comment110269 Most of the values in ProducerRecord can be null. That condition needs to be handled here as well as in hashCode() - Ewen Cheslack-Postava On Dec. 30, 2014, 12:37 a.m., Parth Brahmbhatt wrote

[jira] [Commented] (KAFKA-1836) metadata.fetch.timeout.ms set to zero blocks forever

2015-01-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268178#comment-14268178 ] Ewen Cheslack-Postava commented on KAFKA-1836: -- A couple of notes

Re: Review Request 29647: Patch for KAFKA-1697

2015-01-07 Thread Ewen Cheslack-Postava
Cheslack-Postava On Jan. 7, 2015, 12:20 a.m., Gwen Shapira wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647

[jira] [Commented] (KAFKA-1697) remove code related to ack1 on the broker

2015-01-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267940#comment-14267940 ] Ewen Cheslack-Postava commented on KAFKA-1697: -- On a related note (which

Re: [KIP-DISCUSSION] KIP-13 Quotas

2015-03-16 Thread Ewen Cheslack-Postava
Agreed that trying to shoehorn non-error codes into the error field is a bad idea. It makes it *way* too easy to write code that looks (and should be) correct but is actually incorrect. If necessary, I think it's much better to to spend a couple of extra bytes to encode that information separately

Re: [KIP-DISCUSSION] KIP-13 Quotas

2015-03-17 Thread Ewen Cheslack-Postava
- And for implementation we can probably group the codes accordingly like HTTP status code such that we can do: boolean Error.isOK() { return code 300 code = 200; } Guozhang On Mon, Mar 16, 2015 at 10:24 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Agreed

[jira] [Updated] (KAFKA-1915) Integrate checkstyle for java code

2015-03-17 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1915: - Resolution: Fixed Reviewer: Joel Koshy Status: Resolved (was: Patch

[jira] [Updated] (KAFKA-2026) Logging of unused options always shows null for the value and is misleading if the option is used by serializers

2015-03-17 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2026: - Description: This is a really simple issue. When AbstractConfig logs unused

[jira] [Created] (KAFKA-2026) Logging of unused options always shows null for the value and is misleading if the option is used by serializers

2015-03-17 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-2026: Summary: Logging of unused options always shows null for the value and is misleading if the option is used by serializers Key: KAFKA-2026 URL: https

[jira] [Commented] (KAFKA-2030) Creating a topic cause Unsupported major.minor version 52.0

2015-03-18 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368224#comment-14368224 ] Ewen Cheslack-Postava commented on KAFKA-2030: -- It looks like the homebrew

[jira] [Resolved] (KAFKA-2030) Creating a topic cause Unsupported major.minor version 52.0

2015-03-18 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-2030. -- Resolution: Invalid Creating a topic cause Unsupported major.minor version

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-09 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353363#comment-14353363 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- Updated reviewboard https

Re: Review Request 31806: Patch for KAFKA-1501

2015-03-09 Thread Ewen Cheslack-Postava
://reviews.apache.org/r/31806/#review75654 --- On March 9, 2015, 6:41 p.m., Ewen Cheslack-Postava wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 31806: Patch for KAFKA-1501

2015-03-09 Thread Ewen Cheslack-Postava
9897b2fa8f8261fe8ab6b62b45b9052adb07043f core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4 Diff: https://reviews.apache.org/r/31806/diff/ Testing --- Thanks, Ewen Cheslack-Postava

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-09 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1501: - Attachment: KAFKA-1501_2015-03-09_11:41:07.patch transient unit tests failures

Re: adding replicas to existing topic partitions - KAFKA-1313

2015-03-09 Thread Ewen Cheslack-Postava
Geoff, First, if you haven't already, take a look at https://cwiki.apache.org/confluence/display/KAFKA/KIP-6+-+New+reassignment+partition+logic+for+rebalancing and the associated JIRA. My opinion is that we shouldn't do anything to the existing partitions -- it would probably violate the

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-11 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357673#comment-14357673 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- [~guozhang] Yes, that's

Review Request 31806: Patch for KAFKA-1501

2015-03-06 Thread Ewen Cheslack-Postava
/ZooKeeperTestHarness.scala 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4 Diff: https://reviews.apache.org/r/31806/diff/ Testing --- Thanks, Ewen Cheslack-Postava

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-06 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1501: - Attachment: KAFKA-1501.patch transient unit tests failures due to port already

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-06 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350725#comment-14350725 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- Uploaded a wip patch. It gets

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-06 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350706#comment-14350706 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- Created reviewboard https

[jira] [Commented] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

2015-03-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360932#comment-14360932 ] Ewen Cheslack-Postava commented on KAFKA-2020: -- A bit more detail

[jira] [Commented] (KAFKA-2020) I expect ReplicaNotAvailableException to have proper Javadocs

2015-03-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361935#comment-14361935 ] Ewen Cheslack-Postava commented on KAFKA-2020: -- Yes, exactly. I expect

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-12 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359004#comment-14359004 ] Ewen Cheslack-Postava commented on KAFKA-1988: -- [~noxis] Because it wasn't

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-12 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1988: - Fix Version/s: (was: 0.8.2.1) 0.8.3

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-03-12 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359678#comment-14359678 ] Ewen Cheslack-Postava commented on KAFKA-1988: -- [~tongli] You're all good

Re: [jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-03-12 Thread Ewen Cheslack-Postava
I think the real problem is that the conditionals are spread across a bunch of different files. Seven special cases isn't necessarily unsustainable, but is difficult to manage now because they aren't isolated to one location. I think platform specific customizations are sustainable (as long as

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1501: - Attachment: KAFKA-1501_2015-03-25_00:44:50.patch transient unit tests failures

Re: Review Request 31806: Patch for KAFKA-1501

2015-03-25 Thread Ewen Cheslack-Postava
/unit/kafka/zk/ZKPathTest.scala 9897b2fa8f8261fe8ab6b62b45b9052adb07043f core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4 Diff: https://reviews.apache.org/r/31806/diff/ Testing --- Thanks, Ewen Cheslack-Postava

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2015-03-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379451#comment-14379451 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- [~guozhang] Sorry, seems I

Re: Review Request 31806: Patch for KAFKA-1501

2015-03-25 Thread Ewen Cheslack-Postava
--- On March 9, 2015, 6:41 p.m., Ewen Cheslack-Postava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31806

Re: Does system_test work on MacOs?

2015-03-31 Thread Ewen Cheslack-Postava
It's been awhile and I mostly ran them in VMs, but I don't recall having any issues running them on OS X. -Ewen On Tue, Mar 31, 2015 at 6:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Hi, The first line of the system_test README says: This test framework currently doesn't support MacOS

[jira] [Commented] (KAFKA-1995) JMS to Kafka: Inbuilt JMSAdaptor/JMSProxy/JMSBridge (Client can speak JMS but hit Kafka)

2015-03-05 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348342#comment-14348342 ] Ewen Cheslack-Postava commented on KAFKA-1995: -- This sounds like a good idea

Re: Review Request 29379: Patch for KAFKA-1788

2015-02-22 Thread Ewen Cheslack-Postava
On Jan. 6, 2015, 6:43 p.m., Parth Brahmbhatt wrote: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, line 225 https://reviews.apache.org/r/29379/diff/1/?file=799704#file799704line225 sender.completeBatch() is only called as part of produce

[jira] [Commented] (KAFKA-1680) JmxTool exits if no arguments are given

2015-02-22 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333020#comment-14333020 ] Ewen Cheslack-Postava commented on KAFKA-1680: -- Pretty sure this is still

Re: Review Request 29379: Patch for KAFKA-1788

2015-02-22 Thread Ewen Cheslack-Postava
Cheslack-Postava On Jan. 6, 2015, 6:44 p.m., Parth Brahmbhatt wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29379

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

2015-02-22 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333041#comment-14333041 ] Ewen Cheslack-Postava commented on KAFKA-1788: -- Ok, I'll try to clear up

Re: Review Request 31363: Patch for kafka-1984

2015-02-24 Thread Ewen Cheslack-Postava
Cheslack-Postava On Feb. 24, 2015, 5:43 p.m., Jun Rao wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31363/ --- (Updated Feb

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-26 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

[jira] [Updated] (KAFKA-1881) transient unit test failure in testDeleteTopicWithCleaner due to OOME

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1881: - Assignee: Ewen Cheslack-Postava (was: Gwen Shapira) Status: Patch Available

[jira] [Commented] (KAFKA-1881) transient unit test failure in testDeleteTopicWithCleaner due to OOME

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337455#comment-14337455 ] Ewen Cheslack-Postava commented on KAFKA-1881: -- Created reviewboard https

[jira] [Updated] (KAFKA-1881) transient unit test failure in testDeleteTopicWithCleaner due to OOME

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1881: - Attachment: KAFKA-1881.patch transient unit test failure

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
. 25, 2015, 11:27 p.m., Ewen Cheslack-Postava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31447/ --- (Updated Feb. 25, 2015

[jira] [Commented] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337564#comment-14337564 ] Ewen Cheslack-Postava commented on KAFKA-1978: -- [~anigam] Can you explain

Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
: https://reviews.apache.org/r/31447/diff/ Testing --- Thanks, Ewen Cheslack-Postava

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-25 Thread Ewen Cheslack-Postava
/MockProducer.java https://reviews.apache.org/r/30763/#comment120749 synchronized no longer matches the regular non-Mock version. - Ewen Cheslack-Postava On Feb. 26, 2015, 1:16 a.m., Jay Kreps wrote: --- This is an automatically generated e

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-25 Thread Ewen Cheslack-Postava
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: Ah, now I get what dedupe buffer refers to :) I never managed to reproduce the oom, but this looks like the right fix. Ewen Cheslack-Postava wrote: This happened consistently for me, which provided good motivation to figure out

Re: Review Request 31510: Patch for kafka-1400

2015-02-26 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31510/#review74411 --- Ship it! LGTM. Tested 50 times with no failures. - Ewen Cheslack

[jira] [Commented] (KAFKA-2051) Add hashCode() and equals() to ProducerRecord

2015-03-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381321#comment-14381321 ] Ewen Cheslack-Postava commented on KAFKA-2051: -- This was already addressed

[jira] [Resolved] (KAFKA-2051) Add hashCode() and equals() to ProducerRecord

2015-03-25 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-2051. -- Resolution: Duplicate Add hashCode() and equals() to ProducerRecord

Re: C++ Client Library -- libkafka-asio

2015-03-23 Thread Ewen Cheslack-Postava
You don't get edit permission by default, you need to get one of the admins to give you permission. @Daniel, I've added libkafka-asio. @svante I started to add csi-kafka, but couldn't find a license? On Sun, Mar 22, 2015 at 8:29 AM, svante karlsson s...@csi.se wrote: Cool, Looks nice. I was

[jira] [Created] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-2119: Summary: ConsumerRecord key() and value() methods should not have throws Exception Key: KAFKA-2119 URL: https://issues.apache.org/jira/browse/KAFKA-2119

[jira] [Updated] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2119: - Assignee: Ewen Cheslack-Postava (was: Neha Narkhede) Status: Patch

Review Request 33140: Patch for KAFKA-2119

2015-04-13 Thread Ewen Cheslack-Postava
Diff: https://reviews.apache.org/r/33140/diff/ Testing --- Thanks, Ewen Cheslack-Postava

[jira] [Commented] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-04-10 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490780#comment-14490780 ] Ewen Cheslack-Postava commented on KAFKA-2055: -- [~lvfangmin] You may need

Re: Review Request 33135: Fix KAFKA-2117

2015-04-13 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33135/#review79978 --- Ship it! Ship It! - Ewen Cheslack-Postava On April 13, 2015, 3

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-13 Thread Ewen Cheslack-Postava
Steven, Looks like there is even more that could potentially be leaked -- since key and value serializers are created and configured at the end, even the IO thread allocated by the producer could leak. Given that, I think 1 isn't a great option since, as you said, it doesn't really address the

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-14 Thread Ewen Cheslack-Postava
Jiangjie, Great start. I have a couple of comments. Under the motivation section, is it really true that the request will never be completed? Presumably if the broker goes down the connection will be severed, at worst by a TCP timeout, which should clean up the connection and any outstanding

[jira] [Commented] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492855#comment-14492855 ] Ewen Cheslack-Postava commented on KAFKA-2119: -- Created reviewboard https

[jira] [Updated] (KAFKA-2119) ConsumerRecord key() and value() methods should not have throws Exception

2015-04-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2119: - Attachment: KAFKA-2119.patch ConsumerRecord key() and value() methods should

Re: [DISCUSS] New consumer offset commit API

2015-04-23 Thread Ewen Cheslack-Postava
a previous pending offset commit does not seem to be ideal in this case because the two commits could be for different partitions. Thanks. Jiangjie (Becket) Qin On 4/14/15, 4:31 PM, Ewen Cheslack-Postava e...@confluent.io wrote: I'd like to get some feedback

Re: Leap second coming up!

2015-04-23 Thread Ewen Cheslack-Postava
, but unfortunately that's not specified, so we probably couldn't rely on it. -Ewen On Thu, Apr 23, 2015 at 8:06 PM, Gwen Shapira gshap...@cloudera.com wrote: Any ideas on how to simulate leap seconds on test environments? On Thu, Apr 23, 2015 at 7:51 PM, Ewen Cheslack-Postava e

[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-26 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513374#comment-14513374 ] Ewen Cheslack-Postava commented on KAFKA-2140: -- Not sure if it's changed

Re: Review Request 33410: Patch for KAFKA-2034

2015-04-21 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33410/#review81109 --- Ship it! Ship It! - Ewen Cheslack-Postava On April 21, 2015, 9

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-22 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507518#comment-14507518 ] Ewen Cheslack-Postava commented on KAFKA-2121: -- [~stevenz3wu] Yes, it'll

[jira] [Updated] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-22 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2121: - Fix Version/s: 0.8.3 prevent potential resource leak in KafkaProducer

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-20 Thread Ewen Cheslack-Postava
all tests for me. Great work! - Ewen Cheslack-Postava On April 20, 2015, 4:57 p.m., Steven Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-19 Thread Ewen Cheslack-Postava
-up issue for the new consumer, which has the same issue. - Ewen Cheslack-Postava On April 19, 2015, 3:09 a.m., Steven Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-20 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503345#comment-14503345 ] Ewen Cheslack-Postava commented on KAFKA-2121: -- Latest patch LGTM, maybe

[jira] [Updated] (KAFKA-2126) New consumer does not correctly configure deserializers

2015-04-20 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2126: - Resolution: Duplicate Status: Resolved (was: Patch Available) KAFKA-2121

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-19 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502327#comment-14502327 ] Ewen Cheslack-Postava commented on KAFKA-2121: -- Odd, I don't see those, but I

[jira] [Resolved] (KAFKA-2137) New Kafka Producer not fully asynchronous

2015-04-21 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-2137. -- Resolution: Duplicate This is the same issue as KAFKA-1835, which has a patch

Re: Should 0.8.3 consumers correctly function with 0.8.2 brokers?

2015-04-23 Thread Ewen Cheslack-Postava
@Neha I think you're mixing up the 0.8.1/0.8.2 updates and the 0.8.2/0.8.3 that's being discussed here? I think the original question was about using the *new* consumer (clients consumer) with 0.8.2. Gwen's right, it will use features not even implemented in the broker in trunk yet, let alone the

Re: Leap second coming up!

2015-04-23 Thread Ewen Cheslack-Postava
That sounds like a great candidate for a system test. On Thu, Apr 23, 2015 at 7:48 PM, Gwen Shapira gshap...@cloudera.com wrote: Hi, Looks like we are getting a new leap second on June 30. Is anyone planning on testing Kafka with leap seconds before it happens in production? Gwen --

Re: [DISCUSSION] java.io.Closeable in KAFKA-2121

2015-04-28 Thread Ewen Cheslack-Postava
Good point Jay. More specifically we were already implementing without the checked exception, we'd need to override close() in the Serializer and Deserializer interfaces and omit the throws clause. That definitely makes them source compatible. Not sure about binary compatibility, I couldn't find a

Re: Review Request 33574: Patch for KAFKA-2151

2015-04-27 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33574/#review81724 --- Ship it! Ship It! - Ewen Cheslack-Postava On April 27, 2015, 2

<    1   2   3   4   5   6   7   8   9   10   >