ijuma commented on issue #8467:
URL: https://github.com/apache/kafka/pull/8467#issuecomment-616239344
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kkonstantine commented on a change in pull request #8445:
URL: https://github.com/apache/kafka/pull/8445#discussion_r411123324
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -737,16 +751,21 @@ public void
ijuma commented on issue #7677:
URL: https://github.com/apache/kafka/pull/7677#issuecomment-616271179
I tested `./gradlew install` with trunk versus this PR after `./gradlew
clean`:
* trunk: BUILD SUCCESSFUL in 1m 23s
* this PR: BUILD SUCCESSFUL in 1m 50s
I think that's OK
kkonstantine commented on a change in pull request #8445:
URL: https://github.com/apache/kafka/pull/8445#discussion_r411125481
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -737,16 +751,21 @@ public void
ijuma commented on issue #7677:
URL: https://github.com/apache/kafka/pull/7677#issuecomment-616272581
@omkreddy I've done a bunch of testing and this seems to work as expected
generally.
One part that I wasn't completely sure about is the behavior of `./gradlew
uploadArchivesAll`
LiamClarkeNZ opened a new pull request #8520:
URL: https://github.com/apache/kafka/pull/8520
Comments also discuss current default grace period value, and the fact that
it may change with the next major release.
### Committer Checklist (excluded from commit message)
- [n/a]
ijuma commented on issue #8517:
URL: https://github.com/apache/kafka/pull/8517#issuecomment-616264737
Same test failed in both jobs:
>
kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup
Seems unrelated, but will retest just in
ijuma commented on issue #8517:
URL: https://github.com/apache/kafka/pull/8517#issuecomment-616264759
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma opened a new pull request #8519:
URL: https://github.com/apache/kafka/pull/8519
Also remove deprecated `=` in resolutionStrategy.
With these changes, the build works with Java 14 and Scala 2.12. The
same will apply to Scala 2.13 when Scala 2.13.2 is released (should
mjsax commented on issue #8114:
URL: https://github.com/apache/kafka/pull/8114#issuecomment-616325249
Build failed with checkstyle error:
```
[ant:checkstyle] [ERROR]
cadonna commented on a change in pull request #8514:
URL: https://github.com/apache/kafka/pull/8514#discussion_r411304452
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
##
@@ -319,18 +266,6 @@ private void
cadonna commented on a change in pull request #8514:
URL: https://github.com/apache/kafka/pull/8514#discussion_r411304452
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
##
@@ -319,18 +266,6 @@ private void
tombentley commented on a change in pull request #8222:
URL: https://github.com/apache/kafka/pull/8222#discussion_r411295815
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -1179,6 +1186,50 @@ protected String getConfigValue(ConfigKey
highluck commented on issue #8114:
URL: https://github.com/apache/kafka/pull/8114#issuecomment-616510519
Thank you for reivew
Yes ok!
This is an automated message from the Apache Git Service.
To respond to the message,
tombentley commented on issue #8222:
URL: https://github.com/apache/kafka/pull/8222#issuecomment-616538532
@mimaison I rewrote that code, which I think makes it clear enough and
avoids the repeated constants.
Rendered it looks like this:
**TOC in the content:**
mjsax commented on pull request #264:
URL: https://github.com/apache/kafka-site/pull/264#issuecomment-623619312
Thanks for the PR @showuon!
This is an automated message from the Apache Git Service.
To respond to the message,
showuon opened a new pull request #265:
URL: https://github.com/apache/kafka-site/pull/265
1. fix broken links
2. rephrase a sentence
3. update the version number
This is an automated message from the Apache Git
showuon commented on pull request #265:
URL: https://github.com/apache/kafka-site/pull/265#issuecomment-629911823
Same change with the PR to `kafka` repo:
https://github.com/apache/kafka/pull/8622/ per @bbejeck 's request. Thanks. :)
bbejeck commented on pull request #265:
URL: https://github.com/apache/kafka-site/pull/265#issuecomment-630893259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bbejeck merged pull request #265:
URL: https://github.com/apache/kafka-site/pull/265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman opened a new pull request #301:
URL: https://github.com/apache/kafka-site/pull/301
Just noticed that all of the docs I added just before 2.6 aren't actually
showing up on the site. Seems like they were accidentally reverted by [this
vvcephei merged pull request #301:
URL: https://github.com/apache/kafka-site/pull/301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vvcephei commented on a change in pull request #301:
URL: https://github.com/apache/kafka-site/pull/301#discussion_r485142442
##
File path: 26/streams/developer-guide/memory-mgmt.html
##
@@ -202,7 +202,10 @@ RocksDB}
}
-1. INDEX_FILTER_BLOCK_RATIO can be
ableegoldman commented on a change in pull request #301:
URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723
##
File path: 26/streams/developer-guide/memory-mgmt.html
##
@@ -202,7 +202,10 @@ RocksDB}
}
-1. INDEX_FILTER_BLOCK_RATIO can
ableegoldman commented on a change in pull request #301:
URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723
##
File path: 26/streams/developer-guide/memory-mgmt.html
##
@@ -202,7 +202,10 @@ RocksDB}
}
-1. INDEX_FILTER_BLOCK_RATIO can
ewencp merged pull request #300:
URL: https://github.com/apache/kafka-site/pull/300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
scott-confluent opened a new pull request #302:
URL: https://github.com/apache/kafka-site/pull/302
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mjsax merged pull request #302:
URL: https://github.com/apache/kafka-site/pull/302
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac opened a new pull request #303:
URL: https://github.com/apache/kafka-site/pull/303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac merged pull request #303:
URL: https://github.com/apache/kafka-site/pull/303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 merged pull request #304:
URL: https://github.com/apache/kafka-site/pull/304
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 commented on pull request #304:
URL: https://github.com/apache/kafka-site/pull/304#issuecomment-711161869
@guozhangwang Thanks for confirming. Merge it to trunk :)
This is an automated message from the Apache Git
chia7712 opened a new pull request #304:
URL: https://github.com/apache/kafka-site/pull/304
hello Kafka :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guozhangwang commented on pull request #304:
URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710760998
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on pull request #304:
URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710767238
@guozhangwang thanks for reviews!
> you'd also need to git add the image file as well.
The image file is already included. Please correct me if I misunderstand
guozhangwang commented on pull request #304:
URL: https://github.com/apache/kafka-site/pull/304#issuecomment-711025894
I missed that file. You are good to go.
This is an automated message from the Apache Git Service.
To
miguno commented on pull request #305:
URL: https://github.com/apache/kafka-site/pull/305#issuecomment-711975561
I tested the PR locally with `vnu` (HTML validation) and via
https://cwiki.apache.org/confluence/display/KAFKA/Setup+Kafka+Website+on+Local+Apache+Server.
miguno commented on pull request #305:
URL: https://github.com/apache/kafka-site/pull/305#issuecomment-711980559
HTML cleanup example.
After cleanup:
```html
miguno opened a new pull request #305:
URL: https://github.com/apache/kafka-site/pull/305
This PR adds the thirty best Kafka Summit 2020 talks as rated by the
community (summit attendees).
To make maintenance of the Videos page easier, I also refactored (read:
cleaned up) the HTML
tom1299 closed pull request #290:
URL: https://github.com/apache/kafka-site/pull/290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mjsax merged pull request #305:
URL: https://github.com/apache/kafka-site/pull/305
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vvcephei merged pull request #295:
URL: https://github.com/apache/kafka-site/pull/295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SanjayYr opened a new pull request #296:
URL: https://github.com/apache/kafka-site/pull/296
Removed the extra "/p" tag.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SanjayYr opened a new pull request #297:
URL: https://github.com/apache/kafka-site/pull/297
Fixed method invocation and arguments.
This is an automated message from the Apache Git Service.
To respond to the message, please
scott-confluent opened a new pull request #295:
URL: https://github.com/apache/kafka-site/pull/295
Someone opened a JIRA ticket for this:
https://issues.apache.org/jira/browse/KAFKA-10406
This is an automated message from
guozhangwang commented on pull request #293:
URL: https://github.com/apache/kafka-site/pull/293#issuecomment-675832265
@scott-confluent After merged the PR the new link seems still not working?
This is an automated message
guozhangwang merged pull request #293:
URL: https://github.com/apache/kafka-site/pull/293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mimaison merged pull request #299:
URL: https://github.com/apache/kafka-site/pull/299
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
katheris opened a new pull request #299:
URL: https://github.com/apache/kafka-site/pull/299
Signed-off-by: Katherine Stanley
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mjsax merged pull request #298:
URL: https://github.com/apache/kafka-site/pull/298
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax opened a new pull request #298:
URL: https://github.com/apache/kafka-site/pull/298
As reported on the mailing list:
https://lists.apache.org/list.html?dev@kafka.apache.org:lte=1M:cve%202.0.2%202.1.2
Call for review @ijuma
scott-confluent opened a new pull request #300:
URL: https://github.com/apache/kafka-site/pull/300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
viktorsomogyi edited a comment on pull request #220:
URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637
Otherwise it looks good, I can approve it once you create the PR in the
kafka repo (and perhaps get someone to merge it).
viktorsomogyi commented on pull request #220:
URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637
Otherwise it looks good, I can approve it once you create the PR in the
kafka repo.
This is an
ankit-kumar-25 commented on pull request #220:
URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603
Hey @viktorsomogyi,
Thank you for the pointers, I have created a PR against the ops.html
available in the Kafka project:
ankit-kumar-25 edited a comment on pull request #220:
URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603
Hey @viktorsomogyi,
Thank you for the pointers, I have created a PR against the ops.html
available in the Kafka project:
ankit-kumar-25 closed pull request #220:
URL: https://github.com/apache/kafka-site/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ankit-kumar-25 commented on pull request #220:
URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603
Hey @viktorsomogyi,
Thank you for the pointers, I have created a PR against the ops.html
available in the Kafka project:
mjsax commented on pull request #266:
URL: https://github.com/apache/kafka-site/pull/266#issuecomment-634390804
Thanks a lot @showuon! This seems to be super helpful!
This is an automated message from the Apache Git Service.
showuon commented on pull request #266:
URL: https://github.com/apache/kafka-site/pull/266#issuecomment-634381918
hi @mjsax , I think you must love this PR because you won't have to handle
the "requesting to be added into contributor list" but without JIRA ID provided
issue. :)
mjsax merged pull request #266:
URL: https://github.com/apache/kafka-site/pull/266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon opened a new pull request #266:
URL: https://github.com/apache/kafka-site/pull/266
We usually got this kind of email to request to be added into contributor
list, but without JIRA username provided. That wasted the committer's or the
existing contributor's time to do more
viktorsomogyi commented on pull request #220:
URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637
Otherwise it looks good, I can approve it once you create the PR in the
kafka repo.
This is an
viktorsomogyi edited a comment on pull request #220:
URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637
Otherwise it looks good, I can approve it once you create the PR in the
kafka repo (and perhaps get someone to merge it).
ableegoldman opened a new pull request #306:
URL: https://github.com/apache/kafka-site/pull/306
A bit late on this but here we go
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman commented on a change in pull request #306:
URL: https://github.com/apache/kafka-site/pull/306#discussion_r513151562
##
File path: committers.html
##
@@ -334,6 +334,14 @@ The committers
Committer
chia7712 commented on a change in pull request #306:
URL: https://github.com/apache/kafka-site/pull/306#discussion_r513148887
##
File path: committers.html
##
@@ -334,6 +334,14 @@ The committers
Committer
ableegoldman merged pull request #306:
URL: https://github.com/apache/kafka-site/pull/306
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rhauch commented on a change in pull request #260:
URL: https://github.com/apache/kafka-site/pull/260#discussion_r464774655
##
File path: downloads.html
##
@@ -5,12 +5,52 @@
Download
-2.4.1 is the latest release. The current stable version is 2.4.1.
+
rhauch opened a new pull request #277:
URL: https://github.com/apache/kafka-site/pull/277
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
guozhangwang merged pull request #269:
URL: https://github.com/apache/kafka-site/pull/269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r465425702
##
File path: 26/upgrade.html
##
@@ -19,6 +19,48 @@
rhauch commented on a change in pull request #277:
URL: https://github.com/apache/kafka-site/pull/277#discussion_r465425450
##
File path: 26/upgrade.html
##
@@ -19,6 +19,48 @@
scott-confluent commented on a change in pull request #284:
URL: https://github.com/apache/kafka-site/pull/284#discussion_r466554238
##
File path: includes/_footer.htm
##
@@ -329,7 +329,13 @@
var docsHandle =
1 - 100 of 857 matches
Mail list logo
