Re: Review Request 33125: Fix timing issue in MetadataTest

/apache/kafka/clients/MetadataTest.java https://reviews.apache.org/r/33125/#comment129487 Maybe add a comment explaining we do this to make sure update happen after metadata update is requestd? - Jiangjie Qin On April 13, 2015, 7:36 a.m., Rajini Sivaram wrote

Re: Review Request 33135: Fix KAFKA-2117

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33135/#review79907 --- Ship it! Ship It! - Jiangjie Qin On April 13, 2015, 3:51 p.m

[DISCUSS] KIP-19 Add a request timeout to NetworkClient

Hi, I just created a KIP to add a request timeout to NetworkClient for new Kafka clients. https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient Comments and suggestions are welcome! Thanks. Jiangjie (Becket) Qin

[jira] [Created] (KAFKA-2120) Add a request timeout to NetworkClient

Jiangjie Qin created KAFKA-2120: --- Summary: Add a request timeout to NetworkClient Key: KAFKA-2120 URL: https://issues.apache.org/jira/browse/KAFKA-2120 Project: Kafka Issue Type: New Feature

Re: Review Request 31850: Patch for KAFKA-1660

, 2015, 10:09 p.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/ --- (Updated April 10, 2015, 10:09 p.m

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Attachment: KAFKA-1660_2015-04-10_15:08:54.patch Ability to call close() with a timeout

Re: Review Request 31850: Patch for KAFKA-1660

9811a2b2b1e9bf1beb301138f7626e12d275a8db Diff: https://reviews.apache.org/r/31850/diff/ Testing --- Unit tests passed. Thanks, Jiangjie Qin

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490445#comment-14490445 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org

Re: Review Request 31850: Patch for KAFKA-1660

: https://reviews.apache.org/r/31850/#review79677 --- On April 10, 2015, 10:09 p.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33017: Fix timing issue in MetadataTest

On April 10, 2015, 9:52 p.m., Jiangjie Qin wrote: Ship It! BTW, I think KafkaProducer has the same issue there. Could you update the code there as well? - Jiangjie --- This is an automatically generated e-mail. To reply, visit

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490624#comment-14490624 ] Jiangjie Qin commented on KAFKA-2102: - I'm with Ewen on this. We probably can take

Re: Review Request 32890: Patch for conrolled shutdown rebase on trunk

/ReplicaManager.scala https://reviews.apache.org/r/32890/#comment128942 This seems not needed anymore after KAFKA-1647 is checked in, because we now always restore the HW on each makeLeader and makeFollower. Can you double check? - Jiangjie Qin On April 6, 2015, 5:28 p.m., Dmitry Bugaychenko

Re: Review Request 31850: Patch for KAFKA-1660

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/#review79379 --- On April 8, 2015, 1:18 a.m., Jiangjie Qin wrote: --- This is an automatically

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486022#comment-14486022 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Attachment: KAFKA-1660_2015-04-08_14:01:12.patch Ability to call close() with a timeout

Re: Review Request 31850: Patch for KAFKA-1660

://reviews.apache.org/r/31850/diff/ Testing --- Unit tests passed. Thanks, Jiangjie Qin

[jira] [Commented] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486359#comment-14486359 ] Jiangjie Qin commented on KAFKA-2076: - Hi [~jkreps], Actually thought about this again

[jira] [Commented] (KAFKA-2108) Node deleted all data and re-sync from replicas after attempted upgrade from 0.8.1.1 to 0.8.2.0

[ https://issues.apache.org/jira/browse/KAFKA-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486345#comment-14486345 ] Jiangjie Qin commented on KAFKA-2108: - [~slimunholyone] sent me some logs offline

Re: Review Request 31850: Patch for KAFKA-1660

/diff/ Testing --- Unit tests passed. Thanks, Jiangjie Qin

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Attachment: KAFKA-1660_2015-04-07_18:18:40.patch Ability to call close() with a timeout

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484498#comment-14484498 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org

[jira] [Created] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

Jiangjie Qin created KAFKA-2103: --- Summary: kafka.producer.AsyncProducerTest failure. Key: KAFKA-2103 URL: https://issues.apache.org/jira/browse/KAFKA-2103 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393516#comment-14393516 ] Jiangjie Qin commented on KAFKA-2076: - Hey [~jkreps], any more thoughts on this? Add

[jira] [Assigned] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-2076: --- Assignee: Jiangjie Qin Add an API to new consumer to allow user get high watermark

Re: Review Request 32781: Patch for KAFKA-2087

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32781/#review78683 --- Ship it! Ship It! - Jiangjie Qin On April 2, 2015, 5:29 p.m

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390958#comment-14390958 ] Jiangjie Qin commented on KAFKA-1660: - [~jkreps] Ping to see if you could help review

[jira] [Commented] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389839#comment-14389839 ] Jiangjie Qin commented on KAFKA-2076: - Return a map of time-offset would be useful. I

[jira] [Commented] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389652#comment-14389652 ] Jiangjie Qin commented on KAFKA-2076: - Got it. Thanks for the explanation, [~jkreps

[jira] [Commented] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389466#comment-14389466 ] Jiangjie Qin commented on KAFKA-2076: - [~jkreps] Totally agree that we need to think

Re: KIP Hangout - March 31, 2015 - TL;DR;

. On Tue, Mar 31, 2015 at 08:44:44PM +, Jiangjie Qin wrote: Thanks a lot for the summary, Gwen! About the Quota, does that mean the first quota implementation will be based on YM? I¹m thinking can we pursue a quota solution that has a loose coupling with metrics interfaces? Like something

Re: KIP Hangout - March 31, 2015 - TL;DR;

Thanks a lot for the summary, Gwen! About the Quota, does that mean the first quota implementation will be based on YM? I¹m thinking can we pursue a quota solution that has a loose coupling with metrics interfaces? Like something operating system does for FUSE, so we don¹t need to care about which

[jira] [Resolved] (KAFKA-1932) kafka topic (creation) templates

[ https://issues.apache.org/jira/browse/KAFKA-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved KAFKA-1932. - Resolution: Duplicate [~liqusha] The requirement looks also covered in KIP-4. Close for now

[jira] [Created] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

Jiangjie Qin created KAFKA-2076: --- Summary: Add an API to new consumer to allow user get high watermark of partitions. Key: KAFKA-2076 URL: https://issues.apache.org/jira/browse/KAFKA-2076 Project

[jira] [Commented] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386002#comment-14386002 ] Jiangjie Qin commented on KAFKA-2029: - [~dmitrybugaychenko] I was trying to apply

[jira] [Issue Comment Deleted] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1716: Comment: was deleted (was: [~dchu] Do you mean that the fetchers have never been created? That's

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386022#comment-14386022 ] Jiangjie Qin commented on KAFKA-1716: - [~dchu] Do you mean that the fetchers have

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386019#comment-14386019 ] Jiangjie Qin commented on KAFKA-1716: - [~dchu] Do you mean that the fetchers have

[jira] [Updated] (KAFKA-1848) Checking shutdown during each iteration of ZookeeperConsumerConnector

[ https://issues.apache.org/jira/browse/KAFKA-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1848: Fix Version/s: (was: 0.9.0) 0.8.3 Checking shutdown during each iteration

[CANCEL] [VOTE] KIP-15 add a close with timeout to new producer

. Guozhang On Thu, Mar 26, 2015 at 6:31 AM, Jiangjie Qin j...@linkedin.com.invalid wrote: Hi Neha, I totally agree that from program behavior point of view, blocking is not a good idea. I think the ultimate question here is whether we define calling

[VOTE] KIP-15 Add a close method with timeout to new producer

https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+method+with+a+timeout+in+the+producer Let us vote again!

[CLOSED] [VOTE] KIP-15 Add a close method with timeout to new producer

calling close(), and that we are preventing a deadlock here. The only reason I could see that sender thread calls close() refers to the callbacks was because I followed the discussion on the list. Gwen On Fri, Mar 27, 2015 at 11:48 AM, Jiangjie Qin j...@linkedin.com.invalid wrote: https

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384895#comment-14384895 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org

Re: Review Request 31850: Patch for KAFKA-1660

/RecordAccumulatorTest.java e379ac89c9a2fbfe750d6b0dec693b7eabb76204 core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 3df450784592b894008e7507b2737f9bb07f7bd2 Diff: https://reviews.apache.org/r/31850/diff/ Testing --- Unit tests passed. Thanks, Jiangjie Qin

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Attachment: KAFKA-1660_2015-03-27_16:35:42.patch Ability to call close() with a timeout

Re: [VOTE] KIP-15 add a close with timeout to new producer

vote to log an appropriate error message and exit. On Wed, Mar 25, 2015 at 10:04 AM, Jiangjie Qin j...@linkedin.com.invalid wrote: Hi Jay, The reason we keep the blocking behavior if close() or close(timeout) is called from callback is discussed in another thread. I copy/paste the message

Re: [DISCUSSION] Keep docs updated per jira

On 3/26/15, 7:00 PM, Neha Narkhede n...@confluent.io wrote: Much much easier to do this if the docs are in git and can be reviewed and committed / reverted with the code (transactions makes synchronization easier...). +1 on this, too! Huge +1. On Thu, Mar 26, 2015 at 6:54 PM, Joel Koshy

Re: [VOTE] KIP-15 add a close with timeout to new producer

Kreps jay.kr...@gmail.com wrote: +1 -Jay On Tue, Mar 24, 2015 at 2:43 PM, Guozhang Wang wangg...@gmail.com wrote: +1. On Tue, Mar 24, 2015 at 2:15 PM, Jiangjie Qin j...@linkedin.com.invalid wrote: https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+m ethod

Re: Review Request 31850: Patch for KAFKA-1660

e379ac89c9a2fbfe750d6b0dec693b7eabb76204 core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 3df450784592b894008e7507b2737f9bb07f7bd2 Diff: https://reviews.apache.org/r/31850/diff/ Testing --- Unit tests passed. Thanks, Jiangjie Qin

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Attachment: KAFKA-1660_2015-03-25_10:55:42.patch Ability to call close() with a timeout

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380359#comment-14380359 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org

Re: MirrorMaker improvements

Hi Jun, I think bumping up socket.receive.buffer.bytes will help but might not be sufficient. There are actually two related factors here: 1. Pipelining TCP packets when send a single request/response. 2. Pipelining multiple requests/responses Bumping up socket.receive.buffer.bytes help with the

Re: Review Request 32465: Patch for KAFKA-2047

/diff/ Testing --- Thanks, Jiangjie Qin

[jira] [Commented] (KAFKA-2047) Accelarate consumer rebalance in mirror maker.

[ https://issues.apache.org/jira/browse/KAFKA-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380737#comment-14380737 ] Jiangjie Qin commented on KAFKA-2047: - Updated reviewboard https://reviews.apache.org

Re: Review Request 32465: Patch for KAFKA-2047

://reviews.apache.org/r/32465/#review77789 --- On March 25, 2015, 8:48 p.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32465

[jira] [Updated] (KAFKA-2047) Accelarate consumer rebalance in mirror maker.

[ https://issues.apache.org/jira/browse/KAFKA-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2047: Attachment: KAFKA-2047_2015-03-25_13:48:34.patch Accelarate consumer rebalance in mirror maker

Re: MirrorMaker improvements

, usually a single connection will cap (due to random losses and high RTT), long before achieving the capacity of the link. Here is a reference for this: http://www.ece.virginia.edu/~mv/edu/715/lectures/TCP/padhye98modeling.pdf Regards, Vlad On Wed, Mar 25, 2015 at 3:43 PM, Jiangjie Qin j

[jira] [Updated] (KAFKA-2047) Accelarate consumer rebalance in mirror maker.

[ https://issues.apache.org/jira/browse/KAFKA-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2047: Attachment: KAFKA-2047.patch Accelarate consumer rebalance in mirror maker

[jira] [Commented] (KAFKA-2047) Accelarate consumer rebalance in mirror maker.

[ https://issues.apache.org/jira/browse/KAFKA-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378935#comment-14378935 ] Jiangjie Qin commented on KAFKA-2047: - Created reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-2047) Accelarate consumer rebalance in mirror maker.

[ https://issues.apache.org/jira/browse/KAFKA-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2047: Status: Patch Available (was: Open) Accelarate consumer rebalance in mirror maker

Review Request 32465: Patch for KAFKA-2047

/diff/ Testing --- Thanks, Jiangjie Qin

Re: KAFKA-2042

Hi Jun, This issue does not only affect flush(). It is just with flush() the probability is much higher. It will affect the following scenario: 1. Producer started and refreshed metadata. 2. User call producer.send() to send message 1 to topic A, but message A is in accumulator. 3. User call

[jira] [Created] (KAFKA-2047) Accelarate consumer rebalance in mirror maker.

Jiangjie Qin created KAFKA-2047: --- Summary: Accelarate consumer rebalance in mirror maker. Key: KAFKA-2047 URL: https://issues.apache.org/jira/browse/KAFKA-2047 Project: Kafka Issue Type

[CANCEL] [VOTE] KIP-15 add a close method with timeout to KafkaProducer

a new thread. On Tue, Mar 24, 2015 at 12:19 PM, Jiangjie Qin j...@linkedin.com.invalid wrote: Push up the thread for voting after discussion on the KIP hangout. On 3/19/15, 9:03 PM, Jiangjie Qin j...@linkedin.com wrote: We had some additional discussions on the discussion thread. Pushing up

[jira] [Commented] (KAFKA-1293) Mirror maker housecleaning

[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379033#comment-14379033 ] Jiangjie Qin commented on KAFKA-1293: - [~mwarhaftig] It looks very closely related

[jira] [Commented] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379175#comment-14379175 ] Jiangjie Qin commented on KAFKA-2029: - I see. Yes, there is value to put per event

[jira] [Commented] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378986#comment-14378986 ] Jiangjie Qin commented on KAFKA-2042: - Yes, it depends on whether the topic list

[jira] [Commented] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379120#comment-14379120 ] Jiangjie Qin commented on KAFKA-2042: - Ah, yes, that's right. I found this issue when

[jira] [Updated] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2042: Priority: Blocker (was: Major) New producer metadata update always get all topics

Re: [VOTE] KIP-15 add a close method with timeout to KafkaProducer

Push up the thread for voting after discussion on the KIP hangout. On 3/19/15, 9:03 PM, Jiangjie Qin j...@linkedin.com wrote: We had some additional discussions on the discussion thread. Pushing up this thread to resume voting. On 3/11/15, 8:47 PM, Jay Kreps jay.kr...@gmail.com wrote: Yeah

[jira] [Updated] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2042: Attachment: KAFKA-2042_2015-03-24_13:37:49.patch New producer metadata update always get all

Re: Review Request 32434: Patch for KAFKA-2042

feda9c922d7dab17e424f8e6f0aa0a3f968e3729 Diff: https://reviews.apache.org/r/32434/diff/ Testing --- Thanks, Jiangjie Qin

[jira] [Commented] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378551#comment-14378551 ] Jiangjie Qin commented on KAFKA-2042: - Updated reviewboard https://reviews.apache.org

[jira] [Commented] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378586#comment-14378586 ] Jiangjie Qin commented on KAFKA-2042: - Updated reviewboard https://reviews.apache.org

Re: Review Request 32434: Patch for KAFKA-2042

c8bde8b732defa20819730d87303a9a80d01116f clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java feda9c922d7dab17e424f8e6f0aa0a3f968e3729 Diff: https://reviews.apache.org/r/32434/diff/ Testing --- Thanks, Jiangjie Qin

[jira] [Created] (KAFKA-2042) New producer metadata update always get all topics.

Jiangjie Qin created KAFKA-2042: --- Summary: New producer metadata update always get all topics. Key: KAFKA-2042 URL: https://issues.apache.org/jira/browse/KAFKA-2042 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2042: Attachment: KAFKA-2042.patch New producer metadata update always get all topics

[jira] [Updated] (KAFKA-2042) New producer metadata update always get all topics.

[ https://issues.apache.org/jira/browse/KAFKA-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2042: Assignee: Jiangjie Qin Status: Patch Available (was: Open) New producer metadata update

Review Request 32434: Patch for KAFKA-2042

://reviews.apache.org/r/32434/diff/ Testing --- Thanks, Jiangjie Qin

[jira] [Commented] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377446#comment-14377446 ] Jiangjie Qin commented on KAFKA-2029: - [~mstr] I'm not sure if adding complexity

[VOTE] KIP-15 add a close with timeout to new producer

https://cwiki.apache.org/confluence/display/KAFKA/KIP-15+-+Add+a+close+method+with+a+timeout+in+the+producer As a short summary, the new interface will be as following: Close(Long Timeout, TimeUnit timeUnit) 1. When timeout 0, it will try to wait up to timeout for the sender thread to

Re: Review Request 32434: Patch for KAFKA-2042

--- On March 24, 2015, 8:57 p.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434

Re: [DISCUSSION] KIP-15 close(timeout) for producer

thread or not? Thanks, Jun On Wed, Mar 18, 2015 at 2:13 PM, Jiangjie Qin j...@linkedin.com.invalid wrote: It looks we have another option and are now deciding between the following two interfaces: 1. Close() + close(timeout) - timeout could be either positive or zero. - only

Re: [DISCUSSION] KIP-15 close(timeout) for producer

, Jiangjie Qin j...@linkedin.com.invalid wrote: I think the we agreed that we are going to log an error and block. By doing this we can make sure the error log to be checked by user in all cases. If we silently replace close() to close(0) in sender thread, in some cases such as send error during

Re: [VOTE] KIP-15 add a close method with timeout to KafkaProducer

://www.stealth.ly - - - - - - - - - - - - - - - - - On Wed, Mar 11, 2015 at 11:24 PM, Guozhang Wang wangg...@gmail.com wrote: +1 (binding) On Wed, Mar 11, 2015 at 8:10 PM, Jiangjie Qin j...@linkedin.com.invalid wrote: https://cwiki.apache.org/confluence/display/KAFKA/KIP-15

Re: [DISCUSSION] KIP-15 close(timeout) for producer

of different APIs. People will find the difference between abort and close subtle and confusing and the only instance where you want it is this somewhat unusual case you guys are pursuing, right? -Jay On Wed, Mar 18, 2015 at 2:13 PM, Jiangjie Qin j...@linkedin.com.invalid wrote

[jira] [Commented] (KAFKA-2019) RoundRobinAssignor clusters by consumer

[ https://issues.apache.org/jira/browse/KAFKA-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367189#comment-14367189 ] Jiangjie Qin commented on KAFKA-2019: - Yeah, you are right. I somehow thought

[jira] [Commented] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367275#comment-14367275 ] Jiangjie Qin commented on KAFKA-2029: - +1 on this in general. Current design has

Re: Review Request 32199: Patch for KAFKA-1858

does it make sense to add a non deamon thread check in each test? So we can make sure there is no deamon thread left from some tests. - Jiangjie Qin On March 18, 2015, 11:12 a.m., Adrian Preston wrote: --- This is an automatically

Re: Review Request 32193: Patch for KAFKA-1997

://reviews.apache.org/r/32193/diff/ Testing --- Thanks, Jiangjie Qin

[jira] [Updated] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1997: Attachment: KAFKA-1997_2015-03-18_12:47:32.patch Refactor Mirror Maker

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367761#comment-14367761 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard https://reviews.apache.org

Re: [DISCUSSION] KIP-15 close(timeout) for producer

code, assuming users are always calling producer.close() as a clean up step, personally I prefer approach 2) as it follows convention. Any thoughts? Jiangjie (Becket) Qin On 3/17/15, 10:25 AM, Jiangjie Qin j...@linkedin.com wrote: Hi Jun, Yes, as Guozhang said, the main reason we set a flag

Review Request 32193: Patch for KAFKA-1997

, Jiangjie Qin

[jira] [Updated] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1997: Attachment: KAFKA-1997.patch Refactor Mirror Maker - Key

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366588#comment-14366588 ] Jiangjie Qin commented on KAFKA-1997: - Created reviewboard https://reviews.apache.org

Re: [DISCUSSION] KIP-15 close(timeout) for producer

close(0), the sender thread is not necessary gone? Normally, after closing an entity, we expect all internal threads associated with the entity are shut down completely. Thanks, Jun On Mon, Mar 16, 2015 at 3:18 PM, Jiangjie Qin j...@linkedin.com.invalid wrote: Hi Jun, Close(0) will set

Re: [Discussion] Using Client Requests and Responses in Server

I think those two requests are only used by controller to broker communication. Not sure if client side will need them in KIP-4, unlikely I guess. Jiangjie (Becket) Qin On 3/17/15, 6:08 PM, Gwen Shapira gshap...@cloudera.com wrote: Hi, I'm starting this thread for the various questions I run

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366549#comment-14366549 ] Jiangjie Qin commented on KAFKA-1997: - [~xiaotao183] Yes, that's not right. I'll

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366052#comment-14366052 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard https://reviews.apache.org

Re: Review Request 31706: Patch for KAFKA-1997

) - core/src/main/scala/kafka/tools/MirrorMaker.scala 87b925c7332470de59a5b098d51c4bf0dfab8b8f Diff: https://reviews.apache.org/r/31706/diff/ Testing --- Thanks, Jiangjie Qin

<    5   6   7   8   9   10   11   12   13   14   >