Review Request 23363: Patch for KAFKA-1325

2014-07-09 Thread Manikumar Reddy O
6f4809da9968de293f365307ffd9cfe1d5c34ce0 Diff: https://reviews.apache.org/r/23363/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1325) Fix inconsistent per topic log configs

2014-07-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1325: --- Attachment: KAFKA-1325.patch Fix inconsistent per topic log configs

[jira] [Commented] (KAFKA-1325) Fix inconsistent per topic log configs

2014-07-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056402#comment-14056402 ] Manikumar Reddy commented on KAFKA-1325: Created reviewboard https

[jira] [Commented] (KAFKA-1325) Fix inconsistent per topic log configs

2014-07-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056410#comment-14056410 ] Manikumar Reddy commented on KAFKA-1325: I added log.retention.ms and log.roll.ms

[jira] [Commented] (KAFKA-1325) Fix inconsistent per topic log configs

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057559#comment-14057559 ] Manikumar Reddy commented on KAFKA-1325: Now we are not renaming any topic-level

[jira] [Issue Comment Deleted] (KAFKA-1325) Fix inconsistent per topic log configs

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1325: --- Comment: was deleted (was: Now we are not renaming any topic-level configs

[jira] [Commented] (KAFKA-1325) Fix inconsistent per topic log configs

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057582#comment-14057582 ] Manikumar Reddy commented on KAFKA-1325: Now we are not renaming any topic-level

[jira] [Commented] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057629#comment-14057629 ] Manikumar Reddy commented on KAFKA-1531: Can I submit a patch by setting all

[jira] [Assigned] (KAFKA-1480) support log.roll.minutes

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1480: -- Assignee: Manikumar Reddy support log.roll.minutes

[jira] [Commented] (KAFKA-1480) support log.roll.minutes

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057656#comment-14057656 ] Manikumar Reddy commented on KAFKA-1480: We have introduced log.roll.ms server

Review Request 23396: Patch for KAFKA-1531

2014-07-10 Thread Manikumar Reddy O
/23396/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057692#comment-14057692 ] Manikumar Reddy commented on KAFKA-1531: Created reviewboard https

[jira] [Assigned] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1531: -- Assignee: Manikumar Reddy zookeeper.connection.timeout.ms is set to 1000

[jira] [Comment Edited] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058555#comment-14058555 ] Manikumar Reddy edited comment on KAFKA-1531 at 7/11/14 8:43 AM

Review Request 23417: Patch for KAFKA-1531

2014-07-11 Thread Manikumar Reddy O
: https://reviews.apache.org/r/23417/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1531: --- Attachment: KAFKA-1531.patch zookeeper.connection.timeout.ms is set to 1000

[jira] [Commented] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059054#comment-14059054 ] Manikumar Reddy commented on KAFKA-1531: Created reviewboard https

[jira] [Commented] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059058#comment-14059058 ] Manikumar Reddy commented on KAFKA-1531: The following properties updated

[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059734#comment-14059734 ] Manikumar Reddy commented on KAFKA-1377: LogOffsetTests are consistently failing

Review Request 23439: Patch for KAFKA-1258

2014-07-12 Thread Manikumar Reddy O
/23439/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059741#comment-14059741 ] Manikumar Reddy commented on KAFKA-1258: Created reviewboard https

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1258: --- Attachment: KAFKA-1258.patch Delete temporary data directory after unit test finishes

[jira] [Assigned] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1258: -- Assignee: Manikumar Reddy Delete temporary data directory after unit test finishes

[jira] [Commented] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059742#comment-14059742 ] Manikumar Reddy commented on KAFKA-1258: Junit 4.7 can be used to manage temporary

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1258: --- Status: Patch Available (was: Open) Delete temporary data directory after unit test

[jira] [Updated] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1531: --- Status: Patch Available (was: Open) zookeeper.connection.timeout.ms is set to 1000

Review Request 23440: Patch for KAFKA-1536

2014-07-12 Thread Manikumar Reddy O
/browse/KAFKA-1536 Repository: kafka Description --- JIRA status set to Patch Available in kafka-patch-review script Diffs - kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef Diff: https://reviews.apache.org/r/23440/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Change the status

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059791#comment-14059791 ] Manikumar Reddy commented on KAFKA-1536: Created reviewboard https

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Attachment: KAFKA-1536.patch Change the status of the JIRA to Patch Available in the kafka

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059793#comment-14059793 ] Manikumar Reddy commented on KAFKA-1536: kafka-patch-review.py script updated

[jira] [Commented] (KAFKA-1059) Improve the patch review tool to use OAuth for JIRA access

2014-07-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060059#comment-14060059 ] Manikumar Reddy commented on KAFKA-1059: Below links gives steps to configure

[jira] [Commented] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063541#comment-14063541 ] Manikumar Reddy commented on KAFKA-1531: Previous patch I tried to update all

[jira] [Comment Edited] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063541#comment-14063541 ] Manikumar Reddy edited comment on KAFKA-1531 at 7/16/14 2:35 PM

[jira] [Assigned] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1192: -- Assignee: Manikumar Reddy Enable DumpLogSegments tool to deserialize messages

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066021#comment-14066021 ] Manikumar Reddy commented on KAFKA-1192: Some points 1. Users need to provide

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Attachment: (was: KAFKA-1536.patch) Change the status of the JIRA to Patch Available

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066424#comment-14066424 ] Manikumar Reddy commented on KAFKA-1536: Updated reviewboard https

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Attachment: KAFKA-1536_2014-07-18_20:41:40.patch Change the status of the JIRA to Patch

Re: Review Request 23440: addressing reviewer comments

2014-07-18 Thread Manikumar Reddy O
dc45549f886440f1721c60aab9aa0a4af9b4cbef Diff: https://reviews.apache.org/r/23440/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Assignee: Manikumar Reddy (was: Neha Narkhede) Status: Open (was: Patch Available

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Status: Patch Available (was: Open) Change the status of the JIRA to Patch Available

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Attachment: (was: KAFKA-1536_2014-07-18_20:36:29.patch) Change the status of the JIRA

Review Request 23705: Patch for KAFKA-1192

2014-07-19 Thread Manikumar Reddy O
--- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: KAFKA-1192.patch Enable DumpLogSegments tool to deserialize messages

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067439#comment-14067439 ] Manikumar Reddy commented on KAFKA-1192: Created reviewboard https

Re: Review Request 23705: Patch for KAFKA-1192

2014-07-19 Thread Manikumar Reddy O
://reviews.apache.org/r/23705/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067443#comment-14067443 ] Manikumar Reddy commented on KAFKA-1192: Updated reviewboard https

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: KAFKA-1192_2014-07-19_13:56:18.patch Enable DumpLogSegments tool to deserialize

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067444#comment-14067444 ] Manikumar Reddy commented on KAFKA-1192: Introduced new command-line parameter

Re: Review Request 23705: Addressing Jun's comments

2014-07-21 Thread Manikumar Reddy O
/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f Diff: https://reviews.apache.org/r/23705/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: KAFKA-1192_2014-07-21_20:44:08.patch Enable DumpLogSegments tool to deserialize

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068611#comment-14068611 ] Manikumar Reddy commented on KAFKA-1192: Updated reviewboard https

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: (was: KAFKA-1192_2014-07-19_13:56:18.patch) Enable DumpLogSegments tool

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: (was: KAFKA-1192.patch) Enable DumpLogSegments tool to deserialize messages

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068623#comment-14068623 ] Manikumar Reddy commented on KAFKA-1192: Introduced new command-line parameter key

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Assignee: Neha Narkhede (was: Manikumar Reddy) Change the status of the JIRA to Patch

[jira] [Commented] (KAFKA-1059) Improve the patch review tool to use OAuth for JIRA access

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068651#comment-14068651 ] Manikumar Reddy commented on KAFKA-1059: [nehanarkhede] I am unable to contact

[jira] [Comment Edited] (KAFKA-1059) Improve the patch review tool to use OAuth for JIRA access

2014-07-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068651#comment-14068651 ] Manikumar Reddy edited comment on KAFKA-1059 at 7/21/14 3:44 PM

Re: Review Request 23705: Addressing Jun's comments

2014-07-22 Thread Manikumar Reddy O
returns true for non-zero length keys. So we don't need any additional null check. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/#review48265

Re: Review Request 23705: Addressing Jun's comments

2014-07-23 Thread Manikumar Reddy O
://reviews.apache.org/r/23705/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071812#comment-14071812 ] Manikumar Reddy commented on KAFKA-1192: Updated reviewboard https

[jira] [Updated] (KAFKA-1192) Enable DumpLogSegments tool to deserialize messages

2014-07-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1192: --- Attachment: KAFKA-1192_2014-07-23_20:23:08.patch Enable DumpLogSegments tool to deserialize

Re: Review Request 23705: Addressing Jun's comments

2014-07-23 Thread Manikumar Reddy O
On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165 Would key also be null possibly? Manikumar Reddy O wrote: This line is surrounded

Review Request 23858: Patch for KAFKA-1544

2014-07-23 Thread Manikumar Reddy O
/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1544) LogCleaner may take a long time to shutdown

2014-07-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071937#comment-14071937 ] Manikumar Reddy commented on KAFKA-1544: Created reviewboard https

[jira] [Updated] (KAFKA-1544) LogCleaner may take a long time to shutdown

2014-07-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1544: --- Attachment: KAFKA-1544.patch LogCleaner may take a long time to shutdown

[jira] [Assigned] (KAFKA-1544) LogCleaner may take a long time to shutdown

2014-07-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1544: -- Assignee: Manikumar Reddy LogCleaner may take a long time to shutdown

Re: Review Request 23858: Patch for KAFKA-1544

2014-07-24 Thread Manikumar Reddy O
2faa196a4dc612bc634d5ff5f5f275d09073f13b Diff: https://reviews.apache.org/r/23858/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1544) LogCleaner may take a long time to shutdown

2014-07-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1544: --- Attachment: KAFKA-1544_2014-07-24_20:38:52.patch LogCleaner may take a long time

[jira] [Commented] (KAFKA-1544) LogCleaner may take a long time to shutdown

2014-07-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073282#comment-14073282 ] Manikumar Reddy commented on KAFKA-1544: Updated reviewboard https

Re: Review Request 23858: Patch for KAFKA-1544

2014-07-24 Thread Manikumar Reddy O
. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23858/#review48532 --- On July 24, 2014, 3:11 p.m., Manikumar Reddy O wrote

Review Request 23962: Patch for KAFKA-1451

2014-07-26 Thread Manikumar Reddy O
/23962/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Assigned] (KAFKA-1451) Broker stuck due to leader election race

2014-07-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1451: -- Assignee: Manikumar Reddy Broker stuck due to leader election race

[jira] [Updated] (KAFKA-1451) Broker stuck due to leader election race

2014-07-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1451: --- Attachment: KAFKA-1451.patch Broker stuck due to leader election race

[jira] [Commented] (KAFKA-1451) Broker stuck due to leader election race

2014-07-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075317#comment-14075317 ] Manikumar Reddy commented on KAFKA-1451: Created reviewboard https

[jira] [Commented] (KAFKA-1451) Broker stuck due to leader election race

2014-07-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075321#comment-14075321 ] Manikumar Reddy commented on KAFKA-1451: Uploaded a patch which checks controller

Re: Review Request 23962: Patch for KAFKA-1451

2014-07-28 Thread Manikumar Reddy O
/23962/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076270#comment-14076270 ] Manikumar Reddy commented on KAFKA-1451: Updated reviewboard https

[jira] [Updated] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1451: --- Attachment: KAFKA-1451_2014-07-28_20:17:21.patch Broker stuck due to leader election race

[jira] [Updated] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1451: --- Attachment: (was: KAFKA-1451_2014-07-28_20:17:21.patch) Broker stuck due to leader

Review Request 23983: Patch for KAFKA-1451

2014-07-28 Thread Manikumar Reddy O
/23983/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076274#comment-14076274 ] Manikumar Reddy commented on KAFKA-1451: Created reviewboard https

[jira] [Updated] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1451: --- Attachment: KAFKA-1451.patch Broker stuck due to leader election race

Re: Review Request 23962: Patch for KAFKA-1451

2014-07-28 Thread Manikumar Reddy O
/23962/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1451: --- Attachment: (was: KAFKA-1451.patch) Broker stuck due to leader election race

[jira] [Updated] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1451: --- Attachment: KAFKA-1451_2014-07-28_20:27:32.patch Broker stuck due to leader election race

[jira] [Commented] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076277#comment-14076277 ] Manikumar Reddy commented on KAFKA-1451: Updated reviewboard https

[jira] [Commented] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077385#comment-14077385 ] Manikumar Reddy commented on KAFKA-1451: Updated reviewboard https

Re: Review Request 23962: Patch for KAFKA-1451

2014-07-28 Thread Manikumar Reddy O
to not to update leaderId field. Anyhow.. i will upload a new patch with correct leaderId update. - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23962/#review48965

[jira] [Updated] (KAFKA-1451) Broker stuck due to leader election race

2014-07-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1451: --- Attachment: KAFKA-1451_2014-07-29_10:13:23.patch Broker stuck due to leader election race

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-07-29 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078858#comment-14078858 ] Manikumar Reddy commented on KAFKA-1374: I am trying to look in to the issue

[jira] [Comment Edited] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-07-29 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078858#comment-14078858 ] Manikumar Reddy edited comment on KAFKA-1374 at 7/30/14 4:29 AM

Review Request 24214: Patch for KAFKA-1374

2014-08-03 Thread Manikumar Reddy O
/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 5bfa764638e92f217d0ff7108ec8f53193c22978 Diff: https://reviews.apache.org/r/24214/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Assigned] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-03 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1374: -- Assignee: Manikumar Reddy LogCleaner (compaction) does not support compressed topics

[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-03 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1374: --- Attachment: KAFKA-1374.patch LogCleaner (compaction) does not support compressed topics

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-03 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084047#comment-14084047 ] Manikumar Reddy commented on KAFKA-1374: In this patch, LogCleaner decompress

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-08-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084777#comment-14084777 ] Manikumar Reddy commented on KAFKA-1499: I would like to propose new server

[jira] [Assigned] (KAFKA-1499) Broker-side compression configuration

2014-08-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1499: -- Assignee: Manikumar Reddy Broker-side compression configuration

[jira] [Comment Edited] (KAFKA-1499) Broker-side compression configuration

2014-08-04 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084777#comment-14084777 ] Manikumar Reddy edited comment on KAFKA-1499 at 8/4/14 3:43 PM

<    6   7   8   9   10   11   12   13   14   15   >