/coordinator/CoordinatorMetadata.scala
c39e6de34ee531c6dfa9107b830752bd7f8fbe59
core/src/test/scala/unit/kafka/coordinator/ConsumerCoordinatorResponseTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/35086/diff/
Testing
---
Thanks,
Onur Karaman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35086/#review88247
---
On June 4, 2015, 7:57 p.m., Onur Karaman wrote
On June 11, 2015, 1:07 a.m., Jun Rao wrote:
core/src/main/scala/kafka/server/DelayedOperation.scala, lines 264-266
https://reviews.apache.org/r/35201/diff/2/?file=980805#file980805line264
Not sure if we need this check. Since all writes to watchersForKey are
sync-ed, it's ok to
group.
2. A manual group management (subscribes to partitions) consumer that sends
an OffsetFetchRequest whose groupId hashes to the coordinator.
Should these be distinguishable? We can do this with an added flag in
OffsetFetchRequest.
- Onur Karaman
On June 8, 2015, 11:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35201/#review87077
---
Ship it!
Ship It!
- Onur Karaman
On June 8, 2015, 6:47 p.m
. You'd
have to mock out dependencies(ReplicaManager) that are a level deeper than what
you actually care about(OffsetManager) with the hope that OffsetManager would
react nicely to your mock instead of directly mocking the OffsetManager itself.
- Onur Karaman
On June 8, 2015, 11:12 p.m
://reviews.apache.org/r/35187/#comment139163
Forgot to mention that the commented out code should be removed.
- Onur Karaman
On June 7, 2015, 4:49 a.m., Guozhang Wang wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35187/#review86950
---
Ship it!
Ship It!
- Onur Karaman
On June 7, 2015, 4:49 a.m
[
https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2253:
Description:
We hit a deadlock while running brokers with git hash
[
https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2253:
Reviewer: (was: Jun Rao)
Deadlock in delayed operation purgatory
[
https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2253:
Description:
We hit a deadlock while running brokers with git hash
[
https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman reassigned KAFKA-2245:
---
Assignee: Onur Karaman (was: Guozhang Wang)
Add tests for ConsumerCoordinator
[
https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573479#comment-14573479
]
Onur Karaman commented on KAFKA-2245:
-
Created reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2245:
Status: Patch Available (was: Open)
Add tests for ConsumerCoordinator
[
https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2245:
Attachment: KAFKA-2245.patch
Add tests for ConsumerCoordinator
c39e6de34ee531c6dfa9107b830752bd7f8fbe59
core/src/test/scala/unit/kafka/coordinator/ConsumerCoordinatorResponseTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/35086/diff/
Testing
---
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2245:
Summary: Add response tests for ConsumerCoordinator (was: Add tests for
ConsumerCoordinator)
Add
to the other broker.
- Onur Karaman
On June 2, 2015, 9:07 p.m., Guozhang Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34524
[
https://issues.apache.org/jira/browse/KAFKA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567640#comment-14567640
]
Onur Karaman commented on KAFKA-2231:
-
Can you provide the number of partitions
wheel design would be simpler if:
1. we allow TimerTasks to only be run at most once
2. we force TimerTask to have exactly one TimerTaskEntry and TimerTaskEntry to
only ever belong to exactly one TimerTask (just make the TimerTaskEntry in the
TimerTask's constructor).
- Onur Karaman
On May 29
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 132-135
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line132
So, I guess the race condition is the following. The expiration thread
moves a
/#comment137317
Is returning NOT_COORDINATOR_FOR_CONSUMER right? By this point in
handleHeartbeat, we've already verified that we are the coordinator for the
group.
- Onur Karaman
On May 21, 2015, 2:15 a.m., Guozhang Wang wrote
a TimerTaskEntry that
already exists in another TimerTaskList. Can you explain how that can happen?
My understanding of the timing wheel stuff is only so-so.
- Onur Karaman
On May 27, 2015, 9 p.m., Yasuhiro Matsuda wrote
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561366#comment-14561366
]
Onur Karaman edited comment on KAFKA-1989 at 5/27/15 5:59 PM
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561481#comment-14561481
]
Onur Karaman commented on KAFKA-1989:
-
Here's the ticket: https://issues.apache.org
Onur Karaman created KAFKA-2226:
---
Summary: NullPointerException in TestPurgatoryPerformance
Key: KAFKA-2226
URL: https://issues.apache.org/jira/browse/KAFKA-2226
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561366#comment-14561366
]
Onur Karaman commented on KAFKA-1989:
-
Hi Yasuhiro.
A NullPointerException sometimes
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Summary: Coordinator should detect consumer failures (was: Add failure
detection capability
On May 20, 2015, 5:15 p.m., Onur Karaman wrote:
I only did a brief skim. This optimization tries to switch consumers over
to a new coordinator without a rebalance. From my understanding, the
consumers would detect a coordinator failure, discover the new coordinator
to work
[
https://issues.apache.org/jira/browse/KAFKA-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552707#comment-14552707
]
Onur Karaman commented on KAFKA-1335:
-
Part 1 was handled by: https
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Description: Add failure detection capability to the coordinator when group
management is used
[
https://issues.apache.org/jira/browse/KAFKA-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552703#comment-14552703
]
Onur Karaman commented on KAFKA-2017:
-
I left a review.
Persist Coordinator State
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552701#comment-14552701
]
Onur Karaman commented on KAFKA-1334:
-
This ticket originally was two things:
1
Onur Karaman created KAFKA-2208:
---
Summary: Consumer should detect coordinator failures
Key: KAFKA-2208
URL: https://issues.apache.org/jira/browse/KAFKA-2208
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553458#comment-14553458
]
Onur Karaman commented on KAFKA-1335:
-
I'll write up the ticket with the details
---
On May 15, 2015, 3:46 p.m., Onur Karaman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34273
Onur Karaman created KAFKA-2196:
---
Summary: remove roundrobin identical topic constraint in consumer
coordinator
Key: KAFKA-2196
URL: https://issues.apache.org/jira/browse/KAFKA-2196
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2196:
Status: Patch Available (was: Open)
remove roundrobin identical topic constraint in consumer
[
https://issues.apache.org/jira/browse/KAFKA-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2196:
Attachment: KAFKA-2196.patch
remove roundrobin identical topic constraint in consumer coordinator
106982286ce7a9e4f0e9722da2812e3a8e7a6cc3
core/src/test/scala/unit/kafka/coordinator/PartitionAssignorTest.scala
ba6d5cd85b89214247209d974701eb6c9eb1e2b2
Diff: https://reviews.apache.org/r/34273/diff/
Testing
---
Thanks,
Onur Karaman
/coordinator/CoordinatorMetadataTest.scala
PRE-CREATION
core/src/test/scala/unit/kafka/coordinator/GroupTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/coordinator/PartitionAssignorTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1454#comment-1454
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-05-14_00:38:39.patch
Add failure detection capability
On May 7, 2015, 10:07 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/coordinator/CoordinatorMetadata.scala, line 53
https://reviews.apache.org/r/33088/diff/10/?file=950430#file950430line53
Add @nonthreadsafe for this function.
Onur Karaman wrote:
It would be awkward
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-05-08_10:55:02.patch
Add failure detection capability
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535105#comment-14535105
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
/coordinator/CoordinatorMetadataTest.scala
PRE-CREATION
core/src/test/scala/unit/kafka/coordinator/GroupTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/coordinator/PartitionAssignorTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur
patch does not apply cleanly on
trunk?
Onur Karaman wrote:
Will do.
I merged in the patch with HEAD of trunk.
- Onur
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/#review82921
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/#review81743
---
On May 8, 2015, 5:55 p.m., Onur Karaman wrote
., Onur Karaman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/
---
(Updated May 5, 2015, 5:50 p.m.)
Review request
---
On May 5, 2015, 5:50 p.m., Onur Karaman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088
synchronization.
A basic version of striped locks:
https://gist.github.com/onurkaraman/e8afb91154ec4a832234
- Onur Karaman
On May 6, 2015, 11:31 p.m., Guozhang Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
during
rebalance from marking rejoined consumers as dead regardless of how that
scheduleHeartbeatExpiration method is split up.
On April 28, 2015, 12:13 a.m., Onur Karaman wrote:
Some general comments:
1. Could you add some step-by-step and if-else comments in coordinator's
functions
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/#review81743
---
On May 5, 2015, 5:50 p.m., Onur Karaman wrote:
---
This is an automatically
: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528896#comment-14528896
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
On April 30, 2015, 10:45 p.m., Onur Karaman wrote:
core/src/main/scala/kafka/server/DelayedOperation.scala, line 224
https://reviews.apache.org/r/33731/diff/2/?file=946502#file946502line224
We can put the key inside Watchers and just use the watchersForKey
that's already
/coordinator/GroupTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/coordinator/PartitionAssignorTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512810#comment-14512810
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512752#comment-14512752
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-25_15:21:25.patch
Add failure detection capability
/33088/#review79762
---
On April 25, 2015, 5:46 a.m., Onur Karaman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088
[
https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511899#comment-14511899
]
Onur Karaman commented on KAFKA-2149:
-
Okay that sounds fair. I hadn't seen
[
https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2149:
Resolution: Not A Problem
Status: Resolved (was: Patch Available)
fix default
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512134#comment-14512134
]
Onur Karaman commented on KAFKA-1809:
-
As a follow-up: there was inconsistent
[
https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511943#comment-14511943
]
Onur Karaman commented on KAFKA-2149:
-
Cool thanks!
fix default
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-24_22:46:15.patch
Add failure detection capability
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512277#comment-14512277
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
core/src/test/scala/unit/kafka/coordinator/GroupTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur Karaman
---
On April 25, 2015, 5:46 a.m., Onur Karaman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/
---
(Updated April 25, 2015, 5:46
Onur Karaman created KAFKA-2149:
---
Summary: fix default InterBrokerProtocolVersion
Key: KAFKA-2149
URL: https://issues.apache.org/jira/browse/KAFKA-2149
Project: Kafka
Issue Type: Bug
/server/KafkaConfigTest.scala
2428dbd7197a58cf4cad42ef82b385dab3a2b15e
Diff: https://reviews.apache.org/r/33532/diff/
Testing
---
Thanks,
Onur Karaman
BufferUnderflowException from UpdateMetadataRequest.
After this patch: brought up a controller with this patch and then an older
broker. Broker no longer gets BufferUnderflowException.
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2149:
Status: Patch Available (was: Open)
fix default InterBrokerProtocolVersion
[
https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511657#comment-14511657
]
Onur Karaman commented on KAFKA-2149:
-
Created reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-2149:
Attachment: KAFKA-2149.patch
fix default InterBrokerProtocolVersion
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511660#comment-14511660
]
Onur Karaman commented on KAFKA-1809:
-
I hit problems upgrading to this patch because
://reviews.apache.org/r/33088/#review79762
---
On April 18, 2015, 7:16 p.m., Onur Karaman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
to set this property.
- Onur Karaman
On April 19, 2015, 6:10 p.m., Sriharsha Chintalapani wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33342
:
https://reviews.apache.org/r/33088/#review80619
---
On April 18, 2015, 7:16 p.m., Onur Karaman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
[
https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502065#comment-14502065
]
Onur Karaman commented on KAFKA-2046:
-
I forgot to give an update on Clark's case. I
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-18_10:16:23.patch
Add failure detection capability
420e2c3535e722c503f13d093849469983f6f08d
core/src/test/scala/unit/kafka/coordinator/GroupTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501479#comment-14501479
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501538#comment-14501538
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
core/src/test/scala/unit/kafka/coordinator/GroupTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-18_12:16:39.patch
Add failure detection capability
[
https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494497#comment-14494497
]
Onur Karaman commented on KAFKA-2046:
-
I made a jira for this: https
[
https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494496#comment-14494496
]
Onur Karaman commented on KAFKA-1993:
-
I made the jira: https://issues.apache.org/jira
Onur Karaman created KAFKA-2122:
---
Summary: Remove controller.message.queue.size Config
Key: KAFKA-2122
URL: https://issues.apache.org/jira/browse/KAFKA-2122
Project: Kafka
Issue Type: Bug
/
Testing
---
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-13_11:55:06.patch
Add failure detection capability
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492849#comment-14492849
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492856#comment-14492856
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard https://reviews.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-13_11:58:53.patch
Add failure detection capability
/
Testing
---
Thanks,
Onur Karaman
c63f4ba9d622817ea8636d4e6135fba917ce085a
core/src/main/scala/kafka/server/OffsetManager.scala
420e2c3535e722c503f13d093849469983f6f08d
Diff: https://reviews.apache.org/r/33088/diff/
Testing
---
Thanks,
Onur Karaman
[
https://issues.apache.org/jira/browse/KAFKA-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492106#comment-14492106
]
Onur Karaman commented on KAFKA-2115:
-
Trunk's coordinator is pretty much
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-04-11_22:47:27.patch
Add failure detection capability
On April 8, 2015, 4:51 a.m., Jun Rao wrote:
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 137
https://reviews.apache.org/r/32953/diff/1/?file=920411#file920411line137
Do you know why the test passes before? ConfigDef currently seems to
ignore undefined
301 - 400 of 488 matches
Mail list logo
