/
Testing
---
Thanks,
Yasuhiro Matsuda
On March 17, 2015, 8:56 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/server/DelayedOperation.scala, line 116
https://reviews.apache.org/r/31568/diff/1/?file=881353#file881353line116
We need to make tickMs and wheelSize configurable.
Yasuhiro Matsuda wrote:
What
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31893/#review76566
---
On March 16, 2015, 8:23 p.m., Yasuhiro Matsuda wrote
---
Thanks,
Yasuhiro Matsuda
---
Thanks,
Yasuhiro Matsuda
On March 13, 2015, 11:43 p.m., Yasuhiro Matsuda wrote:
The inheritance of MessageWriter from BufferingOutputStream is a bit
confusing, since it will always use itself in the writePayload function
parameter.
I feel it is more clear to read the code if we just let MessageWriter
---
Thanks,
Yasuhiro Matsuda
tryComplete() and onComplete() need to be overwritten in a
subclass of DelayedOperation.
Actually, I am not sure how we complete the requests before the timeout
is reached since there is no explict call for tryComplete()?
Yasuhiro Matsuda wrote:
isCompleted checks
://reviews.apache.org/r/31568/#review76459
---
On Feb. 28, 2015, 12:14 a.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
Thanks,
Yasuhiro Matsuda
---
On March 16, 2015, 10:19 p.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31742/
---
(Updated March 16, 2015
PRE-CREATION
core/src/test/scala/unit/kafka/message/MessageWriterTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/31742/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31742/#review76985
---
On March 16, 2015, 10:19 p.m., Yasuhiro Matsuda wrote
-CREATION
Diff: https://reviews.apache.org/r/31568/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
when the task entry gets reinsurted its correspondence
to the task will not change, right?
If that is true we can just set the entry for the task in the
constructor of the task entry.
Yasuhiro Matsuda wrote:
This sets TimerTaskEntry to TimerTask. TimeTask is created
/31742/#review76985
---
On March 16, 2015, 10:19 p.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31742
., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31568/
---
(Updated Feb. 28, 2015, 12:14 a.m.)
Review
Better group the private functions together after the public functions.
Well, I don't think it is particulary better way to organize code, but if you
insist I can change it.
Kafka code base doesn't seem to follow that convention...
On March 13, 2015, 11:43 p.m., Yasuhiro Matsuda wrote
/browse/KAFKA-2013
Repository: kafka
Description
---
purgatory micro benchmark
Diffs
-
core/src/test/scala/other/kafka/TestPurgatoryPerformance.scala PRE-CREATION
Diff: https://reviews.apache.org/r/31893/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
PRE-CREATION
core/src/test/scala/unit/kafka/message/MessageWriterTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/31742/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
---
Thanks,
Yasuhiro Matsuda
/#review76975
---
On April 1, 2015, 12:31 a.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31893
/TimerTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/31568/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
/message/MessageWriterTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/31742/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33071/#review80342
---
Cool! It looks good to me.
- Yasuhiro Matsuda
On April 10, 2015
-CREATION
Diff: https://reviews.apache.org/r/31568/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31568/#review79257
---
On April 7, 2015, 9:59 p.m., Yasuhiro Matsuda wrote
---
On April 1, 2015, 8:50 p.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31568/
---
(Updated April 1, 2015
().
Yasuhiro Matsuda wrote:
This came from the original ExpiredOperationReaper.expireNext(). Also the
comment on onExpiration says, Call-back to execute when a delayed operation
expires, but before completion. So, I cannot call forceComplete before
onExpiration. I think we can do
---
On April 7, 2015, 9:59 p.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31568
20, 2015, 3:45 p.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31568/
---
(Updated March 20, 2015, 3:45
-CREATION
Diff: https://reviews.apache.org/r/31568/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
/33028/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
-CREATION
Diff: https://reviews.apache.org/r/31568/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
list is now null, we quit the loop, (5) the
reinsert process adds the entry to a new list.
At this point, a completed entry still exists in the list.
Yasuhiro Matsuda wrote:
You are right. It should be rare, but a completed entry can remain in the
list until expiration
---
On May 27, 2015, 9 p.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734
.
- Yasuhiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/#review85596
---
On May 27, 2015, 9 p.m., Yasuhiro Matsuda wrote
list is now null, we quit the loop, (5) the
reinsert process adds the entry to a new list.
At this point, a completed entry still exists in the list.
Yasuhiro Matsuda wrote:
You are right. It should be rare, but a completed entry can remain in the
list until expiration
/r/34734/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
,
Yasuhiro Matsuda
---
On May 29, 2015, 12:19 a.m., Yasuhiro Matsuda wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734
/r/34734/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/#review85596
---
On May 29, 2015, 5:49 p.m., Yasuhiro Matsuda wrote
it's created for the first time or when it's removed
from the current list and needs to be added to a new list during reinsert.
In both cases, the list in the entry will be null and there is no need to
remove the entry from the list.
Yasuhiro Matsuda wrote:
I will remove
/r/34734/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
/r/34734/diff/
Testing
---
Thanks,
Yasuhiro Matsuda
.
- Yasuhiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/#review85764
---
On May 29, 2015, 5:49 p.m., Yasuhiro Matsuda wrote
:
https://issues.apache.org/jira/browse/KAFKA-2260?focusedCommentId=14632259page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14632259
In particular, Yasuhiro Matsuda proposed an
interesting
variant on
this that performs the offset
?focusedCommentId=14632259page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14632259
In particular, Yasuhiro Matsuda proposed an interesting variant on
this that performs the offset check on the message key (instead of
just the partition), with bounded space
Jay, I understand that. Context can provide more information without
breaking the compatibility if needed. Also I am not sure ConsumerRecord is
the right abstraction of data for stream processing. After transformation
or join, what is the topic and the offset? It is odd to use ConsumerRecord.
We
The goal of this KIP is to provide a lightweight/embeddable streaming
framework, and allows Kafka users to start using stream processing easily. DSL
is not covered in this KIP. But, DSL is a very attractive option to have.
In the proposed KafkaProcessor API, there is no interface like Collector
A partitioning scheme should be a cluster wide thing. Letting each sink
have a different partitioning scheme does not make sense to me. A
partitioning scheme is not specific to a stream job, each task or a sink. I
think specifying it at sink level is more error prone.
If a user wants to customize
> metrics.
>
> The bottom line is that *different* topics will likely need to be
> partitioned differently.
>
> On October 14, 2015 at 12:57:37 PM, Yasuhiro Matsuda (
> yasuhiro.mats...@gmail.com) wrote:
>
> A partitioning scheme should be a cluster wide thing
The group id is removed from the restore consumer config because the
restore consumer should not participate in the specified consumer group. I
don't know why it is failing.
On Fri, Nov 27, 2015 at 12:37 PM, Guozhang Wang wrote:
> Hello Bill,
>
> Thanks for reporting it,
You can do a conditional branching by using KStream.branch(Predicate...).
You can then merge multiple streams using KStreamBuilder.merge(KStream...).
-Yasuhiro
On Mon, Jun 20, 2016 at 4:45 AM, Jeyhun Karimov
wrote:
> Hi Guozhang,
>
> Thank you for your reply. Yes, it is
It may not be ideal, but there is a way to prioritize particular topics. It
is to set the record timestamps to zero. This can be done by using a custom
TimestampExtractor. Kafka Streams tries to synchronize multiple streams
using the extracted timestamps. So, records with the timestamp 0 have
Yasuhiro Matsuda created KAFKA-1965:
---
Summary: Leaner DelayedItem
Key: KAFKA-1965
URL: https://issues.apache.org/jira/browse/KAFKA-1965
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Status: Patch Available (was: Open)
Leaner DelayedItem
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Description: In DelayedItem, which is a superclass of DelayedOperation,
both the creation
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Description: In DelayedItem, which is a superclass of DelayedOperation,
both the creation
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Attachment: KAFKA-1965.patch
Leaner DelayedItem
--
Key
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Status: Patch Available (was: Open)
Leaner DelayedItem
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Status: Open (was: Patch Available)
Leaner DelayedItem
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Attachment: KAFKA-1965.patch
Leaner DelayedItem
--
Key
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327795#comment-14327795
]
Yasuhiro Matsuda commented on KAFKA-1965:
-
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329725#comment-14329725
]
Yasuhiro Matsuda commented on KAFKA-1965:
-
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2013:
Attachment: KAFKA-2013_2015-03-16_14:13:20.patch
benchmark test for the purgatory
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363843#comment-14363843
]
Yasuhiro Matsuda commented on KAFKA-2013:
-
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2013:
Attachment: KAFKA-2013_2015-03-16_13:23:38.patch
benchmark test for the purgatory
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363957#comment-14363957
]
Yasuhiro Matsuda commented on KAFKA-2013:
-
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2013:
Attachment: KAFKA-2013_2015-03-16_14:39:07.patch
benchmark test for the purgatory
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14364085#comment-14364085
]
Yasuhiro Matsuda commented on KAFKA-527:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-527:
---
Attachment: KAFKA-527_2015-03-16_15:19:29.patch
Compression support does numerous byte copies
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2013:
Attachment: KAFKA-2013_2015-03-19_16:30:52.patch
benchmark test for the purgatory
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370341#comment-14370341
]
Yasuhiro Matsuda commented on KAFKA-2013:
-
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370703#comment-14370703
]
Yasuhiro Matsuda commented on KAFKA-527:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-527:
---
Attachment: KAFKA-527_2015-03-19_21:32:24.patch
Compression support does numerous byte copies
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371503#comment-14371503
]
Yasuhiro Matsuda commented on KAFKA-1989:
-
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1989:
Attachment: KAFKA-1989_2015-03-20_08:44:57.patch
New purgatory design
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352290#comment-14352290
]
Yasuhiro Matsuda commented on KAFKA-527:
This patch is mainly aimed at #1 above
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2013:
Attachment: KAFKA-2013.patch
benchmark test for the purgatory
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2013:
Status: Patch Available (was: Open)
benchmark test for the purgatory
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355189#comment-14355189
]
Yasuhiro Matsuda edited comment on KAFKA-2013 at 3/10/15 4:53 PM
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355189#comment-14355189
]
Yasuhiro Matsuda commented on KAFKA-2013:
-
This benchmark test measures
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355189#comment-14355189
]
Yasuhiro Matsuda edited comment on KAFKA-2013 at 3/10/15 4:53 PM
Yasuhiro Matsuda created KAFKA-2013:
---
Summary: benchmark test for the purgatory
Key: KAFKA-2013
URL: https://issues.apache.org/jira/browse/KAFKA-2013
Project: Kafka
Issue Type: Test
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-527:
---
Attachment: KAFKA-527_2015-03-25_12:08:00.patch
Compression support does numerous byte copies
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380547#comment-14380547
]
Yasuhiro Matsuda commented on KAFKA-527:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389764#comment-14389764
]
Yasuhiro Matsuda commented on KAFKA-2013:
-
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2013:
Attachment: KAFKA-2013_2015-03-31_17:30:56.patch
benchmark test for the purgatory
Yasuhiro Matsuda created KAFKA-1989:
---
Summary: New purgatory design
Key: KAFKA-1989
URL: https://issues.apache.org/jira/browse/KAFKA-1989
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1989:
Status: Patch Available (was: Open)
New purgatory design
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1989:
Attachment: KAFKA-1989.patch
New purgatory design
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341070#comment-14341070
]
Yasuhiro Matsuda commented on KAFKA-1989:
-
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-527:
---
Attachment: KAFKA-527.patch
Compression support does numerous byte copies
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347441#comment-14347441
]
Yasuhiro Matsuda commented on KAFKA-527:
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-527:
---
Assignee: Yasuhiro Matsuda
Status: Patch Available (was: Open)
Compression support
[
https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347478#comment-14347478
]
Yasuhiro Matsuda commented on KAFKA-527:
This patch introduces
[
https://issues.apache.org/jira/browse/KAFKA-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-1965:
Attachment: KAFKA-1965_2015-02-20_15:08:26.patch
Leaner DelayedItem
[
https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484170#comment-14484170
]
Yasuhiro Matsuda commented on KAFKA-1989:
-
Updated reviewboard https
1 - 100 of 157 matches
Mail list logo