Re: [ANNOUNCE] New committer: Jason Gustafson

2016-09-09 Thread Aditya Auradkar
Congrats Jason. On Fri, Sep 9, 2016 at 5:30 AM, Michael Noll wrote: > My compliments, Jason -- well deserved! :-) > > -Michael > > > > On Wed, Sep 7, 2016 at 6:49 PM, Grant Henke wrote: > > > Congratulations and thank you for all of your contributions

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-25 Thread Aditya Auradkar
Hey Rajini - If the quota.type is set to 'user', what happens to unauthenticated clients? They don't supply a principal, so are they essentially unthrottled? This may be a nit, but I prefer 'quota.type' options to be 'authenticated-user' and 'client-id' as opposed to 'client' and 'user'. For a

[jira] [Commented] (KAFKA-3492) support quota based on authenticated user name

2016-04-01 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222349#comment-15222349 ] Aditya Auradkar commented on KAFKA-3492: Very cool. Jun - are you planning to drive

[jira] [Commented] (KAFKA-3456) In-house KafkaMetric misreports metrics when periodically observed

2016-03-25 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212514#comment-15212514 ] Aditya Auradkar commented on KAFKA-3456: Accidentally changed the thread title to gibberish

[jira] [Updated] (KAFKA-3456) bihtfbucbcceinvujekclljidcuf

2016-03-25 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-3456: --- Summary: bihtfbucbcceinvujekclljidcuf (was: In-house KafkaMetric misreports metrics when

[jira] [Updated] (KAFKA-3456) In-house KafkaMetric misreports metrics when periodically observed

2016-03-25 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-3456: --- Summary: In-house KafkaMetric misreports metrics when periodically observed

[jira] [Commented] (KAFKA-3427) broker can return incorrect version of fetch response when the broker hits an unknown exception

2016-03-20 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203370#comment-15203370 ] Aditya Auradkar commented on KAFKA-3427: [~junrao] - Certainly, I can patch 0.9. > broker

[jira] [Commented] (KAFKA-3310) fetch requests can trigger repeated NPE when quota is enabled

2016-03-01 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174366#comment-15174366 ] Aditya Auradkar commented on KAFKA-3310: [~junrao] - can you take a look? > fetch requests

[jira] [Commented] (KAFKA-3310) fetch requests can trigger repeated NPE when quota is enabled

2016-02-29 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173223#comment-15173223 ] Aditya Auradkar commented on KAFKA-3310: [~junrao] - Just making sure, you observe

[jira] [Commented] (KAFKA-3310) fetch requests can trigger repeated NPE when quota is enabled

2016-02-29 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173204#comment-15173204 ] Aditya Auradkar commented on KAFKA-3310: [~junrao] - Let me investigate this. If this is a problem

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

2016-02-23 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159491#comment-15159491 ] Aditya Auradkar commented on KAFKA-1215: [~allenxwang] - Is this patch ready for review? I noticed

Re: [DISCUSS] KIP-46: Self Healing

2016-02-16 Thread Aditya Auradkar
omfortable adding the capability to move large > amounts of data to the controller, after we are very sure that the default > policy is well tested and the replica throttling works. If so, then it is > just a matter of placing the trigger in the controller vs in the tool. But > I'm skeptic

Re: [DISCUSS] KIP-46: Self Healing

2016-02-09 Thread Aditya Auradkar
large-scale data movement in a running > cluster. Once we stabilize these changes and feel confident that they work, > we can push the policy into the controller and have it automatically be > triggered based on different events. > > Thanks, > Neha > > On Tue, Feb 2, 2016

[DISCUSS] KIP-46: Self Healing

2016-02-02 Thread Aditya Auradkar
Hey everyone, I just created a kip to discuss automated replica reassignment when we lose a broker in the cluster. https://cwiki.apache.org/confluence/display/KAFKA/KIP-46%3A+Self+Healing+Kafka Any feedback is welcome. Thanks, Aditya

[jira] [Commented] (KAFKA-3088) 0.9.0.0 broker crash on receipt of produce request with empty client ID

2016-01-21 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111924#comment-15111924 ] Aditya Auradkar commented on KAFKA-3088: I personally prefer preserving the old behavior i.e

Re: [VOTE] KIP-36 - Rack aware replica assignment

2016-01-19 Thread Aditya Auradkar
+1 (non-binding) On Tue, Jan 19, 2016 at 8:28 AM, Grant Henke wrote: > +1 (non-binding) > > On Tue, Jan 19, 2016 at 7:46 AM, Ismael Juma wrote: > > > +1 (non-binding) > > > > On Tue, Jan 19, 2016 at 6:12 AM, Guozhang Wang > wrote: >

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2016-01-08 Thread Aditya Auradkar
avoid > > > > > > unnecessary changes, my current patch did not merge them together > > but > > > > > > simply make sure the version of Record(Message) and > > > > > > MemoryRecords(MessageSet) matches. > > > > >

Re: [DISCUSS] KIP-36 - Rack aware replica assignment

2016-01-05 Thread Aditya Auradkar
t; > >> Allen > >> > >> > >> > >> > >> > >> On Tue, Nov 3, 2015 at 9:03 AM, Neha Narkhede <n...@confluent.io> > >> > wrote: > >> > >> > >> > >>> Few suggestions on improving the KIP > >

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2016-01-05 Thread Aditya Auradkar
rity" even > > though the index interval is configurable now. > > > > 61. In this design, it's possible for a log segment to have an empty time > > index. In the worse case, we may have to scan more than the active > segment > > to recover the latest timestamp. > >

Re: [VOTE] KIP-32 Add CreateTime and LogAppendTime to Kafka message.

2016-01-04 Thread Aditya Auradkar
Hey Becket/Anna - I have a few comments about the KIP. 1. (Minor) Can we rename the KIP? It's currently "Add CreateTime and LogAppendTime etc..". This is actually the title of the now rejected Option 1. 2. (Minor) Can we rename the proposed option? It isn't really "option 4" anymore. 3. I'm not

[jira] [Commented] (KAFKA-2966) 0.9.0 docs missing upgrade notes regarding replica lag

2015-12-09 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049357#comment-15049357 ] Aditya Auradkar commented on KAFKA-2966: I'll work on it since I made those changes. > 0.9.0 d

[jira] [Assigned] (KAFKA-2966) 0.9.0 docs missing upgrade notes regarding replica lag

2015-12-09 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar reassigned KAFKA-2966: -- Assignee: Aditya Auradkar > 0.9.0 docs missing upgrade notes regarding replica

Re: [ANNOUNCE] New Kafka Committer Ewen Cheslack-Postava

2015-12-08 Thread Aditya Auradkar
Congrats Ewen! On Tue, Dec 8, 2015 at 11:51 AM, Guozhang Wang wrote: > Congrats Ewen! Welcome onboard. > > Guozhang > > On Tue, Dec 8, 2015 at 11:42 AM, Liquan Pei wrote: > > > Congrats, Ewen! > > > > On Tue, Dec 8, 2015 at 11:37 AM, Neha Narkhede

[jira] [Commented] (KAFKA-2310) Add config to prevent broker becoming controller

2015-12-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036359#comment-15036359 ] Aditya Auradkar commented on KAFKA-2310: [~abiletskyi] - I see you submitted a pull request

Re: [DISCUSS] KIP-36 - Rack aware replica assignment

2015-11-02 Thread Aditya Auradkar
easily missed. > > The affected command line tools are TopicCommand and > ReassignPartitionsCommand. > > Thanks, > Allen > > > > > > On Mon, Oct 26, 2015 at 12:55 PM, Aditya Auradkar <aaurad...@linkedin.com> > wrote: > > > Hi Allen, > > > > For TopicMeta

[jira] [Commented] (KAFKA-2502) Quotas documentation for 0.8.3

2015-10-29 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980712#comment-14980712 ] Aditya Auradkar commented on KAFKA-2502: [~gwenshap] - Published a patch. Please take a look

[jira] [Commented] (KAFKA-2502) Quotas documentation for 0.8.3

2015-10-28 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979155#comment-14979155 ] Aditya Auradkar commented on KAFKA-2502: [~gwenshap][~ijuma] - Sorry for the delay.. been dealing

[jira] [Created] (KAFKA-2699) Add test to validate times in RequestMetrics

2015-10-27 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2699: -- Summary: Add test to validate times in RequestMetrics Key: KAFKA-2699 URL: https://issues.apache.org/jira/browse/KAFKA-2699 Project: Kafka Issue Type

Re: [DISCUSS] KIP-36 - Rack aware replica assignment

2015-10-26 Thread Aditya Auradkar
> We allow dynamic topic creation with incomplete broker-rack mapping and > fail fast in command line. Another option is to let user determine the > behavior for command line. For example, by default fail fast in command > line but allow incomplete broker-rack mapping if another

Re: [VOTE] KIP-38: ZooKeeper authentication

2015-10-21 Thread Aditya Auradkar
+1 (non-binding). On Wed, Oct 21, 2015 at 3:57 PM, Ismael Juma wrote: > +1 (non-binding) > > On Wed, Oct 21, 2015 at 4:17 PM, Flavio Junqueira wrote: > > > Thanks everyone for the feedback so far. At this point, I'd like to start > > a vote for KIP-38. > > >

[jira] [Assigned] (KAFKA-2664) Adding a new metric with several pre-existing metrics is very expensive

2015-10-20 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar reassigned KAFKA-2664: -- Assignee: Aditya Auradkar (was: Onur Karaman) > Adding a new metric with several

Re: Slow request log in Kafka

2015-10-20 Thread Aditya Auradkar
trics > > 3. Capture detailed timing of a random sample of the requests and log it > > (i.e sample metrics rather than avgs). Note that clients that send more > > requests and longer requests are more likely to get sampled. I've found > > this super useful in the past.

Re: [DISCUSS] KIP-36 - Rack aware replica assignment

2015-10-20 Thread Aditya Auradkar
rote: > >> > > > > >> > > > > I attended Tuesday's KIP hangout but this KIP was not discussed > >> due > >> > to > >> > > > > time constraint. > >> > > > > > >> > > > > However, after hearing

Re: [DISCUSS] KIP-39 Pinning controller to a broker

2015-10-20 Thread Aditya Auradkar
Hi Abhishek - Perhaps it would help if you explained the motivation behind your proposal. I know there was a bunch of discussion on KAFKA-1778, can you summarize? Currently, I'd agree with Neha and Jay that there isn't really a strong reason to pin the controller to a given broker or restricted

[jira] [Commented] (KAFKA-2502) Quotas documentation for 0.8.3

2015-10-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963909#comment-14963909 ] Aditya Auradkar commented on KAFKA-2502: Thanks Gwen and Ismael. I'll have send a patch to review

[jira] [Commented] (KAFKA-2502) Quotas documentation for 0.8.3

2015-10-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963605#comment-14963605 ] Aditya Auradkar commented on KAFKA-2502: [~ijuma] - I assume I need to submit changes to the 0.9

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2015-10-15 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958962#comment-14958962 ] Aditya Auradkar commented on KAFKA-2419: [~ijuma] - We create only a single metrics instance

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2015-10-15 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959588#comment-14959588 ] Aditya Auradkar commented on KAFKA-2419: I agree it would be nice to not need a tick thread

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2015-10-15 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959484#comment-14959484 ] Aditya Auradkar commented on KAFKA-2419: [~junrao] - That is indeed the current implementation i.e

[jira] [Comment Edited] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2015-10-15 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959409#comment-14959409 ] Aditya Auradkar edited comment on KAFKA-2419 at 10/15/15 6:52 PM

Slow request log in Kafka

2015-10-14 Thread Aditya Auradkar
Hey everyone, We were recently discussing a small logging improvement for Kafka. Basically, add a request log for queries that took longer than a certain configurable time to execute. This can be quite useful for debugging purposes, in fact it would have proven handy while investigating a recent

[jira] [Commented] (KAFKA-2536) topics tool should allow users to alter topic configuration

2015-10-13 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955375#comment-14955375 ] Aditya Auradkar commented on KAFKA-2536: [~gwenshap] - Thanks for reporting. Do we plan to keep

[jira] [Commented] (KAFKA-2527) System Test for Quotas in Ducktape

2015-10-13 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955720#comment-14955720 ] Aditya Auradkar commented on KAFKA-2527: [~gwenshap] - Thanks! > System Test for Quo

[jira] [Commented] (KAFKA-2606) Remove kafka.utils.Time in favour of o.a.kafka.common.utils.Time

2015-10-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941984#comment-14941984 ] Aditya Auradkar commented on KAFKA-2606: [~ijuma] This is a duplicate of https://issues.apache.org

[jira] [Updated] (KAFKA-2247) Merge kafka.utils.Time and kafka.common.utils.Time

2015-10-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2247: --- Description: We currently have 2 different versions of Time in clients and core. These need

[jira] [Resolved] (KAFKA-2606) Remove kafka.utils.Time in favour of o.a.kafka.common.utils.Time

2015-10-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar resolved KAFKA-2606. Resolution: Duplicate Duplicate of: https://issues.apache.org/jira/browse/KAFKA-2247

Re: [DISCUSS] KIP-36 - Rack aware replica assignment

2015-09-30 Thread Aditya Auradkar
ady > > have an interface for discovering information about the physical location > > of servers. I don't relish the idea of having to maintain data in > multiple > > places. > > > > -Todd > > > > On Mon, Sep 28, 2015 at 4:48 PM, Aditya Auradkar < >

Re: Release plan for kafka security

2015-09-25 Thread Aditya Auradkar
Basically, 0.8.3 has been renamed to 0.9.0. The plan is to include security in the 0.9 release which should happen once all the blocker bugs have been resolved and testing is complete (committers can provide more accurate timelines). On Fri, Sep 25, 2015 at 10:35 AM, Whitney, Adam

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

2015-09-25 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908460#comment-14908460 ] Aditya Auradkar commented on KAFKA-1215: [~allenxwang] - bump. > Rack-Aware replica assignm

Re: [VOTE] KIP-31 - Move to relative offsets in compressed message sets.

2015-09-23 Thread Aditya Auradkar
+1 On Wed, Sep 23, 2015 at 8:03 PM, Neha Narkhede wrote: > +1 > > On Wed, Sep 23, 2015 at 6:21 PM, Todd Palino wrote: > > > +1000 > > > > ! > > > > -Todd > > > > On Wednesday, September 23, 2015, Jiangjie Qin > > > wrote: > > >

[jira] [Updated] (KAFKA-2567) throttle-time shouldn't be NaN

2015-09-22 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2567: --- Labels: quotas (was: ) > throttle-time shouldn't be

[jira] [Assigned] (KAFKA-2567) throttle-time shouldn't be NaN

2015-09-22 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar reassigned KAFKA-2567: -- Assignee: Aditya Auradkar > throttle-time shouldn't be

[jira] [Commented] (KAFKA-2567) throttle-time shouldn't be NaN

2015-09-22 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903101#comment-14903101 ] Aditya Auradkar commented on KAFKA-2567: [~junrao] - I'l fix this in my next patch > throt

Re: [ANNOUNCE] New Committer Sriharsha Chintalapani

2015-09-21 Thread Aditya Auradkar
Congrats Sriharsha! Great work.. especially on SSL. On Mon, Sep 21, 2015 at 10:31 PM, Prabhjot Bharaj wrote: > Congratulations. It's inspiring for newbies like me > > Regards, > Prabhjot > On Sep 22, 2015 10:30 AM, "Ashish Singh" wrote: > > >

[jira] [Commented] (KAFKA-1599) Change preferred replica election admin command to handle large clusters

2015-09-21 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901142#comment-14901142 ] Aditya Auradkar commented on KAFKA-1599: [~anigam] - Perhaps you can write up your proposal here

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

2015-09-15 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745803#comment-14745803 ] Aditya Auradkar commented on KAFKA-1215: [~allenxwang] One of the committers can provide you write

[jira] [Updated] (KAFKA-2443) Expose windowSize on Rate

2015-09-14 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2443: --- Summary: Expose windowSize on Rate (was: Expose windowSize on Measurable) > Exp

[jira] [Commented] (KAFKA-2500) Make logEndOffset available in the 0.8.3 Consumer

2015-09-10 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739003#comment-14739003 ] Aditya Auradkar commented on KAFKA-2500: [~hachikuji] - Are you planning on supporting

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2015-09-10 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739324#comment-14739324 ] Aditya Auradkar commented on KAFKA-2419: Thanks [~ijuma] I'll take a look today. If I indeed can

[jira] [Commented] (KAFKA-2528) Quota Performance Evaluation

2015-09-10 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739899#comment-14739899 ] Aditya Auradkar commented on KAFKA-2528: One possible explanation for the difference is that we

[jira] [Commented] (KAFKA-2528) Quota Performance Evaluation

2015-09-10 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739438#comment-14739438 ] Aditya Auradkar commented on KAFKA-2528: I'm not quite sure why the actual rate is higher

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2015-09-09 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737756#comment-14737756 ] Aditya Auradkar commented on KAFKA-2419: [~junrao][~jjkoshy] We have a couple of ways to solve

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

2015-09-09 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737918#comment-14737918 ] Aditya Auradkar commented on KAFKA-1215: [~allenxwang] Hi Allen. Thanks for the patch. Can you

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2015-09-09 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737497#comment-14737497 ] Aditya Auradkar commented on KAFKA-2419: [~junrao] I'm working on this now. Shall submit a patch

Re: Maybe 0.8.3 should really be 0.9.0?

2015-09-08 Thread Aditya Auradkar
Hi Gwen, I certainly think 0.9.0 is better than 0.8.3. As regards semantic versioning, do we have a plan for a 1.0 release? IIUC, compatibility rules don't really apply for pre-1.0 stuff. I'd argue that Kafka already qualifies for 1.x. Aditya On Tue, Sep 8, 2015 at 10:26 AM, Gwen Shapira

[jira] [Resolved] (KAFKA-2136) Client side protocol changes to return quota delays

2015-09-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar resolved KAFKA-2136. Resolution: Fixed > Client side protocol changes to return quota del

[jira] [Updated] (KAFKA-2502) Quotas documentation for 0.8.3

2015-09-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2502: --- Labels: quotas (was: ) > Quotas documentation for 0.

[jira] [Created] (KAFKA-2502) Quotas documentation for 0.8.3

2015-09-02 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2502: -- Summary: Quotas documentation for 0.8.3 Key: KAFKA-2502 URL: https://issues.apache.org/jira/browse/KAFKA-2502 Project: Kafka Issue Type: Task

[jira] [Updated] (KAFKA-2209) Change client quotas dynamically using DynamicConfigManager

2015-09-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2209: --- Labels: quotas (was: ) > Change client quotas dynamically using DynamicConfigMana

[jira] [Updated] (KAFKA-2443) Expose windowSize on Measurable

2015-09-02 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar updated KAFKA-2443: --- Labels: quotas (was: ) > Expose windowSize on Measura

Open source Mysql -> Kafka connector

2015-09-01 Thread Aditya Auradkar
I thought this would be of interest: https://developer.zendesk.com/blog/introducing-maxwell-a-mysql-to-kafka-binlog-processor A copycat connector that parses MySQL binlogs would be rather useful I think. Streaming connectors using jdbc are tricky to implement because they rely on an indexed

Re: no Kafka KIP meeting tomorrow

2015-09-01 Thread Aditya Auradkar
Typically to discuss anything listed here or other important changes: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals On Tue, Sep 1, 2015 at 1:28 AM, jinxing wrote: > Can I know what is KIP meeting? > > > > > > > At 2015-09-01 12:30:18, "Jun

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-25 Thread Aditya Auradkar
response) - i.e., when we move the broker over to use these protocol schemas. Aditya Auradkar wrote: Makes sense. Do you want me to tackle this in this patch or should it be tackled in the patch that migrates the broker to use these schemas? Joel Koshy wrote: I think it would

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-25 Thread Aditya Auradkar
/ThrottledResponseExpirationTest.scala c4b5803917e700965677d53624f1460c1a52bf52 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-25 Thread Aditya Auradkar
/server/ThrottledResponseExpirationTest.scala c4b5803917e700965677d53624f1460c1a52bf52 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-24 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review96100 --- On Aug. 24, 2015, 5:33 p.m., Aditya Auradkar wrote

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-24 Thread Aditya Auradkar
/server/ThrottledResponseExpirationTest.scala c4b5803917e700965677d53624f1460c1a52bf52 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

[jira] [Assigned] (KAFKA-2442) QuotasTest should not fail when cpu is busy

2015-08-21 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar reassigned KAFKA-2442: -- Assignee: Aditya Auradkar (was: Dong Lin) QuotasTest should not fail when cpu

[jira] [Commented] (KAFKA-2442) QuotasTest should not fail when cpu is busy

2015-08-21 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707492#comment-14707492 ] Aditya Auradkar commented on KAFKA-2442: [~jjkoshy] - Can you take a look

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-21 Thread Aditya Auradkar
/server/ThrottledResponseExpirationTest.scala c4b5803917e700965677d53624f1460c1a52bf52 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-21 Thread Aditya Auradkar
. - Aditya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review96009 --- On Aug. 18, 2015, 8:24 p.m., Aditya Auradkar wrote

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-21 Thread Aditya Auradkar
Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

[jira] [Commented] (KAFKA-2444) Fail test: kafka.api.QuotasTest testThrottledProducerConsumer FAILED

2015-08-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703192#comment-14703192 ] Aditya Auradkar commented on KAFKA-2444: [~gwenshap] will do Fail test

[jira] [Created] (KAFKA-2446) KAFKA-2205 causes existing Topic config changes to be lost

2015-08-19 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2446: -- Summary: KAFKA-2205 causes existing Topic config changes to be lost Key: KAFKA-2446 URL: https://issues.apache.org/jira/browse/KAFKA-2446 Project: Kafka

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-08-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703701#comment-14703701 ] Aditya Auradkar commented on KAFKA-2084: [~guozhang] Will do byte rate metrics

[jira] [Resolved] (KAFKA-2085) Return delay time in QuotaViolationException

2015-08-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar resolved KAFKA-2085. Resolution: Fixed Resolved in KAFKA-2084 Return delay time in QuotaViolationException

[jira] [Work started] (KAFKA-2097) Implement request delays for quota violations

2015-08-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2097 started by Aditya Auradkar. -- Implement request delays for quota violations

[jira] [Resolved] (KAFKA-2293) IllegalFormatConversionException in Partition.scala

2015-08-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar resolved KAFKA-2293. Resolution: Fixed Committed to trunk IllegalFormatConversionException in Partition.scala

[jira] [Resolved] (KAFKA-2097) Implement request delays for quota violations

2015-08-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar resolved KAFKA-2097. Resolution: Fixed Resolved in KAFKA-2084 Implement request delays for quota violations

[jira] [Commented] (KAFKA-2446) KAFKA-2205 causes existing Topic config changes to be lost

2015-08-19 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704037#comment-14704037 ] Aditya Auradkar commented on KAFKA-2446: [~junrao][~jjkoshy] - Can one of you

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
/server/ThrottledResponseExpirationTest.scala 14a7f4538041d557c190127e3d5f85edf2a0e7c1 Diff: https://reviews.apache.org/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
kafka-2248; Use Apache Rat to enforce copyright headers; patched by Ewen Cheslack-Postava; reviewed by Gwen Shapira, Joel Joshy and Jun Rao kafka-2132; Move Log4J appender to a separate module; patched by Ashish Singh; reviewed by Gwen Shapira, Aditya Auradkar and Jun Rao KAFKA-2314: proper

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
/r/33378/diff/ Testing --- New tests added Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-18 Thread Aditya Auradkar
--- On Aug. 15, 2015, 12:43 a.m., Aditya Auradkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug

[jira] [Created] (KAFKA-2443) Expose windowSize on Measurable

2015-08-18 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2443: -- Summary: Expose windowSize on Measurable Key: KAFKA-2443 URL: https://issues.apache.org/jira/browse/KAFKA-2443 Project: Kafka Issue Type: Task

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-18 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review94167 --- On July 13, 2015, 8:36 p.m., Aditya Auradkar wrote

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-14 Thread Aditya Auradkar
/ThrottledResponseExpirationTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/33049/diff/ Testing --- Thanks, Aditya Auradkar

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-14 Thread Aditya Auradkar
and Jun Rao. Bugs: KAFKA-2084 https://issues.apache.org/jira/browse/KAFKA-2084 Repository: kafka Description (updated) --- Signed-off-by: Aditya Auradkar aaurad...@linkedin.com Addressing Joel's comments Minor imports changes Added testcase to verify that replication traffic

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-14 Thread Aditya Auradkar
be elapsedCurrent and elapsedPrior as computed in Rate.measure()). Aditya Auradkar wrote: Rate/Measurable stat does not expose the windows currently. So we cannot access elapsedCurrent and elapsedPrior from the KafkaMetric object in Sensor. Couple of options: 1. We can simply record

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-13 Thread Aditya Auradkar
and Jun Rao. Bugs: KAFKA-2084 https://issues.apache.org/jira/browse/KAFKA-2084 Repository: kafka Description (updated) --- Signed-off-by: Aditya Auradkar aaurad...@linkedin.com Addressing Joel's comments Minor imports changes Added testcase to verify that replication traffic

  1   2   3   4   5   >