[GitHub] [kafka-site] tom1299 closed pull request #290: MINOR: Add missing to to testing

2020-10-19 Thread GitBox
tom1299 closed pull request #290: URL: https://github.com/apache/kafka-site/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] mjsax merged pull request #305: Add the best talks from Kafka Summit 2020

2020-10-19 Thread GitBox
mjsax merged pull request #305: URL: https://github.com/apache/kafka-site/pull/305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] miguno commented on pull request #305: Add the best talks from Kafka Summit 2020

2020-10-19 Thread GitBox
miguno commented on pull request #305: URL: https://github.com/apache/kafka-site/pull/305#issuecomment-711980559 HTML cleanup example. After cleanup: ```html

[GitHub] [kafka-site] miguno commented on pull request #305: Add the best talks from Kafka Summit 2020

2020-10-19 Thread GitBox
miguno commented on pull request #305: URL: https://github.com/apache/kafka-site/pull/305#issuecomment-711975561 I tested the PR locally with `vnu` (HTML validation) and via https://cwiki.apache.org/confluence/display/KAFKA/Setup+Kafka+Website+on+Local+Apache+Server.

[GitHub] [kafka-site] miguno opened a new pull request #305: Add the best talks from Kafka Summit 2020

2020-10-19 Thread GitBox
miguno opened a new pull request #305: URL: https://github.com/apache/kafka-site/pull/305 This PR adds the thirty best Kafka Summit 2020 talks as rated by the community (summit attendees). To make maintenance of the Videos page easier, I also refactored (read: cleaned up) the HTML

[GitHub] [kafka-site] chia7712 merged pull request #304: Add chia7712 to committers

2020-10-18 Thread GitBox
chia7712 merged pull request #304: URL: https://github.com/apache/kafka-site/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] chia7712 commented on pull request #304: Add chia7712 to committers

2020-10-18 Thread GitBox
chia7712 commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-711161869 @guozhangwang Thanks for confirming. Merge it to trunk :) This is an automated message from the Apache Git

[GitHub] [kafka-site] guozhangwang commented on pull request #304: Add chia7712 to committers

2020-10-17 Thread GitBox
guozhangwang commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-711025894 I missed that file. You are good to go. This is an automated message from the Apache Git Service. To

[GitHub] [kafka-site] chia7712 commented on pull request #304: Add chia7712 to committers

2020-10-17 Thread GitBox
chia7712 commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710767238 @guozhangwang thanks for reviews! > you'd also need to git add the image file as well. The image file is already included. Please correct me if I misunderstand

[GitHub] [kafka-site] guozhangwang commented on pull request #304: Add chia7712 to committers

2020-10-17 Thread GitBox
guozhangwang commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710760998 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka-site] chia7712 opened a new pull request #304: Add chia7712 to committers

2020-10-16 Thread GitBox
chia7712 opened a new pull request #304: URL: https://github.com/apache/kafka-site/pull/304 hello Kafka :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka-site] dajac merged pull request #303: Add dajac to committers

2020-10-16 Thread GitBox
dajac merged pull request #303: URL: https://github.com/apache/kafka-site/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] dajac opened a new pull request #303: Add dajac to committers

2020-10-16 Thread GitBox
dajac opened a new pull request #303: URL: https://github.com/apache/kafka-site/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] mjsax merged pull request #302: Updating title on videos page

2020-10-13 Thread GitBox
mjsax merged pull request #302: URL: https://github.com/apache/kafka-site/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] scott-confluent opened a new pull request #302: Updating title on videos page

2020-10-13 Thread GitBox
scott-confluent opened a new pull request #302: URL: https://github.com/apache/kafka-site/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka-site] ankit-kumar-25 edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread GitBox
ankit-kumar-25 edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project:

[GitHub] [kafka-site] ankit-kumar-25 closed pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-23 Thread GitBox
ankit-kumar-25 closed pull request #220: URL: https://github.com/apache/kafka-site/pull/220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka-site] ankit-kumar-25 commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
ankit-kumar-25 commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project:

[GitHub] [kafka-site] viktorsomogyi edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo (and perhaps get someone to merge it).

[GitHub] [kafka-site] viktorsomogyi commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo. This is an

[GitHub] [kafka-site] ankit-kumar-25 commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
ankit-kumar-25 commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project:

[GitHub] [kafka-site] viktorsomogyi commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo. This is an

[GitHub] [kafka-site] viktorsomogyi edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
viktorsomogyi edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo (and perhaps get someone to merge it).

[GitHub] [kafka-site] vvcephei merged pull request #301: Redo 2.6 docs commit

2020-09-09 Thread GitBox
vvcephei merged pull request #301: URL: https://github.com/apache/kafka-site/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] ableegoldman commented on a change in pull request #301: Redo 2.6 docs commit

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can

[GitHub] [kafka-site] ableegoldman commented on a change in pull request #301: Redo 2.6 docs commit

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can

[GitHub] [kafka-site] vvcephei commented on a change in pull request #301: Redo 2.6 docs commit

2020-09-08 Thread GitBox
vvcephei commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485142442 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can be

[GitHub] [kafka-site] ableegoldman opened a new pull request #301: Redo 2.6 docs commit

2020-09-03 Thread GitBox
ableegoldman opened a new pull request #301: URL: https://github.com/apache/kafka-site/pull/301 Just noticed that all of the docs I added just before 2.6 aren't actually showing up on the site. Seems like they were accidentally reverted by [this

[GitHub] [kafka-site] ewencp merged pull request #300: [MINOR] adding Itau Unibanco and OTICS to the powered-by page

2020-08-31 Thread GitBox
ewencp merged pull request #300: URL: https://github.com/apache/kafka-site/pull/300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] scott-confluent opened a new pull request #300: [MINOR] adding Itau Unibanco and OTICS to the powered-by page

2020-08-27 Thread GitBox
scott-confluent opened a new pull request #300: URL: https://github.com/apache/kafka-site/pull/300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka-site] vvcephei merged pull request #295: MINOR: fix for text wrapping in some tables in docs

2020-08-25 Thread GitBox
vvcephei merged pull request #295: URL: https://github.com/apache/kafka-site/pull/295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] mimaison merged pull request #299: fix: Fix link for Kafka London meetup

2020-08-21 Thread GitBox
mimaison merged pull request #299: URL: https://github.com/apache/kafka-site/pull/299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] katheris opened a new pull request #299: fix: Fix link for Kafka London meetup

2020-08-21 Thread GitBox
katheris opened a new pull request #299: URL: https://github.com/apache/kafka-site/pull/299 Signed-off-by: Katherine Stanley This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] mjsax merged pull request #298: MINOR: remove unreleased versions from CVE page

2020-08-19 Thread GitBox
mjsax merged pull request #298: URL: https://github.com/apache/kafka-site/pull/298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] mjsax opened a new pull request #298: MINOR: remove unreleased versions from CVE page

2020-08-19 Thread GitBox
mjsax opened a new pull request #298: URL: https://github.com/apache/kafka-site/pull/298 As reported on the mailing list: https://lists.apache.org/list.html?dev@kafka.apache.org:lte=1M:cve%202.0.2%202.1.2 Call for review @ijuma

[GitHub] [kafka-site] guozhangwang commented on pull request #293: MINOR: fix for quickstart in docs

2020-08-18 Thread GitBox
guozhangwang commented on pull request #293: URL: https://github.com/apache/kafka-site/pull/293#issuecomment-675832265 @scott-confluent After merged the PR the new link seems still not working? This is an automated message

[GitHub] [kafka-site] guozhangwang merged pull request #293: MINOR: fix for quickstart in docs

2020-08-18 Thread GitBox
guozhangwang merged pull request #293: URL: https://github.com/apache/kafka-site/pull/293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] SanjayYr opened a new pull request #297: MINOR: fix for example implementation of how to add a new header to the record

2020-08-18 Thread GitBox
SanjayYr opened a new pull request #297: URL: https://github.com/apache/kafka-site/pull/297 Fixed method invocation and arguments. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka-site] SanjayYr opened a new pull request #296: MINOR: fix for extra line break in streams processor API documentation

2020-08-18 Thread GitBox
SanjayYr opened a new pull request #296: URL: https://github.com/apache/kafka-site/pull/296 Removed the extra "/p" tag. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka-site] scott-confluent opened a new pull request #295: fix for text wrapping in some tables in docs

2020-08-17 Thread GitBox
scott-confluent opened a new pull request #295: URL: https://github.com/apache/kafka-site/pull/295 Someone opened a JIRA ticket for this: https://issues.apache.org/jira/browse/KAFKA-10406 This is an automated message from

[GitHub] [kafka-site] ableegoldman commented on pull request #294: MINOR: removing docs version header from 2.6 docs

2020-08-13 Thread GitBox
ableegoldman commented on pull request #294: URL: https://github.com/apache/kafka-site/pull/294#issuecomment-673585020 Just tried in a different browser and I still only see the header on 2.5. The 2.4 formatting looks a little different, but no "You're viewing an older version..." header

[GitHub] [kafka-site] ableegoldman commented on pull request #294: MINOR: removing docs version header from 2.6 docs

2020-08-13 Thread GitBox
ableegoldman commented on pull request #294: URL: https://github.com/apache/kafka-site/pull/294#issuecomment-673584334 Huh, I don't see the header on 2.4 (or earlier). Since this has been merged I now only see it on 2.5

[GitHub] [kafka-site] rhauch merged pull request #294: MINOR: removing docs version header from 2.6 docs

2020-08-13 Thread GitBox
rhauch merged pull request #294: URL: https://github.com/apache/kafka-site/pull/294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] rhauch commented on pull request #294: MINOR: removing docs version header from 2.6 docs

2020-08-13 Thread GitBox
rhauch commented on pull request #294: URL: https://github.com/apache/kafka-site/pull/294#issuecomment-673499292 @ableegoldman I see the header on 2.4 and earlier. IIUC, this is to *add* this header to the 2.5 docs and *remove* this header from all of the 2.6 docs (e.g.,

[GitHub] [kafka-site] guozhangwang merged pull request #289: MINOR: Fix the broken past-events link

2020-08-12 Thread GitBox
guozhangwang merged pull request #289: URL: https://github.com/apache/kafka-site/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] showuon commented on pull request #289: MINOR: Fix the broken past-events link

2020-08-12 Thread GitBox
showuon commented on pull request #289: URL: https://github.com/apache/kafka-site/pull/289#issuecomment-673226049 @guozhangwang , the issue you mentioned is already addressed in this PR: https://github.com/apache/kafka-site/pull/293. Not sure if you have other comments for this PR?

[GitHub] [kafka-site] ableegoldman commented on pull request #294: MINOR: removing docs version header from 2.6 docs

2020-08-12 Thread GitBox
ableegoldman commented on pull request #294: URL: https://github.com/apache/kafka-site/pull/294#issuecomment-673035392 Should this header be on all the earlier versions too? I don't see it anywhere at the moment (except for 2.6)

[GitHub] [kafka-site] scott-confluent opened a new pull request #294: MINOR: removing docs version header from 2.6 docs

2020-08-12 Thread GitBox
scott-confluent opened a new pull request #294: URL: https://github.com/apache/kafka-site/pull/294 Also re-adding it to the 2.5 docs This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka-site] scott-confluent opened a new pull request #293: MINOR: fix for quickstart in docs

2020-08-12 Thread GitBox
scott-confluent opened a new pull request #293: URL: https://github.com/apache/kafka-site/pull/293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka-site] guozhangwang merged pull request #292: MINOR: Fix the corrupted html content

2020-08-12 Thread GitBox
guozhangwang merged pull request #292: URL: https://github.com/apache/kafka-site/pull/292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] benstopford commented on pull request #292: MINOR: Fix the corrupted html content

2020-08-12 Thread GitBox
benstopford commented on pull request #292: URL: https://github.com/apache/kafka-site/pull/292#issuecomment-672741561 @guozhangwang Can you merge this one for us. This is an automated message from the Apache Git Service. To

[GitHub] [kafka-site] showuon opened a new pull request #292: MINOR: Fix the corrupted html content

2020-08-12 Thread GitBox
showuon opened a new pull request #292: URL: https://github.com/apache/kafka-site/pull/292 Fix the corrupted html content by referring to the `25/design.html` html content.

[GitHub] [kafka-site] showuon commented on pull request #289: MINOR: Fix the broken past-events link

2020-08-11 Thread GitBox
showuon commented on pull request #289: URL: https://github.com/apache/kafka-site/pull/289#issuecomment-672543644 It's because the `quickstart.html` got removed in this PR: this PR: https://github.com/apache/kafka-site/pull/286. I think we should keep `quickstart.html`,

[GitHub] [kafka-site] vvcephei merged pull request #291: MINOR: add 2.5.1 release to Downloads

2020-08-11 Thread GitBox
vvcephei merged pull request #291: URL: https://github.com/apache/kafka-site/pull/291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] vvcephei commented on pull request #291: MINOR: add 2.5.1 release to Downloads

2020-08-11 Thread GitBox
vvcephei commented on pull request #291: URL: https://github.com/apache/kafka-site/pull/291#issuecomment-672256567 Thanks, all! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka-site] guozhangwang commented on pull request #291: MINOR: add 2.5.1 release to Downloads

2020-08-11 Thread GitBox
guozhangwang commented on pull request #291: URL: https://github.com/apache/kafka-site/pull/291#issuecomment-672204528 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] vvcephei opened a new pull request #291: MINOR: add 2.5.1 release to Downloads

2020-08-11 Thread GitBox
vvcephei opened a new pull request #291: URL: https://github.com/apache/kafka-site/pull/291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka-site] guozhangwang merged pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

2020-08-11 Thread GitBox
guozhangwang merged pull request #284: URL: https://github.com/apache/kafka-site/pull/284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] tom1299 opened a new pull request #290: MINOR: Add missing to to testing

2020-08-11 Thread GitBox
tom1299 opened a new pull request #290: URL: https://github.com/apache/kafka-site/pull/290 Just added a missing "to" to testing.html This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka-site] showuon commented on pull request #289: MINOR: Fix the broken past-events link

2020-08-11 Thread GitBox
showuon commented on pull request #289: URL: https://github.com/apache/kafka-site/pull/289#issuecomment-671857049 @scott-confluent @mjsax , could you help review this PR? Thanks. This is an automated message from the Apache

[GitHub] [kafka-site] showuon opened a new pull request #289: MINOR: Fix the wrong past-events link

2020-08-11 Thread GitBox
showuon opened a new pull request #289: URL: https://github.com/apache/kafka-site/pull/289 Fix the wrong past-events link. It should be in the `kafka-summit.org` domain, not under `kafka.apache.org`. This is an automated

[GitHub] [kafka-site] showuon commented on pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

2020-08-10 Thread GitBox
showuon commented on pull request #284: URL: https://github.com/apache/kafka-site/pull/284#issuecomment-671740187 @guozhangwang , I think this PR is good to merge except you have other opinions. Thanks. This is an automated

[GitHub] [kafka-site] guozhangwang commented on a change in pull request #287: fixes for intro page and various docs page headings

2020-08-10 Thread GitBox
guozhangwang commented on a change in pull request #287: URL: https://github.com/apache/kafka-site/pull/287#discussion_r468191760 ## File path: intro.html ## @@ -20,7 +20,203 @@ Introduction - + Review comment: Why we have to copy-paste now? The

[GitHub] [kafka-site] guozhangwang merged pull request #287: fixes for intro page and various docs page headings

2020-08-10 Thread GitBox
guozhangwang merged pull request #287: URL: https://github.com/apache/kafka-site/pull/287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] vvcephei merged pull request #288: Update John's profile

2020-08-10 Thread GitBox
vvcephei merged pull request #288: URL: https://github.com/apache/kafka-site/pull/288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] guozhangwang commented on pull request #288: Update John's profile

2020-08-10 Thread GitBox
guozhangwang commented on pull request #288: URL: https://github.com/apache/kafka-site/pull/288#issuecomment-671583692 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] vvcephei opened a new pull request #288: Update John's profile

2020-08-10 Thread GitBox
vvcephei opened a new pull request #288: URL: https://github.com/apache/kafka-site/pull/288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka-site] rhauch commented on pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

2020-08-10 Thread GitBox
rhauch commented on pull request #285: URL: https://github.com/apache/kafka-site/pull/285#issuecomment-671539747 https://kafka.apache.org/quickstart appears to be working again after merging #286. This is an automated

[GitHub] [kafka-site] rhauch merged pull request #286: MINOR: Fix renamed and reformatted quickstart, broken since 2.6.0 release

2020-08-10 Thread GitBox
rhauch merged pull request #286: URL: https://github.com/apache/kafka-site/pull/286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] scott-confluent opened a new pull request #287: fixes for intro page and various docs page headings

2020-08-10 Thread GitBox
scott-confluent opened a new pull request #287: URL: https://github.com/apache/kafka-site/pull/287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka-site] rhauch closed pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

2020-08-10 Thread GitBox
rhauch closed pull request #285: URL: https://github.com/apache/kafka-site/pull/285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] rhauch commented on pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

2020-08-10 Thread GitBox
rhauch commented on pull request #285: URL: https://github.com/apache/kafka-site/pull/285#issuecomment-671426816 Thanks for identifying the problem and proposing a fix, @showuon. However, I don't think referencing the quickstarts in `25` directory is what we want -- instead, we want to

[GitHub] [kafka-site] rhauch commented on pull request #285: MINOR: Fix the wrong doc path and missing zk/docker button in quickstart page

2020-08-10 Thread GitBox
rhauch commented on pull request #285: URL: https://github.com/apache/kafka-site/pull/285#issuecomment-671426983 Close without merging. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka-site] rhauch opened a new pull request #286: Fix renamed and reformatted quickstart, broken since 2.6.0 release

2020-08-10 Thread GitBox
rhauch opened a new pull request #286: URL: https://github.com/apache/kafka-site/pull/286 The AK code contains a `quickstart.html` file, so that when 2.6.0 was released the newer `quickstart-docker.html` and `quickstart-zookeeper.html` were not included in the `26` directory, breaking the

[GitHub] [kafka-site] showuon commented on pull request #285: MINOR: Fix the wrong referenced document in quickstart page

2020-08-07 Thread GitBox
showuon commented on pull request #285: URL: https://github.com/apache/kafka-site/pull/285#issuecomment-67045 @scott-confluent @rhauch , could you review this PR ? Thanks. This is an automated message from the Apache Git

[GitHub] [kafka-site] showuon opened a new pull request #285: MINOR: Fix the wrong referenced document name in quickstart page

2020-08-07 Thread GitBox
showuon opened a new pull request #285: URL: https://github.com/apache/kafka-site/pull/285 In quickstart page, we'll see the following error message displayed. After investigation, I found it's because we point to the wrong document `26/quickstart-zookeeper.html`. Change to the correct

[GitHub] [kafka-site] mjsax merged pull request #283: MINOR: fix HTML

2020-08-06 Thread GitBox
mjsax merged pull request #283: URL: https://github.com/apache/kafka-site/pull/283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

2020-08-06 Thread GitBox
scott-confluent commented on a change in pull request #284: URL: https://github.com/apache/kafka-site/pull/284#discussion_r466554238 ## File path: includes/_footer.htm ## @@ -329,7 +329,13 @@ var docsHandle =

[GitHub] [kafka-site] guozhangwang merged pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-06 Thread GitBox
guozhangwang merged pull request #281: URL: https://github.com/apache/kafka-site/pull/281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] rhauch merged pull request #277: 2.6.0 release

2020-08-06 Thread GitBox
rhauch merged pull request #277: URL: https://github.com/apache/kafka-site/pull/277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka-site] mimaison merged pull request #278: Remove console.log()

2020-08-06 Thread GitBox
mimaison merged pull request #278: URL: https://github.com/apache/kafka-site/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] ijuma commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-06 Thread GitBox
ijuma commented on pull request #281: URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669756104 @guozhangwang I updated the PR to mention pull request first. This is an automated message from the Apache Git

[GitHub] [kafka-site] showuon commented on pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

2020-08-05 Thread GitBox
showuon commented on pull request #284: URL: https://github.com/apache/kafka-site/pull/284#issuecomment-669677637 @scott-confluent @guozhangwang , could you help review this PR? Thanks. This is an automated message from the

[GitHub] [kafka-site] showuon opened a new pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not

2020-08-05 Thread GitBox
showuon opened a new pull request #284: URL: https://github.com/apache/kafka-site/pull/284 Change the arrow direction based on the view state is expanded or not. We can identify it's in expanded mode or not by checking the return value of toggle method. Reference:

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r466057952 ## File path: 26/upgrade.html ## @@ -19,6 +19,48 @@

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r466057579 ## File path: 26/upgrade.html ## @@ -19,6 +19,50 @@

[GitHub] [kafka-site] guozhangwang merged pull request #282: bug fixes

2020-08-05 Thread GitBox
guozhangwang merged pull request #282: URL: https://github.com/apache/kafka-site/pull/282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka-site] mjsax opened a new pull request #283: MINOR: fix HTML

2020-08-05 Thread GitBox
mjsax opened a new pull request #283: URL: https://github.com/apache/kafka-site/pull/283 Follow up to https://github.com/apache/kafka/pull/9127 \cc @guozhangwang This is an automated message from the Apache Git

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r465958151 ## File path: 26/upgrade.html ## @@ -19,6 +19,50 @@

[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r465956697 ## File path: 26/upgrade.html ## @@ -19,6 +19,50 @@

[GitHub] [kafka-site] hachikuji merged pull request #279: Add missing "to" to contributing page

2020-08-05 Thread GitBox
hachikuji merged pull request #279: URL: https://github.com/apache/kafka-site/pull/279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox
scott-confluent commented on a change in pull request #282: URL: https://github.com/apache/kafka-site/pull/282#discussion_r465924056 ## File path: 25/documentation.html ## @@ -31,7 +31,7 @@ - Review comment: I believe the older versions SHOULD

[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox
scott-confluent commented on a change in pull request #282: URL: https://github.com/apache/kafka-site/pull/282#discussion_r465921715 ## File path: 25/streams/developer-guide/write-streams.html ## @@ -90,22 +90,22 @@ See the section Data Types and Serialization

[GitHub] [kafka-site] guozhangwang commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox
guozhangwang commented on a change in pull request #282: URL: https://github.com/apache/kafka-site/pull/282#discussion_r465912196 ## File path: 25/documentation.html ## @@ -31,7 +31,7 @@ - Review comment: Ditto for other 25/xyx.html pages: does

[GitHub] [kafka-site] guozhangwang commented on pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
guozhangwang commented on pull request #277: URL: https://github.com/apache/kafka-site/pull/277#issuecomment-669351468 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] rhauch commented on pull request #277: 2.6.0 release

2020-08-05 Thread GitBox
rhauch commented on pull request #277: URL: https://github.com/apache/kafka-site/pull/277#issuecomment-669332049 @guozhangwang, @ijuma: I've updated the content to try to address your comments. Would you mind taking a look?

[GitHub] [kafka-site] scott-confluent commented on pull request #278: Remove console.log()

2020-08-05 Thread GitBox
scott-confluent commented on pull request #278: URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669326459 Nice. Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka-site] guozhangwang commented on pull request #278: Remove console.log()

2020-08-05 Thread GitBox
guozhangwang commented on pull request #278: URL: https://github.com/apache/kafka-site/pull/278#issuecomment-669312037 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] guozhangwang commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-05 Thread GitBox
guozhangwang commented on pull request #281: URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669310726 Anyways, this change LGTM. Please feel free to merge afterwards This is an automated message from the

[GitHub] [kafka-site] guozhangwang commented on pull request #281: Remove mention of Twitter as a way to get added to "Powered By"

2020-08-05 Thread GitBox
guozhangwang commented on pull request #281: URL: https://github.com/apache/kafka-site/pull/281#issuecomment-669310491 Yeah I think encouraging people to directly submit PRs is better. This is an automated message from the

  1   2   3   >