Re: [DISCUSS] Checkstyle Import Order

2020-10-23 Thread John Roesler
Hi Dongjin, Thanks for bringing this up. I’m in favor of adding a check style rule. Thanks for testing out the alternatives. As long as we aren’t adding wildcard imports and as long as it’s easy to configure IDEs with our chosen rules, I have no preference. I assume these hold for your

[jira] [Created] (KAFKA-10638) QueryableStateIntegrationTest fails due to stricter store checking

2020-10-23 Thread John Roesler (Jira)
John Roesler created KAFKA-10638: Summary: QueryableStateIntegrationTest fails due to stricter store checking Key: KAFKA-10638 URL: https://issues.apache.org/jira/browse/KAFKA-10638 Project: Kafka

[jira] [Resolved] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-10-22 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10284. -- Resolution: Fixed > Group membership update due to static member rejoin should be persis

[jira] [Created] (KAFKA-10630) State Directory config could be improved

2020-10-22 Thread John Roesler (Jira)
John Roesler created KAFKA-10630: Summary: State Directory config could be improved Key: KAFKA-10630 URL: https://issues.apache.org/jira/browse/KAFKA-10630 Project: Kafka Issue Type: Task

[jira] [Created] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-10-22 Thread John Roesler (Jira)
John Roesler created KAFKA-10629: Summary: TopologyTestDriver should not require a Properties arg Key: KAFKA-10629 URL: https://issues.apache.org/jira/browse/KAFKA-10629 Project: Kafka Issue

[jira] [Created] (KAFKA-10628) Follow-up: Remove all unnecessary dummy TopologyTestDriver configs

2020-10-22 Thread John Roesler (Jira)
John Roesler created KAFKA-10628: Summary: Follow-up: Remove all unnecessary dummy TopologyTestDriver configs Key: KAFKA-10628 URL: https://issues.apache.org/jira/browse/KAFKA-10628 Project: Kafka

[jira] [Resolved] (KAFKA-10605) KIP-478: deprecate the replaced Processor API members

2020-10-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10605. -- Resolution: Fixed > KIP-478: deprecate the replaced Processor API memb

[jira] [Resolved] (KAFKA-10455) Probing rebalances are not guaranteed to be triggered by non-leader members

2020-10-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10455. -- Resolution: Fixed > Probing rebalances are not guaranteed to be triggered by non-lea

Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application

2020-10-19 Thread John Roesler
now, > Walker > > On Wed, Oct 14, 2020 at 12:51 PM John Roesler wrote: > > > Thanks, Sophie, > > > > That makes sense. Should we add a whole new interface and a > > separate kind of listener just because global threads don't > > support restarts _yet_,

Re: [ANNOUNCE] New committer: Chia-Ping Tsai

2020-10-19 Thread John Roesler
Congratulations, Chia-Ping! -John On Mon, 2020-10-19 at 10:51 -0700, Kowshik Prakasam wrote: > Congrats! > > > Cheers, > Kowshik > > > On Mon, Oct 19, 2020 at 10:40 AM Bruno Cadonna wrote: > > > Congrats! > > > > Best, > > Bruno > > > > On 19.10.20 19:39, Sophie Blee-Goldman wrote: > > >

Re: [ANNOUNCE] New committer: A. Sophie Blee-Goldman

2020-10-19 Thread John Roesler
Congratulations, Sophie! -John On Mon, 2020-10-19 at 10:52 -0700, Kowshik Prakasam wrote: > Congrats Sophie! > > > Cheers, > Kowshik > > > On Mon, Oct 19, 2020 at 10:31 AM Bill Bejeck wrote: > > > Congratulations Sophie! > > > > -Bill > > > > On Mon, Oct 19, 2020 at 12:49 PM Leah Thomas

Re: [ANNOUNCE] New committer: David Jacot

2020-10-16 Thread John Roesler
Congratulations, David! -John On Fri, Oct 16, 2020, at 20:15, Konstantine Karantasis wrote: > Congrats, David! > > Konstantine > > > On Fri, Oct 16, 2020 at 3:36 PM Ismael Juma wrote: > > > Congratulations David! > > > > Ismael > > > > On Fri, Oct 16, 2020 at 9:01 AM Gwen Shapira wrote: > >

Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application

2020-10-14 Thread John Roesler
n > (OffsetOutOfRange). If we want to consider expanding that to allow users > to choose to restart the thread, then KIP-406 seems like the more > appropriate place to engage in that discussion. > > On Wed, Oct 14, 2020 at 7:13 AM John Roesler wrote: > > > Hello Walker, &g

Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application

2020-10-14 Thread John Roesler
ne minor nit: you should also mention the global-thread that also > > > needs > > > >>>> to be shutdown if requested by the user. > > > >>>> > > > >>>> Minor side question: should we actually terminate a thre

[jira] [Resolved] (KAFKA-10215) MockProcessorContext doesn't work with SessionStores

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10215. -- Resolution: Fixed Fixed in the new processor API. > MockProcessorContext doesn't w

[jira] [Created] (KAFKA-10605) KIP-478: deprecate the replaced Processor API members

2020-10-13 Thread John Roesler (Jira)
John Roesler created KAFKA-10605: Summary: KIP-478: deprecate the replaced Processor API members Key: KAFKA-10605 URL: https://issues.apache.org/jira/browse/KAFKA-10605 Project: Kafka Issue

[jira] [Resolved] (KAFKA-10562) KIP-478: Delegate the store wrappers to the new init method

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10562. -- Resolution: Fixed > KIP-478: Delegate the store wrappers to the new init met

[jira] [Resolved] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10437. -- Resolution: Fixed > KIP-478: Implement test-utils chan

[jira] [Resolved] (KAFKA-10536) KIP-478: Implement KStream changes

2020-10-12 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10536. -- Resolution: Fixed > KIP-478: Implement KStream chan

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-10-12 Thread John Roesler
> On 10/1/20 2:50 PM, John Roesler wrote: > > Hello again, all, > > > > I'm sorry to make another tweak to this KIP, but during the > > implementation of the design we've just agreed on, I > > realized that Processors would almost never need to > > reference t

[jira] [Created] (KAFKA-10603) Re-design

2020-10-12 Thread John Roesler (Jira)
John Roesler created KAFKA-10603: Summary: Re-design Key: KAFKA-10603 URL: https://issues.apache.org/jira/browse/KAFKA-10603 Project: Kafka Issue Type: New Feature Reporter

[jira] [Resolved] (KAFKA-10598) KafkaStreams reports inappropriate error message for IQ

2020-10-12 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10598. -- Resolution: Fixed > KafkaStreams reports inappropriate error message for

[jira] [Created] (KAFKA-10598) KafkaStreams reports inappropriate error message for IQ

2020-10-10 Thread John Roesler (Jira)
John Roesler created KAFKA-10598: Summary: KafkaStreams reports inappropriate error message for IQ Key: KAFKA-10598 URL: https://issues.apache.org/jira/browse/KAFKA-10598 Project: Kafka

Re: [VOTE] KIP-676: Respect the logging hierarchy

2020-10-10 Thread John Roesler
+1 (binding) Thanks for the KIP! -John On Fri, Oct 9, 2020, at 05:57, Dongjin Lee wrote: > +1. (Non-binding) > > Thanks, > Dongjin > > On Fri, Oct 9, 2020 at 6:50 PM Tom Bentley wrote: > > > Hi all, > > > > KIP-676 is pretty trivial and the comments on the discussion thread seem to > > be

Re: [DISCUSSION] python code style checks

2020-10-09 Thread John Roesler
Thanks Nikolay, Sounds good to me in principle. I think linters serve a useful purpose. When it comes to the specific configuration, maybe you can open a POC PR so we can see what the formatter will do. Thanks, John On Fri, Oct 9, 2020, at 05:25, Brandon Brown wrote: > I love that idea,

Re: [DISCUSS] KIP-676: Respect the logging hierarchy

2020-10-07 Thread John Roesler
d be TRACE both before and after upgrading. > > I've added more of an explanation to the KIP, since it wasn't very clear. > > Thanks for taking a look. > > Tom > > On Wed, Oct 7, 2020 at 4:29 PM John Roesler wrote: > > > Thanks for this KIP Tom, > > >

Re: [DISCUSS] KIP-676: Respect the logging hierarchy

2020-10-07 Thread John Roesler
Thanks for this KIP Tom, Just to clarify the impact: In your KIP you described a situation in which the root logger is configured at INFO, an "kafka.foo" is configured at TRACE, and then "kafka.foo.bar" is resolved to INFO. Assuming this goes into 3.0, would it be the case that if I had the

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-10-06 Thread John Roesler
n have a rough one by this weekend. > > Regards, > Dongjin > > On Thu, Oct 1, 2020 at 4:52 AM John Roesler wrote: > > > Thanks Dongjin, > > > > It typically is nicer to be able to see usage examples, so > > I'd certainly be in favor if you're willing to add it to the

[jira] [Resolved] (KAFKA-10530) kafka-streams-application-reset misses some internal topics

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10530. -- Resolution: Duplicate Closing now, since this seems like a duplicate report, and visual code

[jira] [Resolved] (KAFKA-10535) KIP-478: Implement StateStoreContext and Record

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10535. -- Resolution: Fixed > KIP-478: Implement StateStoreContext and Rec

Re: [DISCUSS] Apache Kafka 2.7.0 release

2020-10-05 Thread John Roesler
> > > > > > > -Bill > > > > > > > > > > > > > > > > > > On Mon, Sep 7, 2020 at 11:33 AM Bruno Cadonna < > > > > br...@confluent.io> > > > > > > > > wrote: > > > > > >

Re: [VOTE] KIP-653: Upgrade log4j to log4j2

2020-10-02 Thread John Roesler
Thanks for the KIP, Dongjin! I’ve just reviewed the KIP document, and it looks good to me. I’m +1 (binding) Thanks, John On Fri, Oct 2, 2020, at 19:11, Gwen Shapira wrote: > +1 (binding) > > A very welcome update :) > > On Tue, Sep 22, 2020 at 9:09 AM Dongjin Lee wrote: > > > > Hi devs, > >

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-10-01 Thread John Roesler
the PR to try and ease the reviewer's job. I'd greatly appreciate it if anyone can take the time to review. Thanks, -John On Wed, 2020-09-30 at 10:16 -0500, John Roesler wrote: > Thanks, Matthias! > > I can certainly document it. I didn't bother because the old > Processor, Supplier,

[jira] [Created] (KAFKA-10562) Delegate the store wrappers to the new init method

2020-10-01 Thread John Roesler (Jira)
John Roesler created KAFKA-10562: Summary: Delegate the store wrappers to the new init method Key: KAFKA-10562 URL: https://issues.apache.org/jira/browse/KAFKA-10562 Project: Kafka Issue

Re: [DISCUSS] Release Deadlines

2020-09-30 Thread John Roesler
Thanks for this, Matthias! I’m in favor. I’m glad we have all been working hard to stabilize our releases and offer a high quality project, even if it means delays. However, the last several releases have demonstrated that we consistently need more time than we have allocated. Rather than risk

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-09-30 Thread John Roesler
. Does that sound right? > > Yes, it is. Would it be better to add a detailed description of how this > feature effects interactive query, with examples? > > Best, > Dongjin > > On Tue, Sep 29, 2020 at 10:31 AM John Roesler wrote: > > > Hi Dongjin, > > &

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-30 Thread John Roesler
should we also deprecate the corresponding > existing ones that take the old `ProcessorSupplier`? > > > -Matthias > > > On 9/30/20 7:46 AM, John Roesler wrote: > > Thanks Paul and Sophie, > > > > Your feedback certainly underscores the need to b

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-30 Thread John Roesler
ata. Sorry for not giving things a > > > closer look > > > before responding! I'm not sure my original message made much sense given > > > the misunderstanding, but thanks for responding anyway :P > > > > > > Having given the proposal a second pass, I ag

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-29 Thread John Roesler
tor, you need to store the info you need in > order to > set the timestamp, or make one up yourself > > (the one alternative I can think of here is that maybe we could pass in the > current > partition time, so users can at least put in a reasonable estimate for the > timest

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-29 Thread John Roesler
realizing it. What I’m hoping to do is just make the situation explicit and get rid of the dummy values. Thanks, John On Tue, Sep 29, 2020, at 20:01, John Roesler wrote: > Thanks for the review, Paul! > > I had read some of that debate before. There seems to be some subtext > th

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-29 Thread John Roesler
ok at the PR and I didn't > see any spots where I thought it would be empty. Perhaps an example of a > Punctuator using (and not using) the new API would clear things up. > > Best, > Paul > > On Tue, Sep 29, 2020 at 4:10 PM John Roesler wrote: > > > Hello again, all

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-29 Thread John Roesler
.).build()`. > But it looks rather verbose? > > The other question is of course, to what extend to we want to keep the > distinction between "primary" and "secondary" data? To me, it's a > question of easy of use? > > Just putting all this out to

[jira] [Created] (KAFKA-10546) KIP-478: Deprecate old PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10546: Summary: KIP-478: Deprecate old PAPI Key: KAFKA-10546 URL: https://issues.apache.org/jira/browse/KAFKA-10546 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10544) Convert KTable aggregations to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10544: Summary: Convert KTable aggregations to new PAPI Key: KAFKA-10544 URL: https://issues.apache.org/jira/browse/KAFKA-10544 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10541) Convert KTable filters to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10541: Summary: Convert KTable filters to new PAPI Key: KAFKA-10541 URL: https://issues.apache.org/jira/browse/KAFKA-10541 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10542) Convert KTable maps to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10542: Summary: Convert KTable maps to new PAPI Key: KAFKA-10542 URL: https://issues.apache.org/jira/browse/KAFKA-10542 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10543) Convert KTable joins to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10543: Summary: Convert KTable joins to new PAPI Key: KAFKA-10543 URL: https://issues.apache.org/jira/browse/KAFKA-10543 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10540) Convert KStream aggregations to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10540: Summary: Convert KStream aggregations to new PAPI Key: KAFKA-10540 URL: https://issues.apache.org/jira/browse/KAFKA-10540 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-10539) Convert KStreamImpl joins to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10539: Summary: Convert KStreamImpl joins to new PAPI Key: KAFKA-10539 URL: https://issues.apache.org/jira/browse/KAFKA-10539 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10538) Convert KStreamImpl maps to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10538: Summary: Convert KStreamImpl maps to new PAPI Key: KAFKA-10538 URL: https://issues.apache.org/jira/browse/KAFKA-10538 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10537) Convert KStreamImpl filters to new PAPI

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10537: Summary: Convert KStreamImpl filters to new PAPI Key: KAFKA-10537 URL: https://issues.apache.org/jira/browse/KAFKA-10537 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10536) KIP-478: Implement KStream changes

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10536: Summary: KIP-478: Implement KStream changes Key: KAFKA-10536 URL: https://issues.apache.org/jira/browse/KAFKA-10536 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10535) KIP-478: Implement StateStoreContext and Record

2020-09-29 Thread John Roesler (Jira)
John Roesler created KAFKA-10535: Summary: KIP-478: Implement StateStoreContext and Record Key: KAFKA-10535 URL: https://issues.apache.org/jira/browse/KAFKA-10535 Project: Kafka Issue Type

Re: [VOTE] KIP-663: API to Start and Shut Down Stream Threads and to Request Closing of Kafka Streams Clients

2020-09-29 Thread John Roesler
Kafka Streams client will > transit to ERROR if the last alive stream thread dies exceptionally. > This corresponds to the current behavior. > > I will not restart voting and keep the votes so far. > > Best, > Bruno > > On 22.09.20 01:19, John Roesler wrote: > >

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-09-28 Thread John Roesler
ed the PR applying the API changes we discussed above. I am now > > updating the KIP document. > > > > Thanks, > > Dongjin > > > > On Sat, Sep 19, 2020 at 10:42 AM John Roesler wrote: > > > >> Hi Dongjin, > >> > >> Yes, that’s ri

Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application

2020-09-24 Thread John Roesler
Thanks for the KIP, Walker! I’m +1 (binding) -John On Mon, Sep 21, 2020, at 17:04, Guozhang Wang wrote: > Thanks for finalizing the KIP. +1 (binding) > > > Guozhang > > On Mon, Sep 21, 2020 at 1:38 PM Walker Carlson > wrote: > > > Hello all, > > > > I would like to start a thread to vote

Re: [DISCUSS] KIP-671: Shutdown Streams Application when appropriate exception is thrown

2020-09-24 Thread John Roesler
Hello all, Thanks for bringing this up, Bruno. It’s a really good point that a disconnected node would miss the signal and then resurrect a single-node “zombie cluster” when it reconnects. Offhand, I can’t think of a simple and reliable way to distinguish this case from one in which an

Re: [VOTE] KIP-666: Add Instant-based methods to ReadOnlySessionStore

2020-09-21 Thread John Roesler
Thanks, Jorge! I’m +1 (binding) -John On Mon, Sep 21, 2020, at 12:35, Sophie Blee-Goldman wrote: > Thanks for pointing out the vote in the discussion thread, this email > somehow skipped my inbox ¯\_(ツ)_/¯ > > I'm +1 (non-binding) > > -Sophie > > On Mon, Sep 7, 2020 at 4:18 AM Jorge Esteban

Re: [VOTE] KIP-663: API to Start and Shut Down Stream Threads and to Request Closing of Kafka Streams Clients

2020-09-21 Thread John Roesler
+1, please vote again. > > > > Best, > > Bruno > > > > On 04.09.20 23:12, John Roesler wrote: > > > Hi Sophie, > > > > > > Uh, oh, it's never a good sign when the discussion moves > > > into the vote thread :) > > > >

Re: [DISCUSS] KIP-666: Add Instant-based methods to ReadOnlySessionStore

2020-09-18 Thread John Roesler
Thanks for the KIP, Jorge! Sorry it took me so long. I just reviewed the KIP, and it looks good to me. Thanks, John On Tue, Sep 1, 2020, at 12:35, Jorge Esteban Quilcate Otoya wrote: > Thanks Sophie! > > > one nit: you missed updating the startTime long to Instant in both > appearances of the

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-09-18 Thread John Roesler
l update the KIP by adding the discussion > above. > > Best, > Dongjin > > On Thu, Sep 17, 2020 at 11:06 AM John Roesler wrote: > > > Hi Dongjin, > > > > Thanks for the reply. Yes, that’s correct, we added that method to name > > the operation. But

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-09-16 Thread John Roesler
ason that you prefer the second > approach? > > Thanks, > Dongjin > > [^1]: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-307%3A+Allow+to+define+custom+processor+names+with+KStreams+DSL > > > > On Wed, Sep 16, 2020 at 11:48 PM John Roesler wrote: >

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-09-16 Thread John Roesler
he > other related KIPs later. > > Do I understand correctly? > > Thanks, > Dongjin > > On Wed, Sep 16, 2020 at 2:17 AM John Roesler wrote: > > > Hi Dongjin, > > > > Thanks for presenting these options. The concern that > > Matthias brought up is a

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-09-15 Thread John Roesler
; -Matthias > > > > > > On 9/11/20 12:26 AM, Dongjin Lee wrote: > > > Hi All, > > > > > > Here is the voting thread: > > > > > > > https://lists.apache.org/thread.html/r5653bf2dafbb27b247bf20dbe6f070c151b3823d96c

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-14 Thread John Roesler
essing the record context does not seems to be > a requirement. And providing access to the processor context to, eg., > `forward()` or similar seems safe. > > > -Matthias > > On 9/10/20 7:25 PM, John Roesler wrote: > > Thanks for the reply, Paul! > > > >

Re: [DISCUSS] KIP-406: GlobalStreamThread should honor custom reset policy

2020-09-14 Thread John Roesler
restore for global store and get() might have to be exclusive. Is there a way > for a > > store to know if it global store or not because now internally global and > normal > > stores will behave differently. Although if everyone is fine with the above > approach > &

Re: Java Kafka Streams

2020-09-14 Thread John Roesler
Hello Sebastián, Thanks for the question. I think the reason you don't find documentation for this is that it's quite unusual to have a data stream that just stops at some point and never sends any more data. Can you elaborate a little whether you meant that the whole input topic just "ends" at

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

2020-09-11 Thread John Roesler
iki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=59689925=36=37 > > <https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=59689925=36=37> > > Thanks for the help, > -James > > > On Sep 11, 2020, at 12:53 PM, John Roesler wrot

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

2020-09-11 Thread John Roesler
Hi James, Sorry, I overlooked your reply until now. I've granted you access. Thanks, -John On Wed, 2020-09-09 at 21:44 -0700, James Cheng wrote: > Thanks John. My wiki user ID is wushujames > > -James > > Sent from my iPhone > > > On Sep 9, 2020, at 7:03

Re: [DISCUSS] KIP-516: Topic Identifiers

2020-09-11 Thread John Roesler
Have you thought about whether it makes sense to support authorizing a > > principal for a topic ID rather than a topic name to achieve tighter > > security? > > > > Or is the topic ID fundamentally an internal detail similar to epochs used > > in a bunch of other places in Kafk

Re: [DISCUSS] KIP-516: Topic Identifiers

2020-09-11 Thread John Roesler
Hello Justine, Thanks for the KIP! I happen to have been confronted recently with the need to keep track of a large number of topics as compactly as possible. I was going to come up with some way to dictionary encode the topic names as integers, but this seems much better! Apologies if this

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-10 Thread John Roesler
t a time-range query inside a > > punctuator. It genuinely did not occur to me that users might be looking up > > and/or updating records of other keys from within a Processor. Sorry for > > being closed minded > > > > I won't drag out this discussion any further

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-10 Thread John Roesler
ight be > a valid use case or just a lurking bug in itself :) > > Thanks for humoring me. The current proposal for KIP-478 sounds good to me > > On Thu, Sep 10, 2020 at 3:43 PM John Roesler wrote: > > > Ah, thanks Sophie, > > > > I'm sorry for misinterpreting

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-10 Thread John Roesler
of any examples, the conservative approach > sounds good to me. > > If it turns out that someone did need the record context in their custom > state > store, I'm sure they'll submit a politely worded bug report alerting us > that we > broke their application. > >

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-10 Thread John Roesler
I think I do agree that we should leave the current record context > off of > the StateStoreContext, but I don't think the Punctuator argument against it > is > very convincing. It sounds to me like we need to disallow access to the > current > record context from within the Punctuato

Re: [DISCUSS] KIP-508: Make Suppression State Queriable - rebooted.

2020-09-10 Thread John Roesler
; look after your work is done. > > Thanks, > Dongjin > > On Sun, Mar 8, 2020 at 12:20 PM John Roesler wrote: > > > Thanks Matthias, > > > > Good idea. I've changed the ticket name and added a note > > clarifying that this ticket is not the same as >

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-10 Thread John Roesler
n see some other > things being useful, for example the current record's headers. Maybe if/when > we add better (or any) support for headers in state stores this will be > less true. > > Of course as John has made clear, it's pretty hard to judge without > examples > and

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-09 Thread John Roesler
have the writer client of the state store pass this through, but > it would be nice to be able to write state stores where the client did not > have this responsibility. I'm not sure if the solution is to add some > things back to StateStoreContext, or make yet another context that >

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

2020-09-09 Thread John Roesler
tatus of the JIRA to "Patch Available" if it's ready > for review. Do this by clicking the "Submit Patch" button in JIRA, and > then in the resulting dialog, click "Submit Patch". > > -James > > > On Sep 9, 2020, at 6:24 PM, John Roesler wrote: > >

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

2020-09-09 Thread John Roesler
Hi James, I think the button on Jira says “Add Patch” or something confusing like that. Thanks, John On Wed, Sep 9, 2020, at 17:34, James Cheng wrote: > I have a JIRA that I am working on, and a pull request available for it. > > [KAFKA-10473] Website is missing docs on JMX metrics for

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2020-09-09 Thread John Roesler
Hello all, I've been slowly pushing KIP-478 forward over the last year, and I'm happy to say that we're making good progress now. However, several issues with the original design have come to light. The major changes: We discovered that the original plan of just adding generic parameters to

[jira] [Created] (KAFKA-10472) Consider migrating Topology methods to the Builder pattern

2020-09-09 Thread John Roesler (Jira)
John Roesler created KAFKA-10472: Summary: Consider migrating Topology methods to the Builder pattern Key: KAFKA-10472 URL: https://issues.apache.org/jira/browse/KAFKA-10472 Project: Kafka

Re: [VOTE] KIP-667: Remove deprecated methods from ReadOnlyWindowStore

2020-09-08 Thread John Roesler
Hello Jorge, Thanks for the KIP! FYI, it looks like there's still a boilerplate paragraph in the KIP document about it being a template. The KIP looks good to me; I'm +1 (binding) for doing this in 3.0. Thanks, -John On Mon, 2020-09-07 at 12:18 +0100, Jorge Esteban Quilcate Otoya wrote: > Hi

Re: [VOTE] KIP-663: API to Start and Shut Down Stream Threads and to Request Closing of Kafka Streams Clients

2020-09-04 Thread John Roesler
Hi Sophie, Uh, oh, it's never a good sign when the discussion moves into the vote thread :) I agree with you, it seems like a good touch for removeStreamThread() to return the name of the thread that got removed, rather than a boolean flag. Maybe the return value would be `null` if there is no

Re: [DISCUSS] KIP-406: GlobalStreamThread should honor custom reset policy

2020-09-04 Thread John Roesler
oid a special GLOBAL_RESTORING state and just > > > > introduce > > > > a single unified RESTORING state to cover both the regular and global > > case? > > > > Just a thought > > > > > > > > My only concern is that this might be c

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-09-03 Thread John Roesler
thought of bumping this voting thread again to see if we can > > > form > > > > > any > > > > > > consensus around this. > > > > > > > > > > > > Thanks! > > > > > > Sagar. > > > > >

Re: [DISCUSS] KIP-659: Improve TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2020-09-02 Thread John Roesler
me as well, I added a few lines in the > > KIP about logging an error when the *timeWindowedSerde *implicit is called. > > > > Let me know if there are any other concerns, else I'll resume voting. > > > > Cheers, > > Leah > > > > On Tue, Sep 1,

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

2020-09-01 Thread John Roesler
e KIP Yuriy, this will be a great addition. > > > > +1 (binding) > > > > -Bill > > > > On Tue, Aug 18, 2020 at 5:47 PM Matthias J. Sax wrote: > > > > > Thanks for the KIP Yuriy! > > > > > > +1 (binding) > > &

Re: [DISCUSS] KIP-659: Improve TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2020-09-01 Thread John Roesler
hat users can access the constructor > > > that initializes with the correct window size. I agree with your comment > > on > > > the KIP-616 PR that the serde needs to be pre-configured when it's > > passed, > > > but I'm not sure we would need a windowSize config. I t

Re: Request to Add in Contributor list

2020-09-01 Thread John Roesler
Hi Sharath, Please forgive me if this is a mistake, but I think I've just granted this permission for your username "DOJI". Do you need access as "DOJI45"? Thanks, -John On Tue, 2020-09-01 at 16:11 +0530, Sharath Bhat wrote: > Hi TeamPlease guide me on how I can request contributor access for

Re: Need contributor access to Jira

2020-09-01 Thread John Roesler
Hi Sandeep, I've added you to the contributors group in Jira. Thanks for your interest in Apache Kafka! Thanks, -John On Tue, 2020-09-01 at 16:13 +0530, Sandeep Kumar wrote: > Hi Team , > > Please guide me how I can request for the contributor access for jira so > that I can assign some jira

Re: Request to Add in Contributor list

2020-09-01 Thread John Roesler
Hi Sharath, I've added you to the contributor group in Jira. Thanks for your interest in Apache Kafka! Thanks, -John On Tue, 2020-09-01 at 17:22 +0530, Sharath Bhat wrote: > Hi TeamPlease guide me on how I can request contributor access for jira so > that i can assign some jira tickets to

Re: [DISCUSS] KIP-667: Remove deprecated methods from ReadOnlyWindowStore

2020-09-01 Thread John Roesler
Hi all, Thanks for bringing this up, Jorge! I'm not sure if we have a documented rule; I seem to recall having had the same discussion for 2.0. My personal suggestion would be to have a deprecation period of at least one year, and beyond that to weigh how good we feel about removing each

Re: [DISCUSS] KIP-663: API to Start and Shut Down Stream Threads and to Request Closing of Kafka Streams Clients

2020-09-01 Thread John Roesler
Hello Bruno, Thanks for the update! The KIP looks good to me; I only have a grammatical complaint about the proposed metric name. "Died" is a verb, the past tense of "to die", but in the expression,"x stream threads", x should be an adjective. To be fair, "died" is also the past participle of

Re: [DISCUSS] KIP-406: GlobalStreamThread should honor custom reset policy

2020-08-29 Thread John Roesler
make progress on some > tasks. > > Of course, if we collect real world experience and it becomes an issue, > we could still try to change it? > > > -Matthias > > > On 8/18/20 3:31 PM, John Roesler wrote: > > Thanks Matthias, > > > > Sounds good. I

[jira] [Resolved] (KAFKA-10307) Topology cycles in KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2020-08-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10307. -- Resolution: Not A Bug This bug report was based on an invalid assumption that topologies

Re: [VOTE] KIP-662: Throw Exception when Source Topics of a Streams App are Deleted

2020-08-27 Thread John Roesler
Thanks, Bruno! I'm +1 (binding) -John On Thu, 2020-08-27 at 15:35 -0400, Bill Bejeck wrote: > Thanks for the KIP Bruno. > > +1 (binding) > > -Bill > > On Thu, Aug 27, 2020 at 3:15 PM Walker Carlson > wrote: > > > +1 (Non Binding). Good Kip Bruno > > > > Walker > > > > On Tue, Aug 25,

Re: [DISCUSS] KIP-663: API to Start and Shut Down Stream Threads and to Request Closing of Kafka Streams Clients

2020-08-26 Thread John Roesler
Hi Bruno, Thanks for the well motivated and throrough KIP! It's a good point that the record cache should be re- distributed over the threads. Reading your KIP leads me to a few questions: 1. Start vs. Add Maybe this is paranoid, but I'm mildly concerned that users who don't read the docs too

Re: [VOTE] KIP-659: Improve TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2020-08-26 Thread John Roesler
Hi all, I've just sent a new message to the DISCUSS thread. We forgot to include the Scala API in the proposal. Thanks, -John On Mon, 2020-08-24 at 18:00 -0700, Sophie Blee-Goldman wrote: > Thanks for the KIP! +1 (non-binding) > > Sophie > > On Mon, Aug 24, 2020 at 5:06 PM John

Re: [DISCUSS] KIP-659: Improve TimeWindowedDeserializer and TimeWindowedSerde to handle window size

2020-08-26 Thread John Roesler
gt; On Fri, Aug 21, 2020 at 2:50 PM John Roesler wrote: > > > Thanks, all, > > > > Based on my reading of the conversation, it sounds like I > > have some legwork to do in KIP-645, but our collective > > instinct is that Leah's proposal doesn't need to change to

  1   2   3   4   5   6   7   8   9   >