Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-10-05 Thread Sagar
Thanks Guozhang, For the PR review, the PR is already there in the KIP. I am adding it here: https://github.com/confluentinc/kafka/pull/242 It's not complete by any means but maybe one pass would be possible? Thanks! Sagar. On Mon, Oct 5, 2020 at 10:26 PM Guozhang Wang wrote: > Hey Sa

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-10-05 Thread Sagar
Hi All, Just wanted to know, what the next steps are wrt to the KIP? Thanks! Sagar. On Thu, Sep 3, 2020 at 10:17 PM Sagar wrote: > Hi John, > > Thank you! I have marked the KIP as Accepted :) > > Regarding the point on InMemoryKeyValueStore, in the PR I had added the &

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-09-03 Thread Sagar
Hi John, Thank you! I have marked the KIP as Accepted :) Regarding the point on InMemoryKeyValueStore, in the PR I had added the implementation for InMemoryKeyValueStore as well. I hadn't mentioned about it in the KIP which I have done now as you suggested. Thanks! Sagar. On Thu, Sep 3, 2020

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-09-02 Thread Sagar
Thanks All! I see 3 binding +1 votes and 2 non-binding +1s. Does it mean this KIP has gained a lazy majority? Thanks! Sagar. On Thu, Sep 3, 2020 at 6:51 AM Guozhang Wang wrote: > Thanks for the KIP Sagar. I'm +1 (binding) too. > > > Guozhang > > On Tue, Sep 1, 2020 at 1

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-09-01 Thread Sagar
Hi All, Bumping the thread again ! Thanks! Sagar. On Wed, Aug 5, 2020 at 12:08 AM Sophie Blee-Goldman wrote: > Thanks Sagar! +1 (non-binding) > > Sophie > > On Sun, Aug 2, 2020 at 11:37 PM Sagar wrote: > > > Hi All, > > > > Just thought of bumping this

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-08-03 Thread Sagar
Hi All, Just thought of bumping this voting thread again to see if we can form any consensus around this. Thanks! Sagar. On Mon, Jul 20, 2020 at 4:21 AM Adam Bellemare wrote: > LGTM > +1 non-binding > > On Sun, Jul 19, 2020 at 4:13 AM Sagar wrote: > > > Hi All, > &

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-07-19 Thread Sagar
Hi All, Bumping this thread to see if there are any feedbacks. Thanks! Sagar. On Tue, Jul 14, 2020 at 9:49 AM John Roesler wrote: > Thanks for the KIP, Sagar! > > I’m +1 (binding) > > -John > > On Sun, Jul 12, 2020, at 02:05, Sagar wrote: > > Hi All, > > >

[VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-07-12 Thread Sagar
can+support+for+State+Stores> Thanks! Sagar.

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-07-11 Thread Sagar
Thanks John, Sorry I’m new to this process.  does it mean I start a voting email? Pardon my ignorance. Sagar. On Sat, 11 Jul 2020 at 8:06 PM, John Roesler wrote: > Hi Sagar, > > Thanks for the update. As far as I’m concerned, I’m ready to vote now. > > Thanks, > John

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-07-06 Thread Sagar
Hi John, Thanks, I have updated the KIP. Thanks! Sagar. On Mon, Jul 6, 2020 at 12:00 AM John Roesler wrote: > Hi Sagar, > > Sorry for the ambiguity. You could just mention it in the Public > Interfaces section. Or, if you want to be more specific, you can show it in > the me

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-07-05 Thread Sagar
Hi John, Thank you! Question on the comment, where should I add the default implementation? I guess that needs to be added in the Proposal Section of the kIP. Thanks! Sagar. On Sat, Jul 4, 2020 at 11:46 PM John Roesler wrote: > Thanks Sagar, > > That looks good to me! The only mino

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-07-04 Thread Sagar
Hi John, I have updated the KIP with all the new changes we discussed in this discussion thread. https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores Request you to go through the same. Thanks! Sagar. On Tue, Jun 30, 2020 at 8:09 AM John

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-06-28 Thread Sagar
or should I move it to ReadOnlyKeyValueStore where even the range query resides? Regarding the 2 notes on UnsupportedOperationException and changing the name to prefixScan, i will incorporate both of them into the KIP. Thanks! Sagar. On Sun, Jun 28, 2020 at 11:55 PM John Roesler wrote: > W

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-06-28 Thread Sagar
, it would be great if you can provide some feedback on this. Thanks! Sagar. On Wed, Jun 10, 2020 at 9:21 AM Sagar wrote: > Hi John, > > You rightly pointed out, the devil is in the detail :). I will start with > the implementation to get a sense. > > Here are my thoughts on

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-06-09 Thread Sagar
/commands/scan#the-match-option Typically Redis works with Binary Safe strings so the prefix key type and the actual keys are of the same type. Thanks! Sagar. On Wed, Jun 10, 2020 at 1:41 AM John Roesler wrote: > Hi Sagar, > > Thanks for the reply. I agree that your UUID example il

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-06-09 Thread Sagar
sense, I can modify my PR to go along these lines. Please let me know what you think. Lastly, I didn't understand this line of yours: *It might help if there are other typed key/value stores to compare APIs with.* Thanks! Sagar. On Thu, Jun 4, 2020 at 6:03 AM John Roesler wrote: > Hi Sa

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-06-01 Thread Sagar
for searching . Thanks! Sagar. On Mon, Jun 1, 2020 at 11:42 AM Sagar wrote: > Hi John, > > Thank you. I think it makes sense to modify the KIP to add the > prefixScan() as part of the existing interfaces and add the new mixin > behaviour as Rejected alternatives. I am not very aware

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-06-01 Thread Sagar
the type definition of types I will try and think about some alternatives and share if I get any. Thanks! Sagar. On Sun, May 31, 2020 at 1:55 AM John Roesler wrote: > Hi Sagar, > > Thanks for the response. Your use case makes sense to me; I figured it > must be so

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-05-26 Thread Sagar
was really insightful and it's always good to learn/discover new things :) Thanks! Sagar. On Fri, May 15, 2020 at 7:37 AM John Roesler wrote: > Hi, Sagar! > > Thanks for this KIP. I'm sorry it took me so long to reply. I'll number my > points differently to avoid confusion. > > I

Re: [DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-05-14 Thread Sagar
, Thanks for bringing that point up! I have mentioned about that PR in the KIP under a section called Other considerations. Nonetheless, thanks for pointing it out! Thanks! Sagar. On Thu, May 14, 2020 at 5:17 AM Sophie Blee-Goldman wrote: > Not to derail this KIP discussion, but to leave a

[DISCUSS] KIP-614: Add Prefix Scan support for State Stores

2020-05-12 Thread Sagar
Hi All, I would like to start a discussion on the KIP that I created below to add prefix scan support in State Stores: https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores Thanks! Sagar.

Re: Permission to create KIP

2019-12-30 Thread Sagar
Hi, Its sagarmeansocean On Sat, Dec 28, 2019 at 12:29 AM Matthias J. Sax wrote: > What is your wiki account id? > > > -Matthias > > On 12/27/19 7:12 AM, Sagar wrote: > > Hi, > > > > I have done some work on adding prefix scan for state store and would >

Permission to create KIP

2019-12-27 Thread Sagar
Hi, I have done some work on adding prefix scan for state store and would like to create a KIP for the same. Thanks! Sagar.

[jira] [Created] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

2019-11-09 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-9168: Summary: Integrate JNI direct buffer support to RocksDBStore Key: KAFKA-9168 URL: https://issues.apache.org/jira/browse/KAFKA-9168 Project: Kafka Issue Type: Task

Re: Kafka Connect

2019-06-04 Thread Sagar
Hi meirkhan, You can give debezium a shot. It has a connector for mongodb On Tue, 4 Jun 2019 at 6:56 PM, wrote: > Hello Kafka! > > Here is my case. I need the Kafka Connector to Mongodb which imitates JDBC > Source Connector. > So that data is loaded to Kafka by periodically executing a

KAFKA-8238

2019-04-26 Thread Sagar
Hi all, I would like to start contributing to the Kafka project. I looked at the newbie tickets and thought I could start with this:(?) https://issues.apache.org/jira/browse/KAFKA-8238 Or if there's anything else that I can look at, please let me know. Sagar.

Re: Add to JIRA

2018-08-06 Thread Piyush Sagar
er simple. > > kafka/core (brokers) > kafka/clients (consumer,producer,admin) > kafka/connect > kafka/streams > kafka/tools (command line tools like `bin/kafka-consumer-group.sh`) > kafka/tests (system test) > > > Hope this helps. > > > -Matthias > >

Add to JIRA

2018-08-06 Thread Piyush Sagar
Hello All, Can anyone please add me to JIRA ? Also, Is there any document(Confluence page) which briefs folder structure/ sub modules of the main kafka repository ? Thanks

Question Regarding seek() in KafkaConsumer

2018-01-03 Thread Sagar
this way? If I want to reliably retry then what patterns should be used? Couple of other approaches I read in Kafka definitive gide were to push the retriable records to a buffer or to a separate topic. So, are those the correct ways of retrying and not this? Thanks! Sagar.

Re: Kafka Consumer manual partition assignment

2018-01-02 Thread Sagar
Hi, Any help here would be highly appreciated :) Sagar. On Wed, 27 Dec 2017 at 07:53, Sagar <sagarmeansoc...@gmail.com> wrote: > We have a use case where in we want to assign partitions manually for a > set of topics to allow fine grained control of the records we are fetching. &

Re: Question Kafka Reassign partitions tool

2017-12-26 Thread Sagar
the first entry in that list, basically to keep the preferred replica logic intact. Thanks for the help. Thanks! Sagar. On Fri, Dec 22, 2017 at 10:08 PM, Todd Palino <tpal...@gmail.com> wrote: > Yes, the replicas are stored in Zookeeper, so you can iterate over the > information th

Kafka Consumer manual partition assignment

2017-12-26 Thread Sagar
ECS for running our consumers so target group would spin up a new consumer based upon health checks. Any examples + guidelines around this would be highly appreciated. Thanks! Sagar.

Re: Question Kafka Reassign partitions tool

2017-12-22 Thread Sagar
is stored in zookeeper? If yes, then can I probably use that get the current json and then build the json which can be fed to the tool. I tried to search using the zk shell but couldn't find... Sagar. On Fri, Dec 22, 2017 at 7:45 PM, Todd Palino <tpal...@gmail.com> wrote: > Preferre

Question Kafka Reassign partitions tool

2017-12-22 Thread Sagar
there a way I can still do this operation by getting leader for a partition first, then adding it to the replica list and then building the json dynamically? Thanks! Sagar.

[jira] [Created] (KAFKA-6233) Removed unnecessary null check

2017-11-18 Thread sagar sukhadev chavan (JIRA)
sagar sukhadev chavan created KAFKA-6233: Summary: Removed unnecessary null check Key: KAFKA-6233 URL: https://issues.apache.org/jira/browse/KAFKA-6233 Project: Kafka Issue Type: New

Fetching topic metadata issue

2017-09-04 Thread Sagar Nadagoud
Hi, Please help me in this issue i am unable to read the message from topic.

[jira] [Resolved] (KAFKA-5458) SASL handshake fails for METADATA requests

2017-06-29 Thread Sagar Lad (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Lad resolved KAFKA-5458. -- Resolution: Fixed actually there were multiple consumers created from code - each with different

[jira] [Created] (KAFKA-5458) SASL handshake fails for METADATA requests

2017-06-16 Thread Sagar Lad (JIRA)
Sagar Lad created KAFKA-5458: Summary: SASL handshake fails for METADATA requests Key: KAFKA-5458 URL: https://issues.apache.org/jira/browse/KAFKA-5458 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-4739) KafkaConsumer poll going into an infinite loop

2017-02-10 Thread Sagar Sadashiv Patwardhan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861745#comment-15861745 ] Sagar Sadashiv Patwardhan commented on KAFKA-4739: -- [~hachikuji] [~huxi_2b] Thanks

[jira] [Commented] (KAFKA-4739) KafkaConsumer poll going into an infinite loop

2017-02-06 Thread Sagar Sadashiv Patwardhan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854956#comment-15854956 ] Sagar Sadashiv Patwardhan commented on KAFKA-4739: -- [~hachikuji] I am with Vipul Singh

[jira] [Resolved] (KAFKA-4371) Sporadic ConnectException shuts down the whole connect process

2016-11-04 Thread Sagar Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-4371. -- Resolution: Not A Problem > Sporadic ConnectException shuts down the whole connect proc

[jira] [Commented] (KAFKA-4371) Sporadic ConnectException shuts down the whole connect process

2016-11-04 Thread Sagar Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636091#comment-15636091 ] Sagar Rao commented on KAFKA-4371: -- [~ewencp] By shutting down I meant that the processing of data

[jira] [Commented] (KAFKA-4371) Sporadic ConnectException shuts down the whole connect process

2016-11-03 Thread Sagar Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632717#comment-15632717 ] Sagar Rao commented on KAFKA-4371: -- Another thing to note is that we get this exception when I try

[jira] [Created] (KAFKA-4371) Sporadic ConnectException shuts down the whole connect process

2016-11-03 Thread Sagar Rao (JIRA)
Sagar Rao created KAFKA-4371: Summary: Sporadic ConnectException shuts down the whole connect process Key: KAFKA-4371 URL: https://issues.apache.org/jira/browse/KAFKA-4371 Project: Kafka Issue

[jira] [Created] (KAFKA-4342) Kafka-connect- support tinyint values

2016-10-25 Thread Sagar Rao (JIRA)
Sagar Rao created KAFKA-4342: Summary: Kafka-connect- support tinyint values Key: KAFKA-4342 URL: https://issues.apache.org/jira/browse/KAFKA-4342 Project: Kafka Issue Type: Bug

Need Help regarding Jenkins buil

2016-10-23 Thread Sagar
can I have this PR being reviewed by someone? Thanks! Sagar.