Re: [ANNOUNCE] New committer: Igor Soarez

2024-04-24 Thread Tom Bentley
Congratulations Igor! On Thu, 25 Apr 2024 at 6:27 AM, Chia-Ping Tsai wrote: > Congratulations, Igor! you are one of the best Kafka developers!!! > > Mickael Maison 於 2024年4月25日 週四 上午2:16寫道: > > > Congratulations Igor! > > > > On Wed, Apr 24, 2024 at 8:06 PM Colin McCabe wrote: > > > > > > Hi

Re: [DISCUSS] KIP-932: Queues for Kafka

2024-04-03 Thread Tom Bentley
Hi Andrew (and Omnia), Thanks for the KIP. I hope to provide some feedback on this KIP soon, but I had a thought on the specific subject of group configs and MM2. If brokers validate for known groups configs then doesn't this induce an ordering requirement on upgrading clusters: Wouldn't you have

Re: [ANNOUNCE] New committer: Christo Lolov

2024-03-28 Thread Tom Bentley
Congratulations! On Wed, 27 Mar 2024 at 21:10, Matthias J. Sax wrote: > Congrats! > > On 3/26/24 9:39 PM, Christo Lolov wrote: > > Thank you everyone! > > > > It wouldn't have been possible without quite a lot of reviews and > extremely > > helpful inputs from you and the rest of the community!

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

2024-02-08 Thread Tom Bentley
re Works' > > > > section, as Ismael proposed. > > > > > > > > Best, > > > > Dongjin > > > > > > > > > > > > > > > > On Fri, Jun 11, 2021 at 3:03 AM Konstantine Karantasis > > > > wrote: > > >

Re: [VOTE] KIP-877: Mechanism for plugins and connectors to register metrics

2024-01-24 Thread Tom Bentley
Hi Mickael, You'll have seen that I left some comments on the discussion thread, but they're minor enough that I'm happy to vote +1 here. Thanks, Tom On Thu, 11 Jan 2024 at 06:14, Mickael Maison wrote: > Bumping this thread since I've not seen any feedback. > > Thanks, > Mickael > > On Tue,

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2024-01-24 Thread Tom Bentley
Hi Mickael, Thanks for the KIP! I can tell a lot of thought went into this. I have a few comments, but they're all pretty trivial and aimed at making the correct use of this API clearer to implementors. 1. Configurable and Reconfigurable both use a verb in the imperative mood for their method

Re: [ANNOUNCE] New Kafka PMC Member: Divij Vaidya

2023-12-27 Thread Tom Bentley
Congratulations! On Thu, 28 Dec 2023 at 06:17, Philip Nee wrote: > congrats divij! > > On Wed, Dec 27, 2023 at 8:55 AM Justine Olshan > > wrote: > > > Congratulations Divij! > > > > On Wed, Dec 27, 2023 at 4:20 AM Gaurav Narula wrote: > > > > > Congratulations Divij! > > > > > > Regards, > >

Re: [VOTE] 3.5.2 RC1

2023-12-07 Thread Tom Bentley
Hi, I have validated signatures, checked the Java docs, built from source and run tests. I had a few unit test failures, but I note that others saw them pass and the CI was green too, so I think this is a problem with my system rather than the release. +1 (binding). Thanks! On Wed, 6 Dec 2023

Re: [ANNOUNCE] New Kafka PMC Member: Satish Duggana

2023-10-29 Thread Tom Bentley
Congratulations! On Sun, 29 Oct 2023 at 5:41 PM, Guozhang Wang wrote: > Congratulations Satish! > > On Sat, Oct 28, 2023 at 12:59 AM Luke Chen wrote: > > > > Congrats Satish! > > > > Luke > > > > On Sat, Oct 28, 2023 at 11:16 AM ziming deng > > wrote: > > > > > Congratulations Satish! > > > >

Re: [DISCUSS] KIP-987: Connect Static Assignments

2023-10-10 Thread Tom Bentley
Hi Greg, Many thanks for the KIP. Here are a few initial questions 1. Incomplete sentence: "But Connect is not situated to be able to manage resources directly, as workers are given a fixed " 2. You explain how sessioned is now a subset of static, but what happens in a cluster where some workers

Re: [DISCUSS] KIP-986: Cross-Cluster Replication

2023-10-02 Thread Tom Bentley
Hi Greg, Thanks for this KIP! It is obviously very ambitious, but it's great to have a conversation about it. I'll start with some general points: Do you have a plan in mind for how to proceed with elaborating this KIP? While I like how you're involving the community in elaborating the KIP, I

Re: [ANNOUNCE] New Kafka PMC Member: Justine Olshan

2023-09-23 Thread Tom Bentley
Congratulations! On Sun, 24 Sept 2023 at 12:32, Satish Duggana wrote: > Congratulations Justine!! > > On Sat, 23 Sept 2023 at 15:46, Bill Bejeck wrote: > > > > Congrats Justine! > > > > -Bill > > > > On Sat, Sep 23, 2023 at 6:23 PM Greg Harris > > > wrote: > > > > > Congratulations Justine! >

Re: [ANNOUNCE] New committer: Yash Mayya

2023-09-21 Thread Tom Bentley
Congratulations! On Fri, 22 Sept 2023 at 09:11, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Congratulations, Yash! > > On Thu 21. Sep 2023 at 21.57, Randall Hauch wrote: > > > Congratulations, Yash! > > > > On Thu, Sep 21, 2023 at 12:31 PM Satish Duggana < >

Re: [ANNOUNCE] New committer: Lucas Brutschy

2023-09-21 Thread Tom Bentley
Congratulations! On Fri, 22 Sept 2023 at 09:11, Sophie Blee-Goldman wrote: > Congrats Lucas! >

Re: [DISCUSS] KIP-714: Client metrics and observability

2023-08-11 Thread Tom Bentley
Hi Andrew, Thanks for picking this KIP up. I know you've started a vote, so these are unhelpfully late... sorry about that, but hopefully they're still useful. 1. "The Kafka Java client provides an API for the application to read the generated client instance id to assist in mapping and

Re: [ANNOUNCE] New committer: Greg Harris

2023-07-10 Thread Tom Bentley
Congratulations! On Mon, 10 Jul 2023 at 17:32, wrote: > Congrats Greg! > > - > Gaurav > > > On 10 Jul 2023, at 17:25, Hector Geraldino (BLOOMBERG/ 919 3RD A) < > hgerald...@bloomberg.net> wrote: > > > > Congrats Greg! Well deserved > > > > From: dev@kafka.apache.org At: 07/10/23 12:18:48

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-07-04 Thread Tom Bentley
Hi Colin, Thanks for the KIP. 1. It mentions kafka-configs.sh as one of the affected tools, but doesn't mention that ControllerApis doesn't currently support DESCRIBE_CONFIGS. I think this is worth noting as it is, in effect, a change to the wire protocol accepted by the controller, even if it's

Re: [DISCUSS] Apache Kafka 3.5.1 release

2023-06-29 Thread Tom Bentley
SGTM, thanks Divij On Thu, 29 Jun 2023 at 03:16, Luke Chen wrote: > Hi Divij, > > Thanks for volunteering! > > Luke > > On Wed, Jun 28, 2023 at 11:54 PM Manyanda Chitimbo < > manyanda.chiti...@gmail.com> wrote: > > > Thank you Divij for volunteering to perform the release. > > > > On Wed 28 Jun

Re: [DISCUSS] KIP-940: Broker extension point for validating record contents at produce time

2023-06-22 Thread Tom Bentley
Hi Edorado and Adrian, Thanks for the KIP. I think it would be good to elaborate on exactly how validate() gets called, because I think there are a number of potential problems, or at least things to consider. >From the broker's point of view, validate() can do arbitrary things. It might never

Re: [ANNOUNCE] Apache Kafka 3.5.0

2023-06-15 Thread Tom Bentley
Thanks Mickael for the release, and thanks too to all our contributors. On Thu, 15 Jun 2023 at 16:22, Chia-Ping Tsai wrote: > This is a great release. Mickael!!! > > > Chris Egerton 於 2023年6月15日 下午11:09 寫道: > > > > Mickael > >

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Tom Bentley
Congratulations Divij! On Tue, 13 Jun 2023 at 17:21, Mickael Maison wrote: > Congratulations! > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > > > Congratulations Divij! > > > > On Tue, Jun 13, 2023 at 9:20 PM Bruno Cadonna > wrote: > > > > > Hi all, > > > > > > The PMC of Apache

Re: [ANNOUNCE] Apache Kafka 3.4.1

2023-06-07 Thread Tom Bentley
Thanks Luke! On Wed, 7 Jun 2023 at 09:11, Mickael Maison wrote: > Thanks for running the release! > > On Wed, Jun 7, 2023 at 9:11 AM Bruno Cadonna wrote: > > > > Thanks Luke! > > > > On 07.06.23 07:55, Federico Valeri wrote: > > > Thanks Luke! > > > > > > On Wed, Jun 7, 2023 at 5:56 AM Kamal

[jira] [Created] (KAFKA-15050) Prompts in the quickstarts

2023-06-02 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-15050: --- Summary: Prompts in the quickstarts Key: KAFKA-15050 URL: https://issues.apache.org/jira/browse/KAFKA-15050 Project: Kafka Issue Type: Improvement

Re: [VOTE] 3.4.1 RC3

2023-06-02 Thread Tom Bentley
Hi Luke, Thanks for running the release. I've checked signatures, eyeballed the Javadocs, built from source and run the unit and integration tests. DynamicBrokerReconfigurationTest.testAdvertisedListenerUpdate fails for me repeatedly. I opened https://issues.apache.org/jira/browse/KAFKA-15049

[jira] [Created] (KAFKA-15049) Flaky test DynamicBrokerReconfigurationTest#testAdvertisedListenerUpdate

2023-06-02 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-15049: --- Summary: Flaky test DynamicBrokerReconfigurationTest#testAdvertisedListenerUpdate Key: KAFKA-15049 URL: https://issues.apache.org/jira/browse/KAFKA-15049 Project

Re: [ANNOUNCE] New PMC chair: Mickael Maison

2023-04-24 Thread Tom Bentley
Congratulations Mickael and thanks again Jun. On Mon, 24 Apr 2023 at 19:31, Roman Schmitz wrote: > Congratulations Mickael! > > > Am Mo., 24. Apr. 2023 um 19:26 Uhr schrieb José Armando García Sancio > : > > > Congratulations Mickael and thank you Jun for performing this role for > > the past

Re: [VOTE] KIP-906 Tools migration guidelines

2023-04-04 Thread Tom Bentley
Hi Federico, Thanks for the KIP, +1 (binding). Tom On Tue, 4 Apr 2023 at 08:30, Federico Valeri wrote: > Hi, we have 2 binding an 1 non binding votes. Thanks for tacking the > time to review the KIP. Can I get one more binding vote? > > Cheers > Fede > > On Fri, Mar 24, 2023 at 3:05 PM John

Re: [VOTE] KIP-581: Value of optional null field which has default value

2023-03-17 Thread Tom Bentley
+1 (binding), thanks again Mickael. On Fri, 17 Mar 2023 at 14:56, Chris Egerton wrote: > +1 (binding), thanks Mickael! > > On Fri, Mar 17, 2023, 10:11 Mickael Maison > wrote: > > > Hi all, > > > > I'd like to start a vote on KIP-581 to allow keeping null values > > instead of always replacing

Re: [VOTE] KIP-911: Add source tag to MirrorSourceConnector metrics

2023-03-16 Thread Tom Bentley
+1 (binding). Thanks Mickael! On Thu, 16 Mar 2023 at 12:55, Chris Egerton wrote: > +1 (binding). Thanks for the KIP! > > On Wed, Mar 15, 2023 at 7:08 AM Mickael Maison > wrote: > > > Hi, > > > > I'd like to start the vote on KIP-911 to add the source cluster alias > > as a tag on the

Re: [Discuss] KIP-581: Value of optional null field which has default value

2023-03-16 Thread Tom Bentley
Hi Mickael, Thanks to Cheng for the KIP and to you for picking it up. My only comment (feel free to ignore) is about the names of the configs. Personally I don't think I'd correctly guess what "serialize.use.optional.null" meant. Something like "serialize.map.null.to.default" is much clearer to

Re: [ANNOUNCE] New Kafka PMC Member: David Arthur

2023-03-10 Thread Tom Bentley
Congratulations! On Fri, 10 Mar 2023 at 03:36, John Roesler wrote: > Congratulations, David! > -John > > On Thu, Mar 9, 2023, at 20:18, ziming deng wrote: > > Congrats David! > > > > Ziming > > > >> On Mar 10, 2023, at 10:02, Luke Chen wrote: > >> > >> Congratulations, David! > >> > >> On Fri,

Re: [ANNOUNCE] New Kafka PMC Member: Chris Egerton

2023-03-10 Thread Tom Bentley
Congratulations! On Fri, 10 Mar 2023 at 03:35, John Roesler wrote: > Congratulations, Chris! > -John > > On Thu, Mar 9, 2023, at 20:02, Luke Chen wrote: > > Congratulations, Chris! > > > > On Fri, Mar 10, 2023 at 9:57 AM Yash Mayya wrote: > > > >> Congratulations Chris! > >> > >> On Thu, Mar

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-03-01 Thread Tom Bentley
Hi Chris, Thanks for the KIP. +1 (binding). Cheers, Tom On Wed, 15 Feb 2023 at 16:11, Chris Egerton wrote: > Hi all, > > Thanks to everyone who's voted so far! Just wanted to bump this thread and > see if we could get a few more votes; currently we're at +3 non-binding > and +1 binding.

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Tom Bentley
Hi Chia-Ping, To be honest the stateful version, setting an input stream once using the `readFrom(InputStream)` method and then repeatedly asking for the next record using a parameterless `readRecord()`, seems a bit more natural to me than `readRecord(InputStream inputStream)` being called

Re: [ANNOUNCE] New committer: Lucas Bradstreet

2023-02-16 Thread Tom Bentley
Congratulations! On Fri, 17 Feb 2023 at 05:26, Yash Mayya wrote: > Congratulations Lucas! > > On Fri, Feb 17, 2023 at 3:25 AM Jun Rao wrote: > > > Hi, Everyone, > > > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Lucas > > Bradstreet. > > > > Lucas has been a long

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-16 Thread Tom Bentley
Hi Chia-Ping, Thanks for the KIP. I have just a few minor comments: 1. The Javadoc for the new interface says "an `InputStream` received via `init`" but the interface doesn't have an init() method. I guess you meant configure()? 2. The Javadoc should mention the need for implementations to have

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-02-16 Thread Tom Bentley
Hi Greg, Thanks for the KIP. Overall I think using service loading would be a worthwhile improvement. 1. "Both of these are well-established Java interfaces for which public documentation should be readily available." I see no harm in adding a well chosen link or two just to save readers

Re: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2023-01-23 Thread Tom Bentley
Hi Igor, Thanks for your replies on points 21-25. Those all LGTM. See below for a further thought on the meta.properties upgrade. Kind regards, Tom On Fri, 13 Jan 2023 at 18:09, Igor Soarez wrote: > Hi Tom, > > Thank you for having another look. > > 20. Upon a downgrade to a Kafka version

Re: [ANNOUNCE] New committer: Walker Carlson

2023-01-17 Thread Tom Bentley
Congratulations! On Wed, 18 Jan 2023 at 01:26, John Roesler wrote: > Congratulations, Walker! > -John > > On Tue, Jan 17, 2023, at 18:50, Guozhang Wang wrote: > > Congrats, Walker! > > > > On Tue, Jan 17, 2023 at 2:20 PM Chris Egerton > > wrote: > > > >> Congrats, Walker! > >> > >> On Tue, Jan

Re: [ANNOUNCE] New committer: Stanislav Kozlovski

2023-01-17 Thread Tom Bentley
Congratulations! On Tue, 17 Jan 2023 at 16:52, Bill Bejeck wrote: > Congratulations Stan! > > -Bill > > On Tue, Jan 17, 2023 at 11:37 AM Bruno Cadonna wrote: > > > Congrats Stan! > > > > Well deserved! > > > > Best, > > Bruno > > > > On 17.01.23 16:50, Jun Rao wrote: > > > Hi, Everyone, > > >

[jira] [Resolved] (KAFKA-14566) Please Close This Ticket As It Was Inadvertently Created. See KAFKA-14565 For The Correct Ticket.

2023-01-11 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley resolved KAFKA-14566. - Resolution: Invalid > Please Close This Ticket As It Was Inadvertently Created. See KA

Re: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2023-01-10 Thread Tom Bentley
Hi Igor, 20. The description of the changes to meta.properties says "If there any meta.properties file is missing directory.id a new UUID is generated, and assigned to that log directory by updating the file", and the upgrade/migration section says "As the upgraded brokers come up, the existing

Re: [VOTE] 3.3.2 RC1

2023-01-09 Thread Tom Bentley
+1 binding. I have checked signatures, given the javadocs a quick look, followed the quickstart for KRaft and run the tests. Thanks Chris for running the release. Tom On Mon, 9 Jan 2023 at 15:29, Chris Egerton wrote: > Hi all, > > Thanks to everyone who has tested and voted for the release

Re: [ANNOUNCE] New committer: Edoardo Comar

2023-01-09 Thread Tom Bentley
Congratulations! On Sun, 8 Jan 2023 at 01:14, Satish Duggana wrote: > Congratulations, Edorado! > > On Sun, 8 Jan 2023 at 00:15, Viktor Somogyi-Vass > wrote: > > > > Congrats Edoardo! > > > > On Sat, Jan 7, 2023, 18:15 Bill Bejeck wrote: > > > > > Congratulations, Edoardo! > > > > > > -Bill >

Re: [ANNOUNCE] New committer: Justine Olshan

2023-01-03 Thread Tom Bentley
Congratulations! On Mon, 2 Jan 2023 at 18:25, Rajini Sivaram wrote: > Congratulations, Justine, well deserved! > > Regards, > > Rajini > > On Mon, Jan 2, 2023 at 5:29 PM Ismael Juma wrote: > > > Congratulations Justine! > > > > Ismael > > > > On Thu, Dec 29, 2022, 12:58 PM David Jacot wrote:

Re: [ANNOUNCE] New committer: Satish Duggana

2022-12-24 Thread Tom Bentley
Congratulations! On Sat, 24 Dec 2022 at 05:05, Luke Chen wrote: > Congratulations, Satish! > > On Sat, Dec 24, 2022 at 4:12 AM Federico Valeri > wrote: > > > Hi Satish, congrats! > > > > On Fri, Dec 23, 2022, 8:46 PM Viktor Somogyi-Vass > > wrote: > > > > > Congrats Satish! > > > > > > On

Re: [ANNOUNCE] New committer: Josep Prat

2022-12-21 Thread Tom Bentley
Congratulations! On Wed, 21 Dec 2022 at 03:05, John Roesler wrote: > Congratulations, Josep! > -John > > On Tue, Dec 20, 2022, at 20:02, Luke Chen wrote: > > Congratulations, Josep! > > > > Luke > > > > On Wed, Dec 21, 2022 at 6:26 AM Viktor Somogyi-Vass > > wrote: > > > >> Congrats Josep! >

Re: [ANNOUNCE] New Kafka PMC Member: Luke Chen

2022-12-16 Thread Tom Bentley
Congratulations! On Fri, 16 Dec 2022 at 20:40, Viktor Somogyi-Vass wrote: > Congrats Luke! :) > > On Fri, Dec 16, 2022, 21:26 Randall Hauch wrote: > > > Congratulations, Luke! > > > > On Fri, Dec 16, 2022 at 2:08 PM Josep Prat > > wrote: > > > > > Congrats Luke! > > > > > > On Fri, Dec 16,

Re: [ANNOUNCE] New committer: Ron Dagostino

2022-12-15 Thread Tom Bentley
Congratulations! On Thu, 15 Dec 2022 at 07:40, Satish Duggana wrote: > Congratulations, Ron!! > > On Thu, 15 Dec 2022 at 07:48, ziming deng > wrote: > > > Congratulations, Ron! > > Well deserved! > > > > -- > > Ziming > > > > > On Dec 15, 2022, at 09:16, Luke Chen wrote: > > > > > >

Re: [DISCUSS] KIP-888: Batch describe ACLs and describe client quotas

2022-12-02 Thread Tom Bentley
Hi Mickael, Thanks for the KIP. I can understand the motivation, but to be honest I have a doubt about this. Taking the ACLs first, by allowing multiple filters with the current proposal isn't there the chance that the same ACL will match multiple filters, and be returned multiple times in the

Re: Request the account for Kafka Jira

2022-11-15 Thread Tom Bentley
Hi Simon, Usernames have to be all lower case ascii letters and digits, so I used simonzhang. You should have a password reset email where you can complete the account creation. Thanks for your interest in Apache Kafka. On Tue, 15 Nov 2022 at 15:25, zsy112371 wrote: > Hi team, > I would like

Re: [ANNOUNCE] New Kafka PMC Member: Bruno Cadonna

2022-11-02 Thread Tom Bentley
Congratulations! On Wed, 2 Nov 2022 at 06:40, David Jacot wrote: > Congrats, Bruno! Well deserved. > > Le mer. 2 nov. 2022 à 06:12, Randall Hauch a écrit : > > > Congratulations, Bruno! > > > > On Tue, Nov 1, 2022 at 11:20 PM Sagar wrote: > > > > > Congrats Bruno! > > > > > > Sagar. > > > > >

Re: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2022-11-01 Thread Tom Bentley
Hi Igor, Thanks for the KIP, I've finally managed to take an initial look. 0. You mention the command line tools (which one?) in the public interfaces section, but don't spell out how it changes -- what options are added. Reading the proposed changes it suggests that there are no changes to the

Re: [ANNOUNCE] New committer: Deng Ziming

2022-10-10 Thread Tom Bentley
Congratulations! On Mon, 10 Oct 2022 at 18:24, John Roesler wrote: > Congratulations, Ziming! > > On Mon, Oct 10, 2022, at 12:05, Justine Olshan wrote: > > Congratulations Ziming! I'll always remember the help you provided with > > topic IDs. > > Very well deserved! > > > > On Mon, Oct 10, 2022

Re: PR for CVE-2022-34917

2022-09-26 Thread Tom Bentley
Hi Swathi, In this case the PR reviews happened on a private repo because the CVE wasn't public at that time. On the 3.3 branches you can look at/cherry-pick commits 015d7aede6cbd350d56d75006930dd2bf89a4a5a and b2b928338c7226b41a73786df27a2127eaa32ab2. Kind regards, Tom On Mon, 26 Sept 2022

Re: [DISCUSS]: Including TLA+ in the repo

2022-08-11 Thread Tom Bentley
t; > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > m: +491603708037 > > > w: aiven.io e: matthew.dedetr...@aiven.io > > > On 26. Jul 2022, 16:58 +0200, Tom Bentley , > wrot

Re: [VOTE] KIP-854 Separate configuration for producer ID expiry

2022-08-09 Thread Tom Bentley
Hi Justine, Thanks again for the KIP, +1 (binding). On Tue, 9 Aug 2022 at 18:09, Jason Gustafson wrote: > Thanks Justine, +1 from me. > > On Tue, Aug 9, 2022 at 1:12 AM Sagar wrote: > > > Thanks for the KIP. > > > > +1(non-binding) > > > > Sagar. > > > > On Tue, Aug 9, 2022 at 1:13 PM David

Re: [DISCUSS] KIP-854 Separate configuration for producer ID expiry

2022-08-03 Thread Tom Bentley
its own and additional > > improvements can be handled via future KIPs (unless Justine wants to > > combine things, of course). > > > > Ismael > > > > On Wed, Aug 3, 2022 at 9:12 AM Tom Bentley wrote: > > > > > Hi Justine, > > > >

Re: [DISCUSS] KIP-854 Separate configuration for producer ID expiry

2022-08-03 Thread Tom Bentley
Hi Justine, Thanks for the KIP! I can see that this is a pragmatic attempt to address a nasty problem. I have a few questions: 1. The KIP makes the problem significantly harder to trigger, but doesn't eliminate it entirely. How confident are you that it will be sufficient in practice? We can

Re: [ANNOUNCE] New Kafka PMC Member: A. Sophie Blee-Goldman

2022-08-02 Thread Tom Bentley
Congratulations Sophie! On Tue, 2 Aug 2022 at 11:54, Robin Moffatt wrote: > Congrats Sophie, great news! > > > -- > > Robin Moffatt | Principal Developer Advocate | ro...@confluent.io | @rmoff > > > On Tue, 2 Aug 2022 at 00:42, Guozhang Wang wrote: > > > Hi everyone, > > > > I'd like to

Re: [DISCUSS]: Including TLA+ in the repo

2022-07-28 Thread Tom Bentley
ing to suggest the > same > > > in the KIP-853 discussion. The original authors of 3 and 4 are part of > > the > > > kafka community, so we can ask them to submit PRs. > > > > > > Ismael > > > > > > On Tue, Jul 26, 2022 at 7:58 AM Tom

[DISCUSS]: Including TLA+ in the repo

2022-07-26 Thread Tom Bentley
Hi, I noticed that TLA+ has featured in the Test Plans of a couple of recent KIPs [1,2]. This is a good thing in my opinion. I'm aware that TLA+ has been used in the past to prove properties of various parts of the Kafka protocol [3,4]. The point I wanted to raise is that I think it would be

Re: [ANNOUNCE] New Committer: Chris Egerton

2022-07-25 Thread Tom Bentley
Congratulations Chris! On Mon, 25 Jul 2022 at 18:40, Jeremy Custenborder wrote: > Congrats Chris! > > On Mon, Jul 25, 2022 at 12:07 PM Sagar wrote: > > > > Congratulations Chris ! > > > > On Mon, 25 Jul 2022 at 10:32 PM, Viktor Somogyi-Vass > > wrote: > > > > > Congrats Chris! > > > > > > On

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-22 Thread Tom Bentley
Hi José, Thanks for the KIP. As Justine mentioned, this KIP currently lacks a motivation, and nor does the JIRA provide any context. Please could you provide this context, otherwise it's impossible for people on this list to understand the problem you're trying to solve here. Many thanks, Tom

Re: [Vote] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-28 Thread Tom Bentley
Hi again Omnia, I left a couple of really minor points in the discussion thread. Assuming you're happy with those I am +1 (binding). Thanks for your patience on this. Kind regards, Tom On Tue, 28 Jun 2022 at 10:14, Omnia Ibrahim wrote: > Hi, > I did a small change to the KIP interface to

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-28 Thread Tom Bentley
gt; My initial thought was that the constructor with config and delegator > would be for testing while the one with config is the one that will be used > by MM2. > I can removed one of them and keep only one. > > Sent from my iPhone > > > On 22 Jun 2022, at 08:15, Tom Ben

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-22 Thread Tom Bentley
rs will need to define 2 implementations, one for source and another for > target and configure each using .forwarding.admin.class. for > example > - target.forwarding.admin.class = TargetAdmin > - source.forwarding.admin.class = SourceAdmin > > On Tue, Jun 21, 2022 at 2:14 PM Tom

Re: [DISCUSS] KIP-787 - MM2 Interface to manage Kafka resources

2022-06-21 Thread Tom Bentley
Hi Omnia, Thanks for the KIP! I'm sorry for the delay in this response. I have a few questions: 1. I assume there's an undocumented requirement in the KIP that whatever class is named for forwarding.admin.class it has a public single argument constructor that takes an Admin instance? 2. If 1 is

Re: Log4j 1.2 update timeline?

2022-06-03 Thread Tom Bentley
Hi Michael, KIP-653 seeks to update the log4jv1 dependency to log4jv2. Following a discussion a month or so ago [1] I think the plan is to do this in Kafka 4.0. The discussion for KIP-833 [2] suggests we'll see Kafka 3.5 followed by Kafka 4.0, which should be around August 2023 (assuming we stick

Re: [VOTE] KIP-830: Allow disabling JMX Reporter

2022-05-25 Thread Tom Bentley
Hi Mickael, Thanks for the KIP. +1 (binding). Kind regards, Tom On Thu, 19 May 2022 at 13:14, Mickael Maison wrote: > Hi Ismael, > > That's a good idea, I've updated the KIP. > > Thanks, > Mickael > > On Tue, May 17, 2022 at 4:17 PM Federico Valeri > wrote: > > > > +1 (non binding) > > > >

Re: [VOTE] KIP-831: Add metric for log recovery progress

2022-05-25 Thread Tom Bentley
Hi Luke, Thanks for the KIP. +1 (binding). Kind regards, Tom On Fri, 20 May 2022 at 02:58, Raman Verma wrote: > ^^ (non binding) > > On Thu, May 19, 2022 at 5:40 PM Raman Verma wrote: > > > > Hello Luke, > > > > The proposal looks good to me. Thanks. +1 > > > > > > On Tue, May 17, 2022 at

Re: [VOTE] KIP-827: Expose logdirs total and usable space via Kafka API

2022-05-25 Thread Tom Bentley
Hi Mickael, Thanks for the KIP! +1 (binding). Kind regards, Tom On Thu, 19 May 2022 at 11:28, Federico Valeri wrote: > Thanks Mickael. > > +1 (non binding) > > On Wed, May 18, 2022 at 11:08 AM Divij Vaidya > wrote: > > > > +1 non binding. > > > > Divij Vaidya > > > > > > > > On Tue, May 17,

Re: [DISCUSS] KIP-831: Add metric for log recovery progress

2022-05-25 Thread Tom Bentley
> Please update the links to JIRA and the discussion thread. > > > > Best Regards, > > Raman Verma > > > > On Thu, May 19, 2022 at 8:57 AM Tom Bentley wrote: > > > > > > Hi Luke, > > > > > > Thanks for the KIP. I think the

Re: [DISCUSS] KIP-831: Add metric for log recovery progress

2022-05-19 Thread Tom Bentley
Hi Luke, Thanks for the KIP. I think the idea makes sense and would provide useful observability of log recovery. I have a few comments. 1. There's not a JIRA for this KIP (or the JIRA link needs updating). 2. Similarly the link to this discussion thread needs updating. 3. I wonder whether we

[jira] [Created] (KAFKA-13898) metrics.recording.level is underdocumented

2022-05-13 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13898: --- Summary: metrics.recording.level is underdocumented Key: KAFKA-13898 URL: https://issues.apache.org/jira/browse/KAFKA-13898 Project: Kafka Issue Type

[jira] [Created] (KAFKA-13897) Add 3.1.1 to system tests and streams upgrade tests

2022-05-13 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13897: --- Summary: Add 3.1.1 to system tests and streams upgrade tests Key: KAFKA-13897 URL: https://issues.apache.org/jira/browse/KAFKA-13897 Project: Kafka Issue Type

[ANNOUNCE] Apache Kafka 3.1.1

2022-05-13 Thread Tom Bentley
, Mike Lothian, Philip Nee, prince-mahajan, Randall Hauch, Stanislav Vodetskyi, sunshujie1990, Tom Bentley, Vincent Jiang, Xiaobing Fang, Xiaoyue Xue, Yang Yu We welcome your help and feedback. For more information on how to report problems, and to get involved, visit the project website at https

[jira] [Created] (KAFKA-13895) Fix javadocs build with JDK < 12

2022-05-12 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13895: --- Summary: Fix javadocs build with JDK < 12 Key: KAFKA-13895 URL: https://issues.apache.org/jira/browse/KAFKA-13895 Project: Kafka Issue Type: T

[RESULTS] [VOTE] Release Kafka version 3.1.1

2022-05-12 Thread Tom Bentley
This vote passes with 7 +1 votes (3 bindings) and no 0 or -1 votes. +1 votes PMC Members: * Mickael Maison * Bill Bejeck * David Jacot Committers: * Luke Chen * Dongjoon Hyun Community: * Jakub Scholz * Michal Tóth 0 votes * No votes -1 votes * No votes Vote thread:

Re: [VOTE] 3.1.1 RC1

2022-05-12 Thread Tom Bentley
ting out another 3.1 release we should > > probably disable that test on 3.1 as well. > > > > On Wed, May 11, 2022 at 3:32 AM Tom Bentley wrote: > > > > > Hi Dongjoon, > > > > > > I've been trying to get a green build of the 3.1 branch from Jen

Re: [VOTE] 3.1.1 RC1

2022-05-11 Thread Tom Bentley
ed the Scala 2.13 binaries and staged > Maven > > > > > > artifacts > > > > > > > and ran various tests with them. Thanks for doing the release. > > > > > > > > > > > > > > Jakub > >

[jira] [Created] (KAFKA-13882) Dockerfile for previewing website

2022-05-06 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13882: --- Summary: Dockerfile for previewing website Key: KAFKA-13882 URL: https://issues.apache.org/jira/browse/KAFKA-13882 Project: Kafka Issue Type: Task

[jira] [Created] (KAFKA-13881) Add package.java for public package javadoc

2022-05-06 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13881: --- Summary: Add package.java for public package javadoc Key: KAFKA-13881 URL: https://issues.apache.org/jira/browse/KAFKA-13881 Project: Kafka Issue Type: Task

[VOTE] 3.1.1 RC1

2022-04-29 Thread Tom Bentley
Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 3.1.1. Apache Kafka 3.1.1 is a bugfix release and 30 issues have been fixed since 3.1.0. Release notes for the 3.1.1 release:

Re: [VOTE] 3.1.1 RC0

2022-04-28 Thread Tom Bentley
t; > > > > > Hi Tom, > > > > > > > > > > Thanks for running the release. I wonder if we should include: > > > > > > > > > > > > > > > > > https://github.com/apache/kafka/commit/134c432d

Re: [VOTE] KIP-797: Accept duplicate listener on port for IPv4/IPv6

2022-04-22 Thread Tom Bentley
Hi Matthew, Thanks for the KIP, +1 (binding). Kind regards, Tom On Thu, 14 Apr 2022 at 12:15, Matthew de Detrich wrote: > Hi David, > > Thanks for the response. > > > 1. In the public interface section, could we spell out > the configurations that we are changing with this > KIP? The name

Re: [DISCUSS] KIP-821: Connect Transforms support for nested structures

2022-04-22 Thread Tom Bentley
Hi Jorge, Thanks for the KIP, especially for the examples which are super-clear. 100. The name `field.style` isn't so clear for something like ReplaceField: it's not so obvious that field.style applies to `include` and `exclude`. 101. The permitted values for `field.style` don't seem terribly

Re: [DISCUSS] KIP-827: Expose logdirs total and usable space via Kafka API

2022-04-22 Thread Tom Bentley
Hi Mickael, Thanks for the KIP, I can see this would be useful. I guess you could have used optional tagged fields, rather than bumping the version, but then again I don't see it being particularly advantageous in this case either. Kind regards, Tom On Tue, 19 Apr 2022 at 10:23, Divij Vaidya

[VOTE] 3.1.1 RC0

2022-04-08 Thread Tom Bentley
Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 3.1.1. Apache Kafka 3.1.1 is a bugfix release and 29 issues have been fixed since 3.1.0. Release notes for the 3.1.1 release:

Re: [DISCUSS] Apache Kafka 3.1.1

2022-03-30 Thread Tom Bentley
Hi Ismael, I hope to have an RC0 by Friday. Cheers, Tom On Tue, 29 Mar 2022 at 23:20, Ismael Juma wrote: > Hi Tom, > > When do you expect to publish the first RC? > > Ismael > > On Thu, Mar 10, 2022 at 1:27 AM Tom Bentley wrote: > > > I think I was suppos

Re: Subscribe to Kafka dev mailing list

2022-03-29 Thread Tom Bentley
Hi, To subscribe you need to send email to dev-subscr...@kafka.apache.org, not dev@ Full instructions: https://kafka.apache.org/contact Kind regards, Tom On Tue, 29 Mar 2022 at 01:29, 那一叶零落 <1664637...@qq.com.invalid> wrote: > Subscribe to Kafka dev mailing list

Re: [DISCUSS] Apache Kafka 3.1.1

2022-03-10 Thread Tom Bentley
Wed, Mar 9, 2022 at 12:00 PM Ismael Juma wrote: > >> > >>> Thanks Tom. +1 > >>> > >>> Ismael > >>> > >>> > >>> On Wed, Mar 9, 2022 at 8:10 AM Tom Bentley > wrote: > >>> > >>>> Hi, > >>>> > >>>> I'd like to volunteer to be the release manager for the 3.1.1 bugfix > >>>> release. > >>>> > >>>> Kind regards, > >>>> > >>>> Tom > >>>> > >>> > >> > > > >

[DISCUSS] Apache Kafka 3.1.1

2022-03-09 Thread Tom Bentley
Hi, I'd like to volunteer to be the release manager for the 3.1.1 bugfix release. Kind regards, Tom

Re: [VOTE] 3.0.1 RC0

2022-03-09 Thread Tom Bentley
Hi Mickael, In addition to the results others have posted I've also validated the checksums and keys, built from source and executed the unit and integration tests. Overall I'm +1 (binding). Thanks, Tom On Wed, 9 Mar 2022 at 07:55, Michal Tóth wrote: > Hello, > > executed

Re: [DISCUSS] KIP-714: Client metrics and observability

2022-03-08 Thread Tom Bentley
t; data is being sent? > > > > 5. If all metrics are enabled on a regular Consumer or Producer, do > > you have an idea how much throughput this would use? > > > > Thanks > > > > On Tue, Oct 19, 2021 at 5:06 PM Magnus Edenhill > > wrote: > > > > &

Re: [ANNOUNCE] New committer: Luke Chen

2022-02-09 Thread Tom Bentley
Congratulations Luke! On Thu, 10 Feb 2022 at 06:41, Josep Prat wrote: > Congrats Luke! > > ——— > Josep Prat > > Aiven Deutschland GmbH > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > m:

Re: [DISCUSS] Apache Kafka 3.2.0 release

2022-02-07 Thread Tom Bentley
+1, thanks Bruno! On Sat, 5 Feb 2022 at 07:17, Luke Chen wrote: > Thanks Bruno! > > +1 > > Luke > > On Sat, Feb 5, 2022 at 10:50 AM Guozhang Wang wrote: > > > Thanks Bruno! +1 > > > > On Fri, Feb 4, 2022 at 4:14 PM Ismael Juma wrote: > > > > > Thanks for volunteering, Bruno. +1! > > > > > >

Re: [VOTE] KIP-769: Connect APIs to list all connector plugins and retrieve their configuration definitions

2022-01-31 Thread Tom Bentley
Hi Mickael, +1 (binding), thanks! Tom On Wed, 26 Jan 2022 at 09:42, Viktor Somogyi-Vass wrote: > Hi Michael, > > +1 (non-binding) from me. > > Viktor > > On Thu, Jan 13, 2022 at 11:32 AM Mickael Maison > wrote: > > > Bumping this vote. > > > > We have 2 non-binding votes so far. Please take

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2022-01-28 Thread Tom Bentley
Hi Luke, Thanks for the KIP, +1 (binding). Kind regards, Tom On Wed, 19 Jan 2022 at 13:16, Luke Chen wrote: > Hi all, > > Bump this thread to see if there are other comments to this KIP. > So far, I have one +1 vote (binding), and need more votes. > > Thank you. > Luke > > On Tue, Dec 21,

Re: KIP-769: Connect API to retrieve connector configuration definitions

2022-01-27 Thread Tom Bentley
To be honest I'm very sceptical that you can evolve (without breaking compatibility) from a situation of having a large number of plugins which have already implemented version() to return whatever they please, to a situation where you can rely on it as the basis for some feature to support

  1   2   3   4   5   6   >