[GitHub] kafka-site issue #113: HOTFIX: broken /10 docs

2017-12-20 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/113 👍 👍 LGTM ---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

2017-12-20 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/112 👍 💯 LGTM ---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

2017-12-15 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/112 @joel-hamill just took a look at your branch. Content looks good, but I'd suggest adding that horizontal subnav on the developer guide page for consistency and make sure users can easily jump

[GitHub] kafka-site pull request #92: Redesign of Streams page - includes video & cus...

2017-10-06 Thread derrickdoo
Github user derrickdoo commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/92#discussion_r143323026 --- Diff: 0110/streams/index.html --- @@ -1,275 +1,311 @@ - + Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] kafka-site pull request #92: Redesign of Streams page - includes video & cus...

2017-10-06 Thread derrickdoo
Github user derrickdoo commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/92#discussion_r143322899 --- Diff: css/styles.css --- @@ -1031,50 +1054,438 @@ nav .btn { justify-content: center; width: 268px; } - -.green_card

[GitHub] kafka-site pull request #92: Redesign of Streams page - includes video & cus...

2017-10-06 Thread derrickdoo
Github user derrickdoo commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/92#discussion_r143322885 --- Diff: css/styles.css --- @@ -1031,50 +1054,438 @@ nav .btn { justify-content: center; width: 268px; } - -.green_card

[GitHub] kafka-site issue #92: Redesign of Streams page - includes video & customer l...

2017-10-06 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/92 @manjuapu to fix the video clipping issue you need to switch over to relative sizing when you viewport gets smaller than the full size embed (525px) + the total left/right padding/margin (20px

[GitHub] kafka-site issue #92: Redesign of Streams page - includes video & customer l...

2017-10-06 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/92 @manjuapu I'm running your branch locally and I noticed some layout/display issues that should eb sorted out. DESKTOP: 1. Clipping content on the right at certain browser widths

[GitHub] kafka pull request #4028: Update docs to reflect kafka trademark status

2017-10-05 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka/pull/4028 Update docs to reflect kafka trademark status Updated a couple places in docs with the 'registered' trademark symbol. You can merge this pull request into a Git repository by running: $ git

[GitHub] kafka-site pull request #90: Kafka registered trademark

2017-10-05 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/90 Kafka registered trademark Update art assets and content to reflect registered status of the Kafka trademark You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka-site issue #78: MINOR: Add header items

2017-09-29 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/78 @joel-hamill I'm concerned that the horizontal nav you're introducing here is going to cause some usability issues and actually conflicts with some work that's been going on with the Streams

[GitHub] kafka-site pull request #87: Update main bullet verbiage on the homepage

2017-09-27 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/87 Update main bullet verbiage on the homepage Updates to the 3 main bullets at the top of the homepage ![image](https://user-images.githubusercontent.com/271961/30943518-4c62bb1c-a3a6

[GitHub] kafka-site pull request #70: Add learn more verbiage on ctas

2017-08-09 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/70 Add learn more verbiage on ctas Added 'learn more' to the 3 CTAs at the very top of the homepage You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] kafka-site pull request #69: Hyperlink 3 callouts on the homepage

2017-08-02 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/69 Hyperlink 3 callouts on the homepage Hyperlinks on the 3 homepage callouts to specific sections of documentation. You can merge this pull request into a Git repository by running: $ git

[GitHub] kafka-site pull request #68: Docs TOC adjustments

2017-07-21 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/68 Docs TOC adjustments Docs TOC updates for Streams You can merge this pull request into a Git repository by running: $ git pull https://github.com/derrickdoo/kafka-site docs-toc

[GitHub] kafka-site issue #67: Updated docs nav and docs toc

2017-07-17 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/67 @guozhangwang cc @miguno --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] kafka-site pull request #67: Updated docs nav and docs toc

2017-07-17 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/67 Updated docs nav and docs toc - Updated sub nav under docs navigation to display Streams and Connect below APIs - Removed old links to Streams docs that are no longer relevant from table

[GitHub] kafka pull request #3540: Streams landing page

2017-07-17 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka/pull/3540 Streams landing page Content and assets for the updated Streams API landing page You can merge this pull request into a Git repository by running: $ git pull https://github.com/derrickdoo

[GitHub] kafka-site pull request #66: New landing page for Streams API

2017-07-11 Thread derrickdoo
Github user derrickdoo commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/66#discussion_r126789920 --- Diff: 0110/streams/index.html --- @@ -18,56 +18,192 @@ <!--#include virtual="../js/templateData.js" -->

[GitHub] kafka-site pull request #66: New landing page for Streams API

2017-07-06 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/66 New landing page for Streams API New Kafka Streams API landing page for desktop and mobile web. Note: There are a couple of items that need to be filled in before we launch this page

[GitHub] kafka-site pull request #58: Break apart Streams docs

2017-06-30 Thread derrickdoo
Github user derrickdoo commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/58#discussion_r125121166 --- Diff: includes/_footer.htm --- @@ -32,7 +32,8 @@ 'streams', 'quickstart

[GitHub] kafka-site pull request #63: Do not use hyphens in wrapping property names i...

2017-06-23 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/63 Do not use hyphens in wrapping property names in tables Hyphenating long property names that wrap inside of tables cells is causing confusion. CSS to prevent this from happening. (mentioned

[GitHub] kafka-site pull request #58: [PLEASE DO NOT MERGE] Further break apart Strea...

2017-05-30 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/58 [PLEASE DO NOT MERGE] Further break apart Streams docs This is just to illustrate necessary changes for changing the structure of Streams documentation. Please don't merge yet

[GitHub] kafka-site pull request #46: Fix routing bugs

2017-05-30 Thread derrickdoo
Github user derrickdoo closed the pull request at: https://github.com/apache/kafka-site/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka-site pull request #44: 0102 fixes

2017-05-30 Thread derrickdoo
Github user derrickdoo closed the pull request at: https://github.com/apache/kafka-site/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka-site issue #48: Filled in og meta tags

2017-05-30 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/48 @gwenshap sorry forgot to follow up on this PR. Yes, this is still relevant. I just rebased this with the latest changes. Let me know if the changes look ok. --- If your project is set up

[GitHub] kafka-site pull request #57: Updated description for uber card on the powere...

2017-05-30 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/57 Updated description for uber card on the powered by page Swapped in new description for the Uber "Powered By" card You can merge this pull request into a Git repository by running:

[GitHub] kafka-site pull request #48: Filled in og meta tags

2017-02-27 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/48 Filled in og meta tags Set og meta tags so sharing links to places like LinkedIn, Facebook, Twitter gives people good defaults. You can merge this pull request into a Git repository

[GitHub] kafka-site issue #47: More edits on 0.10.2 web docs after the release

2017-02-22 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/47 👍 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] kafka-site issue #46: Fix routing bugs

2017-02-09 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/46 @guozhangwang I think this will fix the routing issues you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] kafka-site pull request #46: Fix routing bugs

2017-02-09 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/46 Fix routing bugs - Update fronted JS redirect logic to handle legacy anchor links - Add documentation sub directories to avoid 404's You can merge this pull request into a Git repository

[GitHub] kafka-site issue #44: 0102 fixes

2017-02-03 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/44 Here's the corresponded PR to get these changes permanently into the main Kafka repo for future releases https://github.com/apache/kafka/pull/2495 --- If your project is set up for it, you

[GitHub] kafka pull request #2495: Adjustments to docs to make them work with latest ...

2017-02-03 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka/pull/2495 Adjustments to docs to make them work with latest template - Change introduction.html to be a partial like all the other doc content sections - Fix typo with include statement for the footer

[GitHub] kafka-site issue #44: 0102 fixes

2017-02-03 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/44 @guozhangwang can you take a look at this and double check to make sure this fixes all the issues you were seeing. I'll make another PR into the main Kafka repo to make sure we don't run

[GitHub] kafka-site pull request #42: fix typos on powered by page

2017-01-20 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/42 fix typos on powered by page - Fix typos in markup for Tumblr, Etsy, Paypal descriptions You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] kafka-site pull request #41: New design for the "powered by" page

2017-01-19 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/41 New design for the "powered by" page New design for the "powered by" page. - Stop linking off the site to show content - Include company logos - Displa

[GitHub] kafka-site pull request #39: New europe meetup links

2017-01-11 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/39 New europe meetup links Added 2 new meetups to the Events page You can merge this pull request into a Git repository by running: $ git pull https://github.com/derrickdoo/kafka-site

[GitHub] kafka pull request #2245: get docs setup with handlebars and seperate stream...

2016-12-12 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka/pull/2245 get docs setup with handlebars and seperate streams out to its own page - Seperate Streams documentation out to a standalone page. - Setup templates to use handlebars.js - Create

[GitHub] kafka pull request #2239: Docs templates

2016-12-12 Thread derrickdoo
Github user derrickdoo closed the pull request at: https://github.com/apache/kafka/pull/2239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #2239: Docs templates

2016-12-09 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka/pull/2239 Docs templates - Move Streams documentation out to it's own page - Render docs with Handlebars.js so we quickly set repeated items like doc version numbers You can merge this pull request

[GitHub] kafka-site issue #36: Streams standalone docs

2016-12-09 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/36 @guozhangwang yes, 2 things need to happen to new copies of stuff in side the versioned docs folder. 1. streams.html will need to have the full shell around it, so the includes

[GitHub] kafka-site issue #36: Streams standalone docs

2016-12-08 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/36 @guozhangwang here's a PR for the standalone Streams docs page --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] kafka-site pull request #36: Streams standalone docs

2016-12-08 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/36 Streams standalone docs Here's the changes we talked about to pull Streams documentation out to it's own page. Ended up having to do the redirect on URLs that contain anchor tags that match

[GitHub] kafka-site pull request #32: Added section for Kafka Summit on the Events pa...

2016-11-22 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/32 Added section for Kafka Summit on the Events page Added section for Kafka Summit on the Events page You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] kafka-site pull request #31: Documentation nav updates for older versions of...

2016-11-17 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/31 Documentation nav updates for older versions of our docs plus new meetup links on Events page - Remove subnav for old versions of our docs to avoid confusion - Make the navigation/page

[GitHub] kafka-site pull request #26: add trademark symbol on all pages plus longer f...

2016-11-17 Thread derrickdoo
Github user derrickdoo closed the pull request at: https://github.com/apache/kafka-site/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka-site pull request #30: New meetup links and kafka summit to events pag...

2016-11-09 Thread derrickdoo
Github user derrickdoo closed the pull request at: https://github.com/apache/kafka-site/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka-site pull request #30: New meetup links and kafka summit to events pag...

2016-11-09 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/30 New meetup links and kafka summit to events page Added new meetup locations and a link to the Kafka Summit conference page You can merge this pull request into a Git repository by running

[GitHub] kafka-site pull request #27: fix includes to missing files in 0101 docs and ...

2016-10-29 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/27 fix includes to missing files in 0101 docs and update mobile nav to a… - Update includes on the 0101 docs "Protocol" and "Migration" pages to point at correct files

[GitHub] kafka-site pull request #26: add trademark symbol on all pages plus longer f...

2016-10-22 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/26 add trademark symbol on all pages plus longer footer message - Added trademark symbol to first instance of "Kafka" or "Apache Kafka" across the site. - Updated footer

[GitHub] kafka-site pull request #24: update htaccess to load images nested inside of...

2016-10-11 Thread derrickdoo
Github user derrickdoo closed the pull request at: https://github.com/apache/kafka-site/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka-site issue #24: update htaccess to load images nested inside of doc fo...

2016-10-10 Thread derrickdoo
Github user derrickdoo commented on the issue: https://github.com/apache/kafka-site/pull/24 - stop displaying code elements as display:block - don't rewrite requests for images nested in the specific doc version directories --- If your project is set up for it, you can reply

[GitHub] kafka-site pull request #24: update htaccess to load images nested inside of...

2016-10-10 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/24 update htaccess to load images nested inside of doc folders You can merge this pull request into a Git repository by running: $ git pull https://github.com/derrickdoo/kafka-site

[GitHub] kafka pull request #2003: make documentation follow latest template

2016-10-10 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka/pull/2003 make documentation follow latest template Make the latest version of our docs follow the latest site template structure. You can merge this pull request into a Git repository by running

[GitHub] kafka-site pull request #21: Theme enhancement

2016-10-05 Thread derrickdoo
Github user derrickdoo closed the pull request at: https://github.com/apache/kafka-site/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka-site pull request #21: Theme enhancement

2016-10-05 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/21 Theme enhancement - Added Apache branding guideline stuff - 302 redirects for all the odd direct links to partials that are currently floating around - Improved mobile scroll