[GitHub] kafka pull request #4307: KAFKA-6307 mBeanName should be removed before retu...

2017-12-08 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4307 KAFKA-6307 mBeanName should be removed before returning from JmxReporter#removeAttribute() ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] kafka pull request #4288: KAFKA-6300 SelectorTest may fail with ConcurrentMo...

2017-12-06 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/kafka/pull/4288 ---

[GitHub] kafka pull request #4299: KAFKA-6300 SelectorTest may fail with ConcurrentMo...

2017-12-06 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4299 KAFKA-6300 SelectorTest may fail with ConcurrentModificationException Synchronization is added w.r.t. sockets ArrayList to avoid ConcurrentModificationException ### Committer Checklist

[GitHub] kafka pull request #4288: KAFKA-6300 SelectorTest may fail with ConcurrentMo...

2017-12-02 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4288 KAFKA-6300 SelectorTest may fail with ConcurrentModificationException Synchronization is added w.r.t. sockets ArrayList to avoid ConcurrentModificationException ### Committer Checklist

[GitHub] kafka pull request #4254: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-11-22 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4254 KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition Replace ZkUtils with KafkaZkClient in ReplicaManager and Partition Utilize existing unit tests ### Committer Checklist

[GitHub] kafka pull request #4166: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-11-22 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/kafka/pull/4166 ---

[GitHub] kafka pull request #4176: KAFKA-6168 Connect Schema comparison is slow for l...

2017-11-03 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4176 KAFKA-6168 Connect Schema comparison is slow for large schemas Re-arrange order of comparisons in equals() to evaluate non-composite fields first Cache hash code You can merge this pull request

[GitHub] kafka pull request #4166: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-10-31 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4166 KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/kafka trunk Alternatively

[GitHub] kafka pull request #4134: KAFKA-6075 Kafka cannot recover after an unclean s...

2017-10-25 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4134 KAFKA-6075 Kafka cannot recover after an unclean shutdown on Windows As Vahid commented, Files.deleteIfExists(file.toPath) seems to destabilize Windows environment. This PR reverts

[GitHub] kafka pull request #4127: MINOR use proper template classes for internalSele...

2017-10-24 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4127 MINOR use proper template classes for internalSelectKey() As pointed out in this thread: http://search-hadoop.com/m/Kafka/uyzND1fy2K7I85G1?subj=Kafka+source+code+Build+Error , Eclipse shows syntax

[GitHub] kafka pull request #4124: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-10-23 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4124 KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/kafka trunk Alternatively

[GitHub] kafka pull request #4118: KAFKA-6101 Reconnecting to broker does not exponen...

2017-10-23 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4118 KAFKA-6101 Reconnecting to broker does not exponentially backoff You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/kafka trunk Alternatively

[GitHub] kafka pull request #4108: KAFKA-6101 Reconnecting to broker does not exponen...

2017-10-23 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/kafka/pull/4108 ---

[GitHub] kafka pull request #4108: KAFKA-6101 Reconnecting to broker does not exponen...

2017-10-20 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4108 KAFKA-6101 Reconnecting to broker does not exponentially backoff You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/kafka trunk Alternatively

[GitHub] kafka pull request #4052: KAFKA-6046 DeleteRecordsRequest to a non-leader sh...

2017-10-12 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/kafka/pull/4052 ---

[GitHub] kafka pull request #4052: KAFKA-6046 DeleteRecordsRequest to a non-leader sh...

2017-10-10 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4052 KAFKA-6046 DeleteRecordsRequest to a non-leader should give proper error You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/kafka trunk

[GitHub] kafka pull request #4019: KAFKA-6011 AppInfoParser should only use metrics A...

2017-10-04 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/4019 KAFKA-6011 AppInfoParser should only use metrics API and should not register JMX mbeans directly Added app ID to metrics API. The JMX can be dropped post 1.0.0 You can merge this pull

[GitHub] kafka pull request #3962: KAFKA-5973 Exit when ShutdownableThread encounters...

2017-09-27 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/kafka/pull/3962 ---

[GitHub] kafka pull request #3962: KAFKA-5973 Exit when ShutdownableThread encounters...

2017-09-26 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/3962 KAFKA-5973 Exit when ShutdownableThread encounters uncaught exception This PR installs UncaughtExceptionHandler which calls Exit.exit() . According to discussion on KAFKA-5973, exiting seems

[GitHub] kafka pull request #3935: MINOR: improvement on top of KAFKA-5793: Tighten u...

2017-09-21 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/3935 MINOR: improvement on top of KAFKA-5793: Tighten up the semantics of the OutOfOrderSequenceException Simplified the condition in Sender#failBatch() Added log in TransactionManager

[GitHub] kafka pull request #3925: KAFKA-5911 Avoid creation of extra Map for futures...

2017-09-20 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/3925 KAFKA-5911 Avoid creation of extra Map for futures in KafkaAdminClient This reduces creation of garbage while keeping thread safety untouched. You can merge this pull request into a Git repository

[GitHub] kafka pull request #3812: KAFKA-5657 Connect REST API should include the con...

2017-09-07 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/3812 KAFKA-5657 Connect REST API should include the connector type when describing a connector Embed the type of connector in ConnectorInfo You can merge this pull request into a Git repository

[GitHub] kafka pull request #3777: KAFKA-5820 Remove unneeded synchronized keyword in...

2017-09-01 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/kafka/pull/3777 KAFKA-5820 Remove unneeded synchronized keyword in StreamThread I removed synchronized keyword from 3 methods. I ran the change thru streams module where test suite passed. You can merge