[GitHub] kafka pull request #1760: KAFKA-3937: Kafka Clients Leak Native Memory For L...

2016-08-18 Thread wiyu
GitHub user wiyu opened a pull request:

https://github.com/apache/kafka/pull/1760

KAFKA-3937: Kafka Clients Leak Native Memory For Longer Than Needed With 
Compressed Messages

@ijuma - Making the change against trunk based on your suggestions to have 
the stream closing handled in the private RecordIterator constructor which I 
understand is only to be used only if the block of message(s) are compressed. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wiyu/kafka compressor_memory_leak_in_fetcher

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1760


commit 56451a38399875ae9d1ccdb2f873de88eae6f940
Author: William Yu <w...@unified.com>
Date:   2016-08-18T17:25:10Z

KAFKA-3937: Kafka Clients Leak Native Memory For Longer Than Needed With 
Compressed Messages




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #1743: KAFKA-3937: Kafka Clients Leak Native Memory For L...

2016-08-17 Thread wiyu
Github user wiyu closed the pull request at:

https://github.com/apache/kafka/pull/1743


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #1743: KAFKA-3937: Kafka Clients Leak Native Memory For L...

2016-08-16 Thread wiyu
GitHub user wiyu opened a pull request:

https://github.com/apache/kafka/pull/1743

KAFKA-3937: Kafka Clients Leak Native Memory For Longer Than Needed With 
Compressed Messages

@ijuma - Creating this PR against 0.9.0 as this is what we're using in 
prod. I can modify this for trunk if the logic solution looks good. 

I modified the record iterator to inherit from closable and implemented the 
method to call streams.close(). The stream will now be closed when we are done 
traversing the inner iterator. I had to move the `try {} catch{}` out of the 
`if` portion to deal with IOException coming from `innerDone()`.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wiyu/kafka compressor_memory_leak_in_fetcher

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1743


commit b56ec1563e34d40c338224970c6b8cd3802e4dcd
Author: William Yu <w...@unified.com>
Date:   2016-08-16T14:09:28Z

KAFKA-3937: Kafka Clients Leak Native Memory For Longer Than Needed With 
Compressed Messages




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---