[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox


scott-confluent commented on a change in pull request #282:
URL: https://github.com/apache/kafka-site/pull/282#discussion_r465924056



##
File path: 25/documentation.html
##
@@ -31,7 +31,7 @@
 
   

-

Review comment:
   I believe the older versions SHOULD have this banner.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

2020-08-05 Thread GitBox


scott-confluent commented on a change in pull request #282:
URL: https://github.com/apache/kafka-site/pull/282#discussion_r465921715



##
File path: 25/streams/developer-guide/write-streams.html
##
@@ -90,22 +90,22 @@
   See the section Data Types and Serialization for more information about 
Serializers/Deserializers.
   
   Example pom.xml snippet when using Maven:
-  
-org.apache.kafka
-kafka-streams
-{{fullDotVersion}}
-
-
-org.apache.kafka
-kafka-clients
-{{fullDotVersion}}
-
+  dependency>
+groupId>org.apache.kafka/groupId>

Review comment:
   theoretically it should be generated with html entities for both gt and 
lt, but the opening is the only one that matters for highlighting the syntax. 
it's not an easy thing to find/replace so we'd have to do an audit of all the 
docs.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org