Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Ismael, Good point! This file hasn't been changed after 2020 Oct.. So I think this is not a blocker for v3.4.0. Thank you. Luke On Wed, Dec 21, 2022 at 9:49 PM Ismael Juma wrote: > Hi Luke, > > Is this a recent change? If not, that gives further credence that we don't > use this method

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Luke, Is this a recent change? If not, that gives further credence that we don't use this method today. Ismael On Wed, Dec 21, 2022 at 2:22 AM Luke Chen wrote: > Hi Sophie and devs, > > KAFKA-14540 is > reported > (from Michael Marshall,

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie and devs, KAFKA-14540 is reported (from Michael Marshall, thanks!) that we might write corrupted data to the output stream due to the wrong buffer position set in DataOutputStreamWritable#writeByteBuffer. Had a search in the project,

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, I have merged https://issues.apache.org/jira/browse/KAFKA-14532. Best, David On Tue, Dec 20, 2022 at 4:31 PM David Arthur wrote: > > Hey Sophie, > > I found a KRaft blocker for 3.4 > https://issues.apache.org/jira/browse/KAFKA-14531. The fix is committed to > trunk and is quite

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey Sophie, I found a KRaft blocker for 3.4 https://issues.apache.org/jira/browse/KAFKA-14531. The fix is committed to trunk and is quite small. If you agree, I'll merge the fix to the 3.4 branch. Thanks! David On Tue, Dec 20, 2022 at 7:53 AM David Jacot wrote: > Hi Sophie, > > We just found

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, We just found a blocker for 3.4.0: https://issues.apache.org/jira/browse/KAFKA-14532. The PR is on the way. Best, David On Sat, Dec 17, 2022 at 1:08 AM Sophie Blee-Goldman wrote: > > Thanks Jose & Kirk. I agree both those fixes should be included in the 3.4 > release > > On Fri, Dec

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks Jose & Kirk. I agree both those fixes should be included in the 3.4 release On Fri, Dec 16, 2022 at 12:30 PM José Armando García Sancio wrote: > Hi Sophie, > > I am interested in including a bug fix for > https://issues.apache.org/jira/browse/KAFKA-14457 in the 3.4.0 > release. The fix

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, I am interested in including a bug fix for https://issues.apache.org/jira/browse/KAFKA-14457 in the 3.4.0 release. The fix is here: https://github.com/apache/kafka/pull/12994. I think it is important to include this fix because some of the controller metrics are inaccurate without

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey Ron, sure, go ahead and merge this to 3.4 Thanks On Mon, Dec 12, 2022 at 12:25 PM Ron Dagostino wrote: > Hi Sophie. https://github.com/apache/kafka/pull/12856 "KAFKA-14392: > KRaft broker heartbeat timeout should not exceed > broker.session.timeout.ms" just merged to trunk and seems like a

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie. https://github.com/apache/kafka/pull/12856 "KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms" just merged to trunk and seems like a potential candidate for 3.4.0 as it is a very small and targeted fix with very low risk. Could it be included even

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey everyone, Rejoice (or not) for we are now past code freeze for the 3.4 release! This means you should not be merging any new code to the 3.4 branch unless/until it's been approved as a blocker. For now feel free to also merge things like flaky test fixes and docs PRs that don't touch any

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey Sophie I was wondering whether we should try to get the ARM build working again so that we can perform release qualification of 3.4.x on ARM as well (which was disabled in https://github.com/apache/kafka/pull/12380)? I would be happy to pick up the work if someone can point me to the history

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks everyone for the updates, that all sounds good. Divij: I pinged some of the relevant reviewers to give your PRs a final pass, but will leave it to their judgement from here as I'm not familiar with either. Everyone else: reminder that today is the official code freeze deadline, so please

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, Thanks for taking a look at the MM2 issue. We've merged a (minimally-scoped) fix and backported it to the 3.4 branch; the issue should be resolved now. Cheers, Chris On Wed, Dec 7, 2022 at 3:12 PM Rajini Sivaram wrote: > Hi Sophie, > > I have merged PR #12954 for KIP-881 to 3.4

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, I have merged PR #12954 for KIP-881 to 3.4 branch. Please let me know if that is ok. Thank you, Rajini On Wed, Dec 7, 2022 at 11:43 AM Rajini Sivaram wrote: > Hi Sophie, > > The first PR for KIP-881 which contains protocol changes has been merged > to trunk

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, The first PR for KIP-881 which contains protocol changes has been merged to trunk (https://github.com/apache/kafka/pull/12954). It is a relatively small PR, can we merge to 3.4.0? Thank you, Rajini On Wed, Dec 7, 2022 at 11:16 AM Divij Vaidya wrote: > Hey Sophie > > I have a

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey Sophie I have a couple of pending PRs which have been waiting for review since preparation of the 3.3 release. They are not blockers for 3.4 but are being tracked as improvements that we would like to add to 3.4 release. Please consider taking a look when you get a chance: 1.

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey all, First off, just a heads up that code freeze will be *tomorrow, Dec 6th* so please make sure to merge any lingering PRs by EOD Wednesday (PST). If you have a potential blocker that may take longer to fix and hasn't already been communicated to me, please reach out to me now and make sure

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Greg, Thanks for finding and raising this issue. I've given the PR a look and plan to continue reviewing it this week until merged. IMO this should qualify as a blocker for the release. Sophie, is it alright if we merge this into the 3.4 branch (or trunk, if one has not been created yet) past

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi All, Just notifying everyone of a regression introduced by KIP-787, currently only present on trunk, but which may qualify as a blocker for the release. It manifests as a moderate resource leak on MirrorMaker2 clusters. The fix should have a small scope and low risk. Here's the bug ticket:

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, FYI - I just merged KIP-840 (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211884652) so it will be in 3.4. Best, David On Thu, Dec 1, 2022 at 3:01 AM Sophie Blee-Goldman wrote: > > Hey all! It's officially *feature freeze for 3.4* so make sure you get that >

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey all! It's officially *feature freeze for 3.4* so make sure you get that feature work merged by the end of today. After this point, only bug fixes and other work focused on stabilizing the release should be merged to the release branch. Also note that the *3.4 code freeze* will be in one week

Re: [DISCUSS] Apache Kafka 3.4.0 release

Sophie, KIP-866 has been accepted. Thanks! -David On Thu, Nov 17, 2022 at 12:21 AM Sophie Blee-Goldman wrote: > > Thanks for the update Rajini, I've added this to the release page since it > looks like > it will pass but of course if anything changes, just let me know. > > David, I'm fine with

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks for the update Rajini, I've added this to the release page since it looks like it will pass but of course if anything changes, just let me know. David, I'm fine with aiming to include KIP-866 in the 3.4 release as well since this seems to be a critical part of the zookeeper

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, KIP-881 has three binding votes (David Jacot, Jun and me) and one non-binding vote (Maulin). So it is good to go for 3.4.0 if there are no objections until the voting time of 72 hours completes on Friday. Thanks, Rajini On Wed, Nov 16, 2022 at 3:15 PM David Arthur wrote: > Sophie,

Re: [DISCUSS] Apache Kafka 3.4.0 release

Sophie, the vote for KIP-866 is underway, but there is still some discussion happening. I'm hopeful that the vote can close this week, but it may fall into next week. Can we include this KIP in 3.4? Thanks, David On Tue, Nov 15, 2022 at 6:52 AM Rajini Sivaram wrote: > Hi Sophie, > > I was out

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks Luke and Sophie! Sorry, I had missed out the entry in the KIP page. Regards, Rajini On Wed, Nov 16, 2022 at 3:36 AM Luke Chen wrote: > Hi Sophie, > > Here it is: > KIP-881: > >

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, Here it is: KIP-881: https://cwiki.apache.org/confluence/display/KAFKA/KIP-881%3A+Rack-aware+Partition+Assignment+for+Kafka+Consumers I've helped create an entry in under discussion table in KIP page. Luke On Wed, Nov 16, 2022 at 11:18 AM Sophie Blee-Goldman wrote: > Rajini can you

Re: [DISCUSS] Apache Kafka 3.4.0 release

Rajini can you send me the link to this KIP? I don't see it on the KIP page yet Actually this is a good reminder to everyone: *please make sure you have added* *and/or updated all KIPs on the *KIP status page . After

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks Rajini, we can include KIP-881 in the 3.4 release assuming it will pass. I'll add it to the release page On Tue, Nov 15, 2022 at 3:51 AM Rajini Sivaram wrote: > Hi Sophie, > > I was out of office and hence couldn't get voting started for KIP-881 in > time. I will start the vote for the

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, I was out of office and hence couldn't get voting started for KIP-881 in time. I will start the vote for the KIP today. If there are sufficient votes by tomorrow (16th Nov), can we include this KIP in 3.4, even though voting will only complete on the 17th? It is a small KIP, so we can

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hello again, This is a reminder that the KIP freeze deadline is approaching, all KIPs must be voted and accepted by *next Wednesday* *(the 16th)* Keep in mind that to allow for the full voting period, this means you must kick off the vote for your KIP no later than* next Monday* (*the 14th*).

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hey all, I've created the release page for 3.4.0 with the current plan, which you can find here: https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.4.0 The freeze deadlines for this release are as follows: 1. KIP Freeze November 16th, 2022 2. Feature Freeze November 30th, 2022 3.

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks for volunteering! On Mon, 10 Oct 2022, 10:56 Bruno Cadonna, wrote: > +1 > > Thanks Sophie! > > Best, > Bruno > > On 06.10.22 00:01, Sophie Blee-Goldman wrote: > > Hey all, > > > > I'd like to volunteer as release manager for the next feature release, > > which will be Apache > > Kafka

Re: [DISCUSS] Apache Kafka 3.4.0 release

+1 Thanks Sophie! Best, Bruno On 06.10.22 00:01, Sophie Blee-Goldman wrote: Hey all, I'd like to volunteer as release manager for the next feature release, which will be Apache Kafka 3.4.0. If that sounds good to everyone I'll update this thread with the release plan in the coming week.

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks for volunteering Sophie On Fri, Oct 7, 2022 at 4:17 PM Ismael Juma wrote: > Thanks for volunteering Sophie! > > Ismael > > On Wed, Oct 5, 2022 at 3:01 PM Sophie Blee-Goldman > wrote: > > > Hey all, > > > > I'd like to volunteer as release manager for the next feature release, > >

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks for volunteering Sophie! Ismael On Wed, Oct 5, 2022 at 3:01 PM Sophie Blee-Goldman wrote: > Hey all, > > I'd like to volunteer as release manager for the next feature release, > which will be Apache > Kafka 3.4.0. If that sounds good to everyone I'll update this thread with > the

Re: [DISCUSS] Apache Kafka 3.4.0 release

4.0 is gonna be the next big milestone :) Thanks Sophie! On Wed, Oct 5, 2022 at 6:08 PM David Jacot wrote: > +1. Thanks, Sophie! > > Le mer. 5 oct. 2022 à 19:57, Luke Chen a écrit : > > > Hi Sophie, > > > > Thanks for volunteering! > > > > Luke > > > > On Thu, Oct 6, 2022 at 6:17 AM José

Re: [DISCUSS] Apache Kafka 3.4.0 release

+1. Thanks, Sophie! Le mer. 5 oct. 2022 à 19:57, Luke Chen a écrit : > Hi Sophie, > > Thanks for volunteering! > > Luke > > On Thu, Oct 6, 2022 at 6:17 AM José Armando García Sancio > wrote: > > > Thanks for volunteering Sophie. > > > > On Wed, Oct 5, 2022 at 3:01 PM Sophie Blee-Goldman > >

Re: [DISCUSS] Apache Kafka 3.4.0 release

Hi Sophie, Thanks for volunteering! Luke On Thu, Oct 6, 2022 at 6:17 AM José Armando García Sancio wrote: > Thanks for volunteering Sophie. > > On Wed, Oct 5, 2022 at 3:01 PM Sophie Blee-Goldman > wrote: > > > > Hey all, > > > > I'd like to volunteer as release manager for the next feature

Re: [DISCUSS] Apache Kafka 3.4.0 release

Thanks for volunteering Sophie. On Wed, Oct 5, 2022 at 3:01 PM Sophie Blee-Goldman wrote: > > Hey all, > > I'd like to volunteer as release manager for the next feature release, > which will be Apache > Kafka 3.4.0. If that sounds good to everyone I'll update this thread with > the release plan

[DISCUSS] Apache Kafka 3.4.0 release

Hey all, I'd like to volunteer as release manager for the next feature release, which will be Apache Kafka 3.4.0. If that sounds good to everyone I'll update this thread with the release plan in the coming week. Cheers, A. Sophie Blee-Goldman