Re: [DISCUSS] KAFKA-4930 & KAFKA 4938 - Treatment of name parameter in create connector requests

Could someone have a look at the PR for KAFKA-4930 if they get the chance (not necessarily you Gwen, just bumping in general)? I've updated it according to the latest comments a little while ago and would like to get this done, before I forget what I did in case more changes are necessary :)

Re: [DISCUSS] KAFKA-4930 & KAFKA 4938 - Treatment of name parameter in create connector requests

This sounds great. I'll try to review later today :) On Thu, Jul 6, 2017 at 12:35 AM Sönke Liebau wrote: > I've updated the pull request to behave as follows: > - reject create requests that contain no "name" element with a > BadRequestException > - reject

Re: [DISCUSS] KAFKA-4930 & KAFKA 4938 - Treatment of name parameter in create connector requests

I've updated the pull request to behave as follows: - reject create requests that contain no "name" element with a BadRequestException - reject name that are empty or contain illegal characters with a ConfigException - leave current logic around when to copy the name from the create request to

Re: [DISCUSS] KAFKA-4930 & KAFKA 4938 - Treatment of name parameter in create connector requests

Hi, regarding "breaking existing functionality" .. yes...that was me getting confused about intended and existing functionality :) You are right, this won't break anything that is currently working. I'll leave placement of "name" parameter as is and open a new issue to clarify this later on.

Re: [DISCUSS] KAFKA-4930 & KAFKA 4938 - Treatment of name parameter in create connector requests

Hey, Nice research and summary. Regarding the ability to have a "nameless" connector - I'm pretty sure we never intended to allow that. I'm confused about breaking something that currently works though - since we get NPE, how will giving more intentional exceptions break anything? Regarding the

[DISCUSS] KAFKA-4930 & KAFKA 4938 - Treatment of name parameter in create connector requests

While working on KAFKA-4930 and KAFKA-4938 I came across some sort of fundamental questions about the rest api for creating connectors in Kafka Connect that I'd like to put up for discussion. Currently requests that do not contain a "name" element on the top level are not accepted by the API, but