Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-07 Thread Roger Hoover
gt; > (the latter may be a simpler dependency for the > > > XXXPolicy.RequestMetadata > > > > > > > > > > > > > > > > 3. For the delet

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-07 Thread Ismael Juma
consider passing a class instead of > > just > > > > a > > > > > string to the validate method so that we have options if we need to > > > > extend > > > > >

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-05 Thread Tom Bentley
gt; > > > string to the validate method so that we have options if we need to > > > extend > > > > it. > > > > > > 3. Agree, we should have the DeletePolicy define its RequestMetadata > > > class, too > > > > > >

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-05 Thread Edoardo Comar
cy define its RequestMetadata > > class, too > > > > > > > 4. Do we want to enhance the AlterConfigs policy as well? > > > > 4. I don't see why not :-) > > > > > > > > thanks > > Edo > > -

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-09-05 Thread Ismael Juma
4. I don't see why not :-) > > > > thanks > Edo > -- > > Edoardo Comar > > IBM Message Hub > > > isma...@gmail.com wrote on 22/06/2017 15:05:06: > > > From: Ismael Juma <ism...@juma.me.uk&g

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-06-23 Thread Edoardo Comar
rdo Comar IBM Message Hub isma...@gmail.com wrote on 22/06/2017 15:05:06: > From: Ismael Juma <ism...@juma.me.uk> > To: dev@kafka.apache.org > Date: 22/06/2017 15:05 > Subject: Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and > introduction of TopicDeletePolicy > Sent by:

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-06-22 Thread Ismael Juma
Thanks for the KIP, Edoardo. A few comments: 1. Have you considered extending RequestMetadata with the additional information you need? We could add Cluster to it, which has topic assignment information, for example. This way, there would be no need for a V2 interface. 2. Something else that

[DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

2017-06-22 Thread Edoardo Comar
Hi all, We've drafted "KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy" for discussion: https://cwiki.apache.org/confluence/display/KAFKA/KIP-170%3A+Enhanced+TopicCreatePolicy+and+introduction+of+TopicDeletePolicy Please take a look. Your feedback is welcome and much