Re: [DISCUSS] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-08-30 Thread Magnus Edenhill 
For what it is worth:

librdkafka-based clients will treat any subscribed topic string that is
prefixed with the regexp start-of-line anchor ("^") as a regexp,
thus providing regex and actual topic subscriptions with the same API, also
allowing a mix of actuals and regexps:
E.g.:
consumer.subscribe(["fixedtopic", "^topic_[0-9]+"])


2017-08-30 8:49 GMT+02:00 Guozhang Wang :

> Sounds good.
>
> On Tue, Aug 29, 2017 at 6:12 PM, Becket Qin  wrote:
>
> > Sounds good to me as well.
> >
> > On Tue, Aug 29, 2017 at 2:43 AM, Ismael Juma  wrote:
> >
> > > Sounds good to me too. Since this is a non controversial change, I
> > suggest
> > > starting the vote in 1-2 days if no-one else comments.
> > >
> > > Ismael
> > >
> > > On Thu, Aug 24, 2017 at 7:32 PM, Jason Gustafson 
> > > wrote:
> > >
> > > > Seems reasonable. I don't recall any specific reason for not
> providing
> > > this
> > > > method initially.
> > > >
> > > > -Jason
> > > >
> > > > On Thu, Aug 24, 2017 at 5:50 AM, Attila Kreiner 
> > > wrote:
> > > >
> > > > > Hi All,
> > > > >
> > > > > I created KIP-191:
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > 191%3A+KafkaConsumer.subscribe%28%29+overload+that+
> > takes+just+Pattern
> > > > >
> > > > > Jira: https://issues.apache.org/jira/browse/KAFKA-5726
> > > > > PR: https://github.com/apache/kafka/pull/3669
> > > > >
> > > > > Please check it.
> > > > >
> > > > > Thanks,
> > > > > Attila
> > > > >
> > > >
> > >
> >
>
>
>
> --
> -- Guozhang
>

Re: [DISCUSS] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-08-30 Thread Guozhang Wang 
Sounds good.

On Tue, Aug 29, 2017 at 6:12 PM, Becket Qin  wrote:

> Sounds good to me as well.
>
> On Tue, Aug 29, 2017 at 2:43 AM, Ismael Juma  wrote:
>
> > Sounds good to me too. Since this is a non controversial change, I
> suggest
> > starting the vote in 1-2 days if no-one else comments.
> >
> > Ismael
> >
> > On Thu, Aug 24, 2017 at 7:32 PM, Jason Gustafson 
> > wrote:
> >
> > > Seems reasonable. I don't recall any specific reason for not providing
> > this
> > > method initially.
> > >
> > > -Jason
> > >
> > > On Thu, Aug 24, 2017 at 5:50 AM, Attila Kreiner 
> > wrote:
> > >
> > > > Hi All,
> > > >
> > > > I created KIP-191:
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 191%3A+KafkaConsumer.subscribe%28%29+overload+that+
> takes+just+Pattern
> > > >
> > > > Jira: https://issues.apache.org/jira/browse/KAFKA-5726
> > > > PR: https://github.com/apache/kafka/pull/3669
> > > >
> > > > Please check it.
> > > >
> > > > Thanks,
> > > > Attila
> > > >
> > >
> >
>



-- 
-- Guozhang

Re: [DISCUSS] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-08-29 Thread Becket Qin 
Sounds good to me as well.

On Tue, Aug 29, 2017 at 2:43 AM, Ismael Juma  wrote:

> Sounds good to me too. Since this is a non controversial change, I suggest
> starting the vote in 1-2 days if no-one else comments.
>
> Ismael
>
> On Thu, Aug 24, 2017 at 7:32 PM, Jason Gustafson 
> wrote:
>
> > Seems reasonable. I don't recall any specific reason for not providing
> this
> > method initially.
> >
> > -Jason
> >
> > On Thu, Aug 24, 2017 at 5:50 AM, Attila Kreiner 
> wrote:
> >
> > > Hi All,
> > >
> > > I created KIP-191:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 191%3A+KafkaConsumer.subscribe%28%29+overload+that+takes+just+Pattern
> > >
> > > Jira: https://issues.apache.org/jira/browse/KAFKA-5726
> > > PR: https://github.com/apache/kafka/pull/3669
> > >
> > > Please check it.
> > >
> > > Thanks,
> > > Attila
> > >
> >
>

Re: [DISCUSS] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-08-29 Thread Ismael Juma 
Sounds good to me too. Since this is a non controversial change, I suggest
starting the vote in 1-2 days if no-one else comments.

Ismael

On Thu, Aug 24, 2017 at 7:32 PM, Jason Gustafson  wrote:

> Seems reasonable. I don't recall any specific reason for not providing this
> method initially.
>
> -Jason
>
> On Thu, Aug 24, 2017 at 5:50 AM, Attila Kreiner  wrote:
>
> > Hi All,
> >
> > I created KIP-191:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 191%3A+KafkaConsumer.subscribe%28%29+overload+that+takes+just+Pattern
> >
> > Jira: https://issues.apache.org/jira/browse/KAFKA-5726
> > PR: https://github.com/apache/kafka/pull/3669
> >
> > Please check it.
> >
> > Thanks,
> > Attila
> >
>

Re: [DISCUSS] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-08-24 Thread Jason Gustafson 
Seems reasonable. I don't recall any specific reason for not providing this
method initially.

-Jason

On Thu, Aug 24, 2017 at 5:50 AM, Attila Kreiner  wrote:

> Hi All,
>
> I created KIP-191:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 191%3A+KafkaConsumer.subscribe%28%29+overload+that+takes+just+Pattern
>
> Jira: https://issues.apache.org/jira/browse/KAFKA-5726
> PR: https://github.com/apache/kafka/pull/3669
>
> Please check it.
>
> Thanks,
> Attila
>

[DISCUSS] KIP-191: KafkaConsumer.subscribe() overload that takes just Pattern

2017-08-24 Thread Attila Kreiner 
Hi All,

I created KIP-191:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-191%3A+KafkaConsumer.subscribe%28%29+overload+that+takes+just+Pattern

Jira: https://issues.apache.org/jira/browse/KAFKA-5726
PR: https://github.com/apache/kafka/pull/3669

Please check it.

Thanks,
Attila