Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

com> Sent: Friday, April 13, 2018 12:34 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers Thanks Ewen and Matthias for the explanation. I'm also in favor of the current proposal, and my rationale are basically 1) inheritance hierarchy is simp

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

ubject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers Thanks Ewen and Matthias for the explanation. I'm also in favor of the current proposal, and my rationale are basically 1) inheritance hierarchy is simple for users to understand (Matthias has explained it well), 2) for

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

ious email, hope this helps! > > > Best, > > Boyang > > > > From: Matthias J. Sax <matth...@confluent.io> > Sent: Thursday, April 12, 2018 8:35 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

this helps! Best, Boyang From: Matthias J. Sax <matth...@confluent.io> Sent: Thursday, April 12, 2018 8:35 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers Thanks for the explanation. I am no

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

l or nothing approach to inheriting from the the >>>> "main" consumer properties? In that mode if you override *anything*, you >>>> should specify *everything*. But if it was just, e.g. group.id, >> client.id, >>>> and offset.reset that needed adjustment for a restoreConsumer, that >> would

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

gt; inheritance; and while people find the config duplication annoying (and > >> confusing!), we inevitably find cases where they need it. I think > >> inheritance in these configuration setups needs to be approached very > >> carefully. Admittedly, some of the challenges in

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

tlook.com> Sent: Friday, April 6, 2018 11:19 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers Hey guys, thanks for the discussion. One good point Matthias pointed out was that the whole "consumer config separation" is for a

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

o: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers Hey guys, thanks for the discussion. One good point Matthias pointed out was that the whole "consumer config separation" is for advanced users. In case someone wants to set different

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

___ From: Matthias J. Sax <matth...@confluent.io> Sent: Friday, April 6, 2018 6:28 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers Ewen, I cannot completely follow your argument. Can you elaborate a little bit? After reading you

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

uration setups needs to be approached very >> carefully. Admittedly, some of the challenges in Connect don't appear here >> (e.g. conflicts in producer/consumer config naming, since this is a >> Consumer-only KIP), but similar problems arise. >> >> -Ewen >> >> On Wed

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Thanks Guozhang! I already updated the pull request and KIP to deprecate > > getConsumerConfigs() function. Do you think we could move to a voting > stage > > now? > > > > > > > > From: Guozhang Wang <wangg...@gmail.com>

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

uest and KIP to deprecate > getConsumerConfigs() function. Do you think we could move to a voting stage > now? > > > > From: Guozhang Wang <wangg...@gmail.com> > Sent: Thursday, April 5, 2018 9:52 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-276: Ad

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

he.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers I agree that renaming the method in this case may not worth it. Let's keep the existing function names. On Wed, Apr 4, 2018 at 6:06 PM, Matthias J. Sax <matth...@confluent.io> wrote: > Thanks for u

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

> Thanks for your valuable feedback! >> >> >> Best, >> >> Boyang >> >> ____________________ >> From: Boyang Chen <bche...@outlook.com> >> Sent: Tuesday, April 3, 2018 11:39 AM >> To: dev@kafka.apache.org

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

> >> > >> > >> Thanks for your valuable feedback! > >> > >> > >> Best, > >> > >> Boyang > >> > >> > >> From: Boyang Chen <bche...@outlook.com> > >> Sent

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

able feedback! >> >> >> Best, >> >> Boyang >> >> ________________ >> From: Boyang Chen <bche...@outlook.com> >> Sent: Tuesday, April 3, 2018 11:39 AM >> To: dev@kafka.apache.org >&g

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

: Boyang Chen <bche...@outlook.com> > Sent: Tuesday, April 3, 2018 11:39 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different > consumers > > Thanks Matthias, Ted and Guozhang for the inputs. I shall address them in > nex

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

est, Boyang From: Boyang Chen <bche...@outlook.com> Sent: Tuesday, April 3, 2018 11:39 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers Thanks Matthias, Ted and Guozhang for the inputs. I shall address t

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Thanks Matthias, Ted and Guozhang for the inputs. I shall address them in next round. From: Matthias J. Sax <matth...@confluent.io> Sent: Tuesday, April 3, 2018 4:43 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-276: Add StreamsConfig

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Yes, your examples make sense to me. That was the idea behind the proposal. -Matthias On 4/2/18 11:25 AM, Guozhang Wang wrote: > @Matthias > > That's a good question: I think adding another config for the main consumer > makes good tradeoffs between compatibility and new user convenience. Just

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

@Matthias That's a good question: I think adding another config for the main consumer makes good tradeoffs between compatibility and new user convenience. Just to clarify, from user's pov on upgrade: 1) I'm already overriding some consumer configs, and now I want to override these values

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

bq. to introduce one more prefix `main.consumer.` Makes sense. On Mon, Apr 2, 2018 at 11:06 AM, Matthias J. Sax wrote: > Boyang, > > thanks a lot for the KIP. > > Couple of questions: > > > (MODIFIED) public Map getRestoreConsumerConfigs(final > String

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Boyang, thanks a lot for the KIP. Couple of questions: > (MODIFIED) public Map getRestoreConsumerConfigs(final String > clientId); You mean that the implementation/semantics of this method changes, but not the API itself? Might be good to add this as "comment style" instead of

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Thanks for the KIP Boyang, the KIP looks good to me. For config values, we use underscore for keeping a single word; for config keys, though, we do not use underscores or dashes. I'd suggest using dots to be consistent with others. Otherwise I'm +1 on the KIP. Guozhang On Sun, Apr 1, 2018

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Looks good overall. public static final String RESTORE_CONSUMER_PREFIX = "restore-consumer."; For other constants in StreamsConfig, underscore is used instead of dash. Cheers On Sun, Apr 1, 2018 at 9:38 AM, Boyang Chen wrote: > Hey friends, > > > I would like to start a

[DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Hey friends, I would like to start a discussion thread for KIP 276: https://cwiki.apache.org/confluence/display/KAFKA/KIP-276+Add+StreamsConfig+prefix+for+different+consumers And pull request is here: https://github.com/apache/kafka/pull/4805