Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-09-03 Thread Matthias J. Sax
Thanks for the KIP. I was initially wondering if we need to add this into Kafka code base not. You could just go with a custom `Partitioner` implementation. The demand of KAFKA- seems not to be big actually. On the other hand, it might be a generic use case that justifies to add to Kafka

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-09-02 Thread M. Manna
Thanks for all your comments and taking it easy on me for my first KIP :) I am trying to check if it's okay for us to start a vote on this? As per some recent comment I'll change the name to RoundRobinPartitioner. I'll need to put some effort in writing Scala tests etc. since I'm a novice with

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-31 Thread M. Manna
Yes I’m more than happy to change it to a more appropriate name. The issue with RoundRobinPatitoner is that the DefaultPartitioner already has a Round-Robin associated to it. But if community doesn’t mind the name, I don’t either. Thanks for reading the KIP btw. Regards, On Fri, 31 Aug 2018 at

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread Magesh Nandakumar
+1 for this. The only small suggestion would be to possibly call this RondRobinPartitioner which makes the intent obvious. On Thu, Aug 30, 2018 at 5:31 PM Stephen Powis wrote: > Neat, this would be super helpful! I submitted this ages ago: > https://issues.apache.org/jira/browse/KAFKA- > >

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread Stephen Powis
Neat, this would be super helpful! I submitted this ages ago: https://issues.apache.org/jira/browse/KAFKA- On Fri, Aug 31, 2018 at 5:04 AM, Satish Duggana wrote: > +including both dev and user mailing lists. > > Hi, > Thanks for the KIP. > > "* For us, the message keys represent some

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread Satish Duggana
+including both dev and user mailing lists. Hi, Thanks for the KIP. "* For us, the message keys represent some metadata which we use to either ignore messages (if a loop-back to the sender), or log some information.*" Above statement was mentioned in the KIP about how key value is used. I guess

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread M. Manna
Hey Bill, Thanks for reading the KIP, much appreciated. The reason we want it to be a separate Partitioner is because: a) We don’t want to specify partition anywhere. b) we want to be able to reuse what’s been done for NULL key in DefaultPartitioner. Using the constructor means we need to

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread Bill Bejeck
Hi, NOTE: I sent this earlier, but that message just went to the dev list. I'm including both users and dev now. Thanks for the KIP. Have you considered using the overloaded ProducerRecord constructor where you can specify the partition? I mention this as an option as I encountered the same

Re: [DISCUSS] KIP-369: Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread Bill Bejeck
Hi, Thanks for the KIP. Have you considered using the overloaded ProducerRecord constructor where you can specify the partition? I mention this as an option as I encountered the same issue on a previous project and that is how we handled round-robin distribution with non-null keys. Would that

Re: [DISCUSS] KIP-369: Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread M. Manna
I just added you as a "Watcher". I can see the page via this link - https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070828 1) visited cwiki.apache.org 2) Opened "Apache Kafka" from Space Directory 3) Browsed to Kafka Improvement Proposals (or Design Proposals). 4) From the side

Re: [DISCUSS] KIP-369: Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread Eno Thereska
Hi there, I can't see this KIP on the KIP wiki, could you double check? Thanks Eno On Thu, Aug 30, 2018 at 9:56 AM, M. Manna wrote: > Hello, > > I opened a very simple KIP and there exists a JIRA for it. > > I have already sent it to users' list - but the mail thread doesn't seem to > get

[DISCUSS] KIP-369: Alternative Partitioner to Support "Always Round-Robin" Selection

2018-08-30 Thread M. Manna
Hello, I opened a very simple KIP and there exists a JIRA for it. I have already sent it to users' list - but the mail thread doesn't seem to get updated. I would be grateful if any comments are available for action. Regards,