Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

, Zhanxiang (Patrick) Huang From: Becket Qin Sent: Monday, November 12, 2018 21:56 To: Dong Lin Cc: dev Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation Hi Dong, That is a good point. But I think

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

st with stale broker epoch since the broker does not need >> and will not do anything for STALE_BROKER_EPOCH response. Thanks for >> pointing it out. >> >> Thanks, >> Zhanxiang (Patrick) Huang >> >> ________ >> From: Becket Qin

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

_ > From: Becket Qin > Sent: Monday, November 12, 2018 6:46 > To: dev > Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and > bounced brokers using broker generation > > Hi Patrick, > > I am wondering why the controller should send STALE_

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

. > > Thanks, > Zhanxiang (Patrick) Huang > > > From: Patrick Huang > Sent: Tuesday, October 23, 2018 6:20 > To: Jun Rao; dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and > bounced brokers using

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

> Thanks, > Zhanxiang (Patrick) Huang > > > From: Patrick Huang > Sent: Tuesday, October 23, 2018 6:20 > To: Jun Rao; dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and > bounced brokers using broker generation > > A

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

apache.org Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation Agreed. I have updated the PR to add czxid in ControlledShutdownRequest (https://github.com/apache/kafka/pull/5821). Appreciated if you can take a look. Btw, I also have the v

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

@%3Cdev.kafka.apache.org%3E Best, Zhanxiang (Patrick) Huang From: Jun Rao Sent: Monday, October 22, 2018 21:31 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation Hi, Patrick, Yes

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

--- > *From:* Jun Rao > *Sent:* Monday, October 22, 2018 14:45 > *To:* dev > *Subject:* Re: [DISCUSS] KIP-380: Detect outdated control requests and > bounced brokers using broker generation > > Hi, Patrick, > > There is another thing that may be worth considering. > >

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

, Zhanxiang (Patrick) Huang From: Jun Rao Sent: Monday, October 22, 2018 14:45 To: dev Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation Hi, Patrick, There is another thing that may be worth considering

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

fter the broker has come back up and > > re-registered > > > himself in ZK? > > > How will the Controller miss the restart, won't he subsequently receive > > > another ZK event saying that broker A has come back up? > > > Controller will not miss the BrokerChange ev

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

dy > joined > > the cluster by this time, controller will not know this broker has been > > bounced because it sees no diff between zk and its in-memory cache. So > > basically both of the BrokerChange event processing become no-op. > > > > > > Hope

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

From: Jun Rao Sent: Thursday, October 11, 2018 16:12 To: dev Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation Hi, Patrick, Thanks for the KIP. Looks good to me overall and very useful. A few comments below. 1. "will reject the req

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

nge event processing become no-op. > > > Hope that I answer your questions. Feel free to follow up if I am missing > something. > > > Thanks, > Zhanxiang (Patrick) Huang > > > From: Stanislav Kozlovski > Sent: Wednesday, October

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

stions. Feel free to follow up if I am missing something. Thanks, Zhanxiang (Patrick) Huang From: Stanislav Kozlovski Sent: Wednesday, October 10, 2018 7:22 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced b

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

Hi Patrick, Thanks for the KIP! Fixing such correctness issues is always very welcome - they're commonly hard to diagnose and debug when they happen in production. I was wondering if I understood the potential correctness issues correctly. Here is what I got: - If a broker bounces during

Re: [DISCUSS] KIP-380: Detect outdated control requests and bounced brokers using broker generation

Hey Patrick, Thanks much for the KIP. The KIP is very well written. LGTM. +1 (binding) Thanks, Dong On Tue, Oct 9, 2018 at 11:46 PM Patrick Huang wrote: > Hi All, > > Please find the below KIP which proposes the concept of broker generation > to resolve issues caused by controller missing