Re: [DISCUSS] KIP-547: Extend ConsumerInterceptor to allow modification of Consumer Commits

2020-01-13 Thread Eric Azama
bumping for any additional feedback. I'll open a vote thread in the next couple days if there aren't any additional comments. On Wed, Nov 20, 2019 at 10:45 PM Eric Azama wrote: > Hi Deng, > > It's similar to Record Headers in that the metadata isn't used within > Kafka itself. The intended

Re: [DISCUSS] KIP-547: Extend ConsumerInterceptor to allow modification of Consumer Commits

2019-11-20 Thread Eric Azama
Hi Deng, It's similar to Record Headers in that the metadata isn't used within Kafka itself. The intended purpose of the Metadata is to store additional information such as what application instance made the commit. Most of the value is going to be in giving organizations the ability to do things

Re: [DISCUSS] KIP-547: Extend ConsumerInterceptor to allow modification of Consumer Commits

2019-11-20 Thread deng ziming
Hi, Eric what's the use of this method? I reviewed the code and couldn't find much of the metadata's usage, and I find its usage trivial. On Tue, Nov 19, 2019 at 3:19 AM Eric Azama wrote: > Hi all, > > I'd like to open discussion on KIP-547: Extend ConsumerInterceptor to allow > modification of

[DISCUSS] KIP-547: Extend ConsumerInterceptor to allow modification of Consumer Commits

2019-11-18 Thread Eric Azama
Hi all, I'd like to open discussion on KIP-547: Extend ConsumerInterceptor to allow modification of Consumer Commits This KIP hopes to enable better access to the Metadata included while committing offsets. LINK: