Re: [DISCUSS] KIP-871: Fix ByteBufferSerializer#serialize(String, ByteBuffer) compatible problem

2022-09-27 Thread ShunKang Lin
Hi Guozhang, Thanks for your comments! I saw this Jira has been open for 5 years so I thought maybe a KIP was needed. I will discard this KIP now. Best, ShunKang Guozhang Wang 于2022年9月27日周二 06:27写道: > Hello ShunKang, > > Thanks for filing the report. I looked at the source code and I agree

Re: [DISCUSS] KIP-871: Fix ByteBufferSerializer#serialize(String, ByteBuffer) compatible problem

2022-09-26 Thread Guozhang Wang
Hello ShunKang, Thanks for filing the report. I looked at the source code and I agree it's a bug. The reason we did not get it in the past is probably just because we were inefficiently keep byte-copying and hence for almost all cases, the offset is set to 0 when serialization happens. Note that

[DISCUSS] KIP-871: Fix ByteBufferSerializer#serialize(String, ByteBuffer) compatible problem

2022-09-25 Thread ShunKang Lin
Hi all, I'd like to start a new discussion thread on KIP-871 (Kafka Client) which proposes that fix ByteBufferSerializer#serialize(String, ByteBuffer) compatible problem. Links: KIP: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495816 Jira: