How about also adding the path from which we loaded the connector (since
users run into issues where they are actually running a different connector
than they think they are running)?
If you think this is too complex or out of scope, no big deal. But it is a
"nice to have" feature.
On Sun, May
Nice. Thanks!
-Konstantine
On Sat, May 6, 2017 at 10:43 PM, dan wrote:
> thanks for the feedback, it all sounds good. i have made the changes to the
> pr and the kip.
>
> dan
>
> On Fri, May 5, 2017 at 9:29 AM, Konstantine Karantasis <
> konstant...@confluent.io> wrote:
thanks for the feedback, it all sounds good. i have made the changes to the
pr and the kip.
dan
On Fri, May 5, 2017 at 9:29 AM, Konstantine Karantasis <
konstant...@confluent.io> wrote:
> Thank you for the KIP. It's a nice improvement.
>
> Two small suggestions:
>
> 1) Let's not use all caps to
Thank you for the KIP. It's a nice improvement.
Two small suggestions:
1) Let's not use all caps to describe the type of the connector. "Source"
and "Sink" seem more appropriate (but even all lower case would be better).
2) It's been discussed in other contexts recently, but I believe finally
Both the proposal and PR look good to me.
-Ewen
On Tue, May 2, 2017 at 1:48 PM, dan wrote:
> hello.
>
> in an attempt to make the connect rest endpoints more useful i'd like to
> add the Connector type (Sink/Source) in our rest endpoints to make them
> more self
hello.
in an attempt to make the connect rest endpoints more useful i'd like to
add the Connector type (Sink/Source) in our rest endpoints to make them
more self descriptive.
KIP here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-151+Expose+Connector+type+in+REST+API
initial pr: