Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

2019-01-23 Thread Ewen Cheslack-Postava
+1 (binding) My only final comment would be that the topic.creation.enable setting could potentially be left out. We're still backwards compatible with what we promised before (or at least compatibility is debatable). You could enforce not being able to create topics with ACLs anyway, so avoiding

Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

2018-09-11 Thread Stephane Maarek
+1 (non binding) On Tue., 11 Sep. 2018, 10:48 am Mickael Maison, wrote: > +1 (non-binding) > Thanks for the KIP! > On Tue, Sep 11, 2018 at 8:40 AM McCaig, Rhys > wrote: > > > > Looks great Randall > > +1 (non-binding) > > > > > On Sep 9, 2018, at 7:17 PM, Gwen Shapira wrote: > > > > > > +1 >

Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

2018-09-11 Thread Mickael Maison
+1 (non-binding) Thanks for the KIP! On Tue, Sep 11, 2018 at 8:40 AM McCaig, Rhys wrote: > > Looks great Randall > +1 (non-binding) > > > On Sep 9, 2018, at 7:17 PM, Gwen Shapira wrote: > > > > +1 > > Useful improvement, thanks Randall. > > > > > > On Fri, Sep 7, 2018, 3:28 PM Randall Hauch

Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

2018-09-11 Thread McCaig, Rhys
Looks great Randall +1 (non-binding) > On Sep 9, 2018, at 7:17 PM, Gwen Shapira wrote: > > +1 > Useful improvement, thanks Randall. > > > On Fri, Sep 7, 2018, 3:28 PM Randall Hauch wrote: > >> I believe the feedback on KIP-158 has been addressed. I'd like to start a >> vote. >> >> KIP: >>