Re: [VOTE] KIP-16: Replica Lag Tuning

2015-03-15 Thread Joe Stein
+1 one more minor nit, please update the KIP with the link to the discuss thread too. ~ Joe Stein - - - - - - - - - - - - - - - - - http://www.stealth.ly - - - - - - - - - - - - - - - - - On Sun, Mar 15, 2015 at 5:27 PM, Neha Narkhede n...@confluent.io wrote: +1 on the KIP. Minor nit: it

Re: [VOTE] KIP-16: Replica Lag Tuning

2015-03-15 Thread Neha Narkhede
+1 on the KIP. Minor nit: it is deemed to not be in ISR because it is not caught up = it is deemed to not be in the ISR because it has fallen behind for more than a certain amount of time as controlled by this config Also took a look at the patch. Looks correct, left review comments. Thanks for

Re: [VOTE] KIP-16: Replica Lag Tuning

2015-03-15 Thread Guozhang Wang
+1 on the KIP. On Sun, Mar 15, 2015 at 2:56 PM, Joe Stein joe.st...@stealth.ly wrote: +1 one more minor nit, please update the KIP with the link to the discuss thread too. ~ Joe Stein - - - - - - - - - - - - - - - - - http://www.stealth.ly - - - - - - - - - - - - - - - - - On Sun,

Re: [VOTE] KIP-16: Replica Lag Tuning

2015-03-15 Thread Jun Rao
+1 on the approach. Much better than before. Thanks, Jun On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar aaurad...@linkedin.com.invalid wrote: Details in the KIP, Jira and RB. https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning

RE: [VOTE] KIP-16: Replica Lag Tuning

2015-03-15 Thread Aditya Auradkar
Thanks. We have 5 binding +1s. I'll update the KIP with your comments and mark as accepted. Aditya From: Jun Rao [j...@confluent.io] Sent: Sunday, March 15, 2015 8:41 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-16: Replica Lag Tuning +1

RE: [VOTE] KIP-16: Replica Lag Tuning

2015-03-15 Thread Aditya Auradkar
Rather, 6 binding +1's. Aditya From: Aditya Auradkar Sent: Sunday, March 15, 2015 10:39 PM To: dev@kafka.apache.org Subject: RE: [VOTE] KIP-16: Replica Lag Tuning Thanks. We have 5 binding +1s. I'll update the KIP with your comments and mark as accepted

Re: [VOTE] KIP-16: Replica Lag Tuning

2015-03-14 Thread Jay Kreps
+1 -Jay On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar aaurad...@linkedin.com.invalid wrote: Details in the KIP, Jira and RB. https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning https://issues.apache.org/jira/browse/KAFKA-1546

Re: [VOTE] KIP-16: Replica Lag Tuning

2015-03-13 Thread Joel Koshy
+1 on the KIP On Fri, Mar 13, 2015 at 04:54:04PM +, Aditya Auradkar wrote: Details in the KIP, Jira and RB. https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning https://issues.apache.org/jira/browse/KAFKA-1546 https://reviews.apache.org/r/31967/

[VOTE] KIP-16: Replica Lag Tuning

2015-03-13 Thread Aditya Auradkar
Details in the KIP, Jira and RB. https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning https://issues.apache.org/jira/browse/KAFKA-1546 https://reviews.apache.org/r/31967/ Aditya