Re: [VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-21 Thread Colin McCabe
Hmm, do we still need one more binding +1, or did I misread the vote thread? +1 (non-binding) from me. As I posted in the other thread, I think it would make sense to name the new ZK hierarchy /kafka-prefix-acls or similar, to reflect the fact that they are ACLs that match by a name prefix. Th

Re: [VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-21 Thread Piyush Vijay
Thanks for the +1s. I'll send out a PR shortly. Thanks Piyush Vijay On Mon, May 21, 2018 at 8:59 AM, Guozhang Wang wrote: > Thanks for the KIP, +1 from me (binding). > > > Guozhang > > On Mon, May 21, 2018 at 5:22 AM, Damian Guy wrote: > > > +1 (binding) > > > > On Sat, 19 May 2018 at 03:51

Re: [VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-21 Thread Guozhang Wang
Thanks for the KIP, +1 from me (binding). Guozhang On Mon, May 21, 2018 at 5:22 AM, Damian Guy wrote: > +1 (binding) > > On Sat, 19 May 2018 at 03:51 Piyush Vijay wrote: > > > Hi everyone, > > > > I would like to start a vote for > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-

Re: [VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-21 Thread Damian Guy
+1 (binding) On Sat, 19 May 2018 at 03:51 Piyush Vijay wrote: > Hi everyone, > > I would like to start a vote for > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-290%3A+Support+for+wildcard+suffixed+ACLs > . > > The KIP proposes a way to support wildcard-suffixed resource names in Kafk

Re: [VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-19 Thread Piyush Vijay
Hi Ron, I've incorporated both of your suggestions. Thanks Piyush Vijay On Sat, May 19, 2018 at 4:07 AM, Ron Dagostino wrote: > Hi Piyush. I think it would be better to match the flag in kafka-acls.sh > to the new enum. Instead of stating “–wildcard-suffixed-resource true” I > think “–reso

Re: [VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-19 Thread Ron Dagostino
Hi Piyush. I think it would be better to match the flag in kafka-acls.sh to the new enum. Instead of stating “–wildcard-suffixed-resource true” I think “–resource-type wildcard” is much better because it allows support for new enum constants that might be added in the future via the same flag.

[VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-18 Thread Piyush Vijay
Hi everyone, I would like to start a vote for https://cwiki.apache.org/ confluence/display/KAFKA/KIP-290%3A+Support+for+wildcard+suffixed+ACLs. The KIP proposes a way to support wildcard-suffixed resource names in Kafka ACLs. The main challenge was to support it in a backward compatible way beca

[VOTE] KIP-290: Support for wildcard suffixed ACLs

2018-05-18 Thread Piyush Vijay
Hi everyone, I would like to start a vote for https://cwiki.apache.org/confluence/display/KAFKA/KIP-290%3A+Support+for+wildcard+suffixed+ACLs . The KIP proposes a way to support wildcard-suffixed resource names in Kafka ACLs. The main challenge was to support it in a backward compatible way beca