Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-28 Thread John Roesler
Thanks for voting, everyone. KIP-319 has passed with 3 binding (Guozhang, Matthias, Damian) and 3 non-binding votes (Ted, Bill, and me!). If you wish to review the implementation, I plan to build on the draft PR: https://github.com/apache/kafka/pull/5257 Thanks again, -John On Thu, Jun 28,

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-28 Thread Damian Guy
+1 On Tue, 26 Jun 2018 at 17:22 Bill Bejeck wrote: > +1 > > On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax > wrote: > > > +1 (binding) > > > > On 6/25/18 3:00 PM, Guozhang Wang wrote: > > > +1 > > > > > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu wrote: > > > > > >> +1 > > >> > > >> On Mon,

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-26 Thread Bill Bejeck
+1 On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax wrote: > +1 (binding) > > On 6/25/18 3:00 PM, Guozhang Wang wrote: > > +1 > > > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu wrote: > > > >> +1 > >> > >> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler > wrote: > >> > >>> Hello All, > >>> > >>>

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-25 Thread Matthias J. Sax
+1 (binding) On 6/25/18 3:00 PM, Guozhang Wang wrote: > +1 > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu wrote: > >> +1 >> >> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler wrote: >> >>> Hello All, >>> >>> Thanks for the discussion on KIP-319. I'd now like to start the voting. >>> >>> As a

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-25 Thread Guozhang Wang
+1 On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu wrote: > +1 > > On Mon, Jun 25, 2018 at 2:56 PM, John Roesler wrote: > > > Hello All, > > > > Thanks for the discussion on KIP-319. I'd now like to start the voting. > > > > As a reminder, KIP-319 proposes a fix to an issue I identified in > >

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-25 Thread Ted Yu
+1 On Mon, Jun 25, 2018 at 2:56 PM, John Roesler wrote: > Hello All, > > Thanks for the discussion on KIP-319. I'd now like to start the voting. > > As a reminder, KIP-319 proposes a fix to an issue I identified in > KAFKA-7080. Specifically, the issue is that we're creating >

[VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

2018-06-25 Thread John Roesler
Hello All, Thanks for the discussion on KIP-319. I'd now like to start the voting. As a reminder, KIP-319 proposes a fix to an issue I identified in KAFKA-7080. Specifically, the issue is that we're creating CachingWindowStore with the *number of segments* instead of the *segment size*. Here's