Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-20 Thread Chia-Ping Tsai
Thanks for all votes. KIP-367 has passed!!! binding votes (3) : Matthias J. Sax Harsha Jason Gustafson non-binding votes (6): Dongjin Lee Manikumar Mickael Maison vito jeng Colin McCabe Bill Bejeck Cheers, Chia-Ping On 2018/09/08 18:27:59, Chia-Ping Tsai wrote: > Hi All, > > I'd like to put

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-19 Thread Jason Gustafson
+1 Thanks for the KIP On Fri, Sep 14, 2018 at 10:24 PM, Colin McCabe wrote: > +1 (non-binding). > > Thanks, Chia-Ping. > > best, > > > On Fri, Sep 14, 2018, at 21:01, Chia-Ping Tsai wrote: > > hi Colin > > > > > I like the idea of having a close(Duration) call. I would rather keep > the

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-14 Thread Colin McCabe
+1 (non-binding). Thanks, Chia-Ping. best, On Fri, Sep 14, 2018, at 21:01, Chia-Ping Tsai wrote: > hi Colin > > > I like the idea of having a close(Duration) call. I would rather keep the > > existing close(long, TimeUnit) call to avoid breaking compatibility, > > however. Does the KIP

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-14 Thread Chia-Ping Tsai
hi Colin > I like the idea of having a close(Duration) call. I would rather keep the > existing close(long, TimeUnit) call to avoid breaking compatibility, however. > Does the KIP specify keeping the old overload? I can't seem to access the > wiki now. As Ismael said. All existing

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-14 Thread Ismael Juma
Yeah, but it suggests deprecating the old method. Ismael On Fri, Sep 14, 2018 at 2:06 PM Colin McCabe wrote: > Hi Chia-Ping, > > I like the idea of having a close(Duration) call. I would rather keep the > existing close(long, TimeUnit) call to avoid breaking compatibility, > however. Does

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-14 Thread Colin McCabe
Hi Chia-Ping, I like the idea of having a close(Duration) call. I would rather keep the existing close(long, TimeUnit) call to avoid breaking compatibility, however. Does the KIP specify keeping the old overload? I can't seem to access the wiki now. best, Colin On Sat, Sep 8, 2018, at

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-13 Thread Bill Bejeck
+1 -Bill On Thu, Sep 13, 2018 at 4:44 AM Mickael Maison wrote: > +1 (non-binding) > Thanks! > On Thu, Sep 13, 2018 at 7:05 AM Manikumar > wrote: > > > > +1 (non-binding) > > > > Thanks for the KIP. > > > > On Thu, Sep 13, 2018 at 10:38 AM Harsha wrote: > > > > > +1 (Binding). > > > Thanks, >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-13 Thread Mickael Maison
+1 (non-binding) Thanks! On Thu, Sep 13, 2018 at 7:05 AM Manikumar wrote: > > +1 (non-binding) > > Thanks for the KIP. > > On Thu, Sep 13, 2018 at 10:38 AM Harsha wrote: > > > +1 (Binding). > > Thanks, > > Harsha > > > > On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote: > > > +1 > > > > > > > >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-13 Thread Manikumar
+1 (non-binding) Thanks for the KIP. On Thu, Sep 13, 2018 at 10:38 AM Harsha wrote: > +1 (Binding). > Thanks, > Harsha > > On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote: > > +1 > > > > > > > > --- > > Vito > > > > On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee wrote: > > > > > +1.

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-12 Thread Harsha
+1 (Binding). Thanks, Harsha On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote: > +1 > > > > --- > Vito > > On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee wrote: > > > +1. (Non-binding) > > > > On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax > > wrote: > > > > > Thanks a lot for the KIP. > >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-12 Thread vito jeng
+1 --- Vito On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee wrote: > +1. (Non-binding) > > On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax > wrote: > > > Thanks a lot for the KIP. > > > > +1 (binding) > > > > > > -Matthias > > > > > > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote: > > > Hi All, > >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-10 Thread Dongjin Lee
+1. (Non-binding) On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax wrote: > Thanks a lot for the KIP. > > +1 (binding) > > > -Matthias > > > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote: > > Hi All, > > > > I'd like to put KIP-367 to the vote. > > > > >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-09 Thread Matthias J. Sax
Thanks a lot for the KIP. +1 (binding) -Matthias On 9/8/18 11:27 AM, Chia-Ping Tsai wrote: > Hi All, > > I'd like to put KIP-367 to the vote. > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496 > > -- > Chia-Ping > signature.asc Description: OpenPGP digital

[VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-08 Thread Chia-Ping Tsai
Hi All, I'd like to put KIP-367 to the vote. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496 -- Chia-Ping