Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-06-03 Thread David Arthur
The vote for this KIP passes with the following results: * Three binding +1 votes from Colin, Guozhang, and Jason * Two non-binding +1 votes from Jose and Boyang * No +0 or -1 votes Thanks, everyone! -David On Tue, Jun 2, 2020 at 8:56 PM Jason Gustafson wrote: > +1 I agree with Guozhang that

Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-06-02 Thread Jason Gustafson
+1 I agree with Guozhang that broker epoch will need a separate discussion. Thanks! Jason On Thu, May 28, 2020 at 9:34 AM Guozhang Wang wrote: > David, thanks for the KIP. I'm +1 on it as well. > > One note is that in post-ZK world, we would need a different way to get > broker epoch since it i

Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-05-28 Thread Guozhang Wang
David, thanks for the KIP. I'm +1 on it as well. One note is that in post-ZK world, we would need a different way to get broker epoch since it is updated as ZKversion today. I believe we would have this discussion in a different KIP though. Guozhang On Wed, May 27, 2020 at 8:26 PM Colin McCabe

Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-05-27 Thread Colin McCabe
Thanks, David. +1 (binding). cheers, Colin On Wed, May 27, 2020, at 18:21, David Arthur wrote: > Colin, thanks for the feedback. Good points. I've updated the KIP with your > suggestions. > > -David > > On Wed, May 27, 2020 at 4:05 PM Colin McCabe wrote: > > > Hi David, > > > > Thanks for th

Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-05-27 Thread David Arthur
Colin, thanks for the feedback. Good points. I've updated the KIP with your suggestions. -David On Wed, May 27, 2020 at 4:05 PM Colin McCabe wrote: > Hi David, > > Thanks for the KIP! > > The KIP refers to "the KIP-500 bridge release (version 2.6.0 as of the > time of this proposal)". This is

Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-05-27 Thread Colin McCabe
Hi David, Thanks for the KIP! The KIP refers to "the KIP-500 bridge release (version 2.6.0 as of the time of this proposal)". This is out of date-- the bridge release will be one of the 3.x releases. We should either update this to 3.0, or perhaps just take out the reference to a specific v

Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-05-27 Thread Boyang Chen
Thanks David, +1 (non-binding). On Thu, May 21, 2020 at 12:17 PM Jose Garcia Sancio wrote: > +1. LGTM David! > > On Wed, May 20, 2020 at 12:22 PM David Arthur wrote: > > > > Hello, all. I'd like to start the vote for KIP-589 which proposes to add > a > > new AlterReplicaState RPC. > > > > > htt

Re: [VOTE] KIP-589: Add API to update Replica state in Controller

2020-05-21 Thread Jose Garcia Sancio
+1. LGTM David! On Wed, May 20, 2020 at 12:22 PM David Arthur wrote: > > Hello, all. I'd like to start the vote for KIP-589 which proposes to add a > new AlterReplicaState RPC. > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-589+Add+API+to+update+Replica+state+in+Controller > > Cheers,

[VOTE] KIP-589: Add API to update Replica state in Controller

2020-05-20 Thread David Arthur
Hello, all. I'd like to start the vote for KIP-589 which proposes to add a new AlterReplicaState RPC. https://cwiki.apache.org/confluence/display/KAFKA/KIP-589+Add+API+to+update+Replica+state+in+Controller Cheers, David