Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-11 Thread David Arthur
Closing this vote. With four binding +1s and zero -1s, this vote passes. Binding +1: * David Arthur * Guozhang Wang * Tom Bentley * Colin McCabe Non-binding +1: * Ron Dagostino Thanks everyone! David On Tue, May 11, 2021 at 1:07 PM Colin McCabe wrote: > Thanks, David. I don't feel strongly

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-11 Thread Colin McCabe
Thanks, David. I don't feel strongly about preserving the extra records in the snapshot, so let's just leave it as is. +1 (binding) cheers, Colin On Fri, May 7, 2021, at 09:51, David Arthur wrote: > Colin, thanks for the feedback. I like the record name you proposed. I've > also updated the

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-07 Thread David Arthur
Colin, thanks for the feedback. I like the record name you proposed. I've also updated the first paragraph in the Controller section to: In both ZK and KRaft modes, the controller will now be responsible for > generating new blocks of IDs and persisting the latest generated block. In > ZK mode,

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Colin McCabe
Sorry, I meant to write "AllocateProducerIdsRecord" in the previous message. -C. On Thu, May 6, 2021, at 12:58, Colin McCabe wrote: > Hi David, > > Thanks for the KIP -- it looks good. > > It seems like we should be clear that the new RPC should be used for > both the ZK and KRaft cases. I

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Colin McCabe
Hi David, Thanks for the KIP -- it looks good. It seems like we should be clear that the new RPC should be used for both the ZK and KRaft cases. I think that is implied, but it would be good to spell it out just to be clear. As the KIP explains, this is needed for the bridge release. I

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Tom Bentley
Hi David, Thanks for the KIP, +1 binding. Tom On Thu, May 6, 2021 at 7:16 PM Guozhang Wang wrote: > LGTM! Thanks David. > > On Thu, May 6, 2021 at 10:03 AM Ron Dagostino wrote: > > > Thanks again for the KIP, David. +1 (non-binding) from me. > > > > Ron > > > > On Tue, May 4, 2021 at 11:21

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Guozhang Wang
LGTM! Thanks David. On Thu, May 6, 2021 at 10:03 AM Ron Dagostino wrote: > Thanks again for the KIP, David. +1 (non-binding) from me. > > Ron > > On Tue, May 4, 2021 at 11:21 AM David Arthur wrote: > > > Hello everyone, I'd like to start the vote on KIP-730 which adds a new > RPC > > for

Re: [VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-06 Thread Ron Dagostino
Thanks again for the KIP, David. +1 (non-binding) from me. Ron On Tue, May 4, 2021 at 11:21 AM David Arthur wrote: > Hello everyone, I'd like to start the vote on KIP-730 which adds a new RPC > for producer ID generation in KRaft mode. > > >

[VOTE] KIP-730: Producer ID generation in KRaft mode

2021-05-04 Thread David Arthur
Hello everyone, I'd like to start the vote on KIP-730 which adds a new RPC for producer ID generation in KRaft mode. https://cwiki.apache.org/confluence/display/KAFKA/KIP-730%3A+Producer+ID+generation+in+KRaft+mode -- David Arthur