Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-18 Thread Kirk True
Hi all, With four binding +1 votes (Manikumar Reddy, Rajini Sivaram, David Jacot, and Ismael Juma) and one non-binding +1 vote (Ron Dagostino), the vote passes. Thanks everyone! Kirk On Fri, Oct 15, 2021, at 10:40 AM, Ismael Juma wrote: > Thanks Kirk, I'm overall +1 (binding). I think the

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-15 Thread Ismael Juma
Thanks Kirk, I'm overall +1 (binding). I think the timeouts may need a bit of tweaking still. We can update the KIP and the thread if we decide to do that as part of the PR review. Ismael On Thu, Oct 14, 2021 at 11:59 AM Kirk True wrote: > Hi Ismael, > > Thanks for reviewing the KIP. I've made

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-14 Thread Kirk True
Hi Ismael, Thanks for reviewing the KIP. I've made a first pass at updating based on your feedback. Questions/comments inline... On Thu, Oct 14, 2021, at 6:20 AM, Ismael Juma wrote: > Hi Kirk, > > Thanks for the KIP. It looks good overall to me. A few nits: > > 1. "sasl.login.retry.wait.ms":

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-14 Thread Ismael Juma
Hi Kirk, Thanks for the KIP. It looks good overall to me. A few nits: 1. "sasl.login.retry.wait.ms": these configs are typically called `backoff` in Kafka. For example "retry.backoff.ms". The default for `retry.backoff.ms` is 100ms. Is there a reason why we are using a different value for this

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-14 Thread David Jacot
+1 (binding). Thanks for the KIP! On Fri, Oct 8, 2021 at 10:54 AM Rajini Sivaram wrote: > +1 (binding) > Thanks for the KIP, Kirk! > > Regards, > > Rajini > > > On Thu, Sep 30, 2021 at 12:33 PM Manikumar > wrote: > > > Hi Kirk, > > > > Thanks for the KIP! > > > > +1 (binding) > > > > > >

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-08 Thread Rajini Sivaram
+1 (binding) Thanks for the KIP, Kirk! Regards, Rajini On Thu, Sep 30, 2021 at 12:33 PM Manikumar wrote: > Hi Kirk, > > Thanks for the KIP! > > +1 (binding) > > > Thanks, > Manikumar > > On Mon, Sep 27, 2021 at 10:50 PM Kirk True wrote: > > > Hi all! > > > > I'd like to start a vote for

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-30 Thread Manikumar
Hi Kirk, Thanks for the KIP! +1 (binding) Thanks, Manikumar On Mon, Sep 27, 2021 at 10:50 PM Kirk True wrote: > Hi all! > > I'd like to start a vote for KIP-768 that allows Kafka to connect to an > OAuth/OIDC identity provider for authentication and token retrieval: > > >

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-27 Thread Kirk True
Hi Ron, On Mon, Sep 27, 2021, at 10:47 AM, Ron Dagostino wrote: > Hi Kirk -- thanks again for the KIP! +1 (non-binding) from me. > > A minor issues I just spotted: > > >- subClaimName: optional override name of the sub claim; defaults to >scope > > > s/defaults to scope/defaults to

Re: [VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-27 Thread Ron Dagostino
Hi Kirk -- thanks again for the KIP! +1 (non-binding) from me. A minor issues I just spotted: - subClaimName: optional override name of the sub claim; defaults to scope s/defaults to scope/defaults to sub/ Ron On Mon, Sep 27, 2021 at 1:20 PM Kirk True wrote: > Hi all! > > I'd

[VOTE] KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-09-27 Thread Kirk True
Hi all! I'd like to start a vote for KIP-768 that allows Kafka to connect to an OAuth/OIDC identity provider for authentication and token retrieval: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186877575 Thanks! Kirk