Re: [VOTE] KIP-954: expand default DSL store configuration to custom types

2023-07-31 Thread Almog Gavra
Thanks everyone! Marking this KIP as accepted with +1s from Bruno, John & Guozhang. @Bruno, yes I think that's a great idea! I was going to update the KIP but missed that part, I'll do it now as I assume that's not controversial. Cheers, Almog On Mon, Jul 31, 2023 at 1:47 AM Bruno Cadonna

Re: [VOTE] KIP-954: expand default DSL store configuration to custom types

2023-07-31 Thread Bruno Cadonna
Hi Almog, +1 (binding) Last question: Did you consider to let interface DslStoreSuppliers extend Configurable? Thanks, Bruno On 7/30/23 5:53 AM, John Roesler wrote: Thanks for the KIP, Almog! I'm +1 (binding) I've reviewed the KIP and skimmed the discussion thread. I think this is going

Re: [VOTE] KIP-954: expand default DSL store configuration to custom types

2023-07-29 Thread John Roesler
Thanks for the KIP, Almog! I'm +1 (binding) I've reviewed the KIP and skimmed the discussion thread. I think this is going to be a very nice improvement. Thanks, -John On Sat, Jul 29, 2023, at 13:26, Guozhang Wang wrote: > Thanks Almog! I made a pass over the updated wiki and have no more

Re: [VOTE] KIP-954: expand default DSL store configuration to custom types

2023-07-29 Thread Guozhang Wang
Thanks Almog! I made a pass over the updated wiki and have no more questions. +1 Guozhang On Wed, Jul 26, 2023 at 8:14 AM Almog Gavra wrote: > > Hello Everyone, > > Opening the voting for KIP-954. The discussion is converging, but please > feel free to chime in on the last few conversation

[VOTE] KIP-954: expand default DSL store configuration to custom types

2023-07-26 Thread Almog Gavra
Hello Everyone, Opening the voting for KIP-954. The discussion is converging, but please feel free to chime in on the last few conversation points if you aren't happy with where it settled.