[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049123#comment-14049123
]
Jun Rao commented on KAFKA-1308:
Jakob,
Do you plan to commit the patch to trunk too?
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049520#comment-14049520
]
Jakob Homan commented on KAFKA-1308:
Yes, had a merge conflict when I went to do so;
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042455#comment-14042455
]
Neha Narkhede commented on KAFKA-1308:
--
+1 on KAFKA-1308-v2.patch. Thanks Jakob!
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042700#comment-14042700
]
Jakob Homan commented on KAFKA-1308:
We're still blocked on the Samza release even
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042744#comment-14042744
]
Joe Stein commented on KAFKA-1308:
--
I am +1 to Jakob's suggestion and I can do this in a
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042749#comment-14042749
]
Joe Stein commented on KAFKA-1308:
--
which patch(s) would apply to the 0.8.1.1 tag?
it
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042755#comment-14042755
]
Neha Narkhede commented on KAFKA-1308:
--
I'm also +1 on Jakob's suggestion. Joe,
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042775#comment-14042775
]
Jakob Homan commented on KAFKA-1308:
Yes, just KAFKA-1308-2.patch (and then manually
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042776#comment-14042776
]
Jakob Homan commented on KAFKA-1308:
If no one is opposed, I'll go ahead and do it
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042804#comment-14042804
]
Joe Stein commented on KAFKA-1308:
--
Sounds good, I will wait for the commit to the 0.8.1
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042818#comment-14042818
]
Jakob Homan commented on KAFKA-1308:
I've committed this to 0.8.1. I had already
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039246#comment-14039246
]
Jakob Homan commented on KAFKA-1308:
Yes, we need the pom.
Publish jar of test
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037468#comment-14037468
]
Chris Campbell commented on KAFKA-1308:
---
For what its worth, the main reason I
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038469#comment-14038469
]
Jakob Homan commented on KAFKA-1308:
The patches are identical, just slight differing
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038473#comment-14038473
]
Jakob Homan commented on KAFKA-1308:
rb: https://reviews.apache.org/r/22802/
Publish
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14035969#comment-14035969
]
Ivan Lyutov commented on KAFKA-1308:
+1
Patch looks nice. It might be very useful.
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036961#comment-14036961
]
Jun Rao commented on KAFKA-1308:
Thanks for the patch. I am not sure if it's worthwhile to
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994880#comment-13994880
]
Mikael Högqvist commented on KAFKA-1308:
+1
TestUtils are very useful for us as
18 matches
Mail list logo