[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122243#comment-14122243
]
Joel Koshy commented on KAFKA-1510:
---
[~nmarasoi] Your patch looks good to me - however,
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118294#comment-14118294
]
nicu marasoiu commented on KAFKA-1510:
--
[~jjkoshy] Hi, can you check my patch +
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114244#comment-14114244
]
nicu marasoiu commented on KAFKA-1510:
--
Hi, I will do this tomorrow, Friday, so I
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108852#comment-14108852
]
Joel Koshy commented on KAFKA-1510:
---
[~nmarasoi] do you think you will have time to wrap
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108857#comment-14108857
]
Nicolae Marasoiu commented on KAFKA-1510:
-
Hi, I will attach a patch with
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109432#comment-14109432
]
Joel Koshy commented on KAFKA-1510:
---
[~nmarasoi] that's right - whenever storage=kafka,
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101929#comment-14101929
]
Joel Koshy commented on KAFKA-1510:
---
[~nmarasoi] can you update your patch to do
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099423#comment-14099423
]
Jun Rao commented on KAFKA-1510:
Yes, I agree that always do unfiltered commits when
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095940#comment-14095940
]
Joel Koshy commented on KAFKA-1510:
---
After some discussion with [~guozhang] and
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092205#comment-14092205
]
Jun Rao commented on KAFKA-1510:
Thinking about this a bit more, would it be more reliable
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091100#comment-14091100
]
Joel Koshy commented on KAFKA-1510:
---
[~nmarasoi] I realized later there is actually a
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091103#comment-14091103
]
Joel Koshy commented on KAFKA-1510:
---
Would you be able to update your patch to take into
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083541#comment-14083541
]
Nicolae Marasoiu commented on KAFKA-1510:
-
Where is the indefinite retry you
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083551#comment-14083551
]
nicu marasoiu commented on KAFKA-1510:
--
Hi,
I have given it more consideration, and
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083878#comment-14083878
]
nicu marasoiu commented on KAFKA-1510:
--
re-uploaded the patch
Force offset commits
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082166#comment-14082166
]
nicu marasoiu commented on KAFKA-1510:
--
Hi, the || forceCommit on line 318 is meant
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083237#comment-14083237
]
Joel Koshy commented on KAFKA-1510:
---
I see - my thinking was since we retry indefinitely
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081781#comment-14081781
]
Joel Koshy commented on KAFKA-1510:
---
Re: isAutoCommit:
Yes you are right. Can you fix
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079219#comment-14079219
]
nicu marasoiu commented on KAFKA-1510:
--
[~jkreps] Hi, can you please help me with
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080164#comment-14080164
]
Joel Koshy commented on KAFKA-1510:
---
[~nmarasoi] - sure thing. Will get back to you on
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078904#comment-14078904
]
nicu marasoiu commented on KAFKA-1510:
--
[~jjkoshy] Can you please take a look at my
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075447#comment-14075447
]
nicu marasoiu commented on KAFKA-1510:
--
Hi,
I am confused. Let me state some
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075473#comment-14075473
]
nicu marasoiu commented on KAFKA-1510:
--
forcing all to zk too does indeed have the
[
https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072437#comment-14072437
]
Joel Koshy commented on KAFKA-1510:
---
[~nmarasoiu] do you think you will be able to take
24 matches
Mail list logo