[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-09-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122243#comment-14122243 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] Your patch looks good to me - however,

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-09-02 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118294#comment-14118294 ] nicu marasoiu commented on KAFKA-1510: -- [~jjkoshy] Hi, can you check my patch +

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-28 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114244#comment-14114244 ] nicu marasoiu commented on KAFKA-1510: -- Hi, I will do this tomorrow, Friday, so I

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108852#comment-14108852 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] do you think you will have time to wrap

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-25 Thread Nicolae Marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108857#comment-14108857 ] Nicolae Marasoiu commented on KAFKA-1510: - Hi, I will attach a patch with

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109432#comment-14109432 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] that's right - whenever storage=kafka,

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101929#comment-14101929 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] can you update your patch to do

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099423#comment-14099423 ] Jun Rao commented on KAFKA-1510: Yes, I agree that always do unfiltered commits when

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095940#comment-14095940 ] Joel Koshy commented on KAFKA-1510: --- After some discussion with [~guozhang] and

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092205#comment-14092205 ] Jun Rao commented on KAFKA-1510: Thinking about this a bit more, would it be more reliable

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091100#comment-14091100 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] I realized later there is actually a

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091103#comment-14091103 ] Joel Koshy commented on KAFKA-1510: --- Would you be able to update your patch to take into

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-02 Thread Nicolae Marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083541#comment-14083541 ] Nicolae Marasoiu commented on KAFKA-1510: - Where is the indefinite retry you

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-02 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083551#comment-14083551 ] nicu marasoiu commented on KAFKA-1510: -- Hi, I have given it more consideration, and

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-02 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083878#comment-14083878 ] nicu marasoiu commented on KAFKA-1510: -- re-uploaded the patch Force offset commits

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-01 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082166#comment-14082166 ] nicu marasoiu commented on KAFKA-1510: -- Hi, the || forceCommit on line 318 is meant

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-01 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083237#comment-14083237 ] Joel Koshy commented on KAFKA-1510: --- I see - my thinking was since we retry indefinitely

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081781#comment-14081781 ] Joel Koshy commented on KAFKA-1510: --- Re: isAutoCommit: Yes you are right. Can you fix

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-30 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079219#comment-14079219 ] nicu marasoiu commented on KAFKA-1510: -- [~jkreps] Hi, can you please help me with

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080164#comment-14080164 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] - sure thing. Will get back to you on

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-29 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078904#comment-14078904 ] nicu marasoiu commented on KAFKA-1510: -- [~jjkoshy] Can you please take a look at my

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-26 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075447#comment-14075447 ] nicu marasoiu commented on KAFKA-1510: -- Hi, I am confused. Let me state some

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-26 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075473#comment-14075473 ] nicu marasoiu commented on KAFKA-1510: -- forcing all to zk too does indeed have the

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072437#comment-14072437 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoiu] do you think you will be able to take