[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151550#comment-14151550 ] BalajiSeshadri commented on KAFKA-1618: --- [~nehanarkhede] and [~junrao],please veriify. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Priority: Blocker Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL-VERSION.patch, KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151552#comment-14151552 ] BalajiSeshadri commented on KAFKA-1618: --- http://www.scala-lang.org/api/2.9.1/#scala.util.matching.Regex http://www.scala-lang.org/api/2.10.1/#scala.util.matching.Regex Verified in both documentation.Couldnot compile Scala 2.9.1 because of some other issue, * What went wrong: Execution failed for task ':core:compileScala'. com.typesafe.zinc.Setup.create(Lcom/typesafe/zinc/ScalaLocation;Lcom/typesafe/zinc/SbtJars;Ljava/io/File;)Lcom/typesafe/zinc/Setup; Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Priority: Blocker Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL-VERSION.patch, KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151940#comment-14151940 ] Jun Rao commented on KAFKA-1618: Thanks for the patch. That fixes the compilation issue. However, we recently added code to parse ipv6 addresses properly in broker list. I am wondering if you could just reuse org.apache.kafka.common.utils.getPort() in ToolsUtils? Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Priority: Blocker Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL-VERSION.patch, KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152033#comment-14152033 ] BalajiSeshadri commented on KAFKA-1618: --- [~junrao] Normally core is used by client right,in our getPort case client is being used by core,is that right dependency ?. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Priority: Blocker Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL-VERSION.patch, KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REUSED-UTILS.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152435#comment-14152435 ] BalajiSeshadri commented on KAFKA-1618: --- Thanks a lot [~junrao] Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Priority: Blocker Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL-VERSION.patch, KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REUSED-UTILS.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150114#comment-14150114 ] Neha Narkhede commented on KAFKA-1618: -- +1 on your latest patch! Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150350#comment-14150350 ] BalajiSeshadri commented on KAFKA-1618: --- [~nehanarkhede] Thanks a lot. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[
https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148024#comment-14148024
]
Neha Narkhede commented on KAFKA-1618:
--
[~balaji.sesha...@dish.com] I ran into issues applying the patch again. Would
you mind following the Contributor workflow in our wiki -
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review#Patchsubmissionandreview-Simplecontributorworkflow
{noformat}
nnarkhed-mn1:kafka-git-idea nnarkhed$ git apply --check
KAFKA-1618-REBASED.patch
error: src/main/scala/kafka/tools/ConsoleProducer.scala: No such file or
directory
error: src/main/scala/kafka/tools/GetOffsetShell.scala: No such file or
directory
error: src/main/scala/kafka/tools/ProducerPerformance.scala: No such file or
directory
error: src/main/scala/kafka/tools/ReplayLogProducer.scala: No such file or
directory
error: src/main/scala/kafka/tools/ReplicaVerificationTool.scala: No such file
or directory
error: src/main/scala/kafka/tools/SimpleConsumerShell.scala: No such file or
directory
error: src/main/scala/kafka/tools/ToolsUtils.scala: No such file or directory
{noformat}
Exception thrown when running console producer with no port number for the
broker
-
Key: KAFKA-1618
URL: https://issues.apache.org/jira/browse/KAFKA-1618
Project: Kafka
Issue Type: Improvement
Affects Versions: 0.8.1.1
Reporter: Gwen Shapira
Assignee: BalajiSeshadri
Labels: newbie
Fix For: 0.8.2
Attachments: KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch,
KAFKA-1618-REBASED.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch,
KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch
When running console producer with just localhost as the broker list, I get
ArrayIndexOutOfBounds exception.
I expect either a clearer error about arguments or for the producer to
guess a default port.
[root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1
--broker-list localhost
java.lang.ArrayIndexOutOfBoundsException: 1
at
kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102)
at
kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at
scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47)
at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
at scala.collection.AbstractTraversable.map(Traversable.scala:105)
at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97)
at
kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32)
at
kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41)
at kafka.producer.Producer.init(Producer.scala:59)
at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158)
at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148755#comment-14148755 ] BalajiSeshadri commented on KAFKA-1618: --- Ok,this one applies cleanly without issues. Here is the log when i applied. MER2AL-E0043615:kafka-trunk-1 balaji.seshadri$ git apply KAFKA-1618.patch -v Checking patch core/src/main/scala/kafka/tools/ConsoleProducer.scala... Checking patch core/src/main/scala/kafka/tools/GetOffsetShell.scala... Checking patch core/src/main/scala/kafka/tools/ProducerPerformance.scala... Checking patch core/src/main/scala/kafka/tools/ReplayLogProducer.scala... Checking patch core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala... Checking patch core/src/main/scala/kafka/tools/SimpleConsumerShell.scala... Checking patch core/src/main/scala/kafka/utils/ToolsUtils.scala... Applied patch core/src/main/scala/kafka/tools/ConsoleProducer.scala cleanly. Applied patch core/src/main/scala/kafka/tools/GetOffsetShell.scala cleanly. Applied patch core/src/main/scala/kafka/tools/ProducerPerformance.scala cleanly. Applied patch core/src/main/scala/kafka/tools/ReplayLogProducer.scala cleanly. Applied patch core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala cleanly. Applied patch core/src/main/scala/kafka/tools/SimpleConsumerShell.scala cleanly. Applied patch core/src/main/scala/kafka/utils/ToolsUtils.scala cleanly. [~nehanarkhede] Please verify. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618-ALL.patch, KAFKA-1618-CLEAN.patch, KAFKA-1618-REBASED.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147241#comment-14147241 ] Neha Narkhede commented on KAFKA-1618: -- Thanks for the latest patch, [~balaji.sesha...@dish.com]. It's almost there, I have a few more review comments - 1. Whitespace issue still exists for case (, while ( 2. From my last review - Could you get rid of the validate() API as the only place it's use is in validatePortAndDie 3. From my last review - Could you rename validatePortAndDie to validatePortOrDie? 4. From my last review - Whitespaces still exist in the imports of some files (SimpleConsumerShell). After the above changes, I'll check in the patch. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618-REVIEW-COMMENTS-SPACE-CORRECTION.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142716#comment-14142716 ] BalajiSeshadri commented on KAFKA-1618: --- [~nehanarkhede] Sorry couldnt fix the space issue because of Eclipse formatter is not allowing me to edit scala format. I implemented all other review comments. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: Balaji Seshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618-REVIEW-COMMENTS.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142168#comment-14142168 ] Neha Narkhede commented on KAFKA-1618: -- Thanks for the patch, [~balaji.sesha...@dish.com]. Few review comments - ConsoleProducer 1. The variable regex is not used on line 222. 2. In the validate() API, shouldn't the regex be val regex = new Regex(:[0-9].*) instead? 3. Since the PortValidator is common to all tools, it is worth moving the validateAndDie to a new class ToolsUtils. I'm sure we can refactor the tools to move some commonly usable APIs there. 4. Let's rename validateAndDie to validatePortOrDie. When you create ToolsUtils, let's only move validatePortOrDie there and move the logic from validate to validatePortOrDie. validate is only used by that API. Throughout the patch- 1. Please remove the whitespace introduced for the imports. Let's keep things consistent across the codebase 2. Please get rid of the whitespace between if and (. Also not consistent with the rest of the code. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: Balaji Seshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139038#comment-14139038 ] BalajiSeshadri commented on KAFKA-1618: --- [~nehanarkhede] I submitted patch(KAFKA-1618-ALL.patch) for the tools listed by you. Please review and let me know if you have more to fix. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: Balaji Seshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138359#comment-14138359 ] Neha Narkhede commented on KAFKA-1618: -- Agree with [~gwenshap] that whichever way we go, we should make sure that the behavior is consistent across all tools. My intuition is that it will be easier if we don't guess the port. We can make sure all tools behave the same way and give the same error message if the user does not enter the port. Would you like to take a stab at it? Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: Balaji Seshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135588#comment-14135588 ] Balaji Seshadri commented on KAFKA-1618: ok if user doesn't give any port i will default to 9092,if he/she does i will go ahead and use it. Is that ok ?. [~nehanarkhede] and [~gwenshap] Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136206#comment-14136206 ] Jay Kreps commented on KAFKA-1618: -- I think the problem with a default port is that yes, in 70% of cases that will save your having to enter the port, but in the 30% of cases where the default is wrong it will be may be confusing why it isn't working. I think having people enter the port is not so bad and a pretty common thing for tools that connect to remote hosts and ports. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136220#comment-14136220 ] Balaji Seshadri commented on KAFKA-1618: I agree with you [~jkreps] and [~nehanarkhede],its just ceremonial to have deafult one like Tomcat or any App server. Most of the cases it will be custom port. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134813#comment-14134813 ] Gwen Shapira commented on KAFKA-1618: - I still think that using port 9092 as default makes tons of sense. Its true that admins can run Kafka brokers on any port, but in practice any client-server architecture has defaults and I'll be hard-pressed to think of tools that absolutely require port number to connect to a server. Browsers default to port 80 (although we run HTTP servers on many other ports), ZK client will connect to port 2181 by default, HDFS will default to 8020 if you don't specify anything, etc, etc. People are used to not having to specify a port if they use a default - why do we want to make usage of Kafka any more difficult? Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134883#comment-14134883 ] Neha Narkhede commented on KAFKA-1618: -- [~gwenshap] The tools that ship with Kafka are also used by many users on production clusters. More often than not, each deployment customizes the Kafka port. It is true that the out-of-the-box experience is improved though. I'm fine with defaulting as well, as long as the error message of guessing the wrong port is clear and the tool exits if that happens. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618-ALL.patch, KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[
https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133254#comment-14133254
]
Neha Narkhede commented on KAFKA-1618:
--
[~balaji.sesha...@dish.com] To answer your question -
{noformat}
nnarkhed-mn1:tools nnarkhed$ pwd
/Users/nnarkhed/Projects/kafka-git-idea/core/src/main/scala/kafka/tools
nnarkhed-mn1:tools nnarkhed$ grep -R broker-list *
ConsoleProducer.scala:val brokerListOpt = parser.accepts(broker-list,
REQUIRED: The broker list string in the form HOST1:PORT1,HOST2:PORT2.)
ConsoleProducer.scala: .describedAs(broker-list)
GetOffsetShell.scala:val brokerListOpt = parser.accepts(broker-list,
REQUIRED: The list of hostname and port of the server to connect to.)
ProducerPerformance.scala:val brokerListOpt = parser.accepts(broker-list,
REQUIRED: broker info (the list of broker host and port for bootstrap.)
ReplayLogProducer.scala:val brokerListOpt = parser.accepts(broker-list,
REQUIRED: the broker list must be specified.)
ReplicaVerificationTool.scala:val brokerListOpt =
parser.accepts(broker-list, REQUIRED: The list of hostname and port of the
server to connect to.)
SimpleConsumerShell.scala:val brokerListOpt = parser.accepts(broker-list,
REQUIRED: The list of hostname and port of the server to connect to.)
{noformat}
Few review comments -
1. In lines 222-227, options.valueOf(brokerListOpt) is repeated several times.
It will be great if you can extract the value in a local variable and use that.
2. I'm actually a -1 on guessing anything and hardcoding it. Currently, the
defaults we have for the broker port are inconsistent and exist in 2 different
places (KafkaConfig and server.properties). Since the users can start Kafka on
a different port anyways, the behavior of the tools would be more confusing if
we attempt to guess the port ineffectively. I'd prefer exiting after giving a
clear error message instead.
Exception thrown when running console producer with no port number for the
broker
-
Key: KAFKA-1618
URL: https://issues.apache.org/jira/browse/KAFKA-1618
Project: Kafka
Issue Type: Improvement
Affects Versions: 0.8.1.1
Reporter: Gwen Shapira
Assignee: Gwen Shapira
Labels: newbie
Fix For: 0.8.2
Attachments: KAFKA-1618.patch
When running console producer with just localhost as the broker list, I get
ArrayIndexOutOfBounds exception.
I expect either a clearer error about arguments or for the producer to
guess a default port.
[root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1
--broker-list localhost
java.lang.ArrayIndexOutOfBoundsException: 1
at
kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102)
at
kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
at
scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47)
at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
at scala.collection.AbstractTraversable.map(Traversable.scala:105)
at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97)
at
kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32)
at
kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41)
at kafka.producer.Producer.init(Producer.scala:59)
at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158)
at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14133272#comment-14133272 ] BalajiSeshadri commented on KAFKA-1618: --- [~nehanarkhede] thanks a lot for review comments,i agree 100% defaulting to a port is not good idea because its people's wish to use the port they like based on availability, some architects like prime numbers :).I will go ahead and provide error message if port is not mentioned in the input. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: Gwen Shapira Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123632#comment-14123632 ] Gwen Shapira commented on KAFKA-1618: - [~balaji.sesha...@dish.com] - per Joe's comment, can you make sure URI handling is consistent across the scripts? That we always accept either hostname:port or hostname (and use default port)? Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123652#comment-14123652 ] BalajiSeshadri commented on KAFKA-1618: --- gwenshap Can you please list down the scripts for me ?. I will have them updated. Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.1.1 Reporter: Gwen Shapira Assignee: BalajiSeshadri Labels: newbie Fix For: 0.8.2 Attachments: KAFKA-1618.patch When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114689#comment-14114689 ] Joe Stein commented on KAFKA-1618: -- +1 to guess a default port, would be great to make that consistent across all the tooled scripts, zk too Exception thrown when running console producer with no port number for the broker - Key: KAFKA-1618 URL: https://issues.apache.org/jira/browse/KAFKA-1618 Project: Kafka Issue Type: Improvement Reporter: Gwen Shapira When running console producer with just localhost as the broker list, I get ArrayIndexOutOfBounds exception. I expect either a clearer error about arguments or for the producer to guess a default port. [root@shapira-1 bin]# ./kafka-console-producer.sh --topic rufus1 --broker-list localhost java.lang.ArrayIndexOutOfBoundsException: 1 at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:102) at kafka.client.ClientUtils$$anonfun$parseBrokerList$1.apply(ClientUtils.scala:97) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244) at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at scala.collection.TraversableLike$class.map(TraversableLike.scala:244) at scala.collection.AbstractTraversable.map(Traversable.scala:105) at kafka.client.ClientUtils$.parseBrokerList(ClientUtils.scala:97) at kafka.producer.BrokerPartitionInfo.init(BrokerPartitionInfo.scala:32) at kafka.producer.async.DefaultEventHandler.init(DefaultEventHandler.scala:41) at kafka.producer.Producer.init(Producer.scala:59) at kafka.producer.ConsoleProducer$.main(ConsoleProducer.scala:158) at kafka.producer.ConsoleProducer.main(ConsoleProducer.scala) -- This message was sent by Atlassian JIRA (v6.2#6252)
