[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595450#comment-14595450
]
Honghai Chen commented on KAFKA-1646:
-
See the commit
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593116#comment-14593116
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588170#comment-14588170
]
Jun Rao commented on KAFKA-1646:
[~waldenchen], thanks for the latest patch. A couple of
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587601#comment-14587601
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578235#comment-14578235
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552777#comment-14552777
]
Jay Kreps commented on KAFKA-1646:
--
This looks good to me but it would be good to get a
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537786#comment-14537786
]
Honghai Chen commented on KAFKA-1646:
-
Add test cases
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537793#comment-14537793
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537791#comment-14537791
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537796#comment-14537796
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537787#comment-14537787
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537798#comment-14537798
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529694#comment-14529694
]
Honghai Chen commented on KAFKA-1646:
-
When trying add test case for Log, got test
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509311#comment-14509311
]
Jay Kreps commented on KAFKA-1646:
--
So [~waldenchen] next steps for this patch:
1. KIP is
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506767#comment-14506767
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506795#comment-14506795
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504171#comment-14504171
]
Honghai Chen commented on KAFKA-1646:
-
Added KIP here and send out the email, will
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503261#comment-14503261
]
Jay Kreps commented on KAFKA-1646:
--
Cool, this looks good to me. This introduces a new
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493868#comment-14493868
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493899#comment-14493899
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494314#comment-14494314
]
Jay Kreps commented on KAFKA-1646:
--
Oh yes, also, we'll need a patch against trunk to be
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495541#comment-14495541
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495592#comment-14495592
]
Honghai Chen commented on KAFKA-1646:
-
Created reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387828#comment-14387828
]
Sriharsha Chintalapani commented on KAFKA-1646:
---
[~jkreps] Any guidance on
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14364344#comment-14364344
]
Sriharsha Chintalapani commented on KAFKA-1646:
---
[~waldenchen] Its looks
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363051#comment-14363051
]
Honghai Chen commented on KAFKA-1646:
-
Hey [~jkreps] Is it ok to add one configuration
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359855#comment-14359855
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359829#comment-14359829
]
Jay Kreps commented on KAFKA-1646:
--
Yeah I was proposing doing this across the board
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359859#comment-14359859
]
Honghai Chen commented on KAFKA-1646:
-
Reduce the check of if OS.IsWindows from 7 to
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359658#comment-14359658
]
Honghai Chen commented on KAFKA-1646:
-
Hey [~jkreps] We have ask the NTFS owners,
I think the real problem is that the conditionals are spread across a bunch
of different files. Seven special cases isn't necessarily unsustainable,
but is difficult to manage now because they aren't isolated to one
location. I think platform specific customizations are sustainable (as long
as
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358096#comment-14358096
]
Honghai Chen commented on KAFKA-1646:
-
Het, [~jkreps] Would you like help check the
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358125#comment-14358125
]
Jay Kreps commented on KAFKA-1646:
--
Hey [~waldenchen] this patch is adding a TON of
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350101#comment-14350101
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350110#comment-14350110
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350118#comment-14350118
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350121#comment-14350121
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350126#comment-14350126
]
Honghai Chen commented on KAFKA-1646:
-
Updated reviewboard against branch
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14349621#comment-14349621
]
Honghai Chen commented on KAFKA-1646:
-
Or do you prefer the second option:
Add one
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348401#comment-14348401
]
Honghai Chen commented on KAFKA-1646:
-
Actually we want to add one more column to file
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316747#comment-14316747
]
Jay Kreps commented on KAFKA-1646:
--
Hey [~waldenchen] yeah I think what you are saying is
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14315710#comment-14315710
]
Honghai Chen commented on KAFKA-1646:
-
How about add one more column to
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310912#comment-14310912
]
Jay Kreps commented on KAFKA-1646:
--
Hey guys if this forces full recovery the impact on
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307979#comment-14307979
]
Jakob Homan commented on KAFKA-1646:
To make it easier to test future patches that
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305923#comment-14305923
]
Jakob Homan commented on KAFKA-1646:
This is a big performance hit on Windows, and it
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304596#comment-14304596
]
Honghai Chen commented on KAFKA-1646:
-
Jay Kreps Jun Rao Neha NarkhedeThe Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289447#comment-14289447
]
Sriharsha Chintalapani commented on KAFKA-1646:
---
[~jkreps] [~junrao]
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266290#comment-14266290
]
Sriharsha Chintalapani commented on KAFKA-1646:
---
[~jkreps] [~junrao] Can you
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247936#comment-14247936
]
Qianlin Xia commented on KAFKA-1646:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248597#comment-14248597
]
Sriharsha Chintalapani commented on KAFKA-1646:
---
Thanks [~qixia] for the
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247842#comment-14247842
]
Qianlin Xia commented on KAFKA-1646:
Created reviewboard against branch origin/0.8.1
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247843#comment-14247843
]
Qianlin Xia commented on KAFKA-1646:
Created reviewboard against branch origin/0.8.1
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247852#comment-14247852
]
Qianlin Xia commented on KAFKA-1646:
Created reviewboard against branch origin/0.8.1
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247862#comment-14247862
]
Qianlin Xia commented on KAFKA-1646:
Created reviewboard against branch origin/0.8.1
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247865#comment-14247865
]
Qianlin Xia commented on KAFKA-1646:
Created reviewboard against branch origin/0.8.1
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247879#comment-14247879
]
Qianlin Xia commented on KAFKA-1646:
Created reviewboard against branch origin/0.8.1
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239494#comment-14239494
]
Sriharsha Chintalapani commented on KAFKA-1646:
---
[~jkreps] [~junrao] can you
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231258#comment-14231258
]
Qianlin Xia commented on KAFKA-1646:
Hi, Jun.
I also came from same team with
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225536#comment-14225536
]
Jun Rao commented on KAFKA-1646:
The bug fix patch forces log recovery on clean shutdown.
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14220515#comment-14220515
]
Honghai Chen commented on KAFKA-1646:
-
Hi Jay,
I came from same team with
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179731#comment-14179731
]
xueqiang wang commented on KAFKA-1646:
--
Hey, Jay, sorry for late. I have done a test
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169717#comment-14169717
]
Jay Kreps commented on KAFKA-1646:
--
Hey [~xueqiang] what is the latency impact for that
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164557#comment-14164557
]
Jay Kreps commented on KAFKA-1646:
--
Interesting. What is the behavior of
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161857#comment-14161857
]
xueqiang wang commented on KAFKA-1646:
--
This issue is caused by the discrete blocks
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162106#comment-14162106
]
Jay Kreps commented on KAFKA-1646:
--
Ah, you are saying Windows does a worse job of
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162987#comment-14162987
]
xueqiang wang commented on KAFKA-1646:
--
Yes, if there are many deleting and creating,
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151788#comment-14151788
]
Jay Kreps commented on KAFKA-1646:
--
Can you describe the problem in a little more detail?
67 matches
Mail list logo