[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992208#comment-14992208
]
Jiangjie Qin commented on KAFKA-2350:
-
[~hachikuji] [~guozhang] I noticed that currently if we pause a
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992357#comment-14992357
]
Guozhang Wang commented on KAFKA-2350:
--
Could this be resolved by calling
{code}
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992452#comment-14992452
]
Jiangjie Qin commented on KAFKA-2350:
-
Ah, right. That would work. It still a bit weird we commit the
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992466#comment-14992466
]
Guozhang Wang commented on KAFKA-2350:
--
I think this can be fixed by filtering out the partitions
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648329#comment-14648329
]
ASF GitHub Bot commented on KAFKA-2350:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645343#comment-14645343
]
ASF GitHub Bot commented on KAFKA-2350:
---
GitHub user hachikuji opened a pull
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643249#comment-14643249
]
Guozhang Wang commented on KAFKA-2350:
--
[~becket_qin], I was not considering the
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643442#comment-14643442
]
Jason Gustafson commented on KAFKA-2350:
[~becket_qin] I think that we're on the
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643349#comment-14643349
]
Jason Gustafson commented on KAFKA-2350:
There's one interesting implementation
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643418#comment-14643418
]
Jiangjie Qin commented on KAFKA-2350:
-
[~hachikuji], I am with [~guozhang] that it is
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642229#comment-14642229
]
Neha Narkhede commented on KAFKA-2350:
--
Few thoughts:
bq. 1. Add pause/unpause
bq. 2.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640958#comment-14640958
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
Throwing exceptions makes sense.
In
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639657#comment-14639657
]
Guozhang Wang commented on KAFKA-2350:
--
Personally I would prefer not mixing the
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639460#comment-14639460
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
Suppose we are using auto assignment.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639665#comment-14639665
]
Jiangjie Qin commented on KAFKA-2350:
-
Hmm, good point. When rebalance come into
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639796#comment-14639796
]
Jason Gustafson commented on KAFKA-2350:
I agree that even if we use
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639746#comment-14639746
]
Jiangjie Qin commented on KAFKA-2350:
-
[~guozhang], my understanding is that
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639424#comment-14639424
]
Jason Gustafson commented on KAFKA-2350:
[~becket_qin] It would help if you would
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639307#comment-14639307
]
Jiangjie Qin commented on KAFKA-2350:
-
Ah, I see your concern. Originally I was
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639080#comment-14639080
]
Jay Kreps commented on KAFKA-2350:
--
[~becket_qin] I think there are three proposals:
1.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639085#comment-14639085
]
Gwen Shapira commented on KAFKA-2350:
-
[~becket_qin] - when I imagined how the API
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637126#comment-14637126
]
Jay Kreps commented on KAFKA-2350:
--
[~becket_qin] Cool, we're on the same page, that was
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637219#comment-14637219
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
I think overloading
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637317#comment-14637317
]
Jay Kreps commented on KAFKA-2350:
--
[~hachikuji] Yeah I agree that would help this case.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637338#comment-14637338
]
Gwen Shapira commented on KAFKA-2350:
-
Agree with [~yasuhiro.matsuda].
The notion of
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637179#comment-14637179
]
Guozhang Wang commented on KAFKA-2350:
--
Currently there is already a function for
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637187#comment-14637187
]
Jason Gustafson commented on KAFKA-2350:
[~becket_qin] [~jkreps] Currently
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637753#comment-14637753
]
Jason Gustafson commented on KAFKA-2350:
[~jkreps] This is a little unrelated to
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637792#comment-14637792
]
Jiangjie Qin commented on KAFKA-2350:
-
[~guozhang] In the last case you mentioned, is
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638063#comment-14638063
]
Jiangjie Qin commented on KAFKA-2350:
-
Yes, that is what I meant.
Isn't it the case
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638070#comment-14638070
]
Jiangjie Qin commented on KAFKA-2350:
-
I think an explicit configuration makes sense.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638139#comment-14638139
]
Jay Kreps commented on KAFKA-2350:
--
[~hachikuji] yeah i vote for pause/resume (or
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638182#comment-14638182
]
Jiangjie Qin commented on KAFKA-2350:
-
[~yasuhiro.matsuda] [~jkreps] [~hachikuji]
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637890#comment-14637890
]
Guozhang Wang commented on KAFKA-2350:
--
[~becket_qin] OK I understand now. The
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636098#comment-14636098
]
Jay Kreps commented on KAFKA-2350:
--
+1 on resume instead of unpause though it doesn't
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636105#comment-14636105
]
Jason Gustafson commented on KAFKA-2350:
Hey [~becket_qin], thanks for the
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636319#comment-14636319
]
Jiangjie Qin commented on KAFKA-2350:
-
[~jkreps][~hachikuji], I actually was not
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636074#comment-14636074
]
Jiangjie Qin commented on KAFKA-2350:
-
I am thinking that currently we keep two
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634124#comment-14634124
]
Jason Gustafson commented on KAFKA-2350:
Sure, I just meant that if you fail to
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634114#comment-14634114
]
Gwen Shapira commented on KAFKA-2350:
-
Cool feature :)
Can you clarify: If you skip
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634126#comment-14634126
]
Gwen Shapira commented on KAFKA-2350:
-
oh, for some reason I expected heartbeats to be
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634169#comment-14634169
]
Jason Gustafson commented on KAFKA-2350:
There will probably be a large number of
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634229#comment-14634229
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
Can we have TopicPartition rather than
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634296#comment-14634296
]
Edward Ribeiro commented on KAFKA-2350:
---
Nit: wouldn't the inverse of ``pause`` to
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634294#comment-14634294
]
Jason Gustafson commented on KAFKA-2350:
I don't see why not. In that case, I
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634322#comment-14634322
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
To me the state preservation is not a
46 matches
Mail list logo
